)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"a7f03da609f462a633f40e0cfaa5c52dd71df02d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor /node/\u003cuuid\u003e/state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Ironic now have a periodic task that checks the current power state of"},{"line_number":10,"context_line":"the nodes[1] and keep the db updated, so the API does not need to call"},{"line_number":11,"context_line":"rpcapi.get_node_power_state every time someone GET /nodes/\u003cuuid\u003e/state"},{"line_number":12,"context_line":"we can just rely on the db for it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9xh8%3D","line":9,"updated":"2013-12-06 17:34:06.000000000","message":"s/have/has/","commit_id":"b6d22f028bba2964e3fc0ebc61f96820d412c3bc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ef4518041f2cc07a3bc69d50e12ad3c21f146400","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor /node/\u003cuuid\u003e/state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Ironic now have a periodic task that checks the current power state of"},{"line_number":10,"context_line":"the nodes[1] and keep the db updated, so the API does not need to call"},{"line_number":11,"context_line":"rpcapi.get_node_power_state every time someone GET /nodes/\u003cuuid\u003e/state"},{"line_number":12,"context_line":"we can just rely on the db for it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9uZ8%3D","line":9,"in_reply_to":"AAAATn%2F9xh8%3D","updated":"2013-12-06 17:59:21.000000000","message":"done :)","commit_id":"b6d22f028bba2964e3fc0ebc61f96820d412c3bc"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"a7f03da609f462a633f40e0cfaa5c52dd71df02d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Ironic now have a periodic task that checks the current power state of"},{"line_number":10,"context_line":"the nodes[1] and keep the db updated, so the API does not need to call"},{"line_number":11,"context_line":"rpcapi.get_node_power_state every time someone GET /nodes/\u003cuuid\u003e/state"},{"line_number":12,"context_line":"we can just rely on the db for it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* The API will now return all the states in one request, before it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9xgw%3D","line":11,"updated":"2013-12-06 17:34:06.000000000","message":"grammar is a little awkward here. Perhaps:\n\n  so the API does not need to call rpcapi.get_node_power_state.\n  it can just rely on the current status in the DB.","commit_id":"b6d22f028bba2964e3fc0ebc61f96820d412c3bc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ef4518041f2cc07a3bc69d50e12ad3c21f146400","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Ironic now have a periodic task that checks the current power state of"},{"line_number":10,"context_line":"the nodes[1] and keep the db updated, so the API does not need to call"},{"line_number":11,"context_line":"rpcapi.get_node_power_state every time someone GET /nodes/\u003cuuid\u003e/state"},{"line_number":12,"context_line":"we can just rely on the db for it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* The API will now return all the states in one request, before it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9uZY%3D","line":11,"in_reply_to":"AAAATn%2F9xgw%3D","updated":"2013-12-06 17:59:21.000000000","message":"done :) Thanks for the correction","commit_id":"b6d22f028bba2964e3fc0ebc61f96820d412c3bc"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"a7f03da609f462a633f40e0cfaa5c52dd71df02d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"we can just rely on the db for it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* The API will now return all the states in one request, before it"},{"line_number":15,"context_line":"was needed two requests to to get all the currents and targets (GET"},{"line_number":16,"context_line":"/node/\u003cuuid\u003e/state/power and /node/\u003cuuid\u003e/state/provision)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"* Rename /node/\u003cuuid\u003e/state to /node/\u003cuuid\u003e/states (plural) since it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9xgk%3D","line":15,"updated":"2013-12-06 17:34:06.000000000","message":"this reads slightly awkwardly as well. Perhaps:\n\n  in one request, whereas before two requests were needed\n  (one for power, and one for provision) to get all the state information.","commit_id":"b6d22f028bba2964e3fc0ebc61f96820d412c3bc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ef4518041f2cc07a3bc69d50e12ad3c21f146400","unresolved":false,"context_lines":[{"line_number":12,"context_line":"we can just rely on the db for it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* The API will now return all the states in one request, before it"},{"line_number":15,"context_line":"was needed two requests to to get all the currents and targets (GET"},{"line_number":16,"context_line":"/node/\u003cuuid\u003e/state/power and /node/\u003cuuid\u003e/state/provision)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"* Rename /node/\u003cuuid\u003e/state to /node/\u003cuuid\u003e/states (plural) since it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9uV8%3D","line":15,"in_reply_to":"AAAATn%2F9xgk%3D","updated":"2013-12-06 17:59:21.000000000","message":"done :) Thanks for the correction","commit_id":"b6d22f028bba2964e3fc0ebc61f96820d412c3bc"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"33eac8541f3d3062fae3e42ac719f9ffd1d16589","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @wsme_pecan.wsexpose(NodeStates, wtypes.text)"},{"line_number":88,"context_line":"    def get(self, node_uuid):"},{"line_number":89,"context_line":"        \"\"\"List or update the state of a node.\"\"\""},{"line_number":90,"context_line":"        rpc_node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"},{"line_number":91,"context_line":"        return NodeStates.convert(rpc_node)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9wyw%3D","line":89,"updated":"2013-12-06 08:40:39.000000000","message":"Please put a note here about power state updates by periodical task.","commit_id":"b6d22f028bba2964e3fc0ebc61f96820d412c3bc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d749701d680a175f0f91653df3e7472f790b97a1","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @wsme_pecan.wsexpose(NodeStates, wtypes.text)"},{"line_number":88,"context_line":"    def get(self, node_uuid):"},{"line_number":89,"context_line":"        \"\"\"List or update the state of a node.\"\"\""},{"line_number":90,"context_line":"        rpc_node \u003d objects.Node.get_by_uuid(pecan.request.context, node_uuid)"},{"line_number":91,"context_line":"        return NodeStates.convert(rpc_node)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9wbY%3D","line":89,"in_reply_to":"AAAATn%2F9wyw%3D","updated":"2013-12-06 10:27:45.000000000","message":"Agreed, the note will be added :)\n\nThanks","commit_id":"b6d22f028bba2964e3fc0ebc61f96820d412c3bc"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"f878ece88663b72f3fbf5ba3fff9a7f82ddc4e8f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"class NodeStates(base.APIBase):"},{"line_number":59,"context_line":"    \"\"\"API representation of the states of a node.\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    power_state \u003d wtypes.text"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    provision_state \u003d wtypes.text"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9ScE%3D","line":61,"updated":"2013-12-13 00:47:31.000000000","message":"This patch drops all the docstrings. Is that intentional? Why aren\u0027t they needed anymore?","commit_id":"959bea3b39a89aa5629ea6a25ab84b01189de933"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fe9b5019544bcb0a4bf0289e09d817fc525385a8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"class NodeStates(base.APIBase):"},{"line_number":59,"context_line":"    \"\"\"API representation of the states of a node.\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    power_state \u003d wtypes.text"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    provision_state \u003d wtypes.text"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9ROc%3D","line":61,"in_reply_to":"AAAATn%2F9ScE%3D","updated":"2013-12-13 09:35:57.000000000","message":"Actually it doesn\u0027t the Node class has the docstrings for these attributes, as the /states just expose them here as well I thought it would be redundant, do you think it\u0027s better to have the docstring on both?","commit_id":"959bea3b39a89aa5629ea6a25ab84b01189de933"}]}