)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e63949eb538c96075aa67559987711bffa43ae8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-10-24 01:19:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Activating/deactiating console can cause node being exclusively locked"},{"line_number":8,"context_line":"by the conductor and never unlocked after."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This patch forces kill of console process with SIGKILL if it did not"},{"line_number":11,"context_line":"terminate on SIGTERM and reads shellinabox subprocess stdout/stderr"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_4af55551","line":8,"updated":"2018-10-24 10:13:24.000000000","message":"could you please adjust your commit message to match https://wiki.openstack.org/wiki/GitCommitMessages ?","commit_id":"b0e3d5dc31224263bc36578db8f805e0a05add82"}],"ironic/drivers/modules/console_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e63949eb538c96075aa67559987711bffa43ae8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            if psutil.pid_exists(console_pid):"},{"line_number":109,"context_line":"                if attempt \u003d\u003d 2:"},{"line_number":110,"context_line":"                    os.kill(console_pid, signal.SIGKILL)"},{"line_number":111,"context_line":"                time.sleep(CONF.console.subprocess_checking_interval / 10.0)"},{"line_number":112,"context_line":"                attempt +\u003d 1"},{"line_number":113,"context_line":"            else:"},{"line_number":114,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_cae16599","line":111,"updated":"2018-10-24 10:13:24.000000000","message":"why dividing over 10.0? At least a NOTE could help, even though I wonder if we should just use subprocess_checking_interval here (it defaults to 1 second, so 3 seconds totally).","commit_id":"b0e3d5dc31224263bc36578db8f805e0a05add82"},{"author":{"_account_id":20104,"name":"Dmitrii Galkin","display_name":"Dmitry Galkin","email":"galkindmitrii@gmail.com","username":"galkindmitrii"},"change_message_id":"3f0c4c60130ea8fd941ae43a283248c98735af18","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            if psutil.pid_exists(console_pid):"},{"line_number":109,"context_line":"                if attempt \u003d\u003d 2:"},{"line_number":110,"context_line":"                    os.kill(console_pid, signal.SIGKILL)"},{"line_number":111,"context_line":"                time.sleep(CONF.console.subprocess_checking_interval / 10.0)"},{"line_number":112,"context_line":"                attempt +\u003d 1"},{"line_number":113,"context_line":"            else:"},{"line_number":114,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8b904f51","line":111,"in_reply_to":"3f79a3b5_cae16599","updated":"2018-10-24 12:45:45.000000000","message":"I think it might be better to simply put here 0.1 sec here. Leaving here the subprocess_checking_interval would mean user might have to wait 3 sec before the console is stopped/restarted. (That means also node will be under exclusive lock all that 3sec.)","commit_id":"b0e3d5dc31224263bc36578db8f805e0a05add82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e63949eb538c96075aa67559987711bffa43ae8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                if attempt \u003d\u003d 2:"},{"line_number":110,"context_line":"                    os.kill(console_pid, signal.SIGKILL)"},{"line_number":111,"context_line":"                time.sleep(CONF.console.subprocess_checking_interval / 10.0)"},{"line_number":112,"context_line":"                attempt +\u003d 1"},{"line_number":113,"context_line":"            else:"},{"line_number":114,"context_line":"                break"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_eae6a1af","line":112,"updated":"2018-10-24 10:13:24.000000000","message":"Let\u0027s have some debug logging so that operators know what is happening?","commit_id":"b0e3d5dc31224263bc36578db8f805e0a05add82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e63949eb538c96075aa67559987711bffa43ae8","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        # check if the console pid is created and the process is running."},{"line_number":211,"context_line":"        # if it is, then the shellinaboxd is invoked successfully as a daemon."},{"line_number":212,"context_line":"        # otherwise check the error."},{"line_number":213,"context_line":"        if locals[\u0027returncode\u0027] is not None:"},{"line_number":214,"context_line":"            if (locals[\u0027returncode\u0027] \u003d\u003d 0 and os.path.exists(pid_file)"},{"line_number":215,"context_line":"                and psutil.pid_exists(_get_console_pid(node_uuid))):"},{"line_number":216,"context_line":"                raise loopingcall.LoopingCallDone()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8affed33","line":213,"updated":"2018-10-24 10:13:24.000000000","message":"this condition is now redundant","commit_id":"b0e3d5dc31224263bc36578db8f805e0a05add82"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1e63949eb538c96075aa67559987711bffa43ae8","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        if (time.time() \u003e expiration):"},{"line_number":219,"context_line":"            error \u003d _(\"Timeout while waiting for console subprocess\""},{"line_number":220,"context_line":"                      \"to start for node %s.\") % node_uuid"},{"line_number":221,"context_line":"            LOG.warning(error)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            (stdout, stderr) \u003d popen_obj.communicate()"},{"line_number":224,"context_line":"            locals[\u0027errstr\u0027] \u003d _("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_aafc293f","line":221,"updated":"2018-10-24 10:13:24.000000000","message":"please merge two warnings into one, otherwise it will be hard to understand the context in busy logs","commit_id":"b0e3d5dc31224263bc36578db8f805e0a05add82"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"e78657450bce1b8b5ce7ffe1e6d1811f05f27793","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # make sure the process get\u0027s killed"},{"line_number":106,"context_line":"        attempt \u003d 0"},{"line_number":107,"context_line":"        while attempt !\u003d 3:"},{"line_number":108,"context_line":"            if psutil.pid_exists(console_pid):"},{"line_number":109,"context_line":"                if attempt \u003d\u003d 2:"},{"line_number":110,"context_line":"                    os.kill(console_pid, signal.SIGKILL)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_dfc6b315","line":107,"range":{"start_line":107,"start_character":22,"end_line":107,"end_character":24},"updated":"2018-10-29 04:07:10.000000000","message":"I would prefer to use attempt \u003c 3 here.","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"e78657450bce1b8b5ce7ffe1e6d1811f05f27793","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        attempt \u003d 0"},{"line_number":107,"context_line":"        while attempt !\u003d 3:"},{"line_number":108,"context_line":"            if psutil.pid_exists(console_pid):"},{"line_number":109,"context_line":"                if attempt \u003d\u003d 2:"},{"line_number":110,"context_line":"                    os.kill(console_pid, signal.SIGKILL)"},{"line_number":111,"context_line":"                LOG.debug(\"Waiting for the console process with PID %(pid)s \""},{"line_number":112,"context_line":"                          \"to exit. Node: %(node)s.\","},{"line_number":113,"context_line":"                          {\u0027pid\u0027: console_pid, \u0027node\u0027: node_uuid})"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_1fd8abea","line":110,"range":{"start_line":109,"start_character":16,"end_line":110,"end_character":56},"updated":"2018-10-29 04:07:10.000000000","message":"the code can be logically divided into two parts: waiting for SIGTERM then enforcing SIGKILL, imho this one can be moved outside of the loop.","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"},{"author":{"_account_id":20104,"name":"Dmitrii Galkin","display_name":"Dmitry Galkin","email":"galkindmitrii@gmail.com","username":"galkindmitrii"},"change_message_id":"c99e55a1428c31edc2f82eab7cdf1df9545fdc9d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        attempt \u003d 0"},{"line_number":107,"context_line":"        while attempt !\u003d 3:"},{"line_number":108,"context_line":"            if psutil.pid_exists(console_pid):"},{"line_number":109,"context_line":"                if attempt \u003d\u003d 2:"},{"line_number":110,"context_line":"                    os.kill(console_pid, signal.SIGKILL)"},{"line_number":111,"context_line":"                LOG.debug(\"Waiting for the console process with PID %(pid)s \""},{"line_number":112,"context_line":"                          \"to exit. Node: %(node)s.\","},{"line_number":113,"context_line":"                          {\u0027pid\u0027: console_pid, \u0027node\u0027: node_uuid})"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_df3ccc92","line":110,"range":{"start_line":109,"start_character":16,"end_line":110,"end_character":56},"in_reply_to":"3f79a3b5_1988276a","updated":"2018-11-06 11:33:25.000000000","message":"No, it is not strictly intentional. SIGKILL always work as long as you have permissions. But it is an async call, so process might exist a little bit longer.","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8269980c7c9b408e2267548f4dffc18528ffbfcc","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        attempt \u003d 0"},{"line_number":107,"context_line":"        while attempt !\u003d 3:"},{"line_number":108,"context_line":"            if psutil.pid_exists(console_pid):"},{"line_number":109,"context_line":"                if attempt \u003d\u003d 2:"},{"line_number":110,"context_line":"                    os.kill(console_pid, signal.SIGKILL)"},{"line_number":111,"context_line":"                LOG.debug(\"Waiting for the console process with PID %(pid)s \""},{"line_number":112,"context_line":"                          \"to exit. Node: %(node)s.\","},{"line_number":113,"context_line":"                          {\u0027pid\u0027: console_pid, \u0027node\u0027: node_uuid})"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_1988276a","line":110,"range":{"start_line":109,"start_character":16,"end_line":110,"end_character":56},"in_reply_to":"3f79a3b5_1fd8abea","updated":"2018-11-06 07:28:28.000000000","message":"Is it intentional to sleep for 0.1 sec again after sending SIGKILL instead of breaking here? I\u0027m asking how it is ensured that the process dies after SIGKILL.","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29f20c268593e3f2539e20e391ca8a6088f4878a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                LOG.debug(\"Waiting for the console process with PID %(pid)s \""},{"line_number":112,"context_line":"                          \"to exit. Node: %(node)s.\","},{"line_number":113,"context_line":"                          {\u0027pid\u0027: console_pid, \u0027node\u0027: node_uuid})"},{"line_number":114,"context_line":"                time.sleep(0.1)"},{"line_number":115,"context_line":"                attempt +\u003d 1"},{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_e74a6c80","line":114,"updated":"2018-11-21 11:05:14.000000000","message":"I wonder if 200ms is enough for a console process to shutdown cleanly..","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"872b1c58c806084266be4766b59ab4bf4f98ae88","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                LOG.debug(\"Waiting for the console process with PID %(pid)s \""},{"line_number":112,"context_line":"                          \"to exit. Node: %(node)s.\","},{"line_number":113,"context_line":"                          {\u0027pid\u0027: console_pid, \u0027node\u0027: node_uuid})"},{"line_number":114,"context_line":"                time.sleep(0.1)"},{"line_number":115,"context_line":"                attempt +\u003d 1"},{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_abbc2b07","line":114,"in_reply_to":"3f79a3b5_8a9a9fc0","updated":"2018-11-22 12:05:51.000000000","message":"Maybe an option [console]kill_timeout defaulting to 1 second? then make 5 attempts with 0.2 sleep between them (5 \u003d 1 / 0.2, will be more for bigger timeout).","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"},{"author":{"_account_id":20104,"name":"Dmitrii Galkin","display_name":"Dmitry Galkin","email":"galkindmitrii@gmail.com","username":"galkindmitrii"},"change_message_id":"7176d1a060071c37965da40a0965fc43c9e2a889","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                LOG.debug(\"Waiting for the console process with PID %(pid)s \""},{"line_number":112,"context_line":"                          \"to exit. Node: %(node)s.\","},{"line_number":113,"context_line":"                          {\u0027pid\u0027: console_pid, \u0027node\u0027: node_uuid})"},{"line_number":114,"context_line":"                time.sleep(0.1)"},{"line_number":115,"context_line":"                attempt +\u003d 1"},{"line_number":116,"context_line":"            else:"},{"line_number":117,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_8a9a9fc0","line":114,"in_reply_to":"3f79a3b5_e74a6c80","updated":"2018-11-21 11:31:22.000000000","message":"Well, that depends on a number of factors I guess. I\u0027m not a fan of having time.sleep anywhere.. do you have any suggestions? - I can think of setting number of attempts to, let\u0027s say 5","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29f20c268593e3f2539e20e391ca8a6088f4878a","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        # check if the console pid is created and the process is running."},{"line_number":214,"context_line":"        # if it is, then the shellinaboxd is invoked successfully as a daemon."},{"line_number":215,"context_line":"        # otherwise check the error."},{"line_number":216,"context_line":"        if (locals[\u0027returncode\u0027] \u003d\u003d 0 and os.path.exists(pid_file)"},{"line_number":217,"context_line":"            and psutil.pid_exists(_get_console_pid(node_uuid))):"},{"line_number":218,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_873b78f1","line":216,"updated":"2018-11-21 11:05:14.000000000","message":"do I get it right that you no longer catch the situation when the console process exits with non-zero status and wait for timeout instead? It sounds wrong to me. I think you need to keep the code here AND add it below.","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"},{"author":{"_account_id":20104,"name":"Dmitrii Galkin","display_name":"Dmitry Galkin","email":"galkindmitrii@gmail.com","username":"galkindmitrii"},"change_message_id":"7176d1a060071c37965da40a0965fc43c9e2a889","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        # check if the console pid is created and the process is running."},{"line_number":214,"context_line":"        # if it is, then the shellinaboxd is invoked successfully as a daemon."},{"line_number":215,"context_line":"        # otherwise check the error."},{"line_number":216,"context_line":"        if (locals[\u0027returncode\u0027] \u003d\u003d 0 and os.path.exists(pid_file)"},{"line_number":217,"context_line":"            and psutil.pid_exists(_get_console_pid(node_uuid))):"},{"line_number":218,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_cafe57b4","line":216,"in_reply_to":"3f79a3b5_873b78f1","updated":"2018-11-21 11:31:22.000000000","message":"good point, will do, thx","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"299391381041e544c0aac2ac1d7aa84082d42152","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        while attempt \u003c max_attempts:"},{"line_number":110,"context_line":"            if psutil.pid_exists(console_pid):"},{"line_number":111,"context_line":"                if attempt \u003d\u003d (max_attempts - 1):"},{"line_number":112,"context_line":"                    os.kill(console_pid, signal.SIGKILL)"},{"line_number":113,"context_line":"                LOG.debug(\"Waiting for the console process with PID %(pid)s \""},{"line_number":114,"context_line":"                          \"to exit. Node: %(node)s.\","}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_fc685257","line":111,"updated":"2018-11-28 10:20:06.000000000","message":"nit: redundant brackets","commit_id":"6b575264c56a4efbe3692a69faebc3f68db40e20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"299391381041e544c0aac2ac1d7aa84082d42152","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            and psutil.pid_exists(_get_console_pid(node_uuid))):"},{"line_number":220,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if (time.time() \u003e expiration) or (locals[\u0027returncode\u0027] is not None):"},{"line_number":223,"context_line":"            (stdout, stderr) \u003d popen_obj.communicate()"},{"line_number":224,"context_line":"            locals[\u0027errstr\u0027] \u003d _("},{"line_number":225,"context_line":"                \"Timeout or error while waiting for console \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_9c891e1f","line":222,"updated":"2018-11-28 10:20:06.000000000","message":"nit: redundant brackets","commit_id":"6b575264c56a4efbe3692a69faebc3f68db40e20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c7a70723f943ea779ed197dc94cd4fbd7f29fc0d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            and psutil.pid_exists(_get_console_pid(node_uuid))):"},{"line_number":220,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if (time.time() \u003e expiration or locals[\u0027returncode\u0027] is not None):"},{"line_number":223,"context_line":"            (stdout, stderr) \u003d popen_obj.communicate()"},{"line_number":224,"context_line":"            locals[\u0027errstr\u0027] \u003d _("},{"line_number":225,"context_line":"                \"Timeout or error while waiting for console \""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_515beff6","line":222,"updated":"2018-12-04 18:55:54.000000000","message":"nit: still too many brackets :)","commit_id":"0256e1e69f4dd38cf0a80532337fa30c89502cb4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f158c8ff860e341bf6ec7c421df47125008da6e3","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            and psutil.pid_exists(_get_console_pid(node_uuid))):"},{"line_number":220,"context_line":"            raise loopingcall.LoopingCallDone()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if (time.time() \u003e expiration or locals[\u0027returncode\u0027] is not None):"},{"line_number":223,"context_line":"            (stdout, stderr) \u003d popen_obj.communicate()"},{"line_number":224,"context_line":"            locals[\u0027errstr\u0027] \u003d _("},{"line_number":225,"context_line":"                \"Timeout or error while waiting for console \""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_06b6988d","line":222,"in_reply_to":"3f79a3b5_515beff6","updated":"2018-12-05 00:28:27.000000000","message":"git-nit my friend :)","commit_id":"0256e1e69f4dd38cf0a80532337fa30c89502cb4"}],"ironic/tests/unit/drivers/modules/test_console_utils.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8269980c7c9b408e2267548f4dffc18528ffbfcc","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                                            mock_popen):"},{"line_number":312,"context_line":"        mock_popen.return_value.poll.return_value \u003d 1"},{"line_number":313,"context_line":"        mock_popen.return_value.communicate.return_value \u003d (\u0027output\u0027, \u0027error\u0027)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        self.assertRaises(exception.ConsoleSubprocessFailed,"},{"line_number":316,"context_line":"                          console_utils.start_shellinabox_console,"},{"line_number":317,"context_line":"                          self.info[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f9a0cba6","line":314,"updated":"2018-11-06 07:28:28.000000000","message":"I prefer overriding console.subprocess_timeout option with a smaller value (1 or 2) to shorten this test.","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8269980c7c9b408e2267548f4dffc18528ffbfcc","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        mock_pid_exists.return_value \u003d False"},{"line_number":343,"context_line":"        mock_popen.return_value.communicate.return_value \u003d (\u0027output\u0027, \u0027error\u0027)"},{"line_number":344,"context_line":"        mock_path_exists.return_value \u003d True"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        self.assertRaises(exception.ConsoleSubprocessFailed,"},{"line_number":347,"context_line":"                          console_utils.start_shellinabox_console,"},{"line_number":348,"context_line":"                          self.info[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b9a6d3be","line":345,"updated":"2018-11-06 07:28:28.000000000","message":"ditto","commit_id":"8a5d9f6f49cfa95f3ea9b2b9e2587176518e48fc"}]}
