)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f7896dacd7456f45767835027062055130cb3f00","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The booting with partition image via virtual media"},{"line_number":10,"context_line":"boot interface does not detach CDROM after boot successfully."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit will fix above issue and bring to local booting."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is working well with Fujitsu TX2540 M1."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_b7df9e65","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":60},"updated":"2018-10-01 04:32:07.000000000","message":"I suppose The vmedia is used in case of boot of partition image. How is it related to local boot?\n\nAlso update commit message with story/task.","commit_id":"52c45bec8274fb89d2480f49e9505d66b31c294e"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"09d724c10117fa2e7901d8beaf48de9901d85f6a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The booting with partition image via virtual media"},{"line_number":10,"context_line":"boot interface does not detach CDROM after boot successfully."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit will fix above issue and bring to local booting."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is working well with Fujitsu TX2540 M1."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_22e10efd","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":60},"in_reply_to":"3f79a3b5_b7df9e65","updated":"2018-10-01 07:13:50.000000000","message":"After complete deployment with partition image then Bare-metal (BM) should boot OS from local disk on RAID controller or hard drives. Currently, BM is booting OS from virtual CDROM after completed deployment.","commit_id":"52c45bec8274fb89d2480f49e9505d66b31c294e"}],"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"963e804b77b449e948a3ee419845347ad038678e","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dTrue)"},{"line_number":1025,"context_line":"        # Clean up after boot successful with partition images"},{"line_number":1026,"context_line":"        if not iwdi:"},{"line_number":1027,"context_line":"            _detach_virtual_cd(node)"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"    @METRICS.timer(\u0027IRMCVirtualMediaBoot.clean_up_instance\u0027)"},{"line_number":1030,"context_line":"    def clean_up_instance(self, task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cd157c4e","line":1027,"updated":"2018-09-24 14:41:43.000000000","message":"I think we need a unit test to help establish the behavior contract moving forward, so we don\u0027t inadvertently break this.","commit_id":"5d9383d4939a1b6a1cbe55ecad88746c6f06ee35"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"09f753eb7c52ec2b40a6ba28400dfba262314bdf","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dTrue)"},{"line_number":1025,"context_line":"        # Clean up after boot successful with partition images"},{"line_number":1026,"context_line":"        if not iwdi:"},{"line_number":1027,"context_line":"            _detach_virtual_cd(node)"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"    @METRICS.timer(\u0027IRMCVirtualMediaBoot.clean_up_instance\u0027)"},{"line_number":1030,"context_line":"    def clean_up_instance(self, task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_96a44409","line":1027,"in_reply_to":"3f79a3b5_cd157c4e","updated":"2018-09-26 08:58:13.000000000","message":"Done","commit_id":"5d9383d4939a1b6a1cbe55ecad88746c6f06ee35"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8a2f063fde2e324cbd38cb4d632bfeb28600f678","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dTrue)"},{"line_number":1025,"context_line":"        # Clean up after boot successful with partition images"},{"line_number":1026,"context_line":"        if not iwdi:"},{"line_number":1027,"context_line":"            _detach_virtual_cd(node)"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"    @METRICS.timer(\u0027IRMCVirtualMediaBoot.clean_up_instance\u0027)"},{"line_number":1030,"context_line":"    def clean_up_instance(self, task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_af953434","line":1027,"updated":"2018-09-28 06:49:53.000000000","message":"I don\u0027t understand the purpose of this change. This just cancels the preparation done at line1020.","commit_id":"51abe48e24fc0421d680bb5e0f4e36a30d56cf10"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"984a5fe86230dbc426ad3f3594995bc98803d7ee","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"            irmc_common.set_secure_boot_mode(node, enable\u003dTrue)"},{"line_number":1025,"context_line":"        # Clean up after boot successful with partition images"},{"line_number":1026,"context_line":"        if not iwdi:"},{"line_number":1027,"context_line":"            _detach_virtual_cd(node)"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"    @METRICS.timer(\u0027IRMCVirtualMediaBoot.clean_up_instance\u0027)"},{"line_number":1030,"context_line":"    def clean_up_instance(self, task):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_2d74cc35","line":1027,"in_reply_to":"3f79a3b5_af953434","updated":"2018-09-28 08:30:52.000000000","message":"Yep. This change should add after L1020 have been completed.  will change them in the next patch.","commit_id":"51abe48e24fc0421d680bb5e0f4e36a30d56cf10"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f7896dacd7456f45767835027062055130cb3f00","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"            driver_internal_info \u003d node.driver_internal_info"},{"line_number":1019,"context_line":"            root_uuid_or_disk_id \u003d driver_internal_info[\u0027root_uuid_or_disk_id\u0027]"},{"line_number":1020,"context_line":"            self._configure_vmedia_boot(task, root_uuid_or_disk_id)"},{"line_number":1021,"context_line":"            # Clean up after boot successful with partition images"},{"line_number":1022,"context_line":"            _detach_virtual_cd(node)"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        # Enable secure boot, if being requested"},{"line_number":1025,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_d7b57a1a","line":1022,"range":{"start_line":1021,"start_character":11,"end_line":1022,"end_character":36},"updated":"2018-10-01 04:32:07.000000000","message":"It is not clear the purpose of this change. It has inserted media at L1020 and no power operation has happened since then to claim successful boot of partition image. I think more detailed comments are required to explain the scenario.","commit_id":"52c45bec8274fb89d2480f49e9505d66b31c294e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"ef34004b322dd8a4666c659b46cbaa7105aa093d","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"            driver_internal_info \u003d node.driver_internal_info"},{"line_number":1019,"context_line":"            root_uuid_or_disk_id \u003d driver_internal_info[\u0027root_uuid_or_disk_id\u0027]"},{"line_number":1020,"context_line":"            self._configure_vmedia_boot(task, root_uuid_or_disk_id)"},{"line_number":1021,"context_line":"            # Clean up after boot successful with partition images"},{"line_number":1022,"context_line":"            _detach_virtual_cd(node)"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        # Enable secure boot, if being requested"},{"line_number":1025,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_2bd554b7","line":1022,"range":{"start_line":1021,"start_character":11,"end_line":1022,"end_character":36},"in_reply_to":"3f79a3b5_427d2a1c","updated":"2018-10-02 08:06:47.000000000","message":"Yes. This is a netboot case. An initrd is booted from virtual CD and this ramdisk executes OS on a local disk.","commit_id":"52c45bec8274fb89d2480f49e9505d66b31c294e"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"09d724c10117fa2e7901d8beaf48de9901d85f6a","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"            driver_internal_info \u003d node.driver_internal_info"},{"line_number":1019,"context_line":"            root_uuid_or_disk_id \u003d driver_internal_info[\u0027root_uuid_or_disk_id\u0027]"},{"line_number":1020,"context_line":"            self._configure_vmedia_boot(task, root_uuid_or_disk_id)"},{"line_number":1021,"context_line":"            # Clean up after boot successful with partition images"},{"line_number":1022,"context_line":"            _detach_virtual_cd(node)"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        # Enable secure boot, if being requested"},{"line_number":1025,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_427d2a1c","line":1022,"range":{"start_line":1021,"start_character":11,"end_line":1022,"end_character":36},"in_reply_to":"3f79a3b5_6255c6f8","updated":"2018-10-01 07:13:50.000000000","message":"- In L1021, they will create boot_image which based on deploy_image then implement into Bare-metal(BM doesn\u0027t reboot during this deployment). After completed deployment, BM should boot OS from local drive on RAID controller which instead of virtual CDROM.\n- After finish deployment, we can detach CDROM then user can use OS on logical drive which deployed from boot_image. @Shiina, I guess you think bare-metal should boot from boot-image via virtual CDROM after completed deployment. is right?","commit_id":"52c45bec8274fb89d2480f49e9505d66b31c294e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"b6b24ce63fca904edf14dc34d7d1a79059fc1c5a","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"            driver_internal_info \u003d node.driver_internal_info"},{"line_number":1019,"context_line":"            root_uuid_or_disk_id \u003d driver_internal_info[\u0027root_uuid_or_disk_id\u0027]"},{"line_number":1020,"context_line":"            self._configure_vmedia_boot(task, root_uuid_or_disk_id)"},{"line_number":1021,"context_line":"            # Clean up after boot successful with partition images"},{"line_number":1022,"context_line":"            _detach_virtual_cd(node)"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        # Enable secure boot, if being requested"},{"line_number":1025,"context_line":"        if deploy_utils.is_secure_boot_requested(node):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6255c6f8","line":1022,"range":{"start_line":1021,"start_character":11,"end_line":1022,"end_character":36},"in_reply_to":"3f79a3b5_d7b57a1a","updated":"2018-10-01 06:45:48.000000000","message":"+1\n\nCould you please clarify the problem? Even if an initial boot in deployment is completed, we cannnot detach the virtual CD because a node can be rebooted by a user. The CD is detached when undeploying the node in L1053.","commit_id":"52c45bec8274fb89d2480f49e9505d66b31c294e"}],"releasenotes/notes/fix_not_detach_virtual_cd_for_irmc_driver-9c7c5d10b41cdf94.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1d02f152a5cedceea92531d654767dca284989dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue about virtual-media-boot interface does not detach"},{"line_number":5,"context_line":"    virtual CDROM after boot an instance successfully with partition images."},{"line_number":6,"context_line":"    This fix will bring to local boot for baremetal after completed provision."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_298379cd","line":3,"updated":"2018-09-27 10:37:09.000000000","message":"\"Fixes the ``irmc-virtual-media`` boot interfaces to correctly detach the virtual CDROM before booting into instance when using partition images. Previously it would prevent booting from local disk.\"","commit_id":"c9a2af8593862bef11f7d8bb3511234cc31927b6"},{"author":{"_account_id":25254,"name":"Nguyen Van Trung","email":"trungnvfet@outlook.com","username":"trungnv"},"change_message_id":"4065eb2192bfd545dae5f9896cc2f78997f9ab4d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue about virtual-media-boot interface does not detach"},{"line_number":5,"context_line":"    virtual CDROM after boot an instance successfully with partition images."},{"line_number":6,"context_line":"    This fix will bring to local boot for baremetal after completed provision."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_9c751436","line":3,"in_reply_to":"3f79a3b5_298379cd","updated":"2018-09-28 05:51:31.000000000","message":"Done","commit_id":"c9a2af8593862bef11f7d8bb3511234cc31927b6"}]}