)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3ef6e88a079eaf5b84fe0ef3999c4bc9d04fdb86","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable configuration of conversion flags for iscsi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an option conv_flags, that wll be passed at ironic.conf into"},{"line_number":10,"context_line":"iscsi section. This will pass the conv_flags option to the iscsi"},{"line_number":11,"context_line":"disk utils, and this will modify the behaviour of the image"},{"line_number":12,"context_line":"copy to disk. It can be used for things as optimization (adding"},{"line_number":13,"context_line":"an sparse flag)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_37770e91","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":15},"updated":"2018-10-01 04:16:48.000000000","message":"Are you planning to introduce this new config in separate patch? If its simple change, may be you could introduce the config in this patch itself.\n\nAlso add story/task to commit message.","commit_id":"1bdb6fbbf9549fc28b539a22e19fce39eb6ff580"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e8c38665ceb9840de1354c7470086580127dae09","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable configuration of conversion flags for iscsi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add an option conv_flags, that wll be passed at ironic.conf into"},{"line_number":10,"context_line":"iscsi section. This will pass the conv_flags option to the iscsi"},{"line_number":11,"context_line":"disk utils, and this will modify the behaviour of the image"},{"line_number":12,"context_line":"copy to disk. It can be used for things as optimization (adding"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_15942ee7","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":34},"updated":"2018-10-02 12:47:00.000000000","message":"typo","commit_id":"cf68796c291feaf552797f6341b1c179af76ef17"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1d24bb3a4c022ab73fe456992dbc8f71bc3454f5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"copy to disk. It can be used for things as optimization (adding"},{"line_number":13,"context_line":"an sparse flag)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I1144303ea89d7c0ac3661a8434413ecb8a2ec6c6"},{"line_number":16,"context_line":"Change-Id: Ia9e11dda35bb06e5b37b00e1b8fb42f9267a95d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_48684421","line":15,"updated":"2018-10-09 08:35:34.000000000","message":"Can be removed (does not work with ironic-lib anyway)","commit_id":"7a280b57aa3d9cdfa89277e3a8554900f5b3f694"}],"ironic/conf/iscsi.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e8c38665ceb9840de1354c7470086580127dae09","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                help\u003d_(\u0027The port number on which the iSCSI portal listens \u0027"},{"line_number":25,"context_line":"                       \u0027for incoming connections.\u0027)),"},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027conv_flags\u0027,"},{"line_number":27,"context_line":"               help\u003d_(\u0027The modifier flags for the command that copies the \u0027"},{"line_number":28,"context_line":"                      \u0027original image to the target disk.\u0027))"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_95235ebe","line":28,"range":{"start_line":27,"start_character":15,"end_line":28,"end_character":60},"updated":"2018-10-02 12:47:00.000000000","message":"Would it make sense to list the valid options here?\n\nHere\u0027s how it\u0027s noted in `ironic-lib`:\n\n    Flags that need to be sent to the dd command, to control\n    the conversion of the original file when copying to \n    the host. It can contain several options separated \n    by commas.","commit_id":"cf68796c291feaf552797f6341b1c179af76ef17"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"11657204f61d11751d9028e550f55ddf093e5825","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            params[\u0027disk_label\u0027] \u003d disk_label"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    missing \u003d [key for key in params if params[key] is None and"},{"line_number":133,"context_line":"               key !\u003d \u0027conv_flags\u0027]"},{"line_number":134,"context_line":"    if missing:"},{"line_number":135,"context_line":"        raise exception.MissingParameterValue("},{"line_number":136,"context_line":"            _(\"Parameters %s were not passed to ironic\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_687a84f0","line":133,"updated":"2018-10-12 12:55:46.000000000","message":"Is there a reason why you didn\u0027t add L113-115 after L137? Then we wouldn\u0027t need to do this.\n\nI think doing it this way is confusing, given that we already have code after L138 that modifies the params dict.","commit_id":"ea52bd834d903de744bcf7f34ed5fc7a65b92c4c"}],"lower-constraints.txt":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3ef6e88a079eaf5b84fe0ef3999c4bc9d04fdb86","unresolved":false,"context_lines":[{"line_number":38,"context_line":"hacking\u003d\u003d1.0.0"},{"line_number":39,"context_line":"idna\u003d\u003d2.6"},{"line_number":40,"context_line":"imagesize\u003d\u003d1.0.0"},{"line_number":41,"context_line":"ironic-lib\u003d\u003d2.15.0"},{"line_number":42,"context_line":"iso8601\u003d\u003d0.1.11"},{"line_number":43,"context_line":"Jinja2\u003d\u003d2.10"},{"line_number":44,"context_line":"jmespath\u003d\u003d0.9.3"}],"source_content_type":"text/plain","patch_set":2,"id":"3f79a3b5_97862265","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":18},"updated":"2018-10-01 04:16:48.000000000","message":"You need to update requirements as well. Its required minimum version is pointing to 2.14.0\nhttps://github.com/openstack/ironic/blob/master/requirements.txt#L14","commit_id":"1bdb6fbbf9549fc28b539a22e19fce39eb6ff580"}],"releasenotes/notes/add_conversion_flags_iscsi-d7f846803a647573.yaml":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e8c38665ceb9840de1354c7470086580127dae09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add an option conv_flags, that wll be passed at ironic.conf into iscsi"},{"line_number":5,"context_line":"    section. This will pass the conv_flags option to the iscsi disk utils,"},{"line_number":6,"context_line":"    and this will modify the behaviour of the image copy to disk. It can be"},{"line_number":7,"context_line":"    used for things as optimization (adding an sparse flag)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_1562ee16","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":28},"updated":"2018-10-02 12:47:00.000000000","message":"``conv_flag``\n?","commit_id":"cf68796c291feaf552797f6341b1c179af76ef17"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1d24bb3a4c022ab73fe456992dbc8f71bc3454f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add an option ``conv_flags``, that will be passed at ironic.conf into iscsi"},{"line_number":5,"context_line":"    section. This will pass the conv_flags option to the iscsi disk utils,"},{"line_number":6,"context_line":"    and this will modify the behaviour of the image copy to disk. It can be"},{"line_number":7,"context_line":"    used for things as optimization (adding an sparse flag)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_6863c046","line":4,"updated":"2018-10-09 08:35:34.000000000","message":"\"Adds a new option ``[iscsi]conv_flags`` that specifies the conversion options to pass to the ``dd`` utility when copying an image. For example, passing ``sparse`` may result in less network traffic for large whole disk images.\"","commit_id":"7a280b57aa3d9cdfa89277e3a8554900f5b3f694"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"11657204f61d11751d9028e550f55ddf093e5825","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new option ``[iscsi]conv_flags``, that specifies the conversion"},{"line_number":5,"context_line":"    options to pass to the ``dd`` utility when copying an image. For example,"},{"line_number":6,"context_line":"    passing ``sparse`` may result in less network traffic for large whole"},{"line_number":7,"context_line":"    disk images."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_68636442","line":4,"updated":"2018-10-12 12:55:46.000000000","message":"nit s/Add/Adds/\n\nnit s/option/configuration option/","commit_id":"ea52bd834d903de744bcf7f34ed5fc7a65b92c4c"}]}
