)]}'
{"ironic/common/glance_service/base_image_service.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"28adb6c024d7fe1e640078b6e518f6bac0067f5a","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # NOTE(dtantsur): when using Glance V2, image_chunks is a wrapper"},{"line_number":220,"context_line":"        # around real data, so we have to check the wrapped data for None."},{"line_number":221,"context_line":"        # Glance V1 returns HTTP 404 in this case, so no need to fix it."},{"line_number":222,"context_line":"        # TODO(dtantsur): remove the hasattr check when we no longer support"},{"line_number":223,"context_line":"        # Glance V1."},{"line_number":224,"context_line":"        if hasattr(image_chunks, \u0027wrapped\u0027) and image_chunks.wrapped is None:"},{"line_number":225,"context_line":"            raise exception.ImageDownloadFailed("},{"line_number":226,"context_line":"                image_href\u003dimage_href, reason\u003d_(\u0027image contains no data.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0f6c7dce","line":223,"range":{"start_line":222,"start_character":0,"end_line":223,"end_character":20},"updated":"2018-10-10 02:07:59.000000000","message":"should this be cleaned up in this patch?","commit_id":"6290eb58d4fdba5947d8e1fc8ef98c80d3404b37"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fcd9a68ae43ba51940ddc23af5b9b6852bba0c77","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # NOTE(dtantsur): when using Glance V2, image_chunks is a wrapper"},{"line_number":220,"context_line":"        # around real data, so we have to check the wrapped data for None."},{"line_number":221,"context_line":"        # Glance V1 returns HTTP 404 in this case, so no need to fix it."},{"line_number":222,"context_line":"        # TODO(dtantsur): remove the hasattr check when we no longer support"},{"line_number":223,"context_line":"        # Glance V1."},{"line_number":224,"context_line":"        if hasattr(image_chunks, \u0027wrapped\u0027) and image_chunks.wrapped is None:"},{"line_number":225,"context_line":"            raise exception.ImageDownloadFailed("},{"line_number":226,"context_line":"                image_href\u003dimage_href, reason\u003d_(\u0027image contains no data.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_dd759bca","line":223,"range":{"start_line":222,"start_character":0,"end_line":223,"end_character":20},"in_reply_to":"3f79a3b5_0f6c7dce","updated":"2018-10-12 10:15:24.000000000","message":"Done","commit_id":"6290eb58d4fdba5947d8e1fc8ef98c80d3404b37"}],"ironic/common/glance_service/service_utils.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"28adb6c024d7fe1e640078b6e518f6bac0067f5a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                     \u0027deleted_at\u0027, \u0027deleted\u0027, \u0027status\u0027,"},{"line_number":41,"context_line":"                     \u0027min_disk\u0027, \u0027min_ram\u0027, \u0027tags\u0027, \u0027visibility\u0027,"},{"line_number":42,"context_line":"                     \u0027protected\u0027, \u0027file\u0027, \u0027schema\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _extract_attributes(image):"},{"line_number":46,"context_line":"    output \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8f73ad4e","line":43,"updated":"2018-10-10 02:07:59.000000000","message":"something not directly related with this patch, just a quick ask.\nwrt the enhanced checksum support, I wonder if we want to put os_hash_algo and os_hash_value into this dict? It seems attributes not listed will be put into properties, so they are still accessible.","commit_id":"6290eb58d4fdba5947d8e1fc8ef98c80d3404b37"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"5076f0633583990354b76ac46da413b25371cb6d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                     \u0027deleted_at\u0027, \u0027deleted\u0027, \u0027status\u0027,"},{"line_number":41,"context_line":"                     \u0027min_disk\u0027, \u0027min_ram\u0027, \u0027tags\u0027, \u0027visibility\u0027,"},{"line_number":42,"context_line":"                     \u0027protected\u0027, \u0027file\u0027, \u0027schema\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _extract_attributes(image):"},{"line_number":46,"context_line":"    output \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d3d56b48","line":43,"in_reply_to":"3f79a3b5_1d59d359","updated":"2018-10-15 03:59:10.000000000","message":"Got it, thanks!","commit_id":"6290eb58d4fdba5947d8e1fc8ef98c80d3404b37"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fcd9a68ae43ba51940ddc23af5b9b6852bba0c77","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                     \u0027deleted_at\u0027, \u0027deleted\u0027, \u0027status\u0027,"},{"line_number":41,"context_line":"                     \u0027min_disk\u0027, \u0027min_ram\u0027, \u0027tags\u0027, \u0027visibility\u0027,"},{"line_number":42,"context_line":"                     \u0027protected\u0027, \u0027file\u0027, \u0027schema\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _extract_attributes(image):"},{"line_number":46,"context_line":"    output \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1d59d359","line":43,"in_reply_to":"3f79a3b5_8f73ad4e","updated":"2018-10-12 10:15:24.000000000","message":"if they\u0027re primary properties, they should be put here. Judging by https://developer.openstack.org/api-ref/image/v2/index.html#show-image they are indeed.","commit_id":"6290eb58d4fdba5947d8e1fc8ef98c80d3404b37"}]}