)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a984e9e628ca6711b5702060ae8418c8bf311877","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make iLO BIOS interface clean steps asynchronous"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I00deaa2f2b68d2a34f8592ea20c36349a87d6c23"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_4ed2b0ff","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"updated":"2018-10-07 14:03:09.000000000","message":"Add story/task for this.","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6295188044a3dbb160fa79e74964e599a578a40d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make iLO BIOS interface clean steps asynchronous"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I00deaa2f2b68d2a34f8592ea20c36349a87d6c23"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_30916647","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"in_reply_to":"3f79a3b5_4ed2b0ff","updated":"2018-10-11 16:45:30.000000000","message":"Done","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"}],"ironic/conf/ilo.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                      \u0027\"auto\" for backward compatibility. When \"auto\" is \u0027"},{"line_number":89,"context_line":"                      \u0027specified, default boot mode will be selected based \u0027"},{"line_number":90,"context_line":"                      \u0027on boot mode settings on the system.\u0027)),"},{"line_number":91,"context_line":"    cfg.IntOpt(\u0027query_post_status_inerval\u0027,"},{"line_number":92,"context_line":"               min\u003d10,"},{"line_number":93,"context_line":"               default\u003d20,"},{"line_number":94,"context_line":"               help\u003d_(\u0027Interval (in seconds) between periodic POST status \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_215d6ceb","line":91,"range":{"start_line":91,"start_character":34,"end_line":91,"end_character":41},"updated":"2018-10-26 07:22:32.000000000","message":"s/ inerval / interval /","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1f8896720903444bd0ea2d200422541c8b235fc","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                      \u0027\"auto\" for backward compatibility. When \"auto\" is \u0027"},{"line_number":89,"context_line":"                      \u0027specified, default boot mode will be selected based \u0027"},{"line_number":90,"context_line":"                      \u0027on boot mode settings on the system.\u0027)),"},{"line_number":91,"context_line":"    cfg.IntOpt(\u0027query_post_status_inerval\u0027,"},{"line_number":92,"context_line":"               min\u003d10,"},{"line_number":93,"context_line":"               default\u003d20,"},{"line_number":94,"context_line":"               help\u003d_(\u0027Interval (in seconds) between periodic POST status \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c3878b0a","line":91,"range":{"start_line":91,"start_character":34,"end_line":91,"end_character":41},"in_reply_to":"3f79a3b5_215d6ceb","updated":"2018-10-31 11:51:08.000000000","message":"Done","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                      \u0027specified, default boot mode will be selected based \u0027"},{"line_number":90,"context_line":"                      \u0027on boot mode settings on the system.\u0027)),"},{"line_number":91,"context_line":"    cfg.IntOpt(\u0027query_post_status_inerval\u0027,"},{"line_number":92,"context_line":"               min\u003d10,"},{"line_number":93,"context_line":"               default\u003d20,"},{"line_number":94,"context_line":"               help\u003d_(\u0027Interval (in seconds) between periodic POST status \u0027"},{"line_number":95,"context_line":"                      \u0027checks to determine whether the node is finished\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_013dd08b","line":92,"range":{"start_line":92,"start_character":15,"end_line":92,"end_character":22},"updated":"2018-10-26 07:22:32.000000000","message":"May be we can remove \u0027min\u0027 value and use the same config parameter to enable/disable periodic task. If the value of this is \u003c 0, we can assume its disabled. See [1]\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1603-L1604","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1f8896720903444bd0ea2d200422541c8b235fc","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                      \u0027specified, default boot mode will be selected based \u0027"},{"line_number":90,"context_line":"                      \u0027on boot mode settings on the system.\u0027)),"},{"line_number":91,"context_line":"    cfg.IntOpt(\u0027query_post_status_inerval\u0027,"},{"line_number":92,"context_line":"               min\u003d10,"},{"line_number":93,"context_line":"               default\u003d20,"},{"line_number":94,"context_line":"               help\u003d_(\u0027Interval (in seconds) between periodic POST status \u0027"},{"line_number":95,"context_line":"                      \u0027checks to determine whether the node is finished\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e38c072f","line":92,"range":{"start_line":92,"start_character":15,"end_line":92,"end_character":22},"in_reply_to":"3f79a3b5_013dd08b","updated":"2018-10-31 11:51:08.000000000","message":"Done","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"               default\u003d20,"},{"line_number":94,"context_line":"               help\u003d_(\u0027Interval (in seconds) between periodic POST status \u0027"},{"line_number":95,"context_line":"                      \u0027checks to determine whether the node is finished\u0027"},{"line_number":96,"context_line":"                      \u0027 POST or not after power cycle.\u0027)),"},{"line_number":97,"context_line":"    cfg.BoolOpt(\u0027enable_post_status_periodic_task\u0027,"},{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d_(\u0027Whether to enable the periodic task to check the POST \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c605ae16","line":96,"range":{"start_line":96,"start_character":22,"end_line":96,"end_character":28},"updated":"2018-10-26 07:22:32.000000000","message":"Move the space (\u0027 \u0027) to end of L95","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1f8896720903444bd0ea2d200422541c8b235fc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"               default\u003d20,"},{"line_number":94,"context_line":"               help\u003d_(\u0027Interval (in seconds) between periodic POST status \u0027"},{"line_number":95,"context_line":"                      \u0027checks to determine whether the node is finished\u0027"},{"line_number":96,"context_line":"                      \u0027 POST or not after power cycle.\u0027)),"},{"line_number":97,"context_line":"    cfg.BoolOpt(\u0027enable_post_status_periodic_task\u0027,"},{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d_(\u0027Whether to enable the periodic task to check the POST \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a3960f3d","line":96,"range":{"start_line":96,"start_character":22,"end_line":96,"end_character":28},"in_reply_to":"3f79a3b5_c605ae16","updated":"2018-10-31 11:51:08.000000000","message":"Done","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"               help\u003d_(\u0027Interval (in seconds) between periodic POST status \u0027"},{"line_number":95,"context_line":"                      \u0027checks to determine whether the node is finished\u0027"},{"line_number":96,"context_line":"                      \u0027 POST or not after power cycle.\u0027)),"},{"line_number":97,"context_line":"    cfg.BoolOpt(\u0027enable_post_status_periodic_task\u0027,"},{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d_(\u0027Whether to enable the periodic task to check the POST \u0027"},{"line_number":100,"context_line":"                       \u0027status of the node after the power cycle when \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_614da43a","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":51},"updated":"2018-10-26 07:22:32.000000000","message":"See comment above.","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dee2f8a203c76b61abfaa493aebc3e6ad04e2aab","unresolved":false,"context_lines":[{"line_number":94,"context_line":"               help\u003d_(\u0027Interval (in seconds) between periodic POST status \u0027"},{"line_number":95,"context_line":"                      \u0027checks to determine whether the node is finished\u0027"},{"line_number":96,"context_line":"                      \u0027 POST or not after power cycle.\u0027)),"},{"line_number":97,"context_line":"    cfg.BoolOpt(\u0027enable_post_status_periodic_task\u0027,"},{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d_(\u0027Whether to enable the periodic task to check the POST \u0027"},{"line_number":100,"context_line":"                       \u0027status of the node after the power cycle when \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c5868816","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":51},"in_reply_to":"3f79a3b5_23a2ff98","updated":"2018-11-02 05:11:25.000000000","message":"Its at L92. We can do away with this variable if we use value of \u0027\u003c 0\u0027 for query_post_status_inerval as indication to disable the periodic task. See [1]\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1603-L1604","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1f8896720903444bd0ea2d200422541c8b235fc","unresolved":false,"context_lines":[{"line_number":94,"context_line":"               help\u003d_(\u0027Interval (in seconds) between periodic POST status \u0027"},{"line_number":95,"context_line":"                      \u0027checks to determine whether the node is finished\u0027"},{"line_number":96,"context_line":"                      \u0027 POST or not after power cycle.\u0027)),"},{"line_number":97,"context_line":"    cfg.BoolOpt(\u0027enable_post_status_periodic_task\u0027,"},{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d_(\u0027Whether to enable the periodic task to check the POST \u0027"},{"line_number":100,"context_line":"                       \u0027status of the node after the power cycle when \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_23a2ff98","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":51},"in_reply_to":"3f79a3b5_614da43a","updated":"2018-10-31 11:51:08.000000000","message":"I didn\u0027t get which line you were refering to.","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d_(\u0027Whether to enable the periodic task to check the POST \u0027"},{"line_number":100,"context_line":"                       \u0027status of the node after the power cycle when \u0027"},{"line_number":101,"context_line":"                       \u0027executing certain clean steps. If not enabled, \u0027"},{"line_number":102,"context_line":"                       \u0027executing certain asynchronous clean steps will \u0027"},{"line_number":103,"context_line":"                       \u0027fail.\u0027)),"},{"line_number":104,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a13dfcbc","line":101,"range":{"start_line":101,"start_character":34,"end_line":101,"end_character":53},"updated":"2018-10-26 07:22:32.000000000","message":"s/ certain clean steps / certain asynchronous clean steps /","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1f8896720903444bd0ea2d200422541c8b235fc","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                default\u003dTrue,"},{"line_number":99,"context_line":"                help\u003d_(\u0027Whether to enable the periodic task to check the POST \u0027"},{"line_number":100,"context_line":"                       \u0027status of the node after the power cycle when \u0027"},{"line_number":101,"context_line":"                       \u0027executing certain clean steps. If not enabled, \u0027"},{"line_number":102,"context_line":"                       \u0027executing certain asynchronous clean steps will \u0027"},{"line_number":103,"context_line":"                       \u0027fail.\u0027)),"},{"line_number":104,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_83aaf36a","line":101,"range":{"start_line":101,"start_character":34,"end_line":101,"end_character":53},"in_reply_to":"3f79a3b5_a13dfcbc","updated":"2018-10-31 11:51:08.000000000","message":"Done","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                help\u003d_(\u0027Whether to enable the periodic task to check the POST \u0027"},{"line_number":100,"context_line":"                       \u0027status of the node after the power cycle when \u0027"},{"line_number":101,"context_line":"                       \u0027executing certain clean steps. If not enabled, \u0027"},{"line_number":102,"context_line":"                       \u0027executing certain asynchronous clean steps will \u0027"},{"line_number":103,"context_line":"                       \u0027fail.\u0027)),"},{"line_number":104,"context_line":"]"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_21256cae","line":102,"range":{"start_line":102,"start_character":24,"end_line":102,"end_character":54},"updated":"2018-10-26 07:22:32.000000000","message":"s/ executing certain asynchronous / execution of these /","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1f8896720903444bd0ea2d200422541c8b235fc","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                help\u003d_(\u0027Whether to enable the periodic task to check the POST \u0027"},{"line_number":100,"context_line":"                       \u0027status of the node after the power cycle when \u0027"},{"line_number":101,"context_line":"                       \u0027executing certain clean steps. If not enabled, \u0027"},{"line_number":102,"context_line":"                       \u0027executing certain asynchronous clean steps will \u0027"},{"line_number":103,"context_line":"                       \u0027fail.\u0027)),"},{"line_number":104,"context_line":"]"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a3afef7a","line":102,"range":{"start_line":102,"start_character":24,"end_line":102,"end_character":54},"in_reply_to":"3f79a3b5_21256cae","updated":"2018-10-31 11:51:08.000000000","message":"Done","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"}],"ironic/drivers/modules/ilo/bios.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a984e9e628ca6711b5702060ae8418c8bf311877","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        ilo_common.parse_driver_info(task.node)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @METRICS.timer(\u0027IloBIOS._query_post_status\u0027)"},{"line_number":60,"context_line":"    @periodics.periodic(spacing\u003d20)"},{"line_number":61,"context_line":"    def _query_post_status(self, manager, context):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        filters \u003d {\u0027reserved\u0027: False, \u0027provision_state\u0027: states.CLEANWAIT,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_aeb024ff","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":34},"updated":"2018-10-07 14:03:09.000000000","message":"This needs to be configurable.","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6295188044a3dbb160fa79e74964e599a578a40d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        ilo_common.parse_driver_info(task.node)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @METRICS.timer(\u0027IloBIOS._query_post_status\u0027)"},{"line_number":60,"context_line":"    @periodics.periodic(spacing\u003d20)"},{"line_number":61,"context_line":"    def _query_post_status(self, manager, context):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        filters \u003d {\u0027reserved\u0027: False, \u0027provision_state\u0027: states.CLEANWAIT,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d007d2c7","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":34},"in_reply_to":"3f79a3b5_aeb024ff","updated":"2018-10-11 16:45:30.000000000","message":"Done","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a984e9e628ca6711b5702060ae8418c8bf311877","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":79,"context_line":"                    apply_bios \u003d driver_internal_info.get(\"apply_bios\")"},{"line_number":80,"context_line":"                    reset_bios \u003d driver_internal_info.get(\"reset_bios\")"},{"line_number":81,"context_line":"                    ilo_object \u003d ilo_common.get_ilo_object(task.node)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"                    if not apply_bios and not reset_bios:"},{"line_number":84,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ceb560ef","line":81,"range":{"start_line":81,"start_character":20,"end_line":81,"end_character":69},"updated":"2018-10-07 14:03:09.000000000","message":"Better to move this to L85 to avoid few proliant calls being made while cerating iLO object in case it returns from L83.","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6295188044a3dbb160fa79e74964e599a578a40d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":79,"context_line":"                    apply_bios \u003d driver_internal_info.get(\"apply_bios\")"},{"line_number":80,"context_line":"                    reset_bios \u003d driver_internal_info.get(\"reset_bios\")"},{"line_number":81,"context_line":"                    ilo_object \u003d ilo_common.get_ilo_object(task.node)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"                    if not apply_bios and not reset_bios:"},{"line_number":84,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_90f5dace","line":81,"range":{"start_line":81,"start_character":20,"end_line":81,"end_character":69},"in_reply_to":"3f79a3b5_ceb560ef","updated":"2018-10-11 16:45:30.000000000","message":"Done","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a984e9e628ca6711b5702060ae8418c8bf311877","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        continue"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"                    task.upgrade_lock()"},{"line_number":87,"context_line":"                    task.node.touch_provisioning()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"                    if ilo_object.get_host_post_state() in ("},{"line_number":90,"context_line":"                            \u0027FinishedPost\u0027, \u0027InPostDiscoveryComplete\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6eca0c70","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":50},"updated":"2018-10-07 14:03:09.000000000","message":"Need to ensure that the provision_state  is still CLAENWAIT after upgrading the lock.\nif node.provision_state !\u003d states.CLEANWAIT:\n    continue","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        continue"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"                    task.upgrade_lock()"},{"line_number":87,"context_line":"                    task.node.touch_provisioning()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"                    if ilo_object.get_host_post_state() in ("},{"line_number":90,"context_line":"                            \u0027FinishedPost\u0027, \u0027InPostDiscoveryComplete\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a11e5c0a","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":50},"in_reply_to":"3f79a3b5_30be46d4","updated":"2018-10-26 07:22:32.000000000","message":"Pleae see [1]\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/irmc/raid.py#L451-L453","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6295188044a3dbb160fa79e74964e599a578a40d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        continue"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"                    task.upgrade_lock()"},{"line_number":87,"context_line":"                    task.node.touch_provisioning()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"                    if ilo_object.get_host_post_state() in ("},{"line_number":90,"context_line":"                            \u0027FinishedPost\u0027, \u0027InPostDiscoveryComplete\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_30be46d4","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":50},"in_reply_to":"3f79a3b5_6eca0c70","updated":"2018-10-11 16:45:30.000000000","message":"I didn\u0027t get the reason. We got here because it is in CLEANWAIT state. It\u0027s going to be a redundant check. I also don\u0027t see such checks at other instances of the method usage.","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a984e9e628ca6711b5702060ae8418c8bf311877","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                            ilo_object.get_bios_settings_result())"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"                        if status.get(\u0027status\u0027) \u003d\u003d \u0027failed\u0027:"},{"line_number":106,"context_line":"                            errmsg \u003d _(\"Error applying BIOS settings on the \""},{"line_number":107,"context_line":"                                       \"node with ID %(node)s.\""},{"line_number":108,"context_line":"                                       \" Error: %(results)s\")"},{"line_number":109,"context_line":"                            ilo_common.set_clean_failed("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2ed5f4e6","line":106,"range":{"start_line":106,"start_character":46,"end_line":106,"end_character":54},"updated":"2018-10-07 14:03:09.000000000","message":"It could be applying or resetting based upon the corresponding clean step call.","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6295188044a3dbb160fa79e74964e599a578a40d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                            ilo_object.get_bios_settings_result())"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"                        if status.get(\u0027status\u0027) \u003d\u003d \u0027failed\u0027:"},{"line_number":106,"context_line":"                            errmsg \u003d _(\"Error applying BIOS settings on the \""},{"line_number":107,"context_line":"                                       \"node with ID %(node)s.\""},{"line_number":108,"context_line":"                                       \" Error: %(results)s\")"},{"line_number":109,"context_line":"                            ilo_common.set_clean_failed("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b0c9f679","line":106,"range":{"start_line":106,"start_character":46,"end_line":106,"end_character":54},"in_reply_to":"3f79a3b5_2ed5f4e6","updated":"2018-10-11 16:45:30.000000000","message":"Done","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a984e9e628ca6711b5702060ae8418c8bf311877","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"                        if status.get(\u0027status\u0027) \u003d\u003d \u0027failed\u0027:"},{"line_number":106,"context_line":"                            errmsg \u003d _(\"Error applying BIOS settings on the \""},{"line_number":107,"context_line":"                                       \"node with ID %(node)s.\""},{"line_number":108,"context_line":"                                       \" Error: %(results)s\")"},{"line_number":109,"context_line":"                            ilo_common.set_clean_failed("},{"line_number":110,"context_line":"                                task, errmsg % {\u0027node\u0027: node_uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0ea118a9","line":107,"range":{"start_line":107,"start_character":61,"end_line":107,"end_character":63},"updated":"2018-10-07 14:03:09.000000000","message":"As per convention space \u0027 \u0027 needs to be here.","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a984e9e628ca6711b5702060ae8418c8bf311877","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"                        if status.get(\u0027status\u0027) \u003d\u003d \u0027failed\u0027:"},{"line_number":106,"context_line":"                            errmsg \u003d _(\"Error applying BIOS settings on the \""},{"line_number":107,"context_line":"                                       \"node with ID %(node)s.\""},{"line_number":108,"context_line":"                                       \" Error: %(results)s\")"},{"line_number":109,"context_line":"                            ilo_common.set_clean_failed("},{"line_number":110,"context_line":"                                task, errmsg % {\u0027node\u0027: node_uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2e997479","line":107,"range":{"start_line":107,"start_character":45,"end_line":107,"end_character":62},"updated":"2018-10-07 14:03:09.000000000","message":"No need to pass the node id here set_clean_failed() updates the node id into the message.","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6295188044a3dbb160fa79e74964e599a578a40d","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"                        if status.get(\u0027status\u0027) \u003d\u003d \u0027failed\u0027:"},{"line_number":106,"context_line":"                            errmsg \u003d _(\"Error applying BIOS settings on the \""},{"line_number":107,"context_line":"                                       \"node with ID %(node)s.\""},{"line_number":108,"context_line":"                                       \" Error: %(results)s\")"},{"line_number":109,"context_line":"                            ilo_common.set_clean_failed("},{"line_number":110,"context_line":"                                task, errmsg % {\u0027node\u0027: node_uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_70bfdec9","line":107,"range":{"start_line":107,"start_character":61,"end_line":107,"end_character":63},"in_reply_to":"3f79a3b5_0ea118a9","updated":"2018-10-11 16:45:30.000000000","message":"Done","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6295188044a3dbb160fa79e74964e599a578a40d","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"                        if status.get(\u0027status\u0027) \u003d\u003d \u0027failed\u0027:"},{"line_number":106,"context_line":"                            errmsg \u003d _(\"Error applying BIOS settings on the \""},{"line_number":107,"context_line":"                                       \"node with ID %(node)s.\""},{"line_number":108,"context_line":"                                       \" Error: %(results)s\")"},{"line_number":109,"context_line":"                            ilo_common.set_clean_failed("},{"line_number":110,"context_line":"                                task, errmsg % {\u0027node\u0027: node_uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_109eaa68","line":107,"range":{"start_line":107,"start_character":45,"end_line":107,"end_character":62},"in_reply_to":"3f79a3b5_2e997479","updated":"2018-10-11 16:45:30.000000000","message":"Done","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a984e9e628ca6711b5702060ae8418c8bf311877","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                            manager_utils.notify_conductor_resume_clean(task)"},{"line_number":117,"context_line":"            except ilo_error.IloError as ilo_exception:"},{"line_number":118,"context_line":"                errmsg \u003d _(\"Failed to run BIOS clean step on the\""},{"line_number":119,"context_line":"                           \"node with ID %(node)s. Error: %(exc)s.\")"},{"line_number":120,"context_line":"                ilo_common.set_clean_failed("},{"line_number":121,"context_line":"                    task, errmsg % {\u0027node\u0027: node_uuid, \u0027exc\u0027: ilo_exception})"},{"line_number":122,"context_line":"            except exception.NodeNotFound:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4e96304c","line":119,"range":{"start_line":119,"start_character":28,"end_line":119,"end_character":50},"updated":"2018-10-07 14:03:09.000000000","message":"ditto","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6295188044a3dbb160fa79e74964e599a578a40d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                            manager_utils.notify_conductor_resume_clean(task)"},{"line_number":117,"context_line":"            except ilo_error.IloError as ilo_exception:"},{"line_number":118,"context_line":"                errmsg \u003d _(\"Failed to run BIOS clean step on the\""},{"line_number":119,"context_line":"                           \"node with ID %(node)s. Error: %(exc)s.\")"},{"line_number":120,"context_line":"                ilo_common.set_clean_failed("},{"line_number":121,"context_line":"                    task, errmsg % {\u0027node\u0027: node_uuid, \u0027exc\u0027: ilo_exception})"},{"line_number":122,"context_line":"            except exception.NodeNotFound:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_30a3a6b3","line":119,"range":{"start_line":119,"start_character":28,"end_line":119,"end_character":50},"in_reply_to":"3f79a3b5_4e96304c","updated":"2018-10-11 16:45:30.000000000","message":"Done","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a984e9e628ca6711b5702060ae8418c8bf311877","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":164,"context_line":"                errmsg % {\u0027node\u0027: node.uuid, \u0027err\u0027: ir_exception})"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        deploy_opts \u003d deploy_utils.build_agent_options(task.node)"},{"line_number":167,"context_line":"        task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":168,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":169,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":170,"context_line":"        driver_internal_info[\u0027cleaning_reboot\u0027] \u003d True"},{"line_number":171,"context_line":"        driver_internal_info[\u0027apply_bios\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0eb838c5","line":168,"range":{"start_line":166,"start_character":8,"end_line":168,"end_character":60},"updated":"2018-10-07 14:03:09.000000000","message":"For any exception here, node cleaning needs to be failed. May be we can use this method instead [1]\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent_base_vendor.py#L121-L145","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6295188044a3dbb160fa79e74964e599a578a40d","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":164,"context_line":"                errmsg % {\u0027node\u0027: node.uuid, \u0027err\u0027: ir_exception})"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        deploy_opts \u003d deploy_utils.build_agent_options(task.node)"},{"line_number":167,"context_line":"        task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":168,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":169,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":170,"context_line":"        driver_internal_info[\u0027cleaning_reboot\u0027] \u003d True"},{"line_number":171,"context_line":"        driver_internal_info[\u0027apply_bios\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_506662be","line":168,"range":{"start_line":166,"start_character":8,"end_line":168,"end_character":60},"in_reply_to":"3f79a3b5_0eb838c5","updated":"2018-10-11 16:45:30.000000000","message":"I thought of using it initially. But it was a private method and would not be appropriate to use in the other files as-is. May require to be changed in multiple files to make it public. Also the implementation is trivial.","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a984e9e628ca6711b5702060ae8418c8bf311877","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":199,"context_line":"                errmsg % {\u0027node\u0027: node.uuid, \u0027err\u0027: ir_exception})"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        deploy_opts \u003d deploy_utils.build_agent_options(task.node)"},{"line_number":202,"context_line":"        task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":203,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":204,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":205,"context_line":"        driver_internal_info[\u0027cleaning_reboot\u0027] \u003d True"},{"line_number":206,"context_line":"        driver_internal_info[\u0027reset_bios\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_aeaca488","line":203,"range":{"start_line":201,"start_character":0,"end_line":203,"end_character":60},"updated":"2018-10-07 14:03:09.000000000","message":"ditto","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6295188044a3dbb160fa79e74964e599a578a40d","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":199,"context_line":"                errmsg % {\u0027node\u0027: node.uuid, \u0027err\u0027: ir_exception})"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        deploy_opts \u003d deploy_utils.build_agent_options(task.node)"},{"line_number":202,"context_line":"        task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":203,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":204,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":205,"context_line":"        driver_internal_info[\u0027cleaning_reboot\u0027] \u003d True"},{"line_number":206,"context_line":"        driver_internal_info[\u0027reset_bios\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_10022abb","line":203,"range":{"start_line":201,"start_character":0,"end_line":203,"end_character":60},"in_reply_to":"3f79a3b5_aeaca488","updated":"2018-10-11 16:45:30.000000000","message":"ditto","commit_id":"edae5fd54f9120a498d78828d29073ca04681832"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                        continue"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"                    driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":81,"context_line":"                    apply_bios \u003d driver_internal_info.get(\"apply_bios\")"},{"line_number":82,"context_line":"                    reset_bios \u003d driver_internal_info.get(\"reset_bios\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"                    if not apply_bios and not reset_bios:"},{"line_number":85,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a1917c55","line":82,"range":{"start_line":81,"start_character":20,"end_line":82,"end_character":71},"updated":"2018-10-26 07:22:32.000000000","message":"Since action is same for both apply_bios and reset_bios we can do:\nbios_operation \u003d (driver_internal_info.get(\"apply_bios\") or  driver_internal_info.get(\"reset_bios\"))","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1f8896720903444bd0ea2d200422541c8b235fc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                        continue"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"                    driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":81,"context_line":"                    apply_bios \u003d driver_internal_info.get(\"apply_bios\")"},{"line_number":82,"context_line":"                    reset_bios \u003d driver_internal_info.get(\"reset_bios\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"                    if not apply_bios and not reset_bios:"},{"line_number":85,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_43761b43","line":82,"range":{"start_line":81,"start_character":20,"end_line":82,"end_character":71},"in_reply_to":"3f79a3b5_a1917c55","updated":"2018-10-31 11:51:08.000000000","message":"Done","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    if ilo_object.get_host_post_state() in ("},{"line_number":93,"context_line":"                            \u0027FinishedPost\u0027, \u0027InPostDiscoveryComplete\u0027):"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"                        if apply_bios:"},{"line_number":96,"context_line":"                            driver_internal_info.pop(\u0027apply_bios\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"                        if reset_bios:"},{"line_number":99,"context_line":"                            driver_internal_info.pop(\u0027reset_bios\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"                        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":102,"context_line":"                        task.node.save()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2187ac14","line":99,"range":{"start_line":95,"start_character":24,"end_line":99,"end_character":66},"updated":"2018-10-26 07:22:32.000000000","message":"We can avoid conditional blocks by just forcing pop:\ndriver_internal_info.pop(\u0027apply_bios\u0027, None)\ndriver_internal_info.pop(\u0027reset_bios\u0027, None)\n\nAlso you can set the string \u0027op_str\u0027 used at L110 before poping\nop_str \u003d \"applying\" if driver_internal_info.get(\"apply_bios\") else \"resetting\"","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1f8896720903444bd0ea2d200422541c8b235fc","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                    if ilo_object.get_host_post_state() in ("},{"line_number":93,"context_line":"                            \u0027FinishedPost\u0027, \u0027InPostDiscoveryComplete\u0027):"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"                        if apply_bios:"},{"line_number":96,"context_line":"                            driver_internal_info.pop(\u0027apply_bios\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"                        if reset_bios:"},{"line_number":99,"context_line":"                            driver_internal_info.pop(\u0027reset_bios\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"                        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":102,"context_line":"                        task.node.save()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_63731751","line":99,"range":{"start_line":95,"start_character":24,"end_line":99,"end_character":66},"in_reply_to":"3f79a3b5_2187ac14","updated":"2018-10-31 11:51:08.000000000","message":"Done","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dee2f8a203c76b61abfaa493aebc3e6ad04e2aab","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                        if status.get(\u0027status\u0027) \u003d\u003d \u0027failed\u0027:"},{"line_number":108,"context_line":"                            errmsg \u003d _(\"Error %(operation)s BIOS settings on \""},{"line_number":109,"context_line":"                                       \"the node. \""},{"line_number":110,"context_line":"                                       \"Error: %(results)s\")"},{"line_number":111,"context_line":"                            ilo_common.set_clean_failed("},{"line_number":112,"context_line":"                                task, errmsg % {\u0027operation\u0027: op_str,"},{"line_number":113,"context_line":"                                                \u0027results\u0027: status.get("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_05a1e092","line":110,"range":{"start_line":110,"start_character":39,"end_line":110,"end_character":60},"updated":"2018-11-02 05:11:25.000000000","message":"nit: This can be moved to L109.","commit_id":"107a146dd0d0e9d1144bdb6e895622680e4b0ed6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dee2f8a203c76b61abfaa493aebc3e6ad04e2aab","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                ilo_error.IloError,"},{"line_number":165,"context_line":"                ilo_error.IloCommandNotSupportedError) as ir_exception:"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            errmsg \u003d _(\"Clean step \\\"apply_configuration\\\" failed \""},{"line_number":168,"context_line":"                       \"on node %(node)s with error: %(err)s\")"},{"line_number":169,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":170,"context_line":"                errmsg % {\u0027node\u0027: node.uuid, \u0027err\u0027: ir_exception})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_8531705b","line":167,"range":{"start_line":167,"start_character":23,"end_line":167,"end_character":67},"updated":"2018-11-02 05:11:25.000000000","message":"Instead of using \u0027\\\u0027 you can format it like:\n\"Clean step \u0027apply_configuration\u0027 failed \"","commit_id":"107a146dd0d0e9d1144bdb6e895622680e4b0ed6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dee2f8a203c76b61abfaa493aebc3e6ad04e2aab","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        except Exception as e:"},{"line_number":173,"context_line":"            errmsg \u003d _(\"Reboot requested by clean step \""},{"line_number":174,"context_line":"                       \"\\\"apply_configuration\\\" failed for \""},{"line_number":175,"context_line":"                       \"node %(node)s: %(err)s\")"},{"line_number":176,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":177,"context_line":"                errmsg % {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_25389c3a","line":174,"range":{"start_line":174,"start_character":23,"end_line":174,"end_character":60},"updated":"2018-11-02 05:11:25.000000000","message":"ditto","commit_id":"107a146dd0d0e9d1144bdb6e895622680e4b0ed6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dee2f8a203c76b61abfaa493aebc3e6ad04e2aab","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        try:"},{"line_number":156,"context_line":"            ilo_object \u003d ilo_common.get_ilo_object(node)"},{"line_number":157,"context_line":"            ilo_object.set_bios_settings(data)"},{"line_number":158,"context_line":"            deploy_opts \u003d deploy_utils.build_agent_options(task.node)"},{"line_number":159,"context_line":"            task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":160,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        except (exception.MissingParameterValue,"},{"line_number":163,"context_line":"                exception.InvalidParameterValue,"},{"line_number":164,"context_line":"                ilo_error.IloError,"},{"line_number":165,"context_line":"                ilo_error.IloCommandNotSupportedError) as ir_exception:"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            errmsg \u003d _(\"Clean step \\\"apply_configuration\\\" failed \""},{"line_number":168,"context_line":"                       \"on node %(node)s with error: %(err)s\")"},{"line_number":169,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":170,"context_line":"                errmsg % {\u0027node\u0027: node.uuid, \u0027err\u0027: ir_exception})"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        except Exception as e:"},{"line_number":173,"context_line":"            errmsg \u003d _(\"Reboot requested by clean step \""},{"line_number":174,"context_line":"                       \"\\\"apply_configuration\\\" failed for \""},{"line_number":175,"context_line":"                       \"node %(node)s: %(err)s\")"},{"line_number":176,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":177,"context_line":"                errmsg % {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":180,"context_line":"        driver_internal_info[\u0027cleaning_reboot\u0027] \u003d True"},{"line_number":181,"context_line":"        driver_internal_info[\u0027apply_bios\u0027] \u003d True"},{"line_number":182,"context_line":"        node.driver_internal_info \u003d driver_internal_info"},{"line_number":183,"context_line":"        node.save()"},{"line_number":184,"context_line":"        return states.CLEANWAIT"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @METRICS.timer(\u0027IloBIOS.factory_reset\u0027)"},{"line_number":187,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_4561183c","line":184,"range":{"start_line":158,"start_character":0,"end_line":184,"end_character":31},"updated":"2018-11-02 05:11:25.000000000","message":"This portion of code is almost common between apply_configuration() and factory_reset() except for the variable set in driver_internal_info and log message. Can we move this to a common private method instead?","commit_id":"107a146dd0d0e9d1144bdb6e895622680e4b0ed6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dee2f8a203c76b61abfaa493aebc3e6ad04e2aab","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                ilo_error.IloError,"},{"line_number":208,"context_line":"                ilo_error.IloCommandNotSupportedError) as ir_exception:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"            errmsg \u003d _(\"Clean step \\\"factory_reset\\\" failed \""},{"line_number":211,"context_line":"                       \"on node %(node)s with error: %(err)s\")"},{"line_number":212,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":213,"context_line":"                errmsg % {\u0027node\u0027: node.uuid, \u0027err\u0027: ir_exception})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_25217cfe","line":210,"range":{"start_line":210,"start_character":35,"end_line":210,"end_character":52},"updated":"2018-11-02 05:11:25.000000000","message":"ditto","commit_id":"107a146dd0d0e9d1144bdb6e895622680e4b0ed6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dee2f8a203c76b61abfaa493aebc3e6ad04e2aab","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        except Exception as e:"},{"line_number":216,"context_line":"            errmsg \u003d _(\"Reboot requested by clean step \""},{"line_number":217,"context_line":"                       \"\\\"factory_reset\\\" failed for \""},{"line_number":218,"context_line":"                       \"node %(node)s: %(err)s\")"},{"line_number":219,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":220,"context_line":"                errmsg % {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_451cb8c2","line":217,"range":{"start_line":217,"start_character":23,"end_line":217,"end_character":54},"updated":"2018-11-02 05:11:25.000000000","message":"ditto","commit_id":"107a146dd0d0e9d1144bdb6e895622680e4b0ed6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"24370b66ab2f94769c8fb140ece5e49932dfaa00","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \"\"\"Perform operations required prior to the reboot."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        Depending on the clean step, it executes the operations required"},{"line_number":62,"context_line":"        and moves the node to clean_wait prior to reboot."},{"line_number":63,"context_line":"        :param task: a task from TaskManager."},{"line_number":64,"context_line":"        :param step: name of the clean step to be performed"},{"line_number":65,"context_line":"        :param data: if the clean step is apply_configuration it holds"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_c9e9ba80","line":62,"range":{"start_line":62,"start_character":30,"end_line":62,"end_character":40},"updated":"2019-01-09 09:36:44.000000000","message":"s/ clean_wait / CLEANWAIT state /","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e501fb976ac767d3079ba43d9d463880f2f52f84","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \"\"\"Perform operations required prior to the reboot."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        Depending on the clean step, it executes the operations required"},{"line_number":62,"context_line":"        and moves the node to clean_wait prior to reboot."},{"line_number":63,"context_line":"        :param task: a task from TaskManager."},{"line_number":64,"context_line":"        :param step: name of the clean step to be performed"},{"line_number":65,"context_line":"        :param data: if the clean step is apply_configuration it holds"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_343fc887","line":62,"range":{"start_line":62,"start_character":30,"end_line":62,"end_character":40},"in_reply_to":"dfd5e7cf_c9e9ba80","updated":"2019-02-02 12:17:28.000000000","message":"Done","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"24370b66ab2f94769c8fb140ece5e49932dfaa00","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            ilo_object.set_bios_settings(data) if step \u003d\u003d ("},{"line_number":89,"context_line":"                \u0027apply_configuration\u0027) else ilo_object.reset_bios_to_default()"},{"line_number":90,"context_line":"        except (ilo_error.IloError,"},{"line_number":91,"context_line":"                ilo_error.IloCommandNotSupportedError) as ilo_exception:"},{"line_number":92,"context_line":"            errmsg \u003d _(\u0027Clean step %(step)s failed \u0027"},{"line_number":93,"context_line":"                       \u0027on the node %(node)s with error: %(err)s\u0027)"},{"line_number":94,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":95,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid,"},{"line_number":96,"context_line":"                          \u0027err\u0027: ilo_exception})"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            deploy_opts \u003d deploy_utils.build_agent_options(node)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_093ca1c6","line":96,"range":{"start_line":90,"start_character":8,"end_line":96,"end_character":48},"updated":"2019-01-09 09:36:44.000000000","message":"Since the exception handling behavior is same, may be we can remove this additional try/except block and move L88-L89 to L78","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e501fb976ac767d3079ba43d9d463880f2f52f84","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            ilo_object.set_bios_settings(data) if step \u003d\u003d ("},{"line_number":89,"context_line":"                \u0027apply_configuration\u0027) else ilo_object.reset_bios_to_default()"},{"line_number":90,"context_line":"        except (ilo_error.IloError,"},{"line_number":91,"context_line":"                ilo_error.IloCommandNotSupportedError) as ilo_exception:"},{"line_number":92,"context_line":"            errmsg \u003d _(\u0027Clean step %(step)s failed \u0027"},{"line_number":93,"context_line":"                       \u0027on the node %(node)s with error: %(err)s\u0027)"},{"line_number":94,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":95,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid,"},{"line_number":96,"context_line":"                          \u0027err\u0027: ilo_exception})"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            deploy_opts \u003d deploy_utils.build_agent_options(node)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_54428c10","line":96,"range":{"start_line":90,"start_character":8,"end_line":96,"end_character":48},"in_reply_to":"dfd5e7cf_093ca1c6","updated":"2019-02-02 12:17:28.000000000","message":"Done","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"24370b66ab2f94769c8fb140ece5e49932dfaa00","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        if step not in (\u0027apply_configuration\u0027, \u0027factory_reset\u0027):"},{"line_number":133,"context_line":"            errmsg \u003d _(\u0027Could not find the step %(step)s for the \u0027"},{"line_number":134,"context_line":"                       \u0027node %(node)s.\u0027)"},{"line_number":135,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":136,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid})"},{"line_number":137,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_099821be","line":135,"range":{"start_line":135,"start_character":12,"end_line":135,"end_character":48},"updated":"2019-01-09 09:36:44.000000000","message":"Need to pop variables set in driver_internal_info so that they do not impact subsequent clean step execution.","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e501fb976ac767d3079ba43d9d463880f2f52f84","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        if step not in (\u0027apply_configuration\u0027, \u0027factory_reset\u0027):"},{"line_number":133,"context_line":"            errmsg \u003d _(\u0027Could not find the step %(step)s for the \u0027"},{"line_number":134,"context_line":"                       \u0027node %(node)s.\u0027)"},{"line_number":135,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":136,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid})"},{"line_number":137,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_f44ce042","line":135,"range":{"start_line":135,"start_character":12,"end_line":135,"end_character":48},"in_reply_to":"dfd5e7cf_099821be","updated":"2019-02-02 12:17:28.000000000","message":"Done.","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"24370b66ab2f94769c8fb140ece5e49932dfaa00","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                exception.InvalidParameterValue) as ir_exception:"},{"line_number":143,"context_line":"            errmsg \u003d _(\u0027Clean step %(step)s failed \u0027"},{"line_number":144,"context_line":"                       \u0027on the node %(node)s with error: %(err)s\u0027)"},{"line_number":145,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":146,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid,"},{"line_number":147,"context_line":"                          \u0027err\u0027: ir_exception})"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_2993a5a5","line":145,"range":{"start_line":145,"start_character":12,"end_line":145,"end_character":48},"updated":"2019-01-09 09:36:44.000000000","message":"ditto","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e501fb976ac767d3079ba43d9d463880f2f52f84","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                exception.InvalidParameterValue) as ir_exception:"},{"line_number":143,"context_line":"            errmsg \u003d _(\u0027Clean step %(step)s failed \u0027"},{"line_number":144,"context_line":"                       \u0027on the node %(node)s with error: %(err)s\u0027)"},{"line_number":145,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":146,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid,"},{"line_number":147,"context_line":"                          \u0027err\u0027: ir_exception})"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_1448842a","line":145,"range":{"start_line":145,"start_character":12,"end_line":145,"end_character":48},"in_reply_to":"dfd5e7cf_2993a5a5","updated":"2019-02-02 12:17:28.000000000","message":"Done","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"24370b66ab2f94769c8fb140ece5e49932dfaa00","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid,"},{"line_number":147,"context_line":"                          \u0027err\u0027: ir_exception})"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        task.driver.bios.cache_bios_settings(task)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        driver_internal_info.pop(\u0027apply_bios\u0027, None) if step \u003d\u003d ("},{"line_number":152,"context_line":"            \u0027apply_configuration\u0027) else driver_internal_info.pop("}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_a909d595","line":149,"range":{"start_line":149,"start_character":8,"end_line":149,"end_character":50},"updated":"2019-01-09 09:36:44.000000000","message":"We do not need to call this. It would get called when apply_configuration and factory_reset have finished [1].\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L1010-L1024","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e501fb976ac767d3079ba43d9d463880f2f52f84","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid,"},{"line_number":147,"context_line":"                          \u0027err\u0027: ir_exception})"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        task.driver.bios.cache_bios_settings(task)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        driver_internal_info.pop(\u0027apply_bios\u0027, None) if step \u003d\u003d ("},{"line_number":152,"context_line":"            \u0027apply_configuration\u0027) else driver_internal_info.pop("}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_d44d1c3b","line":149,"range":{"start_line":149,"start_character":8,"end_line":149,"end_character":50},"in_reply_to":"dfd5e7cf_a909d595","updated":"2019-02-02 12:17:28.000000000","message":"At any point of time during the clean step we don\u0027t want the database to be inconsistent with the server. So we make sure we cache the setting irrespective of any further processing. And yes, the decorator takes care of it but we can not avoid it as it is part of the framewrk.","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"24370b66ab2f94769c8fb140ece5e49932dfaa00","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        task.driver.bios.cache_bios_settings(task)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        driver_internal_info.pop(\u0027apply_bios\u0027, None) if step \u003d\u003d ("},{"line_number":152,"context_line":"            \u0027apply_configuration\u0027) else driver_internal_info.pop("},{"line_number":153,"context_line":"            \u0027reset_bios\u0027, None)"},{"line_number":154,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":155,"context_line":"        task.node.save()"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_89d2d15b","line":153,"range":{"start_line":151,"start_character":7,"end_line":153,"end_character":31},"updated":"2019-01-09 09:36:44.000000000","message":"Can be done without check for the step name.\ndriver_internal_info.pop(\u0027apply_bios\u0027)\ndriver_internal_info.pop(\u0027reset_bios\u0027)","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dda25b88a468cb057ae8f4d60a0f8f2b24d9ac2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from ironic.common.i18n import _"},{"line_number":24,"context_line":"from ironic.common import states"},{"line_number":25,"context_line":"from ironic.conductor import utils as manager_utils"},{"line_number":26,"context_line":"from ironic import conf"},{"line_number":27,"context_line":"from ironic.drivers import base"},{"line_number":28,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":29,"context_line":"from ironic.drivers.modules.ilo import common as ilo_common"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_399d8109","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":23},"updated":"2019-02-04 06:56:25.000000000","message":"This can be removed.","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"bfdd32b1020cc442dd2476f1746cdab1f74e1eed","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from ironic.common.i18n import _"},{"line_number":24,"context_line":"from ironic.common import states"},{"line_number":25,"context_line":"from ironic.conductor import utils as manager_utils"},{"line_number":26,"context_line":"from ironic import conf"},{"line_number":27,"context_line":"from ironic.drivers import base"},{"line_number":28,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":29,"context_line":"from ironic.drivers.modules.ilo import common as ilo_common"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_d3e8c9e2","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":23},"in_reply_to":"9fdfeff1_399d8109","updated":"2019-02-04 11:13:20.000000000","message":"Done","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dda25b88a468cb057ae8f4d60a0f8f2b24d9ac2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from ironic import objects"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"CONF \u003d conf.CONF"},{"line_number":34,"context_line":"METRICS \u003d metrics_utils.get_metrics_logger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"ilo_error \u003d importutils.try_import(\u0027proliantutils.exception\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_999a6d11","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":16},"updated":"2019-02-04 06:56:25.000000000","message":"This is not used.","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"bfdd32b1020cc442dd2476f1746cdab1f74e1eed","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from ironic import objects"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":"CONF \u003d conf.CONF"},{"line_number":34,"context_line":"METRICS \u003d metrics_utils.get_metrics_logger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"ilo_error \u003d importutils.try_import(\u0027proliantutils.exception\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_93eec1ea","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":16},"in_reply_to":"9fdfeff1_999a6d11","updated":"2019-02-04 11:13:20.000000000","message":"Done","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dda25b88a468cb057ae8f4d60a0f8f2b24d9ac2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid,"},{"line_number":89,"context_line":"                          \u0027err\u0027: ir_exception})"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            deploy_opts \u003d deploy_utils.build_agent_options(node)"},{"line_number":93,"context_line":"            task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":94,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":95,"context_line":"        except Exception as e:"},{"line_number":96,"context_line":"            errmsg \u003d _(\u0027Clean step %(step)s failed \u0027"},{"line_number":97,"context_line":"                       \u0027on the node %(node)s with unknown exception: %(err)s\u0027)"},{"line_number":98,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":99,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid, \u0027err\u0027: e})"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":102,"context_line":"        driver_internal_info[\u0027cleaning_reboot\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_c2dd59dd","line":99,"range":{"start_line":91,"start_character":8,"end_line":99,"end_character":69},"updated":"2019-02-04 06:56:25.000000000","message":"There is no  need to catch any Ironic exceptions thrown here just to translate them to NodeCleaningFailure.","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"bfdd32b1020cc442dd2476f1746cdab1f74e1eed","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid,"},{"line_number":89,"context_line":"                          \u0027err\u0027: ir_exception})"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            deploy_opts \u003d deploy_utils.build_agent_options(node)"},{"line_number":93,"context_line":"            task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":94,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":95,"context_line":"        except Exception as e:"},{"line_number":96,"context_line":"            errmsg \u003d _(\u0027Clean step %(step)s failed \u0027"},{"line_number":97,"context_line":"                       \u0027on the node %(node)s with unknown exception: %(err)s\u0027)"},{"line_number":98,"context_line":"            raise exception.NodeCleaningFailure("},{"line_number":99,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid, \u0027err\u0027: e})"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":102,"context_line":"        driver_internal_info[\u0027cleaning_reboot\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_53be19d5","line":99,"range":{"start_line":91,"start_character":8,"end_line":99,"end_character":69},"in_reply_to":"9fdfeff1_c2dd59dd","updated":"2019-02-04 11:13:20.000000000","message":"Done","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dda25b88a468cb057ae8f4d60a0f8f2b24d9ac2","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        node \u003d task.node"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        task.driver.bios.cache_bios_settings(task)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":128,"context_line":"        driver_internal_info.pop(\u0027apply_bios\u0027, None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_ddc77895","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":50},"updated":"2019-02-04 06:56:25.000000000","message":"I do not think caching of settings is required as we execute this when clean step returns. Better not to update the cache as this method could end up in \u0027clean failure\u0027 subsequently. It would overwrite last cached settings when clean step has failed. This would differ from other drivers implementation. Moreover, cache_bios_settings() is available as an independent clean step. The user can always call it if he wants to fetch the latest settings even when settings update has failed.","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"bfdd32b1020cc442dd2476f1746cdab1f74e1eed","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        node \u003d task.node"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        task.driver.bios.cache_bios_settings(task)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":128,"context_line":"        driver_internal_info.pop(\u0027apply_bios\u0027, None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_b31425ea","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":50},"in_reply_to":"9fdfeff1_d899c6c3","updated":"2019-02-04 11:13:20.000000000","message":"Got it. Thanks.","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e09ebefe5ef72b81b288f095ca06e41930ab3a81","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        \"\"\""},{"line_number":123,"context_line":"        node \u003d task.node"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        task.driver.bios.cache_bios_settings(task)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":128,"context_line":"        driver_internal_info.pop(\u0027apply_bios\u0027, None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_d899c6c3","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":50},"in_reply_to":"9fdfeff1_ddc77895","updated":"2019-02-04 08:59:09.000000000","message":"One correction, \u0027cache_bios_settings\u0027 is not available as a clean step. But to be consistent, we should not be caching it unless clean step passes.","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dda25b88a468cb057ae8f4d60a0f8f2b24d9ac2","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                          \u0027err\u0027: ir_exception})"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            status \u003d ilo_object.get_bios_settings_result()"},{"line_number":152,"context_line":"        except (ilo_error.IloError,"},{"line_number":153,"context_line":"                ilo_error.IloCommandNotSupportedError) as ilo_exception:"},{"line_number":154,"context_line":"            errmsg \u003d _(\u0027Clean step %(step)s failed \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_5d3948a1","line":151,"range":{"start_line":151,"start_character":11,"end_line":151,"end_character":58},"updated":"2019-02-04 06:56:25.000000000","message":"This can be moved up at L140 as the exception handling is same. We can update the L141 for additional exceptions that could get raised owing to this call.","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"bfdd32b1020cc442dd2476f1746cdab1f74e1eed","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                          \u0027err\u0027: ir_exception})"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            status \u003d ilo_object.get_bios_settings_result()"},{"line_number":152,"context_line":"        except (ilo_error.IloError,"},{"line_number":153,"context_line":"                ilo_error.IloCommandNotSupportedError) as ilo_exception:"},{"line_number":154,"context_line":"            errmsg \u003d _(\u0027Clean step %(step)s failed \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_13b411f1","line":151,"range":{"start_line":151,"start_character":11,"end_line":151,"end_character":58},"in_reply_to":"9fdfeff1_5d3948a1","updated":"2019-02-04 11:13:20.000000000","message":"Done","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e2a17a4ab5c824fe3edf06696422f3b4892189d0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                errmsg % {\u0027step\u0027: step, \u0027node\u0027: node.uuid,"},{"line_number":87,"context_line":"                          \u0027err\u0027: ir_exception})"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        deploy_opts \u003d deploy_utils.build_agent_options(node)"},{"line_number":90,"context_line":"        task.driver.boot.prepare_ramdisk(task, deploy_opts)"},{"line_number":91,"context_line":"        manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_25668653","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":60},"updated":"2019-02-06 02:35:19.000000000","message":"I realize the odds are kind of low of having an exception raised here, but it might be worth considering to catch, just in case.","commit_id":"335f6b4fd1b1c8c83887eeb1c00eef60a68d39c6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e2a17a4ab5c824fe3edf06696422f3b4892189d0","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":118,"context_line":"        driver_internal_info.pop(\u0027apply_bios\u0027, None)"},{"line_number":119,"context_line":"        driver_internal_info.pop(\u0027reset_bios\u0027, None)"},{"line_number":120,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":121,"context_line":"        task.node.save()"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if step not in (\u0027apply_configuration\u0027, \u0027factory_reset\u0027):"},{"line_number":124,"context_line":"            errmsg \u003d _(\u0027Could not find the step %(step)s for the \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_05c6e217","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":24},"updated":"2019-02-06 02:35:19.000000000","message":"nit: s/task.//","commit_id":"335f6b4fd1b1c8c83887eeb1c00eef60a68d39c6"}],"ironic/tests/unit/drivers/modules/ilo/test_bios.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"24370b66ab2f94769c8fb140ece5e49932dfaa00","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"            exe_pre_boot_mock.assert_called_once_with("},{"line_number":102,"context_line":"                task.driver.bios, task, \u0027apply_configuration\u0027, actual_settings)"},{"line_number":103,"context_line":"            self.assertFalse(exe_post_boot_mock.called)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @mock.patch.object(ilo_bios.IloBIOS, \u0027_execute_post_boot_bios_step\u0027,"},{"line_number":106,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_c91bf918","line":103,"range":{"start_line":103,"start_character":12,"end_line":103,"end_character":55},"updated":"2019-01-09 09:36:44.000000000","message":"Also validate the cleaning_reboot, skip_current_clean_step, apply_bios are set in node\u0027s driver_internal_info","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"24370b66ab2f94769c8fb140ece5e49932dfaa00","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"            exe_post_boot_mock.assert_called_once_with("},{"line_number":134,"context_line":"                task.driver.bios, task, \u0027apply_configuration\u0027)"},{"line_number":135,"context_line":"            self.assertFalse(exe_pre_boot_mock.called)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @mock.patch.object(ilo_boot.IloVirtualMediaBoot, \u0027prepare_ramdisk\u0027,"},{"line_number":138,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd5e7cf_09e7c114","line":135,"range":{"start_line":135,"start_character":12,"end_line":135,"end_character":54},"updated":"2019-01-09 09:36:44.000000000","message":"Also validate that the variables set in driver_internal_info during _execute_pre_boot_bios_step() are cleared.","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e501fb976ac767d3079ba43d9d463880f2f52f84","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"            exe_post_boot_mock.assert_called_once_with("},{"line_number":134,"context_line":"                task.driver.bios, task, \u0027apply_configuration\u0027)"},{"line_number":135,"context_line":"            self.assertFalse(exe_pre_boot_mock.called)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @mock.patch.object(ilo_boot.IloVirtualMediaBoot, \u0027prepare_ramdisk\u0027,"},{"line_number":138,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_746230b0","line":135,"range":{"start_line":135,"start_character":12,"end_line":135,"end_character":54},"in_reply_to":"dfd5e7cf_09e7c114","updated":"2019-02-02 12:17:28.000000000","message":"Handled in the respective test cases.","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"}],"releasenotes/notes/ilo-async-bios-clean-steps-15e49545ba818997.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Makes all ILO driver BIOS interface clean steps as asynchronous. This is"},{"line_number":5,"context_line":"    required to ensure the settings on the baremetal node are consistent with"},{"line_number":6,"context_line":"    the settings stored in the database irrespective of the node clean step"},{"line_number":7,"context_line":"    status."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_41dd0811","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":39},"updated":"2018-10-26 07:22:32.000000000","message":"s/ Makes all ILO driver BIOS interface / Makes all ``ilo`` BIOS interface /","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1f8896720903444bd0ea2d200422541c8b235fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Makes all ILO driver BIOS interface clean steps as asynchronous. This is"},{"line_number":5,"context_line":"    required to ensure the settings on the baremetal node are consistent with"},{"line_number":6,"context_line":"    the settings stored in the database irrespective of the node clean step"},{"line_number":7,"context_line":"    status."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_23943f41","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":39},"in_reply_to":"3f79a3b5_41dd0811","updated":"2018-10-31 11:51:08.000000000","message":"Done","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c95e64e079b4489d46e710ba9d6e0ce42092e84d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Makes all ILO driver BIOS interface clean steps as asynchronous. This is"},{"line_number":5,"context_line":"    required to ensure the settings on the baremetal node are consistent with"},{"line_number":6,"context_line":"    the settings stored in the database irrespective of the node clean step"},{"line_number":7,"context_line":"    status."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_21032c78","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":11},"updated":"2018-10-26 07:22:32.000000000","message":"Better to add a link to story here. Like:\nRefer `story \u003chttps://storyboard.openstack.org/#!/story/2004066\u003e`_.","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1f8896720903444bd0ea2d200422541c8b235fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Makes all ILO driver BIOS interface clean steps as asynchronous. This is"},{"line_number":5,"context_line":"    required to ensure the settings on the baremetal node are consistent with"},{"line_number":6,"context_line":"    the settings stored in the database irrespective of the node clean step"},{"line_number":7,"context_line":"    status."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_c3822b03","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":11},"in_reply_to":"3f79a3b5_21032c78","updated":"2018-10-31 11:51:08.000000000","message":"Done","commit_id":"362e85b33092ffa23430d53afa5ebaeab2535da9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"dee2f8a203c76b61abfaa493aebc3e6ad04e2aab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Makes all ``ilo`` driver BIOS interface clean steps as asynchronous. This is"},{"line_number":5,"context_line":"    required to ensure the settings on the baremetal node are consistent with"},{"line_number":6,"context_line":"    the settings stored in the database irrespective of the node clean step"},{"line_number":7,"context_line":"    status. Refer `story \u003chttps://storyboard.openstack.org/#!/story/2004066`_."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_454a78ae","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"updated":"2018-11-02 05:11:25.000000000","message":"s/ status/ execution status /","commit_id":"107a146dd0d0e9d1144bdb6e895622680e4b0ed6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"24370b66ab2f94769c8fb140ece5e49932dfaa00","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Makes all ``ilo`` driver BIOS interface clean steps as asynchronous. This is"},{"line_number":5,"context_line":"    required to ensure the settings on the baremetal node are consistent with"},{"line_number":6,"context_line":"    the settings stored in the database irrespective of the node clean step"},{"line_number":7,"context_line":"    status. Refer `story \u003chttps://storyboard.openstack.org/#!/story/2004066`_."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfd5e7cf_e98d9dd3","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":77},"updated":"2019-01-09 09:36:44.000000000","message":"Better to provide link to Story Id instead of \u0027story\u0027.\nRefer `story 2004066 \u003chttps://storyboard.openstack.org/#!/story/2004066\u003e`_.","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"24370b66ab2f94769c8fb140ece5e49932dfaa00","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Makes all ``ilo`` driver BIOS interface clean steps as asynchronous. This is"},{"line_number":5,"context_line":"    required to ensure the settings on the baremetal node are consistent with"},{"line_number":6,"context_line":"    the settings stored in the database irrespective of the node clean step"},{"line_number":7,"context_line":"    status. Refer `story \u003chttps://storyboard.openstack.org/#!/story/2004066`_."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfd5e7cf_29ff2535","line":7,"range":{"start_line":7,"start_character":75,"end_line":7,"end_character":76},"updated":"2019-01-09 09:36:44.000000000","message":"Missing \u0027\u003e\u0027","commit_id":"f6c40789e9b31c63390a4916e1e1faa1ae0e7ac5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dda25b88a468cb057ae8f4d60a0f8f2b24d9ac2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Makes all ``ilo`` driver BIOS interface clean steps as asynchronous. This is"},{"line_number":5,"context_line":"    required to ensure the settings on the baremetal node are consistent with"},{"line_number":6,"context_line":"    the settings stored in the database irrespective of the node clean step"},{"line_number":7,"context_line":"    status."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fdfeff1_5d30689f","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":11},"updated":"2019-02-04 06:56:25.000000000","message":"Better to add a link to story here.","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"bfdd32b1020cc442dd2476f1746cdab1f74e1eed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Makes all ``ilo`` driver BIOS interface clean steps as asynchronous. This is"},{"line_number":5,"context_line":"    required to ensure the settings on the baremetal node are consistent with"},{"line_number":6,"context_line":"    the settings stored in the database irrespective of the node clean step"},{"line_number":7,"context_line":"    status."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fdfeff1_b38bc5bd","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":11},"in_reply_to":"9fdfeff1_5d30689f","updated":"2019-02-04 11:13:20.000000000","message":"Done","commit_id":"d0a5ac098db06d6294325e5d4a8e469e6916d102"}]}
