)]}'
{"ironic/tests/api/test_types.py":[{"author":{"_account_id":7308,"name":"Eugene Frolov","email":"efrolov@mirantis.com","username":"efrolov"},"change_message_id":"c7e3cbb17ede2a3ffbbbdd18f6b4cd9baf62f9e8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def test_validate_string_type(self):"},{"line_number":60,"context_line":"        v \u003d types.StringType(min_length\u003d1, max_length\u003d10,"},{"line_number":61,"context_line":"                             pattern\u003d\u0027^[a-zA-Z0-9]*$\u0027)"},{"line_number":62,"context_line":"        v.validate(\u00271\u0027)"},{"line_number":63,"context_line":"        v.validate(\u002712345\u0027)"},{"line_number":64,"context_line":"        v.validate(\u00271234567890\u0027)"},{"line_number":65,"context_line":"        self.assertRaises(ValueError, v.validate, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9hoM%3D","line":62,"updated":"2013-12-10 16:16:59.000000000","message":"I think following is better:\n\nCHECK_VALUE \u003d \u00271\u0027\n\nresult \u003d v.validate(CHECK_VALUE)\n\nself.assertEqual(result, CHECK_VALUE)\n\nArrange Act Assert (AAA) Pattern is good practice","commit_id":"af6cbb20025ef57b3960abad45c48a6ece686471"},{"author":{"_account_id":7308,"name":"Eugene Frolov","email":"efrolov@mirantis.com","username":"efrolov"},"change_message_id":"f2eee90351d0aaa1805e0b0bf8e1b82a3a1a13bf","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def test_validate_string_type(self):"},{"line_number":60,"context_line":"        v \u003d types.StringType(min_length\u003d1, max_length\u003d10,"},{"line_number":61,"context_line":"                             pattern\u003d\u0027^[a-zA-Z0-9]*$\u0027)"},{"line_number":62,"context_line":"        v.validate(\u00271\u0027)"},{"line_number":63,"context_line":"        v.validate(\u002712345\u0027)"},{"line_number":64,"context_line":"        v.validate(\u00271234567890\u0027)"},{"line_number":65,"context_line":"        self.assertRaises(ValueError, v.validate, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9ej0%3D","line":62,"in_reply_to":"AAAATn%2F9hN4%3D","updated":"2013-12-11 04:15:11.000000000","message":"ok. I understood you.","commit_id":"af6cbb20025ef57b3960abad45c48a6ece686471"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ede9fbd5e8f6eb1b2b88051b3a020e579a657357","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def test_validate_string_type(self):"},{"line_number":60,"context_line":"        v \u003d types.StringType(min_length\u003d1, max_length\u003d10,"},{"line_number":61,"context_line":"                             pattern\u003d\u0027^[a-zA-Z0-9]*$\u0027)"},{"line_number":62,"context_line":"        v.validate(\u00271\u0027)"},{"line_number":63,"context_line":"        v.validate(\u002712345\u0027)"},{"line_number":64,"context_line":"        v.validate(\u00271234567890\u0027)"},{"line_number":65,"context_line":"        self.assertRaises(ValueError, v.validate, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9hN4%3D","line":62,"in_reply_to":"AAAATn%2F9hbs%3D","updated":"2013-12-10 18:30:30.000000000","message":"Hi Eugene, thanks for the suggestions, I agree with you that this tests could be improved and broke into different methods to have a better output of each thing being tests. But as Max pointed out and also as lifeless suggested[1] I\u0027m just copying over the tests from WSME[2] without modifications, they should be removed as soon as WSME release a new version and we start using that version in Ironic.\n\n[1] He said https://review.openstack.org/#/c/60194/ (check his comment on Patch Set #3)\n\n[2] https://github.com/stackforge/wsme/blob/master/wsme/tests/test_types.py#L305-327","commit_id":"af6cbb20025ef57b3960abad45c48a6ece686471"},{"author":{"_account_id":8968,"name":"Max Lobur","email":"max_lobur@outlook.com","username":"max_lobur"},"change_message_id":"75aa8d99c7b1199b2695595bd38cef4b3681b2f4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def test_validate_string_type(self):"},{"line_number":60,"context_line":"        v \u003d types.StringType(min_length\u003d1, max_length\u003d10,"},{"line_number":61,"context_line":"                             pattern\u003d\u0027^[a-zA-Z0-9]*$\u0027)"},{"line_number":62,"context_line":"        v.validate(\u00271\u0027)"},{"line_number":63,"context_line":"        v.validate(\u002712345\u0027)"},{"line_number":64,"context_line":"        v.validate(\u00271234567890\u0027)"},{"line_number":65,"context_line":"        self.assertRaises(ValueError, v.validate, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9hbs%3D","line":62,"in_reply_to":"AAAATn%2F9hoM%3D","updated":"2013-12-10 16:25:10.000000000","message":"These tests are ported from wsme trunk so I think we may leave them as is. Moreover we\u0027ll remove them with the next wsme release","commit_id":"af6cbb20025ef57b3960abad45c48a6ece686471"},{"author":{"_account_id":7308,"name":"Eugene Frolov","email":"efrolov@mirantis.com","username":"efrolov"},"change_message_id":"c7e3cbb17ede2a3ffbbbdd18f6b4cd9baf62f9e8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        v \u003d types.StringType(min_length\u003d1, max_length\u003d10,"},{"line_number":61,"context_line":"                             pattern\u003d\u0027^[a-zA-Z0-9]*$\u0027)"},{"line_number":62,"context_line":"        v.validate(\u00271\u0027)"},{"line_number":63,"context_line":"        v.validate(\u002712345\u0027)"},{"line_number":64,"context_line":"        v.validate(\u00271234567890\u0027)"},{"line_number":65,"context_line":"        self.assertRaises(ValueError, v.validate, \u0027\u0027)"},{"line_number":66,"context_line":"        self.assertRaises(ValueError, v.validate, \u002712345678901\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9hoI%3D","line":63,"updated":"2013-12-10 16:16:59.000000000","message":"same","commit_id":"af6cbb20025ef57b3960abad45c48a6ece686471"},{"author":{"_account_id":7308,"name":"Eugene Frolov","email":"efrolov@mirantis.com","username":"efrolov"},"change_message_id":"c7e3cbb17ede2a3ffbbbdd18f6b4cd9baf62f9e8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                             pattern\u003d\u0027^[a-zA-Z0-9]*$\u0027)"},{"line_number":62,"context_line":"        v.validate(\u00271\u0027)"},{"line_number":63,"context_line":"        v.validate(\u002712345\u0027)"},{"line_number":64,"context_line":"        v.validate(\u00271234567890\u0027)"},{"line_number":65,"context_line":"        self.assertRaises(ValueError, v.validate, \u0027\u0027)"},{"line_number":66,"context_line":"        self.assertRaises(ValueError, v.validate, \u002712345678901\u0027)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9hoE%3D","line":64,"updated":"2013-12-10 16:16:59.000000000","message":"same","commit_id":"af6cbb20025ef57b3960abad45c48a6ece686471"},{"author":{"_account_id":7308,"name":"Eugene Frolov","email":"efrolov@mirantis.com","username":"efrolov"},"change_message_id":"c7e3cbb17ede2a3ffbbbdd18f6b4cd9baf62f9e8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertRaises(ValueError, v.validate, \u002712345678901\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # Test a pattern validation"},{"line_number":69,"context_line":"        v.validate(\u0027a\u0027)"},{"line_number":70,"context_line":"        v.validate(\u0027A\u0027)"},{"line_number":71,"context_line":"        self.assertRaises(ValueError, v.validate, \u0027_\u0027)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9hmw%3D","line":69,"updated":"2013-12-10 16:16:59.000000000","message":"same","commit_id":"af6cbb20025ef57b3960abad45c48a6ece686471"},{"author":{"_account_id":7308,"name":"Eugene Frolov","email":"efrolov@mirantis.com","username":"efrolov"},"change_message_id":"c7e3cbb17ede2a3ffbbbdd18f6b4cd9baf62f9e8","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # Test a pattern validation"},{"line_number":69,"context_line":"        v.validate(\u0027a\u0027)"},{"line_number":70,"context_line":"        v.validate(\u0027A\u0027)"},{"line_number":71,"context_line":"        self.assertRaises(ValueError, v.validate, \u0027_\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_validate_string_type_precompile(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9hms%3D","line":70,"updated":"2013-12-10 16:16:59.000000000","message":"same","commit_id":"af6cbb20025ef57b3960abad45c48a6ece686471"},{"author":{"_account_id":7308,"name":"Eugene Frolov","email":"efrolov@mirantis.com","username":"efrolov"},"change_message_id":"c7e3cbb17ede2a3ffbbbdd18f6b4cd9baf62f9e8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                             pattern\u003dprecompile)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # Test a pattern validation"},{"line_number":79,"context_line":"        v.validate(\u0027a\u0027)"},{"line_number":80,"context_line":"        v.validate(\u0027A\u0027)"},{"line_number":81,"context_line":"        self.assertRaises(ValueError, v.validate, \u0027_\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9hn0%3D","line":79,"updated":"2013-12-10 16:16:59.000000000","message":"same","commit_id":"af6cbb20025ef57b3960abad45c48a6ece686471"},{"author":{"_account_id":7308,"name":"Eugene Frolov","email":"efrolov@mirantis.com","username":"efrolov"},"change_message_id":"c7e3cbb17ede2a3ffbbbdd18f6b4cd9baf62f9e8","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # Test a pattern validation"},{"line_number":79,"context_line":"        v.validate(\u0027a\u0027)"},{"line_number":80,"context_line":"        v.validate(\u0027A\u0027)"},{"line_number":81,"context_line":"        self.assertRaises(ValueError, v.validate, \u0027_\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9hns%3D","line":80,"updated":"2013-12-10 16:16:59.000000000","message":"same","commit_id":"af6cbb20025ef57b3960abad45c48a6ece686471"}]}