)]}'
{"ironic/api/controllers/v1/chassis.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6aeb055e112df907c1a0f4d7d6cd968bb00aa242","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        :param limit: maximum number of resources to return in a single result."},{"line_number":146,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":147,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: asc."},{"line_number":148,"context_line":"        \"\"\""},{"line_number":149,"context_line":"        chassis \u003d self._get_chassis(marker, limit, sort_key, sort_dir)"},{"line_number":150,"context_line":"        return ChassisCollection.convert_with_links(chassis, limit,"},{"line_number":151,"context_line":"                                                    sort_key\u003dsort_key,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9jH0%3D","line":148,"updated":"2013-12-10 11:13:31.000000000","message":"/me being a bit pick about PEP257. Multiline docstring should end with 1 blank line.\n\ne.g:\n\n\"\"\"Retrieve a list of chassis.\n\n...\n\n:param sort_dir: direction to sort. \"asc\" or \"desc\". Default: asc.\n\n\"\"\"\n\nhttp://www.python.org/dev/peps/pep-0257/#multi-line-docstrings","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ae28843f00fef5048242e6b75c44a969b0d0cc0c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        :param limit: maximum number of resources to return in a single result."},{"line_number":146,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":147,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: asc."},{"line_number":148,"context_line":"        \"\"\""},{"line_number":149,"context_line":"        chassis \u003d self._get_chassis(marker, limit, sort_key, sort_dir)"},{"line_number":150,"context_line":"        return ChassisCollection.convert_with_links(chassis, limit,"},{"line_number":151,"context_line":"                                                    sort_key\u003dsort_key,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9UaI%3D","line":148,"in_reply_to":"AAAATn%2F9eEw%3D","updated":"2013-12-12 17:45:43.000000000","message":"Fair, thanks for that.\n\nAs lifeless pointed it\u0027s optional. I personally like to add the blank like, I think it looks better. Also, it allows Emac users to use their command and some pep257 checkers check for the blank line as well.\n\n$ pep257 ironic/*\n...\n/home/lucasagomes/Projects/ironic/ironic/tests/drivers/test_ipminative.py:19:0: Multiline docstring should end with 1 blank line.","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"a2fd9b67da1883e169e351849834642f7dbe0a2c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        :param limit: maximum number of resources to return in a single result."},{"line_number":146,"context_line":"        :param sort_key: column to sort results by. Default: id."},{"line_number":147,"context_line":"        :param sort_dir: direction to sort. \"asc\" or \"desc\". Default: asc."},{"line_number":148,"context_line":"        \"\"\""},{"line_number":149,"context_line":"        chassis \u003d self._get_chassis(marker, limit, sort_key, sort_dir)"},{"line_number":150,"context_line":"        return ChassisCollection.convert_with_links(chassis, limit,"},{"line_number":151,"context_line":"                                                    sort_key\u003dsort_key,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9eEw%3D","line":148,"in_reply_to":"AAAATn%2F9jH0%3D","updated":"2013-12-11 06:47:59.000000000","message":"Actually thats optional: \"\n\nThe BDFL [3] recommends inserting a blank line between the last paragraph in a multi-line docstring and its closing quotes, placing the closing quotes on a line by themselves. This way, Emacs\u0027 fill-paragraph command can be used on it.\"\n\nIt\u0027s not part of the requirements, it\u0027s a recommendation for Emacs users. Most folk I know ignore it.","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6aeb055e112df907c1a0f4d7d6cd968bb00aa242","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        \"\"\"Update an existing chassis."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        :param uuid: UUID of a chassis."},{"line_number":204,"context_line":"        :param patch: PATCH document to apply to this chassis."},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        chassis \u003d objects.Chassis.get_by_uuid(pecan.request.context, uuid)"},{"line_number":207,"context_line":"        chassis_dict \u003d chassis.as_dict()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9jMw%3D","line":204,"updated":"2013-12-10 11:13:31.000000000","message":"I think it worth saying \"A json-patch document...\"","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7bd01b5d97d7eb9a7f9899a8b7e061cbec5856a5","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        \"\"\"Update an existing chassis."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        :param uuid: UUID of a chassis."},{"line_number":204,"context_line":"        :param patch: PATCH document to apply to this chassis."},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        chassis \u003d objects.Chassis.get_by_uuid(pecan.request.context, uuid)"},{"line_number":207,"context_line":"        chassis_dict \u003d chassis.as_dict()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9UgE%3D","line":204,"in_reply_to":"AAAATn%2F9jMw%3D","updated":"2013-12-12 17:33:21.000000000","message":"Done","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"}],"ironic/api/controllers/v1/driver.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"15e018b36cfd2df01eebd21f4ef1b57ac63b895e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    @wsme_pecan.wsexpose(DriverList)"},{"line_number":65,"context_line":"    def get_all(self):"},{"line_number":66,"context_line":"        \"\"\"Retrieve a list of drivers."},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        drivers \u003d pecan.request.dbapi.list_active_conductor_drivers("},{"line_number":69,"context_line":"                                     interval\u003dCONF.conductor.heartbeat_timeout)"},{"line_number":70,"context_line":"        return DriverList.convert(drivers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9lH8%3D","line":67,"updated":"2013-12-10 01:00:42.000000000","message":"Strictly speaking this is wrong: one line docstrings should be \n\n \"\"\"Foo bar baz\"\"\" per PEP257.","commit_id":"2755fd956d230f64a70f9b2ce2f73524f7477362"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6aeb055e112df907c1a0f4d7d6cd968bb00aa242","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        This will set the target power state of the node, and a background"},{"line_number":85,"context_line":"        task will begin which actually applies the state change. This call"},{"line_number":86,"context_line":"        will return a 202 INPROGRESS; the client should continue to"},{"line_number":87,"context_line":"        GET the status of this node to observe the status of the requested"},{"line_number":88,"context_line":"        action."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9jKw%3D","line":86,"updated":"2013-12-10 11:13:31.000000000","message":"202 name is Accepted. What you think about something like: \"...return a 202 (Accepted) indicating the request is in progress;\"","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7bd01b5d97d7eb9a7f9899a8b7e061cbec5856a5","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        This will set the target power state of the node, and a background"},{"line_number":85,"context_line":"        task will begin which actually applies the state change. This call"},{"line_number":86,"context_line":"        will return a 202 INPROGRESS; the client should continue to"},{"line_number":87,"context_line":"        GET the status of this node to observe the status of the requested"},{"line_number":88,"context_line":"        action."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9UfY%3D","line":86,"in_reply_to":"AAAATn%2F9jKw%3D","updated":"2013-12-12 17:33:21.000000000","message":"Done","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6aeb055e112df907c1a0f4d7d6cd968bb00aa242","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        GET the status of this node to observe the status of the requested"},{"line_number":88,"context_line":"        action."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        :param node_id: UUID of the node."},{"line_number":91,"context_line":"        :param target: Desired power state."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        node \u003d objects.Node.get_by_uuid(pecan.request.context, node_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9jMg%3D","line":90,"updated":"2013-12-10 11:13:31.000000000","message":"Wondering, as you are already document all the paramters of these methods, what you think about renaming all the parameters in this document that is suppose to receive the UUID of the node to \u0027node_uuid\u0027?  In some methods these parameters are called \u0027node_id\u0027 and others \u0027uuid\u0027 (which might conflict with the uuid module from the stdlib). Do you think that this change would fit in this patch?\n\nI put this comment here but it also affects chassis and ports","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7bd01b5d97d7eb9a7f9899a8b7e061cbec5856a5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        GET the status of this node to observe the status of the requested"},{"line_number":88,"context_line":"        action."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        :param node_id: UUID of the node."},{"line_number":91,"context_line":"        :param target: Desired power state."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        node \u003d objects.Node.get_by_uuid(pecan.request.context, node_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9UfQ%3D","line":90,"in_reply_to":"AAAATn%2F9jMg%3D","updated":"2013-12-12 17:33:21.000000000","message":"I agree that these need to be standardized, and I think I\u0027ve seen some work on this in some of your patches. I would prefer not to mix fix-documentation with change-parameter-names in the same patch, though.","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6aeb055e112df907c1a0f4d7d6cd968bb00aa242","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        \"\"\"Update an existing node."},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        :param uuid: UUID of a node."},{"line_number":507,"context_line":"        :param patch: PATCH document to apply to this node."},{"line_number":508,"context_line":"        \"\"\""},{"line_number":509,"context_line":"        if self._from_chassis:"},{"line_number":510,"context_line":"            raise exception.OperationNotPermitted"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9jMI%3D","line":507,"updated":"2013-12-10 11:13:31.000000000","message":"ditto re: \"A json-patch document...\"","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7bd01b5d97d7eb9a7f9899a8b7e061cbec5856a5","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        \"\"\"Update an existing node."},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        :param uuid: UUID of a node."},{"line_number":507,"context_line":"        :param patch: PATCH document to apply to this node."},{"line_number":508,"context_line":"        \"\"\""},{"line_number":509,"context_line":"        if self._from_chassis:"},{"line_number":510,"context_line":"            raise exception.OperationNotPermitted"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9UfI%3D","line":507,"in_reply_to":"AAAATn%2F9jMI%3D","updated":"2013-12-12 17:33:21.000000000","message":"Done","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"13d6b6eecb7c993f5c4276da4aaefa3cdd93f540","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            wtypes.text, wtypes.text, int, wtypes.text, wtypes.text)"},{"line_number":438,"context_line":"    def detail(self, chassis_id\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":439,"context_line":"               marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027):"},{"line_number":440,"context_line":"        \"\"\"Retrieve a list of nodes with detail."},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        :param chassis_id: Optional UUID of a chassis, to get only nodes for"},{"line_number":443,"context_line":"                           that chassis."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9OKE%3D","line":440,"updated":"2013-12-13 20:50:28.000000000","message":"this is the exact doc string as get_all. Is that correct?\nit is not that way on node and chassis","commit_id":"d34106be9c54c994f0060da1c73140c78bd16ff7"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"a1cf8ad3e0e3b159f005b59eb4e454aa91606415","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            wtypes.text, wtypes.text, int, wtypes.text, wtypes.text)"},{"line_number":438,"context_line":"    def detail(self, chassis_id\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":439,"context_line":"               marker\u003dNone, limit\u003dNone, sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027):"},{"line_number":440,"context_line":"        \"\"\"Retrieve a list of nodes with detail."},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        :param chassis_id: Optional UUID of a chassis, to get only nodes for"},{"line_number":443,"context_line":"                           that chassis."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9OJI%3D","line":440,"in_reply_to":"AAAATn%2F9OKE%3D","updated":"2013-12-13 20:52:54.000000000","message":"this comment should have been made on port.py","commit_id":"d34106be9c54c994f0060da1c73140c78bd16ff7"}],"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6aeb055e112df907c1a0f4d7d6cd968bb00aa242","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"\"\"Update an existing port."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        :param uuid: UUID of a port."},{"line_number":254,"context_line":"        :param patch: PATCH document to apply to this port."},{"line_number":255,"context_line":"        \"\"\""},{"line_number":256,"context_line":"        if self._from_nodes:"},{"line_number":257,"context_line":"            raise exception.OperationNotPermitted"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9jLg%3D","line":254,"updated":"2013-12-10 11:13:31.000000000","message":"ditto re \"A json-patch document...\"","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"7bd01b5d97d7eb9a7f9899a8b7e061cbec5856a5","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"\"\"Update an existing port."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        :param uuid: UUID of a port."},{"line_number":254,"context_line":"        :param patch: PATCH document to apply to this port."},{"line_number":255,"context_line":"        \"\"\""},{"line_number":256,"context_line":"        if self._from_nodes:"},{"line_number":257,"context_line":"            raise exception.OperationNotPermitted"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9UfA%3D","line":254,"in_reply_to":"AAAATn%2F9jLg%3D","updated":"2013-12-12 17:33:21.000000000","message":"Done","commit_id":"7f842f356ca8ba2ab2c1c94757460fa1d655486b"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"a1cf8ad3e0e3b159f005b59eb4e454aa91606415","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                         wtypes.text, wtypes.text)"},{"line_number":194,"context_line":"    def detail(self, node_uuid\u003dNone, marker\u003dNone, limit\u003dNone,"},{"line_number":195,"context_line":"                sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027):"},{"line_number":196,"context_line":"        \"\"\"Retrieve a list of ports."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param node_uuid: UUID of a node, to get only ports for that node."},{"line_number":199,"context_line":"        :param marker: pagination marker for large data sets."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9OJA%3D","line":196,"updated":"2013-12-13 20:52:54.000000000","message":"this is the exact doc string as get_all. Is that correct? it is not that way on node and chassis","commit_id":"d34106be9c54c994f0060da1c73140c78bd16ff7"}]}