)]}'
{"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"791512986db6e933dba799991821a6108e689e6f","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"    def test_direct_deploy_should_convert_raw_image_partition(self):"},{"line_number":1751,"context_line":"        cfg.CONF.set_override(\u0027force_raw_images\u0027, True)"},{"line_number":1752,"context_line":"        cfg.CONF.set_override(\u0027stream_raw_images\u0027, True, group\u003d\u0027agent\u0027)"},{"line_number":1753,"context_line":"        internal_info \u003d self.node.driver_internal_info"},{"line_number":1754,"context_line":"        internal_info[\u0027is_whole_disk_image\u0027] \u003d False"},{"line_number":1755,"context_line":"        self.node.driver_internal_info \u003d internal_info"},{"line_number":1756,"context_line":"        self.assertTrue("},{"line_number":1757,"context_line":"            utils.direct_deploy_should_convert_raw_image(self.node))"},{"line_number":1758,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_58dda16b","line":1755,"range":{"start_line":1753,"start_character":0,"end_line":1755,"end_character":54},"updated":"2018-10-18 08:58:57.000000000","message":"iwdi is not involved now, maybe remove this?\n\nwould be perfect if there is a negative test ;)","commit_id":"1c5f9aea33ca04106e56c6997785e4ddb551f0c7"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"e6d48bff2d5ab3f6ae4a49ad7606f7ded221c6e5","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"    def test_direct_deploy_should_convert_raw_image_partition(self):"},{"line_number":1751,"context_line":"        cfg.CONF.set_override(\u0027force_raw_images\u0027, True)"},{"line_number":1752,"context_line":"        cfg.CONF.set_override(\u0027stream_raw_images\u0027, True, group\u003d\u0027agent\u0027)"},{"line_number":1753,"context_line":"        internal_info \u003d self.node.driver_internal_info"},{"line_number":1754,"context_line":"        internal_info[\u0027is_whole_disk_image\u0027] \u003d False"},{"line_number":1755,"context_line":"        self.node.driver_internal_info \u003d internal_info"},{"line_number":1756,"context_line":"        self.assertTrue("},{"line_number":1757,"context_line":"            utils.direct_deploy_should_convert_raw_image(self.node))"},{"line_number":1758,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_5895a13c","line":1755,"range":{"start_line":1753,"start_character":0,"end_line":1755,"end_character":54},"in_reply_to":"3f79a3b5_384ea539","updated":"2018-10-18 09:11:30.000000000","message":"\u003e \u003e iwdi is not involved now, maybe remove this?\n \u003e \n \u003e I\u0027m verifying it explicitly that for partition images we also\n \u003e enable the conversion.\n\nHmm, make sense too. I am thinking this is a unit test, and the code been tested doesn\u0027t read iwdi at all, works for me either way.\n\n \u003e \u003e would be perfect if there is a negative test ;)\n \u003e \n \u003e Not sure what you mean. Aren\u0027t the previous two tests already\n \u003e covering it?\n\nOh no, you are right, I can\u0027t believe I even don\u0027t remember then code I have writen!","commit_id":"1c5f9aea33ca04106e56c6997785e4ddb551f0c7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1b8113526a0a91806abcdf1972cd072ccc67ac37","unresolved":false,"context_lines":[{"line_number":1750,"context_line":"    def test_direct_deploy_should_convert_raw_image_partition(self):"},{"line_number":1751,"context_line":"        cfg.CONF.set_override(\u0027force_raw_images\u0027, True)"},{"line_number":1752,"context_line":"        cfg.CONF.set_override(\u0027stream_raw_images\u0027, True, group\u003d\u0027agent\u0027)"},{"line_number":1753,"context_line":"        internal_info \u003d self.node.driver_internal_info"},{"line_number":1754,"context_line":"        internal_info[\u0027is_whole_disk_image\u0027] \u003d False"},{"line_number":1755,"context_line":"        self.node.driver_internal_info \u003d internal_info"},{"line_number":1756,"context_line":"        self.assertTrue("},{"line_number":1757,"context_line":"            utils.direct_deploy_should_convert_raw_image(self.node))"},{"line_number":1758,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_384ea539","line":1755,"range":{"start_line":1753,"start_character":0,"end_line":1755,"end_character":54},"in_reply_to":"3f79a3b5_58dda16b","updated":"2018-10-18 09:01:42.000000000","message":"\u003e iwdi is not involved now, maybe remove this?\n\nI\u0027m verifying it explicitly that for partition images we also enable the conversion.\n\n\u003e would be perfect if there is a negative test ;)\n\nNot sure what you mean. Aren\u0027t the previous two tests already covering it?","commit_id":"1c5f9aea33ca04106e56c6997785e4ddb551f0c7"}],"releasenotes/notes/streaming-partition-images-d58fe619658b066e.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7c7fd37fd1880e047d0e530c584a59969cf2b19b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows streaming raw partition images to the ramdisk when using the"},{"line_number":5,"context_line":"    ``direct`` deploy interface. Requires **ironic-python-agent** from"},{"line_number":6,"context_line":"    the Stein release series."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_e7245ab4","line":6,"range":{"start_line":5,"start_character":33,"end_line":6,"end_character":29},"updated":"2018-10-26 16:36:16.000000000","message":"nit: we can change this, but we\u0027ll always follo-up on the release notes.","commit_id":"1c5f9aea33ca04106e56c6997785e4ddb551f0c7"}]}