)]}'
{"ironic/drivers/modules/boot_mode_utils.py":[{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"ea9f796fef6e45b3540658fd145af1fe04322688","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    global warn_about_default_boot_mode"},{"line_number":287,"context_line":"    if not warn_about_default_boot_mode:"},{"line_number":288,"context_line":"        warn_about_default_boot_mode \u003d True"},{"line_number":289,"context_line":"        LOG.warning(\u0027There is a node whose boot mode is not configured \u0027"},{"line_number":290,"context_line":"                    \u0027explicitly. The default boot mode is \"%(bios)s\", but, \u0027"},{"line_number":291,"context_line":"                    \u0027the default will be changed to \"%(uefi)s\" in the future. \u0027"},{"line_number":292,"context_line":"                    \u0027It is recommended to set the boot option into a node\\\u0027s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1ff36fea","line":289,"range":{"start_line":289,"start_character":21,"end_line":289,"end_character":36},"updated":"2018-10-19 14:27:10.000000000","message":"s/There is a node/Node %(node_uuid)s/\n\nI might be misreading, but when this message is triggered the node in scope is the one whose boot mode is not configured. If so, you can identify it in the message as well.","commit_id":"e2e88c1dd33fb97c054624827ed28076c4a7c2f7"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"62ec46d5f7cd1d13cf5c6e6ff3ec23d1b5c16eaa","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    global warn_about_default_boot_mode"},{"line_number":287,"context_line":"    if not warn_about_default_boot_mode:"},{"line_number":288,"context_line":"        warn_about_default_boot_mode \u003d True"},{"line_number":289,"context_line":"        LOG.warning(\u0027There is a node whose boot mode is not configured \u0027"},{"line_number":290,"context_line":"                    \u0027explicitly. The default boot mode is \"%(bios)s\", but, \u0027"},{"line_number":291,"context_line":"                    \u0027the default will be changed to \"%(uefi)s\" in the future. \u0027"},{"line_number":292,"context_line":"                    \u0027It is recommended to set the boot option into a node\\\u0027s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a71eb45b","line":289,"range":{"start_line":289,"start_character":21,"end_line":289,"end_character":36},"in_reply_to":"3f79a3b5_1ff36fea","updated":"2018-10-23 15:48:18.000000000","message":"Yes, you\u0027re right. But, as far as I remember, a similar message was emitted globally once somewhere though it was triggered by a node scope configuration. I slightly modified the message.","commit_id":"e2e88c1dd33fb97c054624827ed28076c4a7c2f7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4663251055967b4d74eb334b7ff8b2249aefefff","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                    \u0027explicitly. The default boot mode is \"%(bios)s\", but, \u0027"},{"line_number":291,"context_line":"                    \u0027the default will be changed to \"%(uefi)s\" in the future. \u0027"},{"line_number":292,"context_line":"                    \u0027It is recommended to set the boot option into a node\\\u0027s \u0027"},{"line_number":293,"context_line":"                    \u0027properties/capabilities/boot_option.\u0027,"},{"line_number":294,"context_line":"                    {\u0027bios\u0027: boot_modes.LEGACY_BIOS,"},{"line_number":295,"context_line":"                     \u0027uefi\u0027: boot_modes.UEFI})"},{"line_number":296,"context_line":"    return boot_modes.LEGACY_BIOS"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1883a957","line":293,"updated":"2018-10-18 08:56:49.000000000","message":"s/boot_option/boot_mode/","commit_id":"e2e88c1dd33fb97c054624827ed28076c4a7c2f7"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"62ec46d5f7cd1d13cf5c6e6ff3ec23d1b5c16eaa","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                    \u0027explicitly. The default boot mode is \"%(bios)s\", but, \u0027"},{"line_number":291,"context_line":"                    \u0027the default will be changed to \"%(uefi)s\" in the future. \u0027"},{"line_number":292,"context_line":"                    \u0027It is recommended to set the boot option into a node\\\u0027s \u0027"},{"line_number":293,"context_line":"                    \u0027properties/capabilities/boot_option.\u0027,"},{"line_number":294,"context_line":"                    {\u0027bios\u0027: boot_modes.LEGACY_BIOS,"},{"line_number":295,"context_line":"                     \u0027uefi\u0027: boot_modes.UEFI})"},{"line_number":296,"context_line":"    return boot_modes.LEGACY_BIOS"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a458f288","line":293,"in_reply_to":"3f79a3b5_1883a957","updated":"2018-10-23 15:48:18.000000000","message":"Done\nThanks.","commit_id":"e2e88c1dd33fb97c054624827ed28076c4a7c2f7"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"732abec054b9d0216e0a05b758cb1f91c52431c2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"warn_about_default_boot_mode \u003d False"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def _set_boot_mode_on_bm(task, ironic_boot_mode, fail_if_unsupported\u003dFalse):"},{"line_number":32,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d51eeb5c","line":29,"updated":"2018-10-24 03:20:19.000000000","message":"It\u0027s not often to see we use a global variable to control deprecation warnings, we just add a TODO and remove it when the time comes.","commit_id":"6b931fd0498d5913c19a89ec617e7b6f43d2eb37"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"732abec054b9d0216e0a05b758cb1f91c52431c2","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                    {\u0027node_uuid\u0027: node.uuid,"},{"line_number":295,"context_line":"                     \u0027bios\u0027: boot_modes.LEGACY_BIOS,"},{"line_number":296,"context_line":"                     \u0027uefi\u0027: boot_modes.UEFI})"},{"line_number":297,"context_line":"    return boot_modes.LEGACY_BIOS"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_75aa77d3","line":297,"updated":"2018-10-24 03:20:19.000000000","message":"oh, I see, you want to control the warning shows only once for a node right? but this doesn\u0027t work, because it\u0027s a global variable.\n\nalso I think if the get_boot_mode supersedes get_boot_mode_for_deploy, why not merge them into one method, or at lease prefix get_boot_mode_for_deploy with a _?","commit_id":"6b931fd0498d5913c19a89ec617e7b6f43d2eb37"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8e4429ef8395b4c81a7393c20b9d93bcd53175a2","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                    {\u0027node_uuid\u0027: node.uuid,"},{"line_number":295,"context_line":"                     \u0027bios\u0027: boot_modes.LEGACY_BIOS,"},{"line_number":296,"context_line":"                     \u0027uefi\u0027: boot_modes.UEFI})"},{"line_number":297,"context_line":"    return boot_modes.LEGACY_BIOS"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ddd8e680","line":297,"in_reply_to":"3f79a3b5_75aa77d3","updated":"2018-10-30 07:23:24.000000000","message":"I intend to emit this warning once for all nodes when a first node is found because logging for every node looks too much. I remember we did similarly for another deprecation. I don\u0027t remember clearly, though.\n\nRegarding get_boot_mode_for_deploy, sync_boot_mode expects it to return None. For other calls, introducing get_boot_mode makes it easy to change the default value. So, it would be tter to put the prefix to get_boot_mode_for_deploy.","commit_id":"6b931fd0498d5913c19a89ec617e7b6f43d2eb37"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"4c71f64b564f23d11b6b16688340599c4e65a060","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                    {\u0027node_uuid\u0027: node.uuid,"},{"line_number":295,"context_line":"                     \u0027bios\u0027: boot_modes.LEGACY_BIOS,"},{"line_number":296,"context_line":"                     \u0027uefi\u0027: boot_modes.UEFI})"},{"line_number":297,"context_line":"    return boot_modes.LEGACY_BIOS"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5d861618","line":297,"in_reply_to":"3f79a3b5_ddd8e680","updated":"2018-10-30 07:36:13.000000000","message":"Got it, so it\u0027s a one time warning. I think logging node uuid may cause confusion here, we warns for one node but not others, maybe just me thinking this way.","commit_id":"6b931fd0498d5913c19a89ec617e7b6f43d2eb37"}],"releasenotes/notes/uefi-first-prepare-e7fa1e2a78b4af99.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4663251055967b4d74eb334b7ff8b2249aefefff","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    boot mode is set to UEFI if no boot mode is set to node\u0027s capabilities. It"},{"line_number":9,"context_line":"    is also recommended to set ``boot_mode`` into ``priorities/capabilities``"},{"line_number":10,"context_line":"    of a node."},{"line_number":11,"context_line":" "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_f87d8d70","line":11,"updated":"2018-10-18 08:56:49.000000000","message":"nit: trailing space","commit_id":"e2e88c1dd33fb97c054624827ed28076c4a7c2f7"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"62ec46d5f7cd1d13cf5c6e6ff3ec23d1b5c16eaa","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    boot mode is set to UEFI if no boot mode is set to node\u0027s capabilities. It"},{"line_number":9,"context_line":"    is also recommended to set ``boot_mode`` into ``priorities/capabilities``"},{"line_number":10,"context_line":"    of a node."},{"line_number":11,"context_line":" "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_4468fe20","line":11,"in_reply_to":"3f79a3b5_f87d8d70","updated":"2018-10-23 15:48:18.000000000","message":"Done","commit_id":"e2e88c1dd33fb97c054624827ed28076c4a7c2f7"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"732abec054b9d0216e0a05b758cb1f91c52431c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A future release will change the default value of"},{"line_number":5,"context_line":"    ``[deploy]/default_boot_mode`` from \"bios\" to \"uefi\". To avoid disruptions,"},{"line_number":6,"context_line":"    it is recommended to set an explicit value for this option. For hardware"},{"line_number":7,"context_line":"    types which don\u0027t support setting boot mode, a future release will assume"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_95be33fe","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"updated":"2018-10-24 03:20:19.000000000","message":"Maybe we could be more specific here if the plan is set, just ignore this comment if we have no plans yet.","commit_id":"6b931fd0498d5913c19a89ec617e7b6f43d2eb37"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8e4429ef8395b4c81a7393c20b9d93bcd53175a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A future release will change the default value of"},{"line_number":5,"context_line":"    ``[deploy]/default_boot_mode`` from \"bios\" to \"uefi\". To avoid disruptions,"},{"line_number":6,"context_line":"    it is recommended to set an explicit value for this option. For hardware"},{"line_number":7,"context_line":"    types which don\u0027t support setting boot mode, a future release will assume"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_dd46a622","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"in_reply_to":"3f79a3b5_95be33fe","updated":"2018-10-30 07:23:24.000000000","message":"We haven\u0027t decided it.","commit_id":"6b931fd0498d5913c19a89ec617e7b6f43d2eb37"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"732abec054b9d0216e0a05b758cb1f91c52431c2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A future release will change the default value of"},{"line_number":5,"context_line":"    ``[deploy]/default_boot_mode`` from \"bios\" to \"uefi\". To avoid disruptions,"},{"line_number":6,"context_line":"    it is recommended to set an explicit value for this option. For hardware"},{"line_number":7,"context_line":"    types which don\u0027t support setting boot mode, a future release will assume"},{"line_number":8,"context_line":"    boot mode is set to UEFI if no boot mode is set to node\u0027s capabilities. It"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d5c82ba8","line":5,"range":{"start_line":5,"start_character":67,"end_line":5,"end_character":78},"updated":"2018-10-24 03:20:19.000000000","message":"This word looks a bit weird to me, I\u0027d remove \u0027To avoid disruptions\u0027 here","commit_id":"6b931fd0498d5913c19a89ec617e7b6f43d2eb37"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8e4429ef8395b4c81a7393c20b9d93bcd53175a2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A future release will change the default value of"},{"line_number":5,"context_line":"    ``[deploy]/default_boot_mode`` from \"bios\" to \"uefi\". To avoid disruptions,"},{"line_number":6,"context_line":"    it is recommended to set an explicit value for this option. For hardware"},{"line_number":7,"context_line":"    types which don\u0027t support setting boot mode, a future release will assume"},{"line_number":8,"context_line":"    boot mode is set to UEFI if no boot mode is set to node\u0027s capabilities. It"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_3dc79a99","line":5,"range":{"start_line":5,"start_character":67,"end_line":5,"end_character":78},"in_reply_to":"3f79a3b5_d5c82ba8","updated":"2018-10-30 07:23:24.000000000","message":"I will remove it.","commit_id":"6b931fd0498d5913c19a89ec617e7b6f43d2eb37"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"732abec054b9d0216e0a05b758cb1f91c52431c2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    it is recommended to set an explicit value for this option. For hardware"},{"line_number":7,"context_line":"    types which don\u0027t support setting boot mode, a future release will assume"},{"line_number":8,"context_line":"    boot mode is set to UEFI if no boot mode is set to node\u0027s capabilities. It"},{"line_number":9,"context_line":"    is also recommended to set ``boot_mode`` into ``priorities/capabilities``"},{"line_number":10,"context_line":"    of a node."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_1538e39c","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":62},"updated":"2018-10-24 03:20:19.000000000","message":"nit: s/priorities/properties/","commit_id":"6b931fd0498d5913c19a89ec617e7b6f43d2eb37"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8e4429ef8395b4c81a7393c20b9d93bcd53175a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    it is recommended to set an explicit value for this option. For hardware"},{"line_number":7,"context_line":"    types which don\u0027t support setting boot mode, a future release will assume"},{"line_number":8,"context_line":"    boot mode is set to UEFI if no boot mode is set to node\u0027s capabilities. It"},{"line_number":9,"context_line":"    is also recommended to set ``boot_mode`` into ``priorities/capabilities``"},{"line_number":10,"context_line":"    of a node."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_7dd19255","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":62},"in_reply_to":"3f79a3b5_1538e39c","updated":"2018-10-30 07:23:24.000000000","message":"I will fix this. Thanks.","commit_id":"6b931fd0498d5913c19a89ec617e7b6f43d2eb37"}]}