)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d80fb59fc4ace8723dcbfa96a20447c7a84ea912","unresolved":false,"context_lines":[{"line_number":16,"context_line":"to get a dict of updates to apply to the database. This patch adds"},{"line_number":17,"context_line":"that as part of the base object and makes every place that does"},{"line_number":18,"context_line":"the above to just use that."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8d2616ecc2c88cf4b21e7e8193f5b985407ed869"},{"line_number":21,"context_line":"Closes-Bug: #1259527"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9c6I%3D","line":19,"updated":"2013-12-11 11:54:58.000000000","message":"As it\u0027s a port from a patch in nova I think it worth to mention that here in the commit message and add a link to the origional patch: https://review.openstack.org/#/c/45353/","commit_id":"9a98fc566adaf14ceaeb3794118f4d9f1e85ffac"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"b9330138bf0920a11f670b9944ce156106bd3f2e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"to get a dict of updates to apply to the database. This patch adds"},{"line_number":17,"context_line":"that as part of the base object and makes every place that does"},{"line_number":18,"context_line":"the above to just use that."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8d2616ecc2c88cf4b21e7e8193f5b985407ed869"},{"line_number":21,"context_line":"Closes-Bug: #1259527"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9bLo%3D","line":19,"in_reply_to":"AAAATn%2F9c6I%3D","updated":"2013-12-11 17:35:48.000000000","message":"Done","commit_id":"9a98fc566adaf14ceaeb3794118f4d9f1e85ffac"}],"ironic/objects/base.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d80fb59fc4ace8723dcbfa96a20447c7a84ea912","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        \"\"\""},{"line_number":310,"context_line":"        raise NotImplementedError(_(\"Cannot save anything in the base class\"))"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def obj_get_updates(self):"},{"line_number":313,"context_line":"        \"\"\"Returns a dict of updated fields and their new values.\"\"\""},{"line_number":314,"context_line":"        updates \u003d {}"},{"line_number":315,"context_line":"        for field in self.obj_what_changed():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9c48%3D","line":312,"updated":"2013-12-11 11:54:58.000000000","message":"In nova this method is called obj_get_changes(), as this patch is pulling these changes from nova I think we should copy the things exactly like they are[1][2] same names, same variable names, docstrings, tests etc...\n\n[1] https://review.openstack.org/#/c/45353/2/nova/objects/base.py\n\n[2] https://github.com/openstack/nova/blob/master/nova/objects/base.py#L320-L325","commit_id":"9a98fc566adaf14ceaeb3794118f4d9f1e85ffac"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"b9330138bf0920a11f670b9944ce156106bd3f2e","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        \"\"\""},{"line_number":310,"context_line":"        raise NotImplementedError(_(\"Cannot save anything in the base class\"))"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def obj_get_updates(self):"},{"line_number":313,"context_line":"        \"\"\"Returns a dict of updated fields and their new values.\"\"\""},{"line_number":314,"context_line":"        updates \u003d {}"},{"line_number":315,"context_line":"        for field in self.obj_what_changed():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9bm8%3D","line":312,"in_reply_to":"AAAATn%2F9c48%3D","updated":"2013-12-11 17:35:48.000000000","message":"Done","commit_id":"9a98fc566adaf14ceaeb3794118f4d9f1e85ffac"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5d9c3cf307dd83bba2ca4a29e28b4f8d35a086c4","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        \"\"\"Returns a dict of updated fields and their new values.\"\"\""},{"line_number":314,"context_line":"        updates \u003d {}"},{"line_number":315,"context_line":"        for field in self.obj_what_changed():"},{"line_number":316,"context_line":"            updates[field] \u003d self[field]"},{"line_number":317,"context_line":"        return updates"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def obj_what_changed(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9hjA%3D","line":316,"updated":"2013-12-10 16:00:31.000000000","message":"Should\n\nupdates[field] \u003d self.field \n\nbe here?\nhttps://review.openstack.org/#/c/60025/6//COMMIT_MSG","commit_id":"9a98fc566adaf14ceaeb3794118f4d9f1e85ffac"},{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"b9330138bf0920a11f670b9944ce156106bd3f2e","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        \"\"\"Returns a dict of updated fields and their new values.\"\"\""},{"line_number":314,"context_line":"        updates \u003d {}"},{"line_number":315,"context_line":"        for field in self.obj_what_changed():"},{"line_number":316,"context_line":"            updates[field] \u003d self[field]"},{"line_number":317,"context_line":"        return updates"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def obj_what_changed(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9g2Q%3D","line":316,"in_reply_to":"AAAATn%2F9hjA%3D","updated":"2013-12-11 17:35:48.000000000","message":"No, not yet. It\u0027s planned in the next patch.","commit_id":"9a98fc566adaf14ceaeb3794118f4d9f1e85ffac"}]}