)]}'
{"ironic/common/pxe_utils.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b44b540faa007c1632e2a9d8c1c673999bed915b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"DHCP_CLIENT_ID \u003d \u002761\u0027  # rfc2132"},{"line_number":44,"context_line":"DHCP_TFTP_SERVER_NAME \u003d \u002766\u0027  # rfc2132"},{"line_number":45,"context_line":"DHCP_BOOTFILE_NAME \u003d \u002767\u0027  # rfc2132"},{"line_number":46,"context_line":"DHCPV6_BOOTFILE_NAME \u003d \u002759\u0027  # rfc5870"},{"line_number":47,"context_line":"# NOTE(TheJulia): adding note for the bootfile parameter"},{"line_number":48,"context_line":"# field as defined by RFC 5870. No practical examples seem"},{"line_number":49,"context_line":"# available. Neither grub2 or ipxe seem to leverage this."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_3f2cd9ff","line":46,"range":{"start_line":46,"start_character":24,"end_line":46,"end_character":26},"updated":"2018-10-24 09:13:49.000000000","message":"FYI: there is a patch talked about this is not working, maybe you can find some useful comments there: https://review.openstack.org/#/c/552897/","commit_id":"f479d91daaba3f28e146cd6a80a917660721a146"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1852a56636697cfe8203b8776e9ff154009606bc","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        # a URL reply."},{"line_number":443,"context_line":"        boot_file_param \u003d DHCPV6_BOOTFILE_NAME"},{"line_number":444,"context_line":"        url_boot \u003d True"},{"line_number":445,"context_line":"    else:"},{"line_number":446,"context_line":"        msg \u003d (_(\"Boot configuration for the conductor is misconfigured. \""},{"line_number":447,"context_line":"                 \"Only ip_version 4 or 6 is supported.\"))"},{"line_number":448,"context_line":"        LOG.error(msg)"},{"line_number":449,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":450,"context_line":"    boot_file \u003d _dhcp_option_file_or_url(task, url_boot)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    if ipxe_enabled:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_398df2d3","line":449,"range":{"start_line":445,"start_character":4,"end_line":449,"end_character":50},"updated":"2018-10-23 10:41:53.000000000","message":"Need a testcase for this exception path.","commit_id":"f479d91daaba3f28e146cd6a80a917660721a146"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9c6f25670a709dd198a0fd37938bec0fb3ecc317","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        # a URL reply."},{"line_number":443,"context_line":"        boot_file_param \u003d DHCPV6_BOOTFILE_NAME"},{"line_number":444,"context_line":"        url_boot \u003d True"},{"line_number":445,"context_line":"    else:"},{"line_number":446,"context_line":"        msg \u003d (_(\"Boot configuration for the conductor is misconfigured. \""},{"line_number":447,"context_line":"                 \"Only ip_version 4 or 6 is supported.\"))"},{"line_number":448,"context_line":"        LOG.error(msg)"},{"line_number":449,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":450,"context_line":"    boot_file \u003d _dhcp_option_file_or_url(task, url_boot)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    if ipxe_enabled:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ba00fe00","line":449,"range":{"start_line":445,"start_character":4,"end_line":449,"end_character":50},"in_reply_to":"3f79a3b5_398df2d3","updated":"2018-10-24 01:52:36.000000000","message":"We can\u0027t actually do that...  I tried to set it to 3, and oslo.config blew up since we guard the value. It means this will never be called, but I\u0027d kind of prefer to be extra defensive. I\u0027ll remove it.\nValueError: Valid values are [4, 6], but found \u00273\u0027","commit_id":"f479d91daaba3f28e146cd6a80a917660721a146"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b44b540faa007c1632e2a9d8c1c673999bed915b","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        # a URL reply."},{"line_number":443,"context_line":"        boot_file_param \u003d DHCPV6_BOOTFILE_NAME"},{"line_number":444,"context_line":"        url_boot \u003d True"},{"line_number":445,"context_line":"    else:"},{"line_number":446,"context_line":"        msg \u003d (_(\"Boot configuration for the conductor is misconfigured. \""},{"line_number":447,"context_line":"                 \"Only ip_version 4 or 6 is supported.\"))"},{"line_number":448,"context_line":"        LOG.error(msg)"},{"line_number":449,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":450,"context_line":"    boot_file \u003d _dhcp_option_file_or_url(task, url_boot)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    if ipxe_enabled:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9f9e4d53","line":449,"range":{"start_line":445,"start_character":4,"end_line":449,"end_character":50},"in_reply_to":"3f79a3b5_ba00fe00","updated":"2018-10-24 09:13:49.000000000","message":"I think if...else... would be fine, it\u0027s already guarded by oslo","commit_id":"f479d91daaba3f28e146cd6a80a917660721a146"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1852a56636697cfe8203b8776e9ff154009606bc","unresolved":false,"context_lines":[{"line_number":500,"context_line":"    # unknown options but potentially it may blow up with others."},{"line_number":501,"context_line":"    # Related bug was opened on Neutron side:"},{"line_number":502,"context_line":"    # https://bugs.launchpad.net/neutron/+bug/1723354"},{"line_number":503,"context_line":"    if not url_boot:"},{"line_number":504,"context_line":"        dhcp_opts.append({\u0027opt_name\u0027: \u0027server-ip-address\u0027,"},{"line_number":505,"context_line":"                          \u0027opt_value\u0027: CONF.pxe.tftp_server})"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b9e4a2a9","line":503,"range":{"start_line":503,"start_character":4,"end_line":503,"end_character":20},"updated":"2018-10-23 10:41:53.000000000","message":"nit: This additional \u0027if statement is not needed. It can get covered as part of \u0027if clause at L485. May be this is fine so as to avoid re-aligning L490-L502.","commit_id":"f479d91daaba3f28e146cd6a80a917660721a146"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7a4add8edb910b582d7f3dc9f7450ea4a0401070","unresolved":false,"context_lines":[{"line_number":500,"context_line":"    # unknown options but potentially it may blow up with others."},{"line_number":501,"context_line":"    # Related bug was opened on Neutron side:"},{"line_number":502,"context_line":"    # https://bugs.launchpad.net/neutron/+bug/1723354"},{"line_number":503,"context_line":"    if not url_boot:"},{"line_number":504,"context_line":"        dhcp_opts.append({\u0027opt_name\u0027: \u0027server-ip-address\u0027,"},{"line_number":505,"context_line":"                          \u0027opt_value\u0027: CONF.pxe.tftp_server})"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9f6f34f9","line":503,"range":{"start_line":503,"start_character":4,"end_line":503,"end_character":20},"in_reply_to":"3f79a3b5_b9e4a2a9","updated":"2018-10-24 01:48:56.000000000","message":"That was actually why I avoided it, I didn\u0027t see the reason in changing every single line :\\","commit_id":"f479d91daaba3f28e146cd6a80a917660721a146"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"94211db8749fa3dd838e3106a961bb319ae97a37","unresolved":false,"context_lines":[{"line_number":434,"context_line":"              the DHCP options to be set."},{"line_number":435,"context_line":"    \"\"\""},{"line_number":436,"context_line":"    dhcp_opts \u003d []"},{"line_number":437,"context_line":"    ip_version \u003d int(CONF.pxe.ip_version)"},{"line_number":438,"context_line":"    if ip_version \u003d\u003d 4:"},{"line_number":439,"context_line":"        boot_file_param \u003d DHCP_BOOTFILE_NAME"},{"line_number":440,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_2a649920","line":437,"updated":"2018-10-24 10:17:41.000000000","message":"also it really should just be IntOpt","commit_id":"09a6164ca7f33cf0bd97fc14c8554c9424de67fd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"38ca8211a9ea1205f66500d93da2a557d2dc67b1","unresolved":false,"context_lines":[{"line_number":434,"context_line":"              the DHCP options to be set."},{"line_number":435,"context_line":"    \"\"\""},{"line_number":436,"context_line":"    dhcp_opts \u003d []"},{"line_number":437,"context_line":"    ip_version \u003d int(CONF.pxe.ip_version)"},{"line_number":438,"context_line":"    if ip_version \u003d\u003d 4:"},{"line_number":439,"context_line":"        boot_file_param \u003d DHCP_BOOTFILE_NAME"},{"line_number":440,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_ea530114","line":437,"range":{"start_line":437,"start_character":17,"end_line":437,"end_character":41},"updated":"2018-10-24 09:40:16.000000000","message":"we might want to check this option earlier, like the time during the conductor init.","commit_id":"09a6164ca7f33cf0bd97fc14c8554c9424de67fd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"094d020c41beac2a5c9356c1e05f53aa306c57c2","unresolved":false,"context_lines":[{"line_number":434,"context_line":"              the DHCP options to be set."},{"line_number":435,"context_line":"    \"\"\""},{"line_number":436,"context_line":"    dhcp_opts \u003d []"},{"line_number":437,"context_line":"    ip_version \u003d int(CONF.pxe.ip_version)"},{"line_number":438,"context_line":"    if ip_version \u003d\u003d 4:"},{"line_number":439,"context_line":"        boot_file_param \u003d DHCP_BOOTFILE_NAME"},{"line_number":440,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_cb908744","line":437,"in_reply_to":"3f79a3b5_2a649920","updated":"2018-10-24 12:48:36.000000000","message":"I guess we could change that, but that would be outside the scope of this patch, and possibly not even back-portable.","commit_id":"09a6164ca7f33cf0bd97fc14c8554c9424de67fd"}],"releasenotes/notes/boot-from-url-98d21670e726c518.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"94211db8749fa3dd838e3106a961bb319ae97a37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a misunderstanding in the how DHCPv6 booting of machines operates"},{"line_number":5,"context_line":"    in that only a URL to the boot loader is expected in that case, as opposed"},{"line_number":6,"context_line":"    to traditional TFTP parameters. Now a URL is sent to the client in the form"},{"line_number":7,"context_line":"    of ``tftp://\u003ctftp_address\u003e/\u003ctftp_path\u003e/\u003cboot_file\u003e``. See"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_0a5f5d4d","line":4,"updated":"2018-10-24 10:17:41.000000000","message":"nit: is \"the\" before \"how\" required?","commit_id":"09a6164ca7f33cf0bd97fc14c8554c9424de67fd"}]}