)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"118edff411e9d9bf6a28ae736cdbef1d258f4507","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_6_INSPECT_STATE:"},{"line_number":131,"context_line":"        obj.inspection_finished_at \u003d wsme.Unset"},{"line_number":132,"context_line":"        obj.inspection_started_at \u003d wsme.Unset"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_7_NODE_CLEAN:"},{"line_number":135,"context_line":"        obj.clean_step \u003d wsme.Unset"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_428d8e7b","side":"PARENT","line":133,"updated":"2018-10-19 15:17:39.000000000","message":"\\o/","commit_id":"7a551c4f4ad3852c1a37ec29235b131d20b6612b"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":28429,"name":"Lenovo LXCA CI","email":"lenovo.lxca.ci@gmail.com","username":"lenovo_lxca_ci","tags":["SERVICE_USER"]},"change_message_id":"fbf897d5cb49f8c7f36ffef2e89af75f479ddef8","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    VERSIONED_FIELDS[field] \u003d versions.MINOR_31_DYNAMIC_INTERFACES"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"def allow_field(field):"},{"line_number":386,"context_line":"    \"\"\"Check if a field is allowed in the current version.\"\"\""},{"line_number":387,"context_line":"    return pecan.request.version.minor \u003e\u003d VERSIONED_FIELDS[field]"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_11136d67","line":385,"range":{"start_line":385,"start_character":4,"end_line":385,"end_character":15},"updated":"2018-10-19 06:44:31.000000000","message":"I think it\u0027s better to use \"allowed_fields\" here","commit_id":"754361489d6161bde85375e844fe2bf0e2b4dd0a"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"97175b567d1e9fd1d0f488fbf73358f362521005","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    VERSIONED_FIELDS[field] \u003d versions.MINOR_31_DYNAMIC_INTERFACES"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"def allow_field(field):"},{"line_number":386,"context_line":"    \"\"\"Check if a field is allowed in the current version.\"\"\""},{"line_number":387,"context_line":"    return pecan.request.version.minor \u003e\u003d VERSIONED_FIELDS[field]"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_540473c5","line":385,"range":{"start_line":385,"start_character":4,"end_line":385,"end_character":15},"in_reply_to":"3f79a3b5_11136d67","updated":"2018-10-19 06:59:34.000000000","message":"Sorry for the inconvenience. This comment is added by \"jiapei\", just a misuse when debugging CI.","commit_id":"754361489d6161bde85375e844fe2bf0e2b4dd0a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"118edff411e9d9bf6a28ae736cdbef1d258f4507","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    VERSIONED_FIELDS[field] \u003d versions.MINOR_31_DYNAMIC_INTERFACES"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"def allow_field(field):"},{"line_number":386,"context_line":"    \"\"\"Check if a field is allowed in the current version.\"\"\""},{"line_number":387,"context_line":"    return pecan.request.version.minor \u003e\u003d VERSIONED_FIELDS[field]"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a27ee26a","line":385,"range":{"start_line":385,"start_character":4,"end_line":385,"end_character":15},"in_reply_to":"3f79a3b5_1f5a8f50","updated":"2018-10-19 15:17:39.000000000","message":"+1 to allow_field, this is called a single field at a time.","commit_id":"754361489d6161bde85375e844fe2bf0e2b4dd0a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dc951876869e98683943ed3e813318a2ec8fa74","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    VERSIONED_FIELDS[field] \u003d versions.MINOR_31_DYNAMIC_INTERFACES"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"def allow_field(field):"},{"line_number":386,"context_line":"    \"\"\"Check if a field is allowed in the current version.\"\"\""},{"line_number":387,"context_line":"    return pecan.request.version.minor \u003e\u003d VERSIONED_FIELDS[field]"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1f5a8f50","line":385,"range":{"start_line":385,"start_character":4,"end_line":385,"end_character":15},"in_reply_to":"3f79a3b5_540473c5","updated":"2018-10-19 14:51:37.000000000","message":"It seems a bit nit-picky, to be honest. I\u0027m essentially following the pattern by the existing functions below. Also \"allowed_fields\" will not work, since this call does not return allowed fields, it just checks one field. Something like \"is_field_allowed\" could be better, but dunno.","commit_id":"754361489d6161bde85375e844fe2bf0e2b4dd0a"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"5f2bdc1da5b307f62a854211adc765951eae8be4","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    VERSIONED_FIELDS[field] \u003d versions.MINOR_31_DYNAMIC_INTERFACES"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"def allow_field(field):"},{"line_number":386,"context_line":"    \"\"\"Check if a field is allowed in the current version.\"\"\""},{"line_number":387,"context_line":"    return pecan.request.version.minor \u003e\u003d VERSIONED_FIELDS[field]"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a9122954","line":385,"range":{"start_line":385,"start_character":4,"end_line":385,"end_character":15},"in_reply_to":"3f79a3b5_a27ee26a","updated":"2018-10-22 14:28:54.000000000","message":"Yes, it just returns a \"True/False\", so I think allow_field is better now.","commit_id":"754361489d6161bde85375e844fe2bf0e2b4dd0a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"118edff411e9d9bf6a28ae736cdbef1d258f4507","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"def allow_field(field):"},{"line_number":386,"context_line":"    \"\"\"Check if a field is allowed in the current version.\"\"\""},{"line_number":387,"context_line":"    return pecan.request.version.minor \u003e\u003d VERSIONED_FIELDS[field]"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"def disallowed_fields():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_229df257","line":387,"range":{"start_line":387,"start_character":11,"end_line":387,"end_character":38},"updated":"2018-10-19 15:17:39.000000000","message":"magic!","commit_id":"754361489d6161bde85375e844fe2bf0e2b4dd0a"},{"author":{"_account_id":28429,"name":"Lenovo LXCA CI","email":"lenovo.lxca.ci@gmail.com","username":"lenovo_lxca_ci","tags":["SERVICE_USER"]},"change_message_id":"fbf897d5cb49f8c7f36ffef2e89af75f479ddef8","unresolved":false,"context_lines":[{"line_number":390,"context_line":"def disallowed_fields():"},{"line_number":391,"context_line":"    \"\"\"Generator of fields not allowed in the current request.\"\"\""},{"line_number":392,"context_line":"    for field in VERSIONED_FIELDS:"},{"line_number":393,"context_line":"        if not allow_field(field):"},{"line_number":394,"context_line":"            yield field"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d104151c","line":393,"range":{"start_line":393,"start_character":15,"end_line":393,"end_character":26},"updated":"2018-10-19 06:44:31.000000000","message":"same as above","commit_id":"754361489d6161bde85375e844fe2bf0e2b4dd0a"},{"author":{"_account_id":25547,"name":"jiapei","email":"jiapeish@gmail.com","username":"jeremy.jia"},"change_message_id":"97175b567d1e9fd1d0f488fbf73358f362521005","unresolved":false,"context_lines":[{"line_number":390,"context_line":"def disallowed_fields():"},{"line_number":391,"context_line":"    \"\"\"Generator of fields not allowed in the current request.\"\"\""},{"line_number":392,"context_line":"    for field in VERSIONED_FIELDS:"},{"line_number":393,"context_line":"        if not allow_field(field):"},{"line_number":394,"context_line":"            yield field"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f4081fd9","line":393,"range":{"start_line":393,"start_character":15,"end_line":393,"end_character":26},"in_reply_to":"3f79a3b5_d104151c","updated":"2018-10-19 06:59:34.000000000","message":"Sorry for the inconvenience. This comment is added by \"jiapei\", just a misuse when debugging CI.","commit_id":"754361489d6161bde85375e844fe2bf0e2b4dd0a"}],"ironic/tests/unit/api/utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"118edff411e9d9bf6a28ae736cdbef1d258f4507","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    # older API versions to fail."},{"line_number":107,"context_line":"    for field in api_utils.VERSIONED_FIELDS:"},{"line_number":108,"context_line":"        if field not in kw:"},{"line_number":109,"context_line":"            node.pop(field, None)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    internal \u003d node_controller.NodePatchType.internal_attrs()"},{"line_number":112,"context_line":"    return remove_internal(node, internal)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_02bb16be","line":109,"updated":"2018-10-19 15:17:39.000000000","message":"\\o/","commit_id":"754361489d6161bde85375e844fe2bf0e2b4dd0a"}]}
