)]}'
{"ironic/conductor/utils.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"998b4953309c06a6d15f28a103ab9ad36ef426ec","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    node.fault \u003d faults.CLEAN_FAILURE"},{"line_number":435,"context_line":"    node.save()"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    if set_fail_state and node.provision_state !\u003d states.CLEANFAIL:"},{"line_number":438,"context_line":"        target_state \u003d states.MANAGEABLE if manual_clean else None"},{"line_number":439,"context_line":"        task.process_event(\u0027fail\u0027, target_state\u003dtarget_state)"},{"line_number":440,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a40bc02a","line":437,"updated":"2018-11-09 02:47:20.000000000","message":"I think this is not required, looks like a defensive move.","commit_id":"78ae60f11ee708442249c3b00f06d5e0fe73910d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b2a81d1f984ef68910099b5a69f6500175bc6f4b","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    node.fault \u003d faults.CLEAN_FAILURE"},{"line_number":435,"context_line":"    node.save()"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    if set_fail_state and node.provision_state !\u003d states.CLEANFAIL:"},{"line_number":438,"context_line":"        target_state \u003d states.MANAGEABLE if manual_clean else None"},{"line_number":439,"context_line":"        task.process_event(\u0027fail\u0027, target_state\u003dtarget_state)"},{"line_number":440,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_78ba00e0","line":437,"in_reply_to":"3f79a3b5_a40bc02a","updated":"2018-11-12 16:13:27.000000000","message":"Right, it shouldn\u0027t happen. However, this code does allow for states.CLEANFAIL (L420), so if the caller doesn\u0027t specify set_fail_state\u003dFalse, our code should still handle this case properly.","commit_id":"78ae60f11ee708442249c3b00f06d5e0fe73910d"}]}
