)]}'
{"ironic/common/utils.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"e4c5ed0d6ab863cd26664aab6d006d17582f7ce9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    if \u0027run_as_root\u0027 in kwargs and not \u0027root_helper\u0027 in kwargs:"},{"line_number":90,"context_line":"        kwargs[\u0027root_helper\u0027] \u003d _get_root_helper()"},{"line_number":91,"context_line":"    result \u003d processutils.trycmd(*args, **kwargs)"},{"line_number":92,"context_line":"    _log_cmd_output(args, result)"},{"line_number":93,"context_line":"    return result"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F88Es%3D","line":92,"updated":"2013-12-18 15:32:31.000000000","message":"IMO log messages in this case would not be correct, because result of trycmd may contains not command\u0027s stdout/stderr: https://github.com/openstack/ironic/blob/master/ironic/openstack/common/processutils.py#L207","commit_id":"9b61fa18f8bb784b5f16f8f6ac80d4bf285eff53"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"37063d33d62631a61ca6393985d7aa01f2091903","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    if \u0027run_as_root\u0027 in kwargs and not \u0027root_helper\u0027 in kwargs:"},{"line_number":90,"context_line":"        kwargs[\u0027root_helper\u0027] \u003d _get_root_helper()"},{"line_number":91,"context_line":"    result \u003d processutils.trycmd(*args, **kwargs)"},{"line_number":92,"context_line":"    _log_cmd_output(args, result)"},{"line_number":93,"context_line":"    return result"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F83%2Bo%3D","line":92,"in_reply_to":"AAAATn%2F88Es%3D","updated":"2013-12-19 09:53:40.000000000","message":"a-ha! Thanks for spotting that :)","commit_id":"9b61fa18f8bb784b5f16f8f6ac80d4bf285eff53"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"43f50ab1ffb10a8942e194839dd3d17d6add5d5e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"\"\"Convenience wrapper around oslo\u0027s trycmd() method.\"\"\""},{"line_number":85,"context_line":"    if \u0027run_as_root\u0027 in kwargs and not \u0027root_helper\u0027 in kwargs:"},{"line_number":86,"context_line":"        kwargs[\u0027root_helper\u0027] \u003d _get_root_helper()"},{"line_number":87,"context_line":"    result \u003d processutils.trycmd(*args, **kwargs)"},{"line_number":88,"context_line":"    return result"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F81eA%3D","line":87,"updated":"2013-12-19 18:28:30.000000000","message":"you could just return this w/o storing in \u0027result\u0027","commit_id":"16c828247f0f9d39f2ee8ae67ba8e434efbd8a37"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"373e63b54d803d54f0b57462a5158659f0d27a7b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"\"\"Convenience wrapper around oslo\u0027s trycmd() method.\"\"\""},{"line_number":85,"context_line":"    if \u0027run_as_root\u0027 in kwargs and not \u0027root_helper\u0027 in kwargs:"},{"line_number":86,"context_line":"        kwargs[\u0027root_helper\u0027] \u003d _get_root_helper()"},{"line_number":87,"context_line":"    result \u003d processutils.trycmd(*args, **kwargs)"},{"line_number":88,"context_line":"    return result"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F8ykU%3D","line":87,"in_reply_to":"AAAATn%2F81eA%3D","updated":"2013-12-20 09:29:47.000000000","message":"Ah! Thanks for it","commit_id":"16c828247f0f9d39f2ee8ae67ba8e434efbd8a37"}]}