)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"0a5448d8bdf8e84c7d90326287a18ad021e019fd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     digambar \u003cdigambarpatil15@yahoo.co.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-11-14 07:54:53 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix OOB introspection to use pxe_enabled flag"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Overcloud nodes fail to pxe boot during overcloud deployment."},{"line_number":10,"context_line":"Reason of this failure is because we are not checking the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_dbae8b7f","line":7,"updated":"2018-11-14 15:46:38.000000000","message":"For idrac driver/hardwaretype","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"0a5448d8bdf8e84c7d90326287a18ad021e019fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix OOB introspection to use pxe_enabled flag"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Overcloud nodes fail to pxe boot during overcloud deployment."},{"line_number":10,"context_line":"Reason of this failure is because we are not checking the"},{"line_number":11,"context_line":"actual pxe device interface and updating the port pxe_enbled field."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_fbfd8770","line":9,"updated":"2018-11-14 15:46:38.000000000","message":"Overcloud makes more sense in the context of RHOSP. Can we use generic terms in openstack world, maybe hardware nodes or baremetal node","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3541b854c9ebcfafcf1917a6897266a9eaa385a6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"values matching to nic id and then update the port\u0027s pxe_enabled field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2890bf16110b713e269d4a4fe410f57273dc8e83"},{"line_number":18,"context_line":"Story: #2004340"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_ff5ecc76","line":18,"updated":"2018-11-14 23:51:11.000000000","message":"A line that references the task is needed here.\n\nTask: 27927","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3541b854c9ebcfafcf1917a6897266a9eaa385a6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"values matching to nic id and then update the port\u0027s pxe_enabled field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I2890bf16110b713e269d4a4fe410f57273dc8e83"},{"line_number":18,"context_line":"Story: #2004340"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_9f53186f","line":18,"updated":"2018-11-14 23:51:11.000000000","message":"Please remove the hash, \u0027#\u0027. While that should be used with Launchpad, it doesn\u0027t appear to work with StoryBoard. Note that the story was not automatically updated when this change was submitted for review -- https://storyboard.openstack.org/#!/story/2004340 Please see https://docs.openstack.org/infra/manual/developers.html#working-on-bugs and its reference to https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"6a83c6ea76b4c0365ceebd1190426c85641895e9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Baremetal nodes fail to pxe boot during OpenStack deployment."},{"line_number":10,"context_line":"Reason of this failure is because we are not checking the"},{"line_number":11,"context_line":"actual pxe device interface and updating the port pxe_enbled field."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch make sure that everytime when port is created, it checks the"},{"line_number":14,"context_line":"the BIOS and UEFI boot modes of node and fetch the pxe device interfaces"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3f79a3b5_536a5718","line":11,"updated":"2018-11-30 20:29:01.000000000","message":"Nit: in the line above, can you change \"pxe_enbled\" to \"pxe_enabled\"?","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"14fefa9afeea2d2236f5fcd8c4d677c46830306c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Baremetal nodes fail to pxe boot during OpenStack deployment."},{"line_number":10,"context_line":"Reason of this failure is because we are not checking the"},{"line_number":11,"context_line":"actual pxe device interface and updating the port pxe_enbled field."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch make sure that everytime when port is created, it checks the"},{"line_number":14,"context_line":"the BIOS and UEFI boot modes of node and fetch the pxe device interfaces"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3f79a3b5_d605e3c1","line":11,"in_reply_to":"3f79a3b5_536a5718","updated":"2018-12-03 06:23:48.000000000","message":"Done","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"}],"ironic/drivers/modules/drac/inspect.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"8e3df0474bed35562d91f7b7fc26f60d694dd84f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        try:"},{"line_number":123,"context_line":"            bios_settings \u003d client.list_bios_settings()"},{"line_number":124,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":125,"context_line":"            LOG.error(\u0027DRAC driver failed to set bios settings\u0027"},{"line_number":126,"context_line":"                      \u0027for node %(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":127,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":128,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8dbd3506","line":125,"updated":"2018-11-14 22:06:29.000000000","message":"Can you change the above to \"... failed to inspect node ...\"?","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"0a5448d8bdf8e84c7d90326287a18ad021e019fd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                port.create()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"                try:"},{"line_number":139,"context_line":"                    if bios_settings[\"BootMode\"].current_value \u003d\u003d \"Bios\":"},{"line_number":140,"context_line":"                        nic_cap \u003d client.list_nic_settings(nic_id\u003dnic.id)"},{"line_number":141,"context_line":"                        if nic_cap[\u0027LegacyBootProto\u0027].current_value \u003d\u003d \"PXE\":"},{"line_number":142,"context_line":"                            port.pxe_enabled \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5b103bf5","line":139,"updated":"2018-11-14 15:46:38.000000000","message":"Can we not hard code these values pl?","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3541b854c9ebcfafcf1917a6897266a9eaa385a6","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                        if nic_cap[\u0027LegacyBootProto\u0027].current_value \u003d\u003d \"PXE\":"},{"line_number":142,"context_line":"                            port.pxe_enabled \u003d True"},{"line_number":143,"context_line":"                    elif bios_settings[\"BootMode\"].current_value \u003d\u003d \"Uefi\":"},{"line_number":144,"context_line":"                        if nic.id in pxe_dev_nics:"},{"line_number":145,"context_line":"                            port.pxe_enabled \u003d True"},{"line_number":146,"context_line":"                except drac_exceptions.BaseClientException as exc:"},{"line_number":147,"context_line":"                    LOG.error(\u0027DRAC driver failed to set nic settings\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bf585489","line":144,"updated":"2018-11-14 23:51:11.000000000","message":"Notice that pxe_dev_nics is used only if the boot mode is UEFI, which seems awkward. Seems to me the code would be better structured if this function were refactored so that it\u0027s independent of the boot mode. To accomplish that, the call to list BIOS settings would be moved to _get_pxe_dev_nics(). The examination of the boot mode BIOS setting would be moved there, too, along with listing the NIC settings, client.list_nic_settings(). _get_pxe_dev_nics() would return a list of NIC port identifiers that are PXE enabled.","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"8e3df0474bed35562d91f7b7fc26f60d694dd84f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                        if nic.id in pxe_dev_nics:"},{"line_number":145,"context_line":"                            port.pxe_enabled \u003d True"},{"line_number":146,"context_line":"                except drac_exceptions.BaseClientException as exc:"},{"line_number":147,"context_line":"                    LOG.error(\u0027DRAC driver failed to set nic settings\u0027"},{"line_number":148,"context_line":"                              \u0027for node %(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":149,"context_line":"                              {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":150,"context_line":"                    raise exception.HardwareInspectionFailure(error\u003dexc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4d4cfd3f","line":147,"updated":"2018-11-14 22:06:29.000000000","message":"Can you change the above to \"... failed to inspect node ...\"?","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"0a5448d8bdf8e84c7d90326287a18ad021e019fd","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                LOG.info(\u0027Port created with MAC address %(mac)s \u0027"},{"line_number":154,"context_line":"                         \u0027for node %(node_uuid)s during inspection\u0027,"},{"line_number":155,"context_line":"                         {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"            except exception.MACAlreadyExists:"},{"line_number":158,"context_line":"                LOG.warning(\u0027Failed to create a port with MAC address \u0027"},{"line_number":159,"context_line":"                            \u0027%(mac)s when inspecting the node \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5be59b06","line":156,"updated":"2018-11-14 15:46:38.000000000","message":"Remove added line","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3541b854c9ebcfafcf1917a6897266a9eaa385a6","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        else:"},{"line_number":190,"context_line":"            return cpu.cores"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def _get_pxe_dev_nics(self, bios_settings):"},{"line_number":193,"context_line":"        pxe_params \u003d [\"PxeDev1EnDis\", \"PxeDev2EnDis\","},{"line_number":194,"context_line":"                      \"PxeDev3EnDis\", \"PxeDev4EnDis\"]"},{"line_number":195,"context_line":"        pxe_nics \u003d [\"PxeDev1Interface\", \"PxeDev2Interface\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5f4d80c4","line":192,"updated":"2018-11-14 23:51:11.000000000","message":"nit: Consider renaming this _get_pxe_dev_nic_ids.","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"0a5448d8bdf8e84c7d90326287a18ad021e019fd","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            return cpu.cores"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def _get_pxe_dev_nics(self, bios_settings):"},{"line_number":193,"context_line":"        pxe_params \u003d [\"PxeDev1EnDis\", \"PxeDev2EnDis\","},{"line_number":194,"context_line":"                      \"PxeDev3EnDis\", \"PxeDev4EnDis\"]"},{"line_number":195,"context_line":"        pxe_nics \u003d [\"PxeDev1Interface\", \"PxeDev2Interface\","},{"line_number":196,"context_line":"                    \"PxeDev3Interface\", \"PxeDev4Interface\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1bb963ea","line":193,"updated":"2018-11-14 15:46:38.000000000","message":"Can we not hard code pl?","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"3541b854c9ebcfafcf1917a6897266a9eaa385a6","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        pxe_nics \u003d [\"PxeDev1Interface\", \"PxeDev2Interface\","},{"line_number":196,"context_line":"                    \"PxeDev3Interface\", \"PxeDev4Interface\"]"},{"line_number":197,"context_line":"        pxe_uefi_nics \u003d []"},{"line_number":198,"context_line":"        for i in range(4):"},{"line_number":199,"context_line":"            if pxe_params[i] in bios_settings and bios_settings["},{"line_number":200,"context_line":"                    pxe_params[i]].current_value \u003d\u003d \"Enabled\":"},{"line_number":201,"context_line":"                pxe_uefi_nics.append(bios_settings[pxe_nics[i]].current_value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7f4abcae","line":198,"updated":"2018-11-14 23:51:11.000000000","message":"This could be made capable of supporting more PXE devices by constructing the attribute name at run-time. If it exists, process it; otherwise, break out of the loop.","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"0a5448d8bdf8e84c7d90326287a18ad021e019fd","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        pxe_uefi_nics \u003d []"},{"line_number":198,"context_line":"        for i in range(4):"},{"line_number":199,"context_line":"            if pxe_params[i] in bios_settings and bios_settings["},{"line_number":200,"context_line":"                    pxe_params[i]].current_value \u003d\u003d \"Enabled\":"},{"line_number":201,"context_line":"                pxe_uefi_nics.append(bios_settings[pxe_nics[i]].current_value)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        return pxe_uefi_nics"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bbadcfa5","line":200,"updated":"2018-11-14 15:46:38.000000000","message":"Ditto","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"2bf8fd5f8e83d8820eaf2a0df8b1dbbb0809f902","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":193,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if bios_settings[\"BootMode\"].current_value \u003d\u003d \"Uefi\":"},{"line_number":196,"context_line":"            for i in range(4):"},{"line_number":197,"context_line":"                if pxe_params[i] in bios_settings and bios_settings["},{"line_number":198,"context_line":"                        pxe_params[i]].current_value \u003d\u003d \"Enabled\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6591b445","line":195,"updated":"2018-11-16 15:19:32.000000000","message":"Can we find a way not to HardCode these values ?","commit_id":"cf68f815e644370e521f5750d7b2db78b0b127a0"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"d754888194c645764c7cd1f9bec3f79019146f95","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":193,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if bios_settings[\"BootMode\"].current_value \u003d\u003d \"Uefi\":"},{"line_number":196,"context_line":"            for i in range(4):"},{"line_number":197,"context_line":"                if pxe_params[i] in bios_settings and bios_settings["},{"line_number":198,"context_line":"                        pxe_params[i]].current_value \u003d\u003d \"Enabled\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4ba5a948","line":195,"in_reply_to":"3f79a3b5_6591b445","updated":"2018-11-16 17:52:10.000000000","message":"Actually above boot mode strings are required without which its difficult to check the condition. \nI will do some investigation if I get atleast constants for boot modes (UEFI/BIOS), rests strings are required because those are very dracclient specific","commit_id":"cf68f815e644370e521f5750d7b2db78b0b127a0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b2464dbaa772ed46f5143f59ad4b4d55413388ce","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        for nic in nics:"},{"line_number":125,"context_line":"            try:"},{"line_number":126,"context_line":"                port \u003d objects.Port(task.context, address\u003dnic.mac,"},{"line_number":127,"context_line":"                                    node_id\u003dnode.id)"},{"line_number":128,"context_line":"                port.create()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"                if nic.id in pxe_dev_nics:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_7115cb3d","line":127,"updated":"2018-11-20 13:23:35.000000000","message":"... pxe_enabled\u003d(nic.id in pxe_dev_nics))","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"37d7c9ce864d09fff111dc9b503da43990a31f67","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        for nic in nics:"},{"line_number":125,"context_line":"            try:"},{"line_number":126,"context_line":"                port \u003d objects.Port(task.context, address\u003dnic.mac,"},{"line_number":127,"context_line":"                                    node_id\u003dnode.id)"},{"line_number":128,"context_line":"                port.create()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"                if nic.id in pxe_dev_nics:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_3347421e","line":127,"in_reply_to":"3f79a3b5_7115cb3d","updated":"2018-11-27 09:18:19.000000000","message":"\u003e ... pxe_enabled\u003d(nic.id in pxe_dev_nics))","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"3248c862f0d14d9baa469f03673a3040659e8df7","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        for nic in nics:"},{"line_number":125,"context_line":"            try:"},{"line_number":126,"context_line":"                port \u003d objects.Port(task.context, address\u003dnic.mac,"},{"line_number":127,"context_line":"                                    node_id\u003dnode.id)"},{"line_number":128,"context_line":"                port.create()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"                if nic.id in pxe_dev_nics:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_d13e1f87","line":127,"in_reply_to":"3f79a3b5_7115cb3d","updated":"2018-11-20 13:52:29.000000000","message":"okay","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b2464dbaa772ed46f5143f59ad4b4d55413388ce","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                port.create()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"                if nic.id in pxe_dev_nics:"},{"line_number":131,"context_line":"                    port.pxe_enabled \u003d True"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"                port.save()"},{"line_number":134,"context_line":"                LOG.info(\u0027Port created with MAC address %(mac)s \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_9110a74e","line":131,"updated":"2018-11-20 13:23:35.000000000","message":"True is the default, you\u0027re not changing anything here","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"3248c862f0d14d9baa469f03673a3040659e8df7","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                port.create()"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"                if nic.id in pxe_dev_nics:"},{"line_number":131,"context_line":"                    port.pxe_enabled \u003d True"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"                port.save()"},{"line_number":134,"context_line":"                LOG.info(\u0027Port created with MAC address %(mac)s \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_9148a72b","line":131,"in_reply_to":"3f79a3b5_9110a74e","updated":"2018-11-20 13:52:29.000000000","message":"Done","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b2464dbaa772ed46f5143f59ad4b4d55413388ce","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if bios_settings[\"BootMode\"].current_value \u003d\u003d \"Uefi\":"},{"line_number":196,"context_line":"            for i in range(4):"},{"line_number":197,"context_line":"                if pxe_params[i] in bios_settings and bios_settings["},{"line_number":198,"context_line":"                        pxe_params[i]].current_value \u003d\u003d \"Enabled\":"},{"line_number":199,"context_line":"                    pxe_uefi_nics.append("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_312193a2","line":196,"updated":"2018-11-20 13:23:35.000000000","message":"nit:\n\n for param, nic in zip(pxe_params, pxe_nics):","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"3248c862f0d14d9baa469f03673a3040659e8df7","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if bios_settings[\"BootMode\"].current_value \u003d\u003d \"Uefi\":"},{"line_number":196,"context_line":"            for i in range(4):"},{"line_number":197,"context_line":"                if pxe_params[i] in bios_settings and bios_settings["},{"line_number":198,"context_line":"                        pxe_params[i]].current_value \u003d\u003d \"Enabled\":"},{"line_number":199,"context_line":"                    pxe_uefi_nics.append("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_1156d7ce","line":196,"in_reply_to":"3f79a3b5_312193a2","updated":"2018-11-20 13:52:29.000000000","message":"got it.","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cf8baa066c069597d635d3c2178b2ee2001bc210","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":120,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        for nic in nics:"},{"line_number":125,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_2e79ff30","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":20},"updated":"2018-11-23 06:54:54.000000000","message":"Would it be useful to log a message/ throw exception if this list is empty (No NICs are in enabled state)?","commit_id":"bdebfb3d204e0784e2a668c7e949de365ac029d1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cf8baa066c069597d635d3c2178b2ee2001bc210","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        :returns: Returns list of pxe device interfaces."},{"line_number":175,"context_line":"        \"\"\""},{"line_number":176,"context_line":"        pxe_uefi_nics \u003d []"},{"line_number":177,"context_line":"        pxe_params \u003d [\"PxeDev1EnDis\", \"PxeDev2EnDis\","},{"line_number":178,"context_line":"                      \"PxeDev3EnDis\", \"PxeDev4EnDis\"]"},{"line_number":179,"context_line":"        pxe_nics \u003d [\"PxeDev1Interface\", \"PxeDev2Interface\","}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_6eccd795","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":21},"updated":"2018-11-23 06:54:54.000000000","message":"nit: since this variable is used to capture NICs for both Legacy BIOS and UEFI, may be variable name could be \u0027pxe_nics\u0027 instead of having \u0027uefi\u0027 in variable name.","commit_id":"bdebfb3d204e0784e2a668c7e949de365ac029d1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cf8baa066c069597d635d3c2178b2ee2001bc210","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            bios_settings \u003d client.list_bios_settings()"},{"line_number":184,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":185,"context_line":"            LOG.error(\u0027DRAC driver failed to inspect node\u0027"},{"line_number":186,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":187,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_4e7ebb1a","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":58},"updated":"2018-11-23 06:54:54.000000000","message":"Add a testacase for this error path.","commit_id":"bdebfb3d204e0784e2a668c7e949de365ac029d1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cf8baa066c069597d635d3c2178b2ee2001bc210","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                        bios_settings[nic].current_value)"},{"line_number":196,"context_line":"        elif bios_settings[\"BootMode\"].current_value \u003d\u003d \"Bios\":"},{"line_number":197,"context_line":"            for nic in nics:"},{"line_number":198,"context_line":"                nic_cap \u003d client.list_nic_settings(nic_id\u003dnic.id)"},{"line_number":199,"context_line":"                if nic_cap[\u0027LegacyBootProto\u0027].current_value \u003d\u003d \"PXE\":"},{"line_number":200,"context_line":"                    pxe_uefi_nics.append(nic.id)"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_cee2cbff","line":198,"range":{"start_line":198,"start_character":16,"end_line":198,"end_character":65},"updated":"2018-11-23 06:54:54.000000000","message":"We need to put this in try/except block to handle any drac_exceptions raised by this client call.","commit_id":"bdebfb3d204e0784e2a668c7e949de365ac029d1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4747cb5be45a6db0d36572dc90f024f6bfb2f44b","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.info(\"NICs are not associated with PXE\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        for nic in nics:"},{"line_number":127,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_507a8d26","line":124,"range":{"start_line":124,"start_character":16,"end_line":124,"end_character":20},"updated":"2018-11-28 06:59:37.000000000","message":"Wondering if this should be a \u0027warning\u0027 as at least one enabled NIC is required for provisioning?","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"64b7faf2ba886a6e75fd9222413732116ad5da52","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.info(\"NICs are not associated with PXE\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        for nic in nics:"},{"line_number":127,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_d0769dd6","line":124,"range":{"start_line":124,"start_character":16,"end_line":124,"end_character":20},"in_reply_to":"3f79a3b5_507a8d26","updated":"2018-11-28 07:20:11.000000000","message":"okay","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4747cb5be45a6db0d36572dc90f024f6bfb2f44b","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            bios_settings \u003d client.list_bios_settings()"},{"line_number":187,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":188,"context_line":"            LOG.error(\u0027DRAC driver failed to list bios settings\u0027"},{"line_number":189,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":190,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_f012b9ac","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":58},"updated":"2018-11-28 06:59:37.000000000","message":"It would be useful to add testcase for this exception path.","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"64b7faf2ba886a6e75fd9222413732116ad5da52","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            bios_settings \u003d client.list_bios_settings()"},{"line_number":187,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":188,"context_line":"            LOG.error(\u0027DRAC driver failed to list bios settings\u0027"},{"line_number":189,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":190,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_107175df","line":187,"range":{"start_line":187,"start_character":8,"end_line":187,"end_character":58},"in_reply_to":"3f79a3b5_f012b9ac","updated":"2018-11-28 07:20:11.000000000","message":"okay","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4747cb5be45a6db0d36572dc90f024f6bfb2f44b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            bios_settings \u003d client.list_bios_settings()"},{"line_number":187,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":188,"context_line":"            LOG.error(\u0027DRAC driver failed to list bios settings\u0027"},{"line_number":189,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":190,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":191,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_b028c1ec","line":188,"range":{"start_line":188,"start_character":55,"end_line":188,"end_character":63},"updated":"2018-11-28 06:59:37.000000000","message":"Need to add space \u0027 \u0027 at the end.\ns/ \u0027settings\u0027 / \u0027settings \u0027 /","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"64b7faf2ba886a6e75fd9222413732116ad5da52","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            bios_settings \u003d client.list_bios_settings()"},{"line_number":187,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":188,"context_line":"            LOG.error(\u0027DRAC driver failed to list bios settings\u0027"},{"line_number":189,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":190,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":191,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_50636d18","line":188,"range":{"start_line":188,"start_character":55,"end_line":188,"end_character":63},"in_reply_to":"3f79a3b5_b028c1ec","updated":"2018-11-28 07:20:11.000000000","message":"Done","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4747cb5be45a6db0d36572dc90f024f6bfb2f44b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            for nic in nics:"},{"line_number":201,"context_line":"                try:"},{"line_number":202,"context_line":"                    nic_cap \u003d client.list_nic_settings(nic_id\u003dnic.id)"},{"line_number":203,"context_line":"                except drac_exceptions.BaseClientException as exc:"},{"line_number":204,"context_line":"                    LOG.error(\u0027DRAC driver failed to list nic settings\u0027"},{"line_number":205,"context_line":"                              \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":206,"context_line":"                              {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_9073451c","line":203,"range":{"start_line":203,"start_character":16,"end_line":203,"end_character":66},"updated":"2018-11-28 06:59:37.000000000","message":"It would be useful to add testcase for this exception path.","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"64b7faf2ba886a6e75fd9222413732116ad5da52","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            for nic in nics:"},{"line_number":201,"context_line":"                try:"},{"line_number":202,"context_line":"                    nic_cap \u003d client.list_nic_settings(nic_id\u003dnic.id)"},{"line_number":203,"context_line":"                except drac_exceptions.BaseClientException as exc:"},{"line_number":204,"context_line":"                    LOG.error(\u0027DRAC driver failed to list nic settings\u0027"},{"line_number":205,"context_line":"                              \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":206,"context_line":"                              {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_b060c10d","line":203,"range":{"start_line":203,"start_character":16,"end_line":203,"end_character":66},"in_reply_to":"3f79a3b5_9073451c","updated":"2018-11-28 07:20:11.000000000","message":"\u003e It would be useful to add testcase for this exception path.\n\nokay","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4747cb5be45a6db0d36572dc90f024f6bfb2f44b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                try:"},{"line_number":202,"context_line":"                    nic_cap \u003d client.list_nic_settings(nic_id\u003dnic.id)"},{"line_number":203,"context_line":"                except drac_exceptions.BaseClientException as exc:"},{"line_number":204,"context_line":"                    LOG.error(\u0027DRAC driver failed to list nic settings\u0027"},{"line_number":205,"context_line":"                              \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":206,"context_line":"                              {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":207,"context_line":"                    raise exception.HardwareInspectionFailure(error\u003dexc)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_502b6de7","line":204,"range":{"start_line":204,"start_character":62,"end_line":204,"end_character":70},"updated":"2018-11-28 06:59:37.000000000","message":"Need to add space \u0027 \u0027 at the end.\ns/ \u0027settings\u0027 / \u0027settings \u0027 /","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"64b7faf2ba886a6e75fd9222413732116ad5da52","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                try:"},{"line_number":202,"context_line":"                    nic_cap \u003d client.list_nic_settings(nic_id\u003dnic.id)"},{"line_number":203,"context_line":"                except drac_exceptions.BaseClientException as exc:"},{"line_number":204,"context_line":"                    LOG.error(\u0027DRAC driver failed to list nic settings\u0027"},{"line_number":205,"context_line":"                              \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":206,"context_line":"                              {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":207,"context_line":"                    raise exception.HardwareInspectionFailure(error\u003dexc)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_306cb103","line":204,"range":{"start_line":204,"start_character":62,"end_line":204,"end_character":70},"in_reply_to":"3f79a3b5_502b6de7","updated":"2018-11-28 07:20:11.000000000","message":"Done","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f186b2adb586ed373e3f1ce092986730fa92335e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_71dbc1ea","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":32},"updated":"2018-12-02 05:46:24.000000000","message":"Add a testcase for this path.","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"14fefa9afeea2d2236f5fcd8c4d677c46830306c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_76488f2a","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":32},"in_reply_to":"3f79a3b5_71dbc1ea","updated":"2018-12-03 06:23:48.000000000","message":"ok","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"6a83c6ea76b4c0365ceebd1190426c85641895e9","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":127,"context_line":"                        {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_9349cfba","line":124,"updated":"2018-11-30 20:29:01.000000000","message":"Nit: in the line above, can you change \"One\" to \"one\"?","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f186b2adb586ed373e3f1ce092986730fa92335e","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":127,"context_line":"                        {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_f1e03196","line":124,"in_reply_to":"3f79a3b5_9349cfba","updated":"2018-12-02 05:46:24.000000000","message":"+1","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"14fefa9afeea2d2236f5fcd8c4d677c46830306c","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":127,"context_line":"                        {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_1657dbce","line":124,"in_reply_to":"3f79a3b5_9349cfba","updated":"2018-12-03 06:23:48.000000000","message":"Done","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f186b2adb586ed373e3f1ce092986730fa92335e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":127,"context_line":"                        {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_01dd7b6d","line":125,"range":{"start_line":125,"start_character":41,"end_line":125,"end_character":51},"updated":"2018-12-02 05:46:24.000000000","message":"s/ introspect / /","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"14fefa9afeea2d2236f5fcd8c4d677c46830306c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":127,"context_line":"                        {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_365c57ee","line":125,"range":{"start_line":125,"start_character":41,"end_line":125,"end_character":51},"in_reply_to":"3f79a3b5_01dd7b6d","updated":"2018-12-03 06:23:48.000000000","message":"Done","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f186b2adb586ed373e3f1ce092986730fa92335e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":127,"context_line":"                        {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        for nic in nics:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_e1cddfb9","line":126,"range":{"start_line":126,"start_character":40,"end_line":126,"end_character":58},"updated":"2018-12-02 05:46:24.000000000","message":"I suppose, there won\u0027t be any error captured here.","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"14fefa9afeea2d2236f5fcd8c4d677c46830306c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":127,"context_line":"                        {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        for nic in nics:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_d65083d4","line":126,"range":{"start_line":126,"start_character":40,"end_line":126,"end_character":58},"in_reply_to":"3f79a3b5_e1cddfb9","updated":"2018-12-03 06:23:48.000000000","message":"I will remove it","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f186b2adb586ed373e3f1ce092986730fa92335e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":127,"context_line":"                        {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        for nic in nics:"},{"line_number":130,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_a13cc791","line":127,"range":{"start_line":127,"start_character":58,"end_line":127,"end_character":61},"updated":"2018-12-02 05:46:24.000000000","message":"You will get \u0027exc\u0027 not defined error here.","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"14fefa9afeea2d2236f5fcd8c4d677c46830306c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            LOG.warning(\u0027At least One enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect node \u0027"},{"line_number":126,"context_line":"                        \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":127,"context_line":"                        {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        for nic in nics:"},{"line_number":130,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_f6557fc2","line":127,"range":{"start_line":127,"start_character":58,"end_line":127,"end_character":61},"in_reply_to":"3f79a3b5_a13cc791","updated":"2018-12-03 06:23:48.000000000","message":"got it","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"6a83c6ea76b4c0365ceebd1190426c85641895e9","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def _get_pxe_dev_nics(self, client, nics, node):"},{"line_number":175,"context_line":"        \"\"\"Get a list of pxe device interfaces."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        :param client: Dracclient to list the bios nics"},{"line_number":178,"context_line":"        :param nics: list of nics"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        :returns: Returns list of pxe device interfaces."}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_f3592368","line":177,"updated":"2018-11-30 20:29:01.000000000","message":"Nit: in the line above, can you change \"the bios nics\" to \"the bios settings and nics\"","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"14fefa9afeea2d2236f5fcd8c4d677c46830306c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def _get_pxe_dev_nics(self, client, nics, node):"},{"line_number":175,"context_line":"        \"\"\"Get a list of pxe device interfaces."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        :param client: Dracclient to list the bios nics"},{"line_number":178,"context_line":"        :param nics: list of nics"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        :returns: Returns list of pxe device interfaces."}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_b66707ba","line":177,"in_reply_to":"3f79a3b5_f3592368","updated":"2018-12-03 06:23:48.000000000","message":"Done","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f186b2adb586ed373e3f1ce092986730fa92335e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            bios_settings \u003d client.list_bios_settings()"},{"line_number":190,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":191,"context_line":"            LOG.error(\u0027DRAC driver failed to list bios settings \u0027"},{"line_number":192,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":193,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":194,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_31bea97d","line":192,"range":{"start_line":192,"start_character":23,"end_line":192,"end_character":36},"updated":"2018-12-02 05:46:24.000000000","message":"s/ %(node_uuid)s / for %(node_uuid)s /","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"14fefa9afeea2d2236f5fcd8c4d677c46830306c","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            bios_settings \u003d client.list_bios_settings()"},{"line_number":190,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":191,"context_line":"            LOG.error(\u0027DRAC driver failed to list bios settings \u0027"},{"line_number":192,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":193,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":194,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_566473b4","line":192,"range":{"start_line":192,"start_character":23,"end_line":192,"end_character":36},"in_reply_to":"3f79a3b5_31bea97d","updated":"2018-12-03 06:23:48.000000000","message":"ok","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f186b2adb586ed373e3f1ce092986730fa92335e","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                    nic_cap \u003d client.list_nic_settings(nic_id\u003dnic.id)"},{"line_number":206,"context_line":"                except drac_exceptions.BaseClientException as exc:"},{"line_number":207,"context_line":"                    LOG.error(\u0027DRAC driver failed to list nic settings \u0027"},{"line_number":208,"context_line":"                              \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":209,"context_line":"                              {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":210,"context_line":"                    raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_51c32506","line":208,"range":{"start_line":208,"start_character":31,"end_line":208,"end_character":44},"updated":"2018-12-02 05:46:24.000000000","message":"s/ %(node_uuid)s / for %(node_uuid)s /","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"14fefa9afeea2d2236f5fcd8c4d677c46830306c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                    nic_cap \u003d client.list_nic_settings(nic_id\u003dnic.id)"},{"line_number":206,"context_line":"                except drac_exceptions.BaseClientException as exc:"},{"line_number":207,"context_line":"                    LOG.error(\u0027DRAC driver failed to list nic settings \u0027"},{"line_number":208,"context_line":"                              \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":209,"context_line":"                              {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":210,"context_line":"                    raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_16fcbbba","line":208,"range":{"start_line":208,"start_character":31,"end_line":208,"end_character":44},"in_reply_to":"3f79a3b5_51c32506","updated":"2018-12-03 06:23:48.000000000","message":"Done","commit_id":"d20b4af73b94c82fd95c55dc56dd83661e1b8609"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6ef0501a738ce7637136f712d96f3f4facde26a4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least one enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect \u0027"},{"line_number":126,"context_line":"                        \u0027for %(node_uuid)s.\u0027, {\u0027node_uuid\u0027: node.uuid})"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        for nic in nics:"},{"line_number":129,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_e3a84a23","line":126,"range":{"start_line":123,"start_character":25,"end_line":126,"end_character":43},"updated":"2018-12-04 05:39:02.000000000","message":"May be this could be something like:-\n\"No PXE enabled NIC was found for node %s(node_uuid)s.\"","commit_id":"06f547825b3463ad67761739c273a70b9d019924"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"4409e7cb5ba40b8a1f0aa235ad598c91a34fac42","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027At least one enabled NIC is required for \u0027"},{"line_number":125,"context_line":"                        \u0027provisioning to introspect \u0027"},{"line_number":126,"context_line":"                        \u0027for %(node_uuid)s.\u0027, {\u0027node_uuid\u0027: node.uuid})"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        for nic in nics:"},{"line_number":129,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_ab478851","line":126,"range":{"start_line":123,"start_character":25,"end_line":126,"end_character":43},"in_reply_to":"3f79a3b5_e3a84a23","updated":"2018-12-04 09:42:21.000000000","message":"Okay","commit_id":"06f547825b3463ad67761739c273a70b9d019924"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6ef0501a738ce7637136f712d96f3f4facde26a4","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                              {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":209,"context_line":"                    raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"                if \"LegacyBootProto\" in nic_cap and nic_cap["},{"line_number":212,"context_line":"                        \u0027LegacyBootProto\u0027].current_value \u003d\u003d \"PXE\":"},{"line_number":213,"context_line":"                    pxe_dev_nics.append(nic.id)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        return pxe_dev_nics"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_75a5cdb2","line":212,"range":{"start_line":211,"start_character":15,"end_line":212,"end_character":66},"updated":"2018-12-04 05:39:02.000000000","message":"Better to format this as:\n if (\u0027LegacyBootProto\u0027 in nic_cap\n         and nic_cap[\u0027LegacyBootProto\u0027].current_value \u003d\u003d \"PXE\"):\n    ...","commit_id":"06f547825b3463ad67761739c273a70b9d019924"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"4409e7cb5ba40b8a1f0aa235ad598c91a34fac42","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                              {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":209,"context_line":"                    raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"                if \"LegacyBootProto\" in nic_cap and nic_cap["},{"line_number":212,"context_line":"                        \u0027LegacyBootProto\u0027].current_value \u003d\u003d \"PXE\":"},{"line_number":213,"context_line":"                    pxe_dev_nics.append(nic.id)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        return pxe_dev_nics"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f79a3b5_4b4ef46d","line":212,"range":{"start_line":211,"start_character":15,"end_line":212,"end_character":66},"in_reply_to":"3f79a3b5_75a5cdb2","updated":"2018-12-04 09:42:21.000000000","message":"okay","commit_id":"06f547825b3463ad67761739c273a70b9d019924"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d675a204ea161c8fc29b4978253eeb6d6921f5ef","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if bios_settings[\"BootMode\"].current_value \u003d\u003d \"Uefi\":"},{"line_number":195,"context_line":"            for param, nic in zip(pxe_params, pxe_nics):"},{"line_number":196,"context_line":"                if param in bios_settings and bios_settings["},{"line_number":197,"context_line":"                        param].current_value \u003d\u003d \"Enabled\":"},{"line_number":198,"context_line":"                    pxe_dev_nics.append("},{"line_number":199,"context_line":"                        bios_settings[nic].current_value)"},{"line_number":200,"context_line":"        elif bios_settings[\"BootMode\"].current_value \u003d\u003d \"Bios\":"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_39d1592f","line":197,"range":{"start_line":196,"start_character":19,"end_line":197,"end_character":57},"updated":"2018-12-05 22:19:16.000000000","message":"maybe?\n\n    if (param in bios_settings\n        and bios_settings[param].current_value \u003d\u003d \"Enabled\"):","commit_id":"2b74d940c932c1bb4498f47372c0545e4480799f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"93f1a849f127d3cee1c1948f05938efd7b7eeb74","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if bios_settings[\"BootMode\"].current_value \u003d\u003d \"Uefi\":"},{"line_number":195,"context_line":"            for param, nic in zip(pxe_params, pxe_nics):"},{"line_number":196,"context_line":"                if param in bios_settings and bios_settings["},{"line_number":197,"context_line":"                        param].current_value \u003d\u003d \"Enabled\":"},{"line_number":198,"context_line":"                    pxe_dev_nics.append("},{"line_number":199,"context_line":"                        bios_settings[nic].current_value)"},{"line_number":200,"context_line":"        elif bios_settings[\"BootMode\"].current_value \u003d\u003d \"Bios\":"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_65ef2280","line":197,"range":{"start_line":196,"start_character":19,"end_line":197,"end_character":57},"in_reply_to":"3f79a3b5_39d1592f","updated":"2018-12-06 04:00:31.000000000","message":"+1","commit_id":"2b74d940c932c1bb4498f47372c0545e4480799f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"93f1a849f127d3cee1c1948f05938efd7b7eeb74","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                              {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":208,"context_line":"                    raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"                if (\"LegacyBootProto\" in nic_cap and nic_cap["},{"line_number":211,"context_line":"                        \u0027LegacyBootProto\u0027].current_value \u003d\u003d \"PXE\"):"},{"line_number":212,"context_line":"                    pxe_dev_nics.append(nic.id)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        return pxe_dev_nics"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_25bcca69","line":211,"range":{"start_line":210,"start_character":19,"end_line":211,"end_character":66},"updated":"2018-12-06 04:00:31.000000000","message":"Same here.\nif (\u0027LegacyBootProto\u0027 in nic_cap\n    and nic_cap[\u0027LegacyBootProto\u0027].current_value \u003d\u003d \"PXE\"):","commit_id":"2b74d940c932c1bb4498f47372c0545e4480799f"}],"ironic/releasenotes/notes/update-port-pxe-enabled-f954f934209cbf5b.yaml":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"0a5448d8bdf8e84c7d90326287a18ad021e019fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug where port is not properly updated as per pxe enabled"},{"line_number":5,"context_line":"    interfaces of BIOS and UEFI boot modes. See bug `2004340"},{"line_number":6,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2004340\u003e`_ for details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_db80cbf9","line":4,"updated":"2018-11-14 15:46:38.000000000","message":"Please mention that this fixes the bug in the idrac hardwaretype or driver.","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b2464dbaa772ed46f5143f59ad4b4d55413388ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug where port is not properly updated as per pxe enabled"},{"line_number":5,"context_line":"    interfaces of BIOS and UEFI boot modes in ``idrac`` hardware type."},{"line_number":6,"context_line":"    See bug `2004340"},{"line_number":7,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2004340\u003e`_ for details."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_f11a3b69","line":4,"updated":"2018-11-20 13:23:35.000000000","message":"nit: s/pxe/PXE/, also let\u0027s mention inspection somewhere.","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"3248c862f0d14d9baa469f03673a3040659e8df7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug where port is not properly updated as per pxe enabled"},{"line_number":5,"context_line":"    interfaces of BIOS and UEFI boot modes in ``idrac`` hardware type."},{"line_number":6,"context_line":"    See bug `2004340"},{"line_number":7,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2004340\u003e`_ for details."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_916187a5","line":4,"in_reply_to":"3f79a3b5_f11a3b69","updated":"2018-11-20 13:52:29.000000000","message":"okay","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"}],"ironic/tests/unit/drivers/modules/drac/test_inspect.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"0a5448d8bdf8e84c7d90326287a18ad021e019fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_9beed3b4","line":298,"updated":"2018-11-14 15:46:38.000000000","message":"Please add -ve test cases for the exceptions you have added","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"2e795a8ee89bd44da5972e0f0e4f1a9bad90f2e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_a5826c01","line":298,"in_reply_to":"3f79a3b5_8dc77567","updated":"2018-11-16 15:17:58.000000000","message":"Negative Testing - testing the system by giving the Invalid data.","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"8e3df0474bed35562d91f7b7fc26f60d694dd84f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_8dc77567","line":298,"in_reply_to":"3f79a3b5_9beed3b4","updated":"2018-11-14 22:06:29.000000000","message":"Rajini, can you clarify what -ve test cases are?","commit_id":"7ffdd422d3a6c53ff808d5f338d4c6b9dac7a5f0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b2464dbaa772ed46f5143f59ad4b4d55413388ce","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self.physical_disks \u003d [test_utils.dict_to_namedtuple(values\u003dpd)"},{"line_number":144,"context_line":"                               for pd in physical_disks]"},{"line_number":145,"context_line":"        self.nics \u003d [test_utils.dict_to_namedtuple(values\u003dn) for n in nics]"},{"line_number":146,"context_line":"        self.bios_settings \u003d test_utils.dict_of_object(bios_settings)"},{"line_number":147,"context_line":"        self.nic_settings \u003d test_utils.dict_of_object(nic_settings)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_get_properties(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_b10b6321","line":146,"updated":"2018-11-20 13:23:35.000000000","message":"self.bios_settings \u003d [mock.Mock(**setting) for setting in bios_settings]","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"3248c862f0d14d9baa469f03673a3040659e8df7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self.physical_disks \u003d [test_utils.dict_to_namedtuple(values\u003dpd)"},{"line_number":144,"context_line":"                               for pd in physical_disks]"},{"line_number":145,"context_line":"        self.nics \u003d [test_utils.dict_to_namedtuple(values\u003dn) for n in nics]"},{"line_number":146,"context_line":"        self.bios_settings \u003d test_utils.dict_of_object(bios_settings)"},{"line_number":147,"context_line":"        self.nic_settings \u003d test_utils.dict_of_object(nic_settings)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_get_properties(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_5101afb3","line":146,"in_reply_to":"3f79a3b5_b10b6321","updated":"2018-11-20 13:52:29.000000000","message":"okay","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b2464dbaa772ed46f5143f59ad4b4d55413388ce","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                               for pd in physical_disks]"},{"line_number":145,"context_line":"        self.nics \u003d [test_utils.dict_to_namedtuple(values\u003dn) for n in nics]"},{"line_number":146,"context_line":"        self.bios_settings \u003d test_utils.dict_of_object(bios_settings)"},{"line_number":147,"context_line":"        self.nic_settings \u003d test_utils.dict_of_object(nic_settings)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_get_properties(self):"},{"line_number":150,"context_line":"        expected \u003d drac_common.COMMON_PROPERTIES"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_d1061f1a","line":147,"updated":"2018-11-20 13:23:35.000000000","message":"similar here","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"3248c862f0d14d9baa469f03673a3040659e8df7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                               for pd in physical_disks]"},{"line_number":145,"context_line":"        self.nics \u003d [test_utils.dict_to_namedtuple(values\u003dn) for n in nics]"},{"line_number":146,"context_line":"        self.bios_settings \u003d test_utils.dict_of_object(bios_settings)"},{"line_number":147,"context_line":"        self.nic_settings \u003d test_utils.dict_of_object(nic_settings)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_get_properties(self):"},{"line_number":150,"context_line":"        expected \u003d drac_common.COMMON_PROPERTIES"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_110b37d4","line":147,"in_reply_to":"3f79a3b5_d1061f1a","updated":"2018-11-20 13:52:29.000000000","message":"ok","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4747cb5be45a6db0d36572dc90f024f6bfb2f44b","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            pxe_dev_nics \u003d task.driver.inspect._get_pxe_dev_nics("},{"line_number":303,"context_line":"                mock_client, self.nics, self.node)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"            self.assertEqual(expected_pxe_nic, pxe_dev_nics[0])"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"},{"line_number":308,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_b05f6172","line":305,"range":{"start_line":305,"start_character":47,"end_line":305,"end_character":63},"updated":"2018-11-28 06:59:37.000000000","message":"Also to ensure that there is only one NIC in the pxe_dev_nics, we can:\nself.assertEqual(1, pxe_dev_nics.len())","commit_id":"94b91ca240348a04de1700a1e2570cbf87e44c3a"}],"ironic/tests/unit/drivers/modules/drac/utils.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"3339f43462b165bac1705ad527cc62dd9e2d4dcb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    enabled_raid_interfaces\u003d[\u0027idrac\u0027, \u0027fake\u0027, \u0027no-raid\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class DictToObj(object):"},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"        Returns a dictionary into a class"},{"line_number":37,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3ad5fc1a","line":34,"updated":"2018-11-19 20:23:33.000000000","message":"If the changes to these files are only used in the unit tests, then these changes really should be made to:\nhttps://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/drac/utils.py","commit_id":"eab50eb0534532d4849d3652348b5d6e0a7b831b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"3339f43462b165bac1705ad527cc62dd9e2d4dcb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    return collections.namedtuple(name, list(values))(**values)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def dict_of_object(items):"},{"line_number":53,"context_line":"    item_cap \u003d []"},{"line_number":54,"context_line":"    for data in items:"},{"line_number":55,"context_line":"        for k, v in data.iteritems():"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_fadea43b","line":52,"updated":"2018-11-19 20:23:33.000000000","message":"Same as above.","commit_id":"eab50eb0534532d4849d3652348b5d6e0a7b831b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b2464dbaa772ed46f5143f59ad4b4d55413388ce","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    enabled_raid_interfaces\u003d[\u0027idrac\u0027, \u0027fake\u0027, \u0027no-raid\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class DictToObj(object):"},{"line_number":35,"context_line":"    \"\"\"Returns a dictionary into a class\"\"\""},{"line_number":36,"context_line":"    def __init__(self, dictionary):"},{"line_number":37,"context_line":"        for key in dictionary:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_51244fb1","line":34,"updated":"2018-11-20 13:23:35.000000000","message":"not needed, see my comments in the tests","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"3248c862f0d14d9baa469f03673a3040659e8df7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    enabled_raid_interfaces\u003d[\u0027idrac\u0027, \u0027fake\u0027, \u0027no-raid\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class DictToObj(object):"},{"line_number":35,"context_line":"    \"\"\"Returns a dictionary into a class\"\"\""},{"line_number":36,"context_line":"    def __init__(self, dictionary):"},{"line_number":37,"context_line":"        for key in dictionary:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_1124975e","line":34,"in_reply_to":"3f79a3b5_51244fb1","updated":"2018-11-20 13:52:29.000000000","message":"ok","commit_id":"4acdb9eaa80f440af26f02c05016095fe618ae0f"}],"releasenotes/notes/update-port-pxe-enabled-f954f934209cbf5b.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6ef0501a738ce7637136f712d96f3f4facde26a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug where port is not updated in node introspection as per PXE"},{"line_number":5,"context_line":"    enabled interfaces of BIOS and UEFI boot modes in ``idrac`` hardware type."},{"line_number":6,"context_line":"    See bug `2004340"},{"line_number":7,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2004340\u003e`_ for details."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_15757934","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":26},"updated":"2018-12-04 05:39:02.000000000","message":"Should it be \u0027ironic ports\u0027?","commit_id":"06f547825b3463ad67761739c273a70b9d019924"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"4409e7cb5ba40b8a1f0aa235ad598c91a34fac42","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug where port is not updated in node introspection as per PXE"},{"line_number":5,"context_line":"    enabled interfaces of BIOS and UEFI boot modes in ``idrac`` hardware type."},{"line_number":6,"context_line":"    See bug `2004340"},{"line_number":7,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2004340\u003e`_ for details."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_6b6ad0b4","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":26},"in_reply_to":"3f79a3b5_15757934","updated":"2018-12-04 09:42:21.000000000","message":"Yes, will update","commit_id":"06f547825b3463ad67761739c273a70b9d019924"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6ef0501a738ce7637136f712d96f3f4facde26a4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug where port is not updated in node introspection as per PXE"},{"line_number":5,"context_line":"    enabled interfaces of BIOS and UEFI boot modes in ``idrac`` hardware type."},{"line_number":6,"context_line":"    See bug `2004340"},{"line_number":7,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2004340\u003e`_ for details."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_35951530","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":53},"updated":"2018-12-04 05:39:02.000000000","message":"s/ interfaces of BIOS and UEFI boot modes in / setting for /","commit_id":"06f547825b3463ad67761739c273a70b9d019924"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"4409e7cb5ba40b8a1f0aa235ad598c91a34fac42","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a bug where port is not updated in node introspection as per PXE"},{"line_number":5,"context_line":"    enabled interfaces of BIOS and UEFI boot modes in ``idrac`` hardware type."},{"line_number":6,"context_line":"    See bug `2004340"},{"line_number":7,"context_line":"    \u003chttps://storyboard.openstack.org/#!/story/2004340\u003e`_ for details."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_8b7bac7b","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":53},"in_reply_to":"3f79a3b5_35951530","updated":"2018-12-04 09:42:21.000000000","message":"okay","commit_id":"06f547825b3463ad67761739c273a70b9d019924"}]}