)]}'
{"ironic/conductor/rpcapi.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"569fe2100eb98d65a61f916c9f2f75439bc8ccc0","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.ring_manager \u003d hash_ring.HashRingManager(use_groups\u003duse_groups)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def get_conductor_for(self, node):"},{"line_number":127,"context_line":"        \"\"\"Get the conductor for the conductor service the node is mapped to."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param node: a node object."},{"line_number":130,"context_line":"        :returns: the conductor hostname."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7e1c4c13","line":127,"updated":"2018-11-27 14:52:18.000000000","message":"s/for the conductor service//","commit_id":"50cbd5dd6ba0d71f9a72d8c7280fe21bc30be6d2"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f9fab5f1ec6a443421632e4d9734b63042a6fce9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.ring_manager \u003d hash_ring.HashRingManager(use_groups\u003duse_groups)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def get_conductor_for(self, node):"},{"line_number":127,"context_line":"        \"\"\"Get the conductor for the conductor service the node is mapped to."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param node: a node object."},{"line_number":130,"context_line":"        :returns: the conductor hostname."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2dc1be30","line":127,"in_reply_to":"3f79a3b5_7e1c4c13","updated":"2018-11-29 02:27:12.000000000","message":"Done","commit_id":"50cbd5dd6ba0d71f9a72d8c7280fe21bc30be6d2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1883d749d367ee07f59179ecf9c8dc4acf0dab43","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                      {\u0027driver\u0027: node.driver, \u0027group\u0027: node.conductor_group})"},{"line_number":144,"context_line":"            raise exception.NoValidHost(reason\u003dreason)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_topic_for(self, node):"},{"line_number":147,"context_line":"        \"\"\"Get the RPC topic for the conductor service the node is mapped to."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param node: a node object."}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_6395292f","line":146,"updated":"2018-12-03 14:52:45.000000000","message":"as a complete aside, I wonder if we need to consider something like a get_topic_any_conductor one day.","commit_id":"e2a768f0cd2abf6f2ac456949a8c46628b27b5ef"}],"ironic/db/api.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"569fe2100eb98d65a61f916c9f2f75439bc8ccc0","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    @abc.abstractmethod"},{"line_number":509,"context_line":"    def get_conductor(self, hostname, ignore_online_flag\u003dFalse):"},{"line_number":510,"context_line":"        \"\"\"Retrieve a conductor\u0027s service record from the database."},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        :param hostname: The hostname of the conductor service."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_be1e640c","line":509,"updated":"2018-11-27 14:52:18.000000000","message":"This is quite confusing, let\u0027s maybe have online\u003d{None,True,False}, where None fetches all conductors?","commit_id":"50cbd5dd6ba0d71f9a72d8c7280fe21bc30be6d2"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f9fab5f1ec6a443421632e4d9734b63042a6fce9","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    @abc.abstractmethod"},{"line_number":509,"context_line":"    def get_conductor(self, hostname, ignore_online_flag\u003dFalse):"},{"line_number":510,"context_line":"        \"\"\"Retrieve a conductor\u0027s service record from the database."},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        :param hostname: The hostname of the conductor service."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8d73321c","line":509,"in_reply_to":"3f79a3b5_be1e640c","updated":"2018-11-29 02:27:12.000000000","message":"Done\n\nI remember Julia mentioned about the online flag during spec review. It seems we could just use update_at as the single source to determine whether the conductor is alive, the online flag is duplicated and doesn\u0027t always reflect the truth.","commit_id":"50cbd5dd6ba0d71f9a72d8c7280fe21bc30be6d2"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"967b7e5f2a941e955fd1cf821d64b32433627c6f","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        \"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    @abc.abstractmethod"},{"line_number":509,"context_line":"    def get_conductor(self, hostname, ignore_online_flag\u003dFalse):"},{"line_number":510,"context_line":"        \"\"\"Retrieve a conductor\u0027s service record from the database."},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        :param hostname: The hostname of the conductor service."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_37a4ab04","line":509,"in_reply_to":"3f79a3b5_be1e640c","updated":"2018-11-28 01:02:36.000000000","message":"Wow, I thought about online, but didn\u0027t aware of the magic None, will use that :)","commit_id":"50cbd5dd6ba0d71f9a72d8c7280fe21bc30be6d2"}],"ironic/objects/conductor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"569fe2100eb98d65a61f916c9f2f75439bc8ccc0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    # Implications of calling new remote procedures should be thought through."},{"line_number":67,"context_line":"    # @object_base.remotable_classmethod"},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def get_by_hostname(cls, context, hostname, ignore_online_flag\u003dFalse):"},{"line_number":70,"context_line":"        \"\"\"Get a Conductor record by its hostname."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        :param cls: the :class:`Conductor`"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_de21e04f","line":69,"updated":"2018-11-27 14:52:18.000000000","message":"ditto re ignore_online_flag","commit_id":"50cbd5dd6ba0d71f9a72d8c7280fe21bc30be6d2"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f9fab5f1ec6a443421632e4d9734b63042a6fce9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    # Implications of calling new remote procedures should be thought through."},{"line_number":67,"context_line":"    # @object_base.remotable_classmethod"},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def get_by_hostname(cls, context, hostname, ignore_online_flag\u003dFalse):"},{"line_number":70,"context_line":"        \"\"\"Get a Conductor record by its hostname."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        :param cls: the :class:`Conductor`"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4de0ba93","line":69,"in_reply_to":"3f79a3b5_de21e04f","updated":"2018-11-29 02:27:12.000000000","message":"Done","commit_id":"50cbd5dd6ba0d71f9a72d8c7280fe21bc30be6d2"}]}
