)]}'
{"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"03512444f45ab6411d60066b3ec1985a2af47334","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        cpu_arch \u003d node.properties.get(\u0027cpu_arch\u0027)"},{"line_number":123,"context_line":"        if cpu_arch is not None:"},{"line_number":124,"context_line":"            params[\u0027cpu_arch\u0027] \u003d cpu_arch"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Append disk label if specified"},{"line_number":127,"context_line":"        disk_label \u003d deploy_utils.get_disk_label(node)"},{"line_number":128,"context_line":"        if disk_label is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d2266f22","line":125,"updated":"2018-11-30 09:29:20.000000000","message":"I don\u0027t think it makes much sense right now, since only ppc has any specific actions based on cpu_arch. But we should think about it if we get more arch-specific code.","commit_id":"9298c2db4420e4526ffcc57a6ae8e82475fddca2"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6fc294adc341d141b6aa3a32dec635723ffb3a22","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        cpu_arch \u003d node.properties.get(\u0027cpu_arch\u0027)"},{"line_number":123,"context_line":"        if cpu_arch is not None:"},{"line_number":124,"context_line":"            params[\u0027cpu_arch\u0027] \u003d cpu_arch"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Append disk label if specified"},{"line_number":127,"context_line":"        disk_label \u003d deploy_utils.get_disk_label(node)"},{"line_number":128,"context_line":"        if disk_label is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_915b2bf7","line":125,"updated":"2018-11-29 12:08:43.000000000","message":"wondering if it makes sense to apply a default arch just like boot option or boot mode?","commit_id":"9298c2db4420e4526ffcc57a6ae8e82475fddca2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c2a55c06d44beab5e2e64e96adf62c0e1cd7631f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        cpu_arch \u003d node.properties.get(\u0027cpu_arch\u0027)"},{"line_number":123,"context_line":"        if cpu_arch is not None:"},{"line_number":124,"context_line":"            params[\u0027cpu_arch\u0027] \u003d cpu_arch"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Append disk label if specified"},{"line_number":127,"context_line":"        disk_label \u003d deploy_utils.get_disk_label(node)"},{"line_number":128,"context_line":"        if disk_label is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_4f1e4e10","line":125,"in_reply_to":"3f79a3b5_915b2bf7","updated":"2018-11-29 13:58:11.000000000","message":"Hi Kaifeng, good point. My understanding is that the cpu_arch property can influence some other options. If cpu_arch is not set in the node properties I wouldn\u0027t apply a default value that could be potentially wrong for the node we\u0027re deploying.","commit_id":"9298c2db4420e4526ffcc57a6ae8e82475fddca2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"87a0e32e6e5e8d724f179b65558ec2e1e10d855c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        cpu_arch \u003d node.properties.get(\u0027cpu_arch\u0027)"},{"line_number":123,"context_line":"        if cpu_arch is not None:"},{"line_number":124,"context_line":"            params[\u0027cpu_arch\u0027] \u003d cpu_arch"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Append disk label if specified"},{"line_number":127,"context_line":"        disk_label \u003d deploy_utils.get_disk_label(node)"},{"line_number":128,"context_line":"        if disk_label is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_ac01170b","line":125,"in_reply_to":"3f79a3b5_d2266f22","updated":"2018-11-30 14:44:49.000000000","message":"I concur with Dmitry. We shouldn\u0027t make assumptions as to what the hardware is, except only some hardware... like PPC is going to require very special actions.\n\nOut of curiosity, why are we not just letting IPA figure that out and do it remotely... oh right, iscsi deply :(","commit_id":"9298c2db4420e4526ffcc57a6ae8e82475fddca2"}],"ironic/tests/unit/drivers/modules/test_iscsi_deploy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c459e6cad721cdcd76ae6dac5275717a0890787","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def test_get_deploy_info_cpu_arch(self):"},{"line_number":422,"context_line":"        ret_val \u003d self._test_get_deploy_info()"},{"line_number":423,"context_line":"        self.assertEqual(\u0027x86_64\u0027, ret_val[\u0027cpu_arch\u0027])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_get_deploy_info_disk_label(self):"},{"line_number":426,"context_line":"        capabilities \u003d {\u0027capabilities\u0027: {\u0027disk_label\u0027: \u0027msdos\u0027}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fc704bdd","line":423,"updated":"2018-11-28 15:43:27.000000000","message":"let\u0027s also add a test with cpu_arch completely missing, and make sure it passes","commit_id":"76d74214a97dea99efb41ded65c3252942601168"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9fc6df48a47518c5605e9dace4f60369a6deaaf9","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def test_get_deploy_info_cpu_arch(self):"},{"line_number":422,"context_line":"        ret_val \u003d self._test_get_deploy_info()"},{"line_number":423,"context_line":"        self.assertEqual(\u0027x86_64\u0027, ret_val[\u0027cpu_arch\u0027])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_get_deploy_info_disk_label(self):"},{"line_number":426,"context_line":"        capabilities \u003d {\u0027capabilities\u0027: {\u0027disk_label\u0027: \u0027msdos\u0027}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5c3fffdc","line":423,"in_reply_to":"3f79a3b5_fc704bdd","updated":"2018-11-28 15:44:37.000000000","message":"++","commit_id":"76d74214a97dea99efb41ded65c3252942601168"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7e3751e16039b142c59e904b084c1f62f9b87109","unresolved":false,"context_lines":[{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def test_get_deploy_info_cpu_arch(self):"},{"line_number":422,"context_line":"        ret_val \u003d self._test_get_deploy_info()"},{"line_number":423,"context_line":"        self.assertEqual(\u0027x86_64\u0027, ret_val[\u0027cpu_arch\u0027])"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def test_get_deploy_info_disk_label(self):"},{"line_number":426,"context_line":"        capabilities \u003d {\u0027capabilities\u0027: {\u0027disk_label\u0027: \u0027msdos\u0027}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5bc7f498","line":423,"in_reply_to":"3f79a3b5_fc704bdd","updated":"2018-11-29 10:13:48.000000000","message":"Done","commit_id":"76d74214a97dea99efb41ded65c3252942601168"}],"releasenotes/notes/isci-optional-cpu-arch-ebf6a90dde34172c.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c459e6cad721cdcd76ae6dac5275717a0890787","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic fails iscsi deployments if cpu_arch is not specified on a node."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_5c661f29","line":4,"updated":"2018-11-28 15:43:27.000000000","message":"\"no longer fails\", s/iscsi/iSCSI/, s/cpu_arch/the ``cpu_arch`` property/","commit_id":"76d74214a97dea99efb41ded65c3252942601168"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"649ee6597690052c80cddf883c915e42700c0006","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic fails iscsi deployments if cpu_arch is not specified on a node."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_3caec330","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":10},"updated":"2018-11-28 15:43:03.000000000","message":"Could you make it \"Fixes an issue where iSCSI based deployments fail if the...","commit_id":"76d74214a97dea99efb41ded65c3252942601168"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2bb93203df46386325f5304e064edf0242688a42","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic fails iscsi deployments if cpu_arch is not specified on a node."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_0e713f47","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":10},"in_reply_to":"3f79a3b5_3caec330","updated":"2018-11-29 09:00:39.000000000","message":"Done","commit_id":"76d74214a97dea99efb41ded65c3252942601168"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2bb93203df46386325f5304e064edf0242688a42","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ironic fails iscsi deployments if cpu_arch is not specified on a node."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_ce6a674f","line":4,"in_reply_to":"3f79a3b5_5c661f29","updated":"2018-11-29 09:00:39.000000000","message":"Done","commit_id":"76d74214a97dea99efb41ded65c3252942601168"}]}