)]}'
{"ironic/cmd/combined.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cfa31023b82d736cb6852d8fb93223db3c6d93d2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # Must load the API after the conductor in order to pass"},{"line_number":73,"context_line":"    # an assertion that ironic.conductor.manager is not in sys.modules"},{"line_number":74,"context_line":"    from ironic.common import wsgi_service  # noqa"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    api_launcher \u003d service.ServiceLauncher(CONF, restart_method\u003d\u0027mutate\u0027)"},{"line_number":77,"context_line":"    api_svc \u003d api_launcher.launch_service("},{"line_number":78,"context_line":"        wsgi_service.WSGIService(\u0027ironic\u0027, CONF.api.enable_ssl_api))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_2cfb2b14","line":75,"updated":"2018-12-20 22:39:10.000000000","message":"So in external discussion, someone brought up \"can we use sqlite?\".\n\nI think it is kind of a valid ask and should be able to work in this case it would be in one process... and the unit tests take this route. I wouldn\u0027t want it to be an integrated default mode because single user trying to manage some baremetal from a vm or their laptop would be idea. Then again, I\u0027m thinking of the number of times I\u0027ve typed out \"drop database ironic;create database ironic;/q\"....","commit_id":"25b78d96341b73067075739a7583f2bcbee895dc"}],"ironic/cmd/standalone.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"64f3ce2a73711780457f6a92bbc7ca7f23ace08b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    assert \u0027ironic.conductor.manager\u0027 not in sys.modules"},{"line_number":39,"context_line":"    # Parse config file and command line options, then start logging"},{"line_number":40,"context_line":"    ironic_service.prepare_service(sys.argv)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    profiler.setup(\u0027ironic\u0027, CONF.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1e120357","line":41,"updated":"2018-12-10 01:54:55.000000000","message":"we may need to override the transport_url to fake:// here.\n\nby using the fake driver, we\u0027ll need to bump requirement to:\noslo.messaging \u003e\u003d 5.32.0\n\nand this work seems to be a good support to functional test :)","commit_id":"e2deae401eea860ae6fb4ff83499aab7c73d425d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1be5cefc4492d2cbfe3a27e1bc1244b7ca0a6d1b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    assert \u0027ironic.conductor.manager\u0027 not in sys.modules"},{"line_number":39,"context_line":"    # Parse config file and command line options, then start logging"},{"line_number":40,"context_line":"    ironic_service.prepare_service(sys.argv)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    profiler.setup(\u0027ironic\u0027, CONF.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_37a6eb56","line":41,"in_reply_to":"3f79a3b5_1e120357","updated":"2018-12-10 23:12:12.000000000","message":"I was kind of thinking to make bifrost use it.... *whistles innocently*\n\nSpeaking of hard coding, I did give that a try.  It didn\u0027t quite work. The issue is we\u0027re initiating RPC transport as part of parsing our configuration file. I tried shifting that and into each individual service load pattern and that didn\u0027t quite work either. :\\\n\nI\u0027m guessing there is something with how class initialization is occurring that it is needing to happen before profiler touches the configuration. :\\","commit_id":"e2deae401eea860ae6fb4ff83499aab7c73d425d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5b86996b68359df264b4500e1bd54bff86766fb0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # default values of the options instead of the configured ones. For"},{"line_number":35,"context_line":"    # more information see: https://bugs.launchpad.net/ironic/+bug/1562258"},{"line_number":36,"context_line":"    # and https://bugs.launchpad.net/ironic/+bug/1279774."},{"line_number":37,"context_line":"    assert \u0027ironic.conductor.manager\u0027 not in sys.modules"},{"line_number":38,"context_line":"    # Parse config file and command line options, then start logging"},{"line_number":39,"context_line":"    ironic_service.prepare_service(sys.argv)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ff603a3a","line":37,"updated":"2018-12-11 15:13:05.000000000","message":"This gets loaded by something above :\\","commit_id":"c0d47e26f52c3d7ad997f1111ea0ec9b0cb8c23b"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"9e32319f30a4e2e6d79885b0e95f7a82e6ba1476","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # default values of the options instead of the configured ones. For"},{"line_number":35,"context_line":"    # more information see: https://bugs.launchpad.net/ironic/+bug/1562258"},{"line_number":36,"context_line":"    # and https://bugs.launchpad.net/ironic/+bug/1279774."},{"line_number":37,"context_line":"    assert \u0027ironic.conductor.manager\u0027 not in sys.modules"},{"line_number":38,"context_line":"    # Parse config file and command line options, then start logging"},{"line_number":39,"context_line":"    ironic_service.prepare_service(sys.argv)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ff7cbac7","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":10},"updated":"2018-12-11 15:12:18.000000000","message":"i had to remove that assert to make it work, as it was failing on it","commit_id":"c0d47e26f52c3d7ad997f1111ea0ec9b0cb8c23b"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"579ff77ca080b472866d70e784b051ac70a9ffda","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        # if using fake driver, do not attach conductor to topic"},{"line_number":155,"context_line":"        if isinstance(self.client.transport._driver,"},{"line_number":156,"context_line":"                      messaging._drivres.impl_fake.FakeDriver):"},{"line_number":157,"context_line":"            return self.topic"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        hostname \u003d self.get_conductor_for(node)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_06a27199","line":156,"range":{"start_line":155,"start_character":11,"end_line":156,"end_character":63},"updated":"2018-12-12 21:43:09.000000000","message":"I have mixed feelings about this. I guess if ever removed we could always temporarilly cap oslo.messaging until we fix it. \n\nOf course, I\u0027ve also chatted with oslo folk about maybe aliasing the name of the fake driver... so maybe this is a better option :\\","commit_id":"7a468a02664b0ace85f9e801ea1d66ade4d84b90"}]}