)]}'
{"doc/source/contributor/releasing.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"74757b794042bf8725a86d789597a2246e47e7c4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    are used to migrate from an old release to this latest release; they"},{"line_number":128,"context_line":"    shouldn\u0027t be needed after that.)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"  * remove any model class names from ``ironic.cmd.dbsync.NEW_MODELS``."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"As **ironic-tempest-plugin** is branchless, we need to submit a patch adding"},{"line_number":133,"context_line":"stable jobs to its master branch. `Example for Queens"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_e6b147e4","line":130,"updated":"2019-01-02 19:16:35.000000000","message":"Ugh, anther step. :(  Can we automate this please?","commit_id":"78d6d95033fa8040157160d010377f571965f981"}],"doc/source/contributor/rolling-upgrades.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9d97c6cf50be89fb67770cf617a9ff7d0597f41e","unresolved":false,"context_lines":[{"line_number":373,"context_line":"  of the object version. The object versions are also maintained in"},{"line_number":374,"context_line":"  ``ironic/common/release_mappings.py``."},{"line_number":375,"context_line":"- New objects must be added to ``ironic/common/release_mappings.py``. Also for"},{"line_number":376,"context_line":"  the first releases they should be excluded from the version check by adding"},{"line_number":377,"context_line":"  their class names to the ``NEW_MODELS`` list in ``ironic/cmd/dbsync.py``."},{"line_number":378,"context_line":"- The arguments of remotable methods (methods which are remoted to the"},{"line_number":379,"context_line":"  conductor via RPC) can only be added as optional. They cannot be removed or"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_13ddb811","line":376,"updated":"2018-12-13 16:41:07.000000000","message":"so all numbered/interim releases upto and including the named release, right?","commit_id":"78d6d95033fa8040157160d010377f571965f981"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"de97e65ba6fb4749c312323c87120b92c0c6e9f5","unresolved":false,"context_lines":[{"line_number":373,"context_line":"  of the object version. The object versions are also maintained in"},{"line_number":374,"context_line":"  ``ironic/common/release_mappings.py``."},{"line_number":375,"context_line":"- New objects must be added to ``ironic/common/release_mappings.py``. Also for"},{"line_number":376,"context_line":"  the first releases they should be excluded from the version check by adding"},{"line_number":377,"context_line":"  their class names to the ``NEW_MODELS`` list in ``ironic/cmd/dbsync.py``."},{"line_number":378,"context_line":"- The arguments of remotable methods (methods which are remoted to the"},{"line_number":379,"context_line":"  conductor via RPC) can only be added as optional. They cannot be removed or"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_93f3086f","line":376,"in_reply_to":"3f79a3b5_13ddb811","updated":"2018-12-13 16:49:32.000000000","message":"I guess so. Generally, we have to operate in terms of the biggest supported gap between upgradable releases, which is between two names releases (ignoring FFU for now).","commit_id":"78d6d95033fa8040157160d010377f571965f981"}],"ironic/cmd/dbsync.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4c980719fa92eefef64f5d1859b8581b05b8a123","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    (dbapi, \u0027update_to_latest_versions\u0027),"},{"line_number":79,"context_line":")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# These are the models added in supported releases. We skip the version check"},{"line_number":82,"context_line":"# for them since the tables do not exist when it happens."},{"line_number":83,"context_line":"NEW_MODELS \u003d ["},{"line_number":84,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f2936b59","line":81,"updated":"2018-12-12 21:48:37.000000000","message":"l looked at common/release_mappings.py and we refer to them as objects, so maybe s/models/models (objects)/. Just want to make sure it is clear what a model is. Or mention DB model?","commit_id":"c3d38f63fff95b4c84b225df4a941134ac3399cc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"05cfcd64229745bec288a06e8ab9bd42ba73018e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    (dbapi, \u0027update_to_latest_versions\u0027),"},{"line_number":79,"context_line":")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# These are the models added in supported releases. We skip the version check"},{"line_number":82,"context_line":"# for them since the tables do not exist when it happens."},{"line_number":83,"context_line":"NEW_MODELS \u003d ["},{"line_number":84,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8d176b9f","line":81,"in_reply_to":"3f79a3b5_f2936b59","updated":"2018-12-13 15:31:23.000000000","message":"Both the DB model and the object model is called the same, so I hope it\u0027s more or less obvious?","commit_id":"c3d38f63fff95b4c84b225df4a941134ac3399cc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"74757b794042bf8725a86d789597a2246e47e7c4","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class DBCommand(object):"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _check_versions(self, ignore_missing_tables\u003dFalse):"},{"line_number":90,"context_line":"        \"\"\"Check the versions of objects."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        Check that the object versions are compatible with this release"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_46991b6a","line":89,"updated":"2019-01-02 19:16:35.000000000","message":"Hey! shouldn\u0027t the upgrade check call this :)","commit_id":"78d6d95033fa8040157160d010377f571965f981"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4e8659ea745cf879c9450876c90917bc8ab667cc","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"                except sa.exc.NoSuchTableError:"},{"line_number":1232,"context_line":"                    # NOTE(dtantsur): during upgrade version checks run before"},{"line_number":1233,"context_line":"                    # tables are created."},{"line_number":1234,"context_line":"                    if not ignore_missing_tables:"},{"line_number":1235,"context_line":"                        raise"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":"                # NOTE(rloo): we use model.version, not model, because we"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_539a8574","line":1234,"updated":"2018-12-11 17:50:59.000000000","message":"I don\u0027t have a solution offhand, but i am concerned about this blanket \u0027ignore missing tables\u0027. what if someone accidentally deletes an existing table. Although if they do that, there will be other problems anyway...\n\nIt seems like the release mappings should have the info we need to do a proper check for this. I thought we added new objects in the past, that are in new tables (eg traits stuff), but maybe I am wrong. Or maybe we added the DB tables, but the actual use of objects was deferred to a following named release...\n\nMaybe this is good enough.","commit_id":"fceab177f66de3e05481a9a7e1e6940273f1efd8"}]}
