)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"529bfeccf1dbe0844b6945879bbe9c219b675127","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Debayan Ray \u003cdebayan.ray@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-03 03:56:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow non-deterministic ``local_gb`` property"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Failure to detect ``local_gb`` makes the Redfish inspection fail."},{"line_number":10,"context_line":"But ideally it shouldn\u0027t fail, for instance the node can be a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffd0ebdf_592634ba","line":7,"updated":"2019-01-03 11:00:04.000000000","message":"nit: non-deterministic means that it can randomly change over time, I don\u0027t think that\u0027s what you meant. maybe just \"missing\"?","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Debayan Ray \u003cdebayan.ray@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-03 03:56:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow non-deterministic ``local_gb`` property"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Failure to detect ``local_gb`` makes the Redfish inspection fail."},{"line_number":10,"context_line":"But ideally it shouldn\u0027t fail, for instance the node can be a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffd0ebdf_fdb7c239","line":7,"in_reply_to":"ffd0ebdf_592634ba","updated":"2019-01-04 05:56:41.000000000","message":"Done","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"aa34c01e041e9e4d72e50131f21187db08585389","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow non-deterministic ``local_gb`` property"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Failure to detect ``local_gb`` makes the Redfish inspection fail."},{"line_number":10,"context_line":"But ideally it shouldn\u0027t fail, for instance the node can be a"},{"line_number":11,"context_line":"disk-less node."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffd0ebdf_870994de","line":9,"range":{"start_line":9,"start_character":59,"end_line":9,"end_character":60},"updated":"2019-01-03 10:42:16.000000000","message":"nit: may be \u0027fails the Redfish inspection\u0027 would read a bit clearer?","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow non-deterministic ``local_gb`` property"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Failure to detect ``local_gb`` makes the Redfish inspection fail."},{"line_number":10,"context_line":"But ideally it shouldn\u0027t fail, for instance the node can be a"},{"line_number":11,"context_line":"disk-less node."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffd0ebdf_dd88be72","line":9,"range":{"start_line":9,"start_character":59,"end_line":9,"end_character":60},"in_reply_to":"ffd0ebdf_870994de","updated":"2019-01-04 05:56:41.000000000","message":"Done","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"}],"doc/source/admin/drivers/redfish.rst":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"aa34c01e041e9e4d72e50131f21187db08585389","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"   To determine ``local_gb`` property the ``redfish`` inspect interface relies"},{"line_number":134,"context_line":"   on the standard Redfish local storage capabilities, like SimpleStorage and"},{"line_number":135,"context_line":"   Storage. But by and large the storage schema support from different vendors"},{"line_number":136,"context_line":"   has not been very consistent with respect to Redfish reference. Most vendors"},{"line_number":137,"context_line":"   still define their own storage resources which are generally exposed by"},{"line_number":138,"context_line":"   Redfish OEM extension schema. In such scenario bare metal node inspection"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffd0ebdf_472c0c47","line":135,"range":{"start_line":135,"start_character":16,"end_line":135,"end_character":28},"updated":"2019-01-03 10:42:16.000000000","message":"this reads confusing, may be rephrase this?","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"   To determine ``local_gb`` property the ``redfish`` inspect interface relies"},{"line_number":134,"context_line":"   on the standard Redfish local storage capabilities, like SimpleStorage and"},{"line_number":135,"context_line":"   Storage. But by and large the storage schema support from different vendors"},{"line_number":136,"context_line":"   has not been very consistent with respect to Redfish reference. Most vendors"},{"line_number":137,"context_line":"   still define their own storage resources which are generally exposed by"},{"line_number":138,"context_line":"   Redfish OEM extension schema. In such scenario bare metal node inspection"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffd0ebdf_3d978a93","line":135,"range":{"start_line":135,"start_character":16,"end_line":135,"end_character":28},"in_reply_to":"ffd0ebdf_472c0c47","updated":"2019-01-04 05:56:41.000000000","message":"Changed the complete note to Dmitry\u0027s suggestive one.","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"aa34c01e041e9e4d72e50131f21187db08585389","unresolved":false,"context_lines":[{"line_number":133,"context_line":"   To determine ``local_gb`` property the ``redfish`` inspect interface relies"},{"line_number":134,"context_line":"   on the standard Redfish local storage capabilities, like SimpleStorage and"},{"line_number":135,"context_line":"   Storage. But by and large the storage schema support from different vendors"},{"line_number":136,"context_line":"   has not been very consistent with respect to Redfish reference. Most vendors"},{"line_number":137,"context_line":"   still define their own storage resources which are generally exposed by"},{"line_number":138,"context_line":"   Redfish OEM extension schema. In such scenario bare metal node inspection"},{"line_number":139,"context_line":"   may not provide the exact intended value for ``local_gb``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffd0ebdf_c7179ced","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":31},"updated":"2019-01-03 10:42:16.000000000","message":"Strictly speaking, Redfish allows the vendors to implement whichever parts of the spec they want. Does their choice of features make their implementation inconsistent. WDYT?","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":133,"context_line":"   To determine ``local_gb`` property the ``redfish`` inspect interface relies"},{"line_number":134,"context_line":"   on the standard Redfish local storage capabilities, like SimpleStorage and"},{"line_number":135,"context_line":"   Storage. But by and large the storage schema support from different vendors"},{"line_number":136,"context_line":"   has not been very consistent with respect to Redfish reference. Most vendors"},{"line_number":137,"context_line":"   still define their own storage resources which are generally exposed by"},{"line_number":138,"context_line":"   Redfish OEM extension schema. In such scenario bare metal node inspection"},{"line_number":139,"context_line":"   may not provide the exact intended value for ``local_gb``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffd0ebdf_9df796f6","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":31},"in_reply_to":"ffd0ebdf_c7179ced","updated":"2019-01-04 05:56:41.000000000","message":"What I tried to mean here is that till now the vendors still have very disparate and vendor specific storage related resources which they haven\u0027t been able to present from the standard Redfish storage resources, like Storage or SimpleStorage. For instance, HPE has SmartStorage resource through which the HPE ProLiant servers mostly expose the storage related details.\n\nAnyway, I am omitting this part and following what Dmitry\u0027s has suggested about the whole part of the note.","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"529bfeccf1dbe0844b6945879bbe9c219b675127","unresolved":false,"context_lines":[{"line_number":136,"context_line":"   has not been very consistent with respect to Redfish reference. Most vendors"},{"line_number":137,"context_line":"   still define their own storage resources which are generally exposed by"},{"line_number":138,"context_line":"   Redfish OEM extension schema. In such scenario bare metal node inspection"},{"line_number":139,"context_line":"   may not provide the exact intended value for ``local_gb``."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. _Redfish: http://redfish.dmtf.org/"},{"line_number":142,"context_line":".. _Sushy: https://git.openstack.org/cgit/openstack/sushy"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffd0ebdf_b93400e0","line":139,"updated":"2019-01-03 11:00:04.000000000","message":"I\u0027d really shorten the whole note to \"The ``local_gb`` property cannot always be discovered, for example, when a node does not have local storage or the Redfish implementation does not support the required schema. In this case the property will be set to 0.\"","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"aa34c01e041e9e4d72e50131f21187db08585389","unresolved":false,"context_lines":[{"line_number":136,"context_line":"   has not been very consistent with respect to Redfish reference. Most vendors"},{"line_number":137,"context_line":"   still define their own storage resources which are generally exposed by"},{"line_number":138,"context_line":"   Redfish OEM extension schema. In such scenario bare metal node inspection"},{"line_number":139,"context_line":"   may not provide the exact intended value for ``local_gb``."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. _Redfish: http://redfish.dmtf.org/"},{"line_number":142,"context_line":".. _Sushy: https://git.openstack.org/cgit/openstack/sushy"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffd0ebdf_c7ec7cf5","line":139,"range":{"start_line":139,"start_character":7,"end_line":139,"end_character":36},"updated":"2019-01-03 10:42:16.000000000","message":"nit: may be rephrase \u0027might not be able to discover the size of such storage resource\u0027","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":136,"context_line":"   has not been very consistent with respect to Redfish reference. Most vendors"},{"line_number":137,"context_line":"   still define their own storage resources which are generally exposed by"},{"line_number":138,"context_line":"   Redfish OEM extension schema. In such scenario bare metal node inspection"},{"line_number":139,"context_line":"   may not provide the exact intended value for ``local_gb``."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. _Redfish: http://redfish.dmtf.org/"},{"line_number":142,"context_line":".. _Sushy: https://git.openstack.org/cgit/openstack/sushy"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffd0ebdf_1de3a635","line":139,"in_reply_to":"ffd0ebdf_b93400e0","updated":"2019-01-04 05:56:41.000000000","message":"Done. Thanks!","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":136,"context_line":"   has not been very consistent with respect to Redfish reference. Most vendors"},{"line_number":137,"context_line":"   still define their own storage resources which are generally exposed by"},{"line_number":138,"context_line":"   Redfish OEM extension schema. In such scenario bare metal node inspection"},{"line_number":139,"context_line":"   may not provide the exact intended value for ``local_gb``."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. _Redfish: http://redfish.dmtf.org/"},{"line_number":142,"context_line":".. _Sushy: https://git.openstack.org/cgit/openstack/sushy"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffd0ebdf_3ddc6a73","line":139,"range":{"start_line":139,"start_character":7,"end_line":139,"end_character":36},"in_reply_to":"ffd0ebdf_c7ec7cf5","updated":"2019-01-04 05:56:41.000000000","message":"Changed the complete note to Dmitry\u0027s suggestive one.","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"}],"ironic/drivers/modules/redfish/inspect.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"aa34c01e041e9e4d72e50131f21187db08585389","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                                                     \u0027err\u0027: ex})"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        try:"},{"line_number":149,"context_line":"            if storage_size \u003d\u003d 0:"},{"line_number":150,"context_line":"                LOG.debug(\"Attempting to get storage disk information for \""},{"line_number":151,"context_line":"                          \"node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":152,"context_line":"                if system.storage and system.storage.drives_sizes_bytes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_a7c4d841","line":149,"range":{"start_line":149,"start_character":15,"end_line":149,"end_character":27},"updated":"2019-01-03 10:42:16.000000000","message":"What if both `system.storage.volumes_sizes_bytes` and `system.storage.drives_sizes_bytes` are available? Would it make sense to consider both types of storage?","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"529bfeccf1dbe0844b6945879bbe9c219b675127","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                                                     \u0027err\u0027: ex})"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        try:"},{"line_number":149,"context_line":"            if storage_size \u003d\u003d 0:"},{"line_number":150,"context_line":"                LOG.debug(\"Attempting to get storage disk information for \""},{"line_number":151,"context_line":"                          \"node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":152,"context_line":"                if system.storage and system.storage.drives_sizes_bytes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_f93a88cb","line":149,"updated":"2019-01-03 11:00:04.000000000","message":"very nit: \"if not storage_size\"","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                                                     \u0027err\u0027: ex})"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        try:"},{"line_number":149,"context_line":"            if storage_size \u003d\u003d 0:"},{"line_number":150,"context_line":"                LOG.debug(\"Attempting to get storage disk information for \""},{"line_number":151,"context_line":"                          \"node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":152,"context_line":"                if system.storage and system.storage.drives_sizes_bytes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_5d47ee1e","line":149,"range":{"start_line":149,"start_character":15,"end_line":149,"end_character":27},"in_reply_to":"ffd0ebdf_a7c4d841","updated":"2019-01-04 05:56:41.000000000","message":"volumes_size_bytes is given preference over the other (drives_size_bytes) as that signifies that logical volume exists. Only when logical volume size is not discovered it attempts to check drives size.","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                                                     \u0027err\u0027: ex})"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        try:"},{"line_number":149,"context_line":"            if storage_size \u003d\u003d 0:"},{"line_number":150,"context_line":"                LOG.debug(\"Attempting to get storage disk information for \""},{"line_number":151,"context_line":"                          \"node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":152,"context_line":"                if system.storage and system.storage.drives_sizes_bytes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_fd5342e1","line":149,"in_reply_to":"ffd0ebdf_f93a88cb","updated":"2019-01-04 05:56:41.000000000","message":"Done","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"aa34c01e041e9e4d72e50131f21187db08585389","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        try:"},{"line_number":149,"context_line":"            if storage_size \u003d\u003d 0:"},{"line_number":150,"context_line":"                LOG.debug(\"Attempting to get storage disk information for \""},{"line_number":151,"context_line":"                          \"node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":152,"context_line":"                if system.storage and system.storage.drives_sizes_bytes:"},{"line_number":153,"context_line":"                    storage_size \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_67b7d0da","line":150,"range":{"start_line":150,"start_character":16,"end_line":150,"end_character":19},"updated":"2019-01-03 10:42:16.000000000","message":"May be add similar debug message at #118 and 135?","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"aa34c01e041e9e4d72e50131f21187db08585389","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        try:"},{"line_number":149,"context_line":"            if storage_size \u003d\u003d 0:"},{"line_number":150,"context_line":"                LOG.debug(\"Attempting to get storage disk information for \""},{"line_number":151,"context_line":"                          \"node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":152,"context_line":"                if system.storage and system.storage.drives_sizes_bytes:"},{"line_number":153,"context_line":"                    storage_size \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_a776183e","line":150,"range":{"start_line":150,"start_character":53,"end_line":150,"end_character":57},"updated":"2019-01-03 10:42:16.000000000","message":"May be rephrase to remain closer to the Redfish schema wording e.g. \u0027Attempting to discover system drives sizes\u0027?","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        try:"},{"line_number":149,"context_line":"            if storage_size \u003d\u003d 0:"},{"line_number":150,"context_line":"                LOG.debug(\"Attempting to get storage disk information for \""},{"line_number":151,"context_line":"                          \"node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":152,"context_line":"                if system.storage and system.storage.drives_sizes_bytes:"},{"line_number":153,"context_line":"                    storage_size \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_bd5ffae3","line":150,"range":{"start_line":150,"start_character":16,"end_line":150,"end_character":19},"in_reply_to":"ffd0ebdf_67b7d0da","updated":"2019-01-04 05:56:41.000000000","message":"Done","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        try:"},{"line_number":149,"context_line":"            if storage_size \u003d\u003d 0:"},{"line_number":150,"context_line":"                LOG.debug(\"Attempting to get storage disk information for \""},{"line_number":151,"context_line":"                          \"node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":152,"context_line":"                if system.storage and system.storage.drives_sizes_bytes:"},{"line_number":153,"context_line":"                    storage_size \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_dd643ebc","line":150,"range":{"start_line":150,"start_character":53,"end_line":150,"end_character":57},"in_reply_to":"ffd0ebdf_a776183e","updated":"2019-01-04 05:56:41.000000000","message":"Done","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"aa34c01e041e9e4d72e50131f21187db08585389","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                    storage_size \u003d storage_size[0]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        except sushy.exceptions.SushyError as ex:"},{"line_number":161,"context_line":"            LOG.debug(\"No storage disk information discovered \""},{"line_number":162,"context_line":"                      \"for node %(node)s: %(err)s\", {\u0027node\u0027: task.node.uuid,"},{"line_number":163,"context_line":"                                                     \u0027err\u0027: ex})"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_47af2c94","line":161,"range":{"start_line":161,"start_character":26,"end_line":161,"end_character":38},"updated":"2019-01-03 10:42:16.000000000","message":"Ditto","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                    storage_size \u003d storage_size[0]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        except sushy.exceptions.SushyError as ex:"},{"line_number":161,"context_line":"            LOG.debug(\"No storage disk information discovered \""},{"line_number":162,"context_line":"                      \"for node %(node)s: %(err)s\", {\u0027node\u0027: task.node.uuid,"},{"line_number":163,"context_line":"                                                     \u0027err\u0027: ex})"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_7d0e72e6","line":161,"range":{"start_line":161,"start_character":26,"end_line":161,"end_character":38},"in_reply_to":"ffd0ebdf_47af2c94","updated":"2019-01-04 05:56:41.000000000","message":"Done","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"529bfeccf1dbe0844b6945879bbe9c219b675127","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            LOG.warning(\"Could not provide a valid storage size configured \""},{"line_number":183,"context_line":"                        \"for node %(node)s. Assuming this is a disk-less node\","},{"line_number":184,"context_line":"                        {\u0027node\u0027: task.node.uuid})"},{"line_number":185,"context_line":"            inspected_properties[\u0027local_gb\u0027] \u003d \u00270\u0027"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":188,"context_line":"        missing_keys \u003d valid_keys - set(inspected_properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_1938acd1","line":185,"updated":"2019-01-03 11:00:04.000000000","message":"I personally would prefer to keep it here.","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"aa34c01e041e9e4d72e50131f21187db08585389","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            LOG.warning(\"Could not provide a valid storage size configured \""},{"line_number":183,"context_line":"                        \"for node %(node)s. Assuming this is a disk-less node\","},{"line_number":184,"context_line":"                        {\u0027node\u0027: task.node.uuid})"},{"line_number":185,"context_line":"            inspected_properties[\u0027local_gb\u0027] \u003d \u00270\u0027"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":188,"context_line":"        missing_keys \u003d valid_keys - set(inspected_properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_47396c3f","line":185,"range":{"start_line":185,"start_character":0,"end_line":185,"end_character":50},"updated":"2019-01-03 10:42:16.000000000","message":"nit: may be we could remove this assignment and bring the assignment at line #180 out of the condition on line #179?","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            LOG.warning(\"Could not provide a valid storage size configured \""},{"line_number":183,"context_line":"                        \"for node %(node)s. Assuming this is a disk-less node\","},{"line_number":184,"context_line":"                        {\u0027node\u0027: task.node.uuid})"},{"line_number":185,"context_line":"            inspected_properties[\u0027local_gb\u0027] \u003d \u00270\u0027"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":188,"context_line":"        missing_keys \u003d valid_keys - set(inspected_properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_ddc0be53","line":185,"in_reply_to":"ffd0ebdf_1938acd1","updated":"2019-01-04 05:56:41.000000000","message":"Retaining it.","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"83846e59f283adde4cfdfd66b4fef544cd064957","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            LOG.warning(\"Could not provide a valid storage size configured \""},{"line_number":183,"context_line":"                        \"for node %(node)s. Assuming this is a disk-less node\","},{"line_number":184,"context_line":"                        {\u0027node\u0027: task.node.uuid})"},{"line_number":185,"context_line":"            inspected_properties[\u0027local_gb\u0027] \u003d \u00270\u0027"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        valid_keys \u003d self.ESSENTIAL_PROPERTIES"},{"line_number":188,"context_line":"        missing_keys \u003d valid_keys - set(inspected_properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffd0ebdf_1dede6ee","line":185,"range":{"start_line":185,"start_character":0,"end_line":185,"end_character":50},"in_reply_to":"ffd0ebdf_47396c3f","updated":"2019-01-04 05:56:41.000000000","message":"I am just thinking that this way of assigning makes it more readable (that it sets to zero if local_gb is not set). \"Readability counts\" :)","commit_id":"9395eb46a647eb747273fa691f94d5746911c12e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"005b24d55f5fb1be7e78979c9c1722f05d3c4bb1","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                                                     \u0027err\u0027: ex})"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        try:"},{"line_number":153,"context_line":"            if not storage_size:"},{"line_number":154,"context_line":"                LOG.debug(\"Attempting to discover system storage drive size \""},{"line_number":155,"context_line":"                          \"for node %(node)s\", {\u0027node\u0027: task.node.uuid})"},{"line_number":156,"context_line":"                if system.storage and system.storage.drives_sizes_bytes:"},{"line_number":157,"context_line":"                    storage_size \u003d ["},{"line_number":158,"context_line":"                        size for size in system.storage.drives_sizes_bytes"},{"line_number":159,"context_line":"                        if size \u003e\u003d 4 * units.Gi"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_e44bb7ad","line":156,"range":{"start_line":153,"start_character":12,"end_line":156,"end_character":72},"updated":"2019-01-07 08:30:44.000000000","message":"Better to add a testcase for this path.","commit_id":"b8e720e51fc9d9ecff31ceb9c58c63c985754e1b"}]}