)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"825e63a86b389275b6fb143fb3986d9649e6f2b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     digambar \u003cdigambarpatil15@yahoo.co.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-27 09:23:39 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the iDRAC driver to use realtime RAID creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3f4282afff860d9771a3d37f4d5e1172d88e87a3"},{"line_number":10,"context_line":"Story: 2004861"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fdfeff1_463bf49a","line":7,"updated":"2019-02-27 19:20:04.000000000","message":"Can you add a description pl?","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"88e7cf6330cb2da144481c852e1ae139cacb15fb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     digambar \u003cdigambarpatil15@yahoo.co.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-27 09:23:39 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the iDRAC driver to use realtime RAID creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3f4282afff860d9771a3d37f4d5e1172d88e87a3"},{"line_number":10,"context_line":"Story: 2004861"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fdfeff1_14542dfd","line":7,"in_reply_to":"9fdfeff1_463bf49a","updated":"2019-02-28 00:15:04.000000000","message":"Done","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"0319d56572f40ed2c1b2b4baf70e3511af6ee519","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the iDRAC driver to use realtime RAID creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support of realtime for RAID creation and deletion. "},{"line_number":10,"context_line":"Dracclient is already supporting to realtime for"},{"line_number":11,"context_line":"RAID creation/deletion."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5fc1f717_85c69f99","line":9,"updated":"2019-04-10 15:21:22.000000000","message":"Can you remove the trailing space on the line above?","commit_id":"cbe0cb15ff3a3d9bccc1e3e2aba04a6ed6a66bf6"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"29a714392f9c03b457be967ab5176aeee55f3801","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the iDRAC driver to use realtime RAID creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support of realtime for RAID creation and deletion. "},{"line_number":10,"context_line":"Dracclient is already supporting to realtime for"},{"line_number":11,"context_line":"RAID creation/deletion."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fce034c_58911c99","line":9,"in_reply_to":"5fc1f717_85c69f99","updated":"2019-04-15 04:21:18.000000000","message":"Done","commit_id":"cbe0cb15ff3a3d9bccc1e3e2aba04a6ed6a66bf6"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"c2a9cebb03c4ced62f45d49914ba3190d70fddd5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     digambar \u003cdigambarpatil15@yahoo.co.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-19 08:29:11 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the iDRAC driver to use realtime RAID creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support of realtime for RAID creation and"},{"line_number":10,"context_line":"deletion. dracclient is already supporting to realtime"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ffb9cba7_2ff3cda0","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":53},"updated":"2019-04-23 02:26:52.000000000","message":"Deletion, too, correct?\n\nHow about the following?\n\n    Add iDRAC driver realtime RAID creation/deletion","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c2d77bb24b6a6d180d8836bc0707cf2f55d4d481","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     digambar \u003cdigambarpatil15@yahoo.co.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-19 08:29:11 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the iDRAC driver to use realtime RAID creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support of realtime for RAID creation and"},{"line_number":10,"context_line":"deletion. dracclient is already supporting to realtime"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ffb9cba7_774f50bd","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":53},"in_reply_to":"ffb9cba7_2ff3cda0","updated":"2019-04-24 08:47:33.000000000","message":"Yes, It support for creation and deletion also. I will update","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"c2a9cebb03c4ced62f45d49914ba3190d70fddd5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Modify the iDRAC driver to use realtime RAID creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support of realtime for RAID creation and"},{"line_number":10,"context_line":"deletion. dracclient is already supporting to realtime"},{"line_number":11,"context_line":"RAID creation/deletion."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f4282afff860d9771a3d37f4d5e1172d88e87a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ffb9cba7_0f512937","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":10},"updated":"2019-04-23 02:26:52.000000000","message":"Please consider mentioning realtime is useful because it completes faster since it does not require a reboot of the baremetal server.","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"c2a9cebb03c4ced62f45d49914ba3190d70fddd5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Modify the iDRAC driver to use realtime RAID creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support of realtime for RAID creation and"},{"line_number":10,"context_line":"deletion. dracclient is already supporting to realtime"},{"line_number":11,"context_line":"RAID creation/deletion."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f4282afff860d9771a3d37f4d5e1172d88e87a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ffb9cba7_2fe42dac","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":20},"updated":"2019-04-23 02:26:52.000000000","message":"python-dracclient","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c2d77bb24b6a6d180d8836bc0707cf2f55d4d481","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Modify the iDRAC driver to use realtime RAID creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support of realtime for RAID creation and"},{"line_number":10,"context_line":"deletion. dracclient is already supporting to realtime"},{"line_number":11,"context_line":"RAID creation/deletion."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f4282afff860d9771a3d37f4d5e1172d88e87a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ffb9cba7_7792f0f8","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":10},"in_reply_to":"ffb9cba7_0f512937","updated":"2019-04-24 08:47:33.000000000","message":"Done","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c2d77bb24b6a6d180d8836bc0707cf2f55d4d481","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Modify the iDRAC driver to use realtime RAID creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support of realtime for RAID creation and"},{"line_number":10,"context_line":"deletion. dracclient is already supporting to realtime"},{"line_number":11,"context_line":"RAID creation/deletion."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f4282afff860d9771a3d37f4d5e1172d88e87a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ffb9cba7_37beb865","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":20},"in_reply_to":"ffb9cba7_2fe42dac","updated":"2019-04-24 08:47:33.000000000","message":"Done","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"c2a9cebb03c4ced62f45d49914ba3190d70fddd5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"RAID creation/deletion."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f4282afff860d9771a3d37f4d5e1172d88e87a3"},{"line_number":14,"context_line":"Story: 2004861"},{"line_number":15,"context_line":"Depends-On: Iefbb2e935fda9b9aeb332d04715b98840a581c86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ffb9cba7_4f4c01c7","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":14},"updated":"2019-04-23 02:26:52.000000000","message":"Please add the Task:. That will cause the story to be updated -- https://docs.openstack.org/infra/manual/developers.html#working-on-bugs\n\n\"Mentioning the task will change the task status in StoryBoard to ‘review’ while the patch is in review, and then ‘merged’ once the patch is merged. When all tasks in a story are marked ‘merged’, the story will automatically change status from ‘active’ to ‘merged’. If the patch is abandoned, the task status will change back to ‘todo’. It’s currently best to note both story and task so that the task status will update and people will be able to find the related story.\"","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"c2a9cebb03c4ced62f45d49914ba3190d70fddd5","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f4282afff860d9771a3d37f4d5e1172d88e87a3"},{"line_number":14,"context_line":"Story: 2004861"},{"line_number":15,"context_line":"Depends-On: Iefbb2e935fda9b9aeb332d04715b98840a581c86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ffb9cba7_8f52f966","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":53},"updated":"2019-04-23 02:26:52.000000000","message":"I believe this can be deleted, because the referenced merged. Also, afaiu, Depends-On: is for cross repository dependencies. Please see https://docs.openstack.org/infra/manual/developers.html#cross-repository-dependencies\n\nSince the referenced change was also to ironic, it\u0027s not applicable. Instead, this change could have been rebased to that one, so that they would have had a parent-child relationship.","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c2d77bb24b6a6d180d8836bc0707cf2f55d4d481","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f4282afff860d9771a3d37f4d5e1172d88e87a3"},{"line_number":14,"context_line":"Story: 2004861"},{"line_number":15,"context_line":"Depends-On: Iefbb2e935fda9b9aeb332d04715b98840a581c86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ffb9cba7_b7038842","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":53},"in_reply_to":"ffb9cba7_8f52f966","updated":"2019-04-24 08:47:33.000000000","message":"Agree to remove this dependency as this change is already rebased.","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"8d8717cc02575a0b4a7d6dee80c109b1828f114f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It adds capability to the idrac driver for creating and deleting RAID"},{"line_number":10,"context_line":"sets without rebooting the bare metal node."},{"line_number":11,"context_line":"Python-dracclient version 3.0.0 is already supporting to"},{"line_number":12,"context_line":"realtime RAID creation and deletion."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3f4282afff860d9771a3d37f4d5e1172d88e87a3"},{"line_number":15,"context_line":"Story: 2004861"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"ffb9cba7_9446504f","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":36},"updated":"2019-04-25 13:20:37.000000000","message":"Not sure this is needed ... the reno defines the requirements.\nIf you\u0027d like to keep it, I\u0027d suggest to use the same phrasing as in the reno.","commit_id":"6dc87684b0095fd987c4de9d71fe80a7a353b06d"}],"driver-requirements.txt":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"470a7a6dac5ab04c883d5215e7307c346ee98377","unresolved":false,"context_lines":[{"line_number":9,"context_line":"python-ironic-inspector-client\u003e\u003d1.5.0"},{"line_number":10,"context_line":"python-scciclient\u003e\u003d0.8.0"},{"line_number":11,"context_line":"UcsSdk\u003d\u003d0.8.2.2;python_version\u003c\u00273\u0027"},{"line_number":12,"context_line":"python-dracclient\u003e\u003d3.0.0"},{"line_number":13,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# The CIMC drivers use the Cisco IMC SDK version 0.7.2 or greater"}],"source_content_type":"text/plain","patch_set":16,"id":"3fce034c_28d4df1f","line":12,"updated":"2019-04-16 15:10:04.000000000","message":"Are there any other changes that are required for this version bump?","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"8643bd338640be56a9bbf4d5bf0fb5f7ddbada00","unresolved":false,"context_lines":[{"line_number":9,"context_line":"python-ironic-inspector-client\u003e\u003d1.5.0"},{"line_number":10,"context_line":"python-scciclient\u003e\u003d0.8.0"},{"line_number":11,"context_line":"UcsSdk\u003d\u003d0.8.2.2;python_version\u003c\u00273\u0027"},{"line_number":12,"context_line":"python-dracclient\u003e\u003d3.0.0"},{"line_number":13,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# The CIMC drivers use the Cisco IMC SDK version 0.7.2 or greater"}],"source_content_type":"text/plain","patch_set":16,"id":"3fce034c_d737f2e2","line":12,"in_reply_to":"3fce034c_28d4df1f","updated":"2019-04-16 21:05:13.000000000","message":"Not sure if this answers your question, but this patch is dependent on realtime support in python-dracclient, and the first release that\u0027s available in is 3.0.0","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"7cd3cd7b104d9461ad25831997baf8a8b8973473","unresolved":false,"context_lines":[{"line_number":9,"context_line":"python-ironic-inspector-client\u003e\u003d1.5.0"},{"line_number":10,"context_line":"python-scciclient\u003e\u003d0.8.0"},{"line_number":11,"context_line":"UcsSdk\u003d\u003d0.8.2.2;python_version\u003c\u00273\u0027"},{"line_number":12,"context_line":"python-dracclient\u003e\u003d3.0.0"},{"line_number":13,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# The CIMC drivers use the Cisco IMC SDK version 0.7.2 or greater"}],"source_content_type":"text/plain","patch_set":16,"id":"3fce034c_0d01c605","line":12,"in_reply_to":"3fce034c_d737f2e2","updated":"2019-04-18 10:26:49.000000000","message":"Yes, The change required for this patch are already available in python-dracclient version 3.0.0","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"}],"ironic/drivers/modules/drac/raid.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"85c336072a50f61a7e91df55c7832e25968cba38","unresolved":false,"context_lines":[{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    for controller in controllers:"},{"line_number":651,"context_line":"        # Do a reboot only for the last controller"},{"line_number":652,"context_line":"        if client.is_realtime_supported(controller):"},{"line_number":653,"context_line":"            realtime \u003d True"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"        if realtime:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_320b4e25","line":652,"updated":"2019-02-18 16:12:20.000000000","message":"We discovered this past week that the flag on the controller indicates if the controller supports realtime at all.  Realtime support for individual operations though can vary based on the firmware.  For example, firmware was released where realtime mode was supported for virtual disk create/delete, but not RAID/JBOD conversion.  To determine if a given operation supports realtime mode, the is_reboot_required flag that is returned by the create_virtual_disk method needs to be examined.  If it is python-dracclient.utils.RebootRequired.optional, then realtime mode is supported for the operation.  As a result, I think you will need to change the caller of this method to create a dict that maps controller FQDD to the dict returned by create/delete_virtual_disk (or at least the is_reboot_required flag from the dict) and pass it into this method.  The above line would then be replaced by a lookup into the dict and a check for utils.RebootRequired.option.","commit_id":"2a663a061961cd4bc1a345a2814dce79e0b0dfc9"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"04550511f5f50c860f0cc84d8ef094408bea512e","unresolved":false,"context_lines":[{"line_number":647,"context_line":"    client \u003d drac_common.get_drac_client(node)"},{"line_number":648,"context_line":"    realtime \u003d False"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    for controller in controllers:"},{"line_number":651,"context_line":"        # Do a reboot only for the last controller"},{"line_number":652,"context_line":"        if client.is_realtime_supported(controller):"},{"line_number":653,"context_line":"            realtime \u003d True"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"        if realtime:"},{"line_number":656,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003dcontroller,"},{"line_number":657,"context_line":"                                   reboot\u003dFalse, realtime\u003drealtime)"},{"line_number":658,"context_line":"        else:"},{"line_number":659,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003dcontroller,"},{"line_number":660,"context_line":"                                   reboot\u003dTrue, realtime\u003drealtime)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"},{"line_number":663,"context_line":"                 \u0027%(controller)s on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_4e28b831","line":660,"range":{"start_line":650,"start_character":0,"end_line":660,"end_character":66},"updated":"2019-02-18 09:13:56.000000000","message":"If there is no realtime support, the behaviour changes as now all controllers (and not only the last one) is rebooted. Is that intended? If so, at least the comment in l. 651 needs a change :)","commit_id":"2a663a061961cd4bc1a345a2814dce79e0b0dfc9"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"4a7464f2c3bf0c312c545354f595eac7d2c590ce","unresolved":false,"context_lines":[{"line_number":647,"context_line":"    client \u003d drac_common.get_drac_client(node)"},{"line_number":648,"context_line":"    realtime \u003d False"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    for controller in controllers:"},{"line_number":651,"context_line":"        # Do a reboot only for the last controller"},{"line_number":652,"context_line":"        if client.is_realtime_supported(controller):"},{"line_number":653,"context_line":"            realtime \u003d True"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"        if realtime:"},{"line_number":656,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003dcontroller,"},{"line_number":657,"context_line":"                                   reboot\u003dFalse, realtime\u003drealtime)"},{"line_number":658,"context_line":"        else:"},{"line_number":659,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003dcontroller,"},{"line_number":660,"context_line":"                                   reboot\u003dTrue, realtime\u003drealtime)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"},{"line_number":663,"context_line":"                 \u0027%(controller)s on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_3d0fa4e0","line":660,"range":{"start_line":650,"start_character":0,"end_line":660,"end_character":66},"in_reply_to":"9fdfeff1_4e28b831","updated":"2019-02-18 14:58:44.000000000","message":"Actually that is old comment, I forgot to remove it. Will remove it.","commit_id":"2a663a061961cd4bc1a345a2814dce79e0b0dfc9"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"85c336072a50f61a7e91df55c7832e25968cba38","unresolved":false,"context_lines":[{"line_number":647,"context_line":"    client \u003d drac_common.get_drac_client(node)"},{"line_number":648,"context_line":"    realtime \u003d False"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    for controller in controllers:"},{"line_number":651,"context_line":"        # Do a reboot only for the last controller"},{"line_number":652,"context_line":"        if client.is_realtime_supported(controller):"},{"line_number":653,"context_line":"            realtime \u003d True"},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"        if realtime:"},{"line_number":656,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003dcontroller,"},{"line_number":657,"context_line":"                                   reboot\u003dFalse, realtime\u003drealtime)"},{"line_number":658,"context_line":"        else:"},{"line_number":659,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003dcontroller,"},{"line_number":660,"context_line":"                                   reboot\u003dTrue, realtime\u003drealtime)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"},{"line_number":663,"context_line":"                 \u0027%(controller)s on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_524a925b","line":660,"range":{"start_line":650,"start_character":0,"end_line":660,"end_character":66},"in_reply_to":"9fdfeff1_4e28b831","updated":"2019-02-18 16:12:20.000000000","message":"I agree with Arne.  We should only set reboot\u003dTrue for the last non-realtime commit.","commit_id":"2a663a061961cd4bc1a345a2814dce79e0b0dfc9"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1c7c20ecb7a953b6a6775ec27d009887704d5910","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        raise exception.DracOperationError(error\u003dexc)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"def commit_config(node, raid_controller, reboot\u003dFalse, realtime\u003dFalse):"},{"line_number":206,"context_line":"    \"\"\"Apply all pending changes on a RAID controller."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    :param node: an ironic node object."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_a5a8f1d8","line":205,"updated":"2019-02-26 19:04:05.000000000","message":"Can you add the parameter realtime to the comment below?","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c1bc3b3174ba90accaab2c5175ab977960370c42","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        raise exception.DracOperationError(error\u003dexc)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"def commit_config(node, raid_controller, reboot\u003dFalse, realtime\u003dFalse):"},{"line_number":206,"context_line":"    \"\"\"Apply all pending changes on a RAID controller."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    :param node: an ironic node object."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_63350fdb","line":205,"updated":"2019-02-25 08:30:31.000000000","message":"Missing parameter definition for \"realtime\".","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"dc2cb1fc7e0a27cfe74a57bc52c134f313997ae0","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        raise exception.DracOperationError(error\u003dexc)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"def commit_config(node, raid_controller, reboot\u003dFalse, realtime\u003dFalse):"},{"line_number":206,"context_line":"    \"\"\"Apply all pending changes on a RAID controller."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    :param node: an ironic node object."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_c5214cb6","line":205,"in_reply_to":"9fdfeff1_23706708","updated":"2019-02-26 01:28:58.000000000","message":"Done","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"a3105fc6d4be53e42830fe7aa7073a1e884235a8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        raise exception.DracOperationError(error\u003dexc)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"def commit_config(node, raid_controller, reboot\u003dFalse, realtime\u003dFalse):"},{"line_number":206,"context_line":"    \"\"\"Apply all pending changes on a RAID controller."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    :param node: an ironic node object."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_a3b3f7e8","line":205,"in_reply_to":"9fdfeff1_63350fdb","updated":"2019-02-25 08:51:31.000000000","message":"No","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"6d894849bad1c387b432df3c2814c663f5cc14ef","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        raise exception.DracOperationError(error\u003dexc)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"def commit_config(node, raid_controller, reboot\u003dFalse, realtime\u003dFalse):"},{"line_number":206,"context_line":"    \"\"\"Apply all pending changes on a RAID controller."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    :param node: an ironic node object."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_23706708","line":205,"in_reply_to":"9fdfeff1_a3b3f7e8","updated":"2019-02-25 09:05:48.000000000","message":"I mean the new parameter \"realtime\" is not defined in the function\u0027s doc.","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"88e7cf6330cb2da144481c852e1ae139cacb15fb","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        raise exception.DracOperationError(error\u003dexc)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"def commit_config(node, raid_controller, reboot\u003dFalse, realtime\u003dFalse):"},{"line_number":206,"context_line":"    \"\"\"Apply all pending changes on a RAID controller."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    :param node: an ironic node object."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_aabb8ce2","line":205,"in_reply_to":"9fdfeff1_a5a8f1d8","updated":"2019-02-28 00:15:04.000000000","message":"Done","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"973ad26c9be6c80a17ed0385908c58295a094646","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        driver_internal_info[\u0027raid_config_job_ids\u0027] \u003d []"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    all_realtime \u003d True"},{"line_number":647,"context_line":"    try:"},{"line_number":648,"context_line":"        for controller in controllers:"},{"line_number":649,"context_line":"            raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":650,"context_line":"            realtime \u003d controller[\u0027is_reboot_required\u0027] \u003d\u003d \u0027optional\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_61caef4f","line":647,"range":{"start_line":647,"start_character":4,"end_line":647,"end_character":8},"updated":"2019-02-24 21:33:33.000000000","message":"What is the try/catch for?","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"794fb557b65f5dc2fe0a7ce842b43e82ea64cdfa","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        driver_internal_info[\u0027raid_config_job_ids\u0027] \u003d []"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    all_realtime \u003d True"},{"line_number":647,"context_line":"    try:"},{"line_number":648,"context_line":"        for controller in controllers:"},{"line_number":649,"context_line":"            raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":650,"context_line":"            realtime \u003d controller[\u0027is_reboot_required\u0027] \u003d\u003d \u0027optional\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_a8ac349f","line":647,"range":{"start_line":647,"start_character":4,"end_line":647,"end_character":8},"in_reply_to":"9fdfeff1_61caef4f","updated":"2019-02-25 07:38:35.000000000","message":"I saw StopIteration came when I try to run multiple controller unit test case so I added try-catch block to catch the error","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"1c7c20ecb7a953b6a6775ec27d009887704d5910","unresolved":false,"context_lines":[{"line_number":644,"context_line":"        driver_internal_info[\u0027raid_config_job_ids\u0027] \u003d []"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    all_realtime \u003d True"},{"line_number":647,"context_line":"    try:"},{"line_number":648,"context_line":"        for controller in controllers:"},{"line_number":649,"context_line":"            raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":650,"context_line":"            realtime \u003d controller[\u0027is_reboot_required\u0027] \u003d\u003d \u0027optional\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_904b6e85","line":647,"range":{"start_line":647,"start_character":4,"end_line":647,"end_character":8},"in_reply_to":"9fdfeff1_a8ac349f","updated":"2019-02-26 19:04:05.000000000","message":"I took a look at this, and there is a bug in the test case.  I\u0027m investigating that now.  As a result, I think you should remove the try/catch here.  I will comment more on the bug when I have it isolated.","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c1bc3b3174ba90accaab2c5175ab977960370c42","unresolved":false,"context_lines":[{"line_number":743,"context_line":"        logical_disks_to_create \u003d _filter_logical_disks("},{"line_number":744,"context_line":"            logical_disks, create_root_volume, create_nonroot_volumes)"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"        controllers \u003d list()"},{"line_number":747,"context_line":"        for logical_disk in logical_disks_to_create:"},{"line_number":748,"context_line":"            controller \u003d dict()"},{"line_number":749,"context_line":"            controller_cap \u003d create_virtual_disk("}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_83a35300","line":746,"updated":"2019-02-25 08:30:31.000000000","message":"I am not sure what was the intention behind using \"sets\" here. Maybe to avoid duplicate controller. Did you consider analyzing the implication?","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"a3105fc6d4be53e42830fe7aa7073a1e884235a8","unresolved":false,"context_lines":[{"line_number":743,"context_line":"        logical_disks_to_create \u003d _filter_logical_disks("},{"line_number":744,"context_line":"            logical_disks, create_root_volume, create_nonroot_volumes)"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"        controllers \u003d list()"},{"line_number":747,"context_line":"        for logical_disk in logical_disks_to_create:"},{"line_number":748,"context_line":"            controller \u003d dict()"},{"line_number":749,"context_line":"            controller_cap \u003d create_virtual_disk("}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_e3901f45","line":746,"in_reply_to":"9fdfeff1_83a35300","updated":"2019-02-25 08:51:31.000000000","message":"Its a list now, where do you see set","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"6d894849bad1c387b432df3c2814c663f5cc14ef","unresolved":false,"context_lines":[{"line_number":743,"context_line":"        logical_disks_to_create \u003d _filter_logical_disks("},{"line_number":744,"context_line":"            logical_disks, create_root_volume, create_nonroot_volumes)"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"        controllers \u003d list()"},{"line_number":747,"context_line":"        for logical_disk in logical_disks_to_create:"},{"line_number":748,"context_line":"            controller \u003d dict()"},{"line_number":749,"context_line":"            controller_cap \u003d create_virtual_disk("}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_231b87ca","line":746,"in_reply_to":"9fdfeff1_e3901f45","updated":"2019-02-25 09:05:48.000000000","message":"The previous declaration was set.","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"10f5a59395db71df6eb75c558f8d1cd119568bc4","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    :param reboot: indicates whether a reboot job should be automatically"},{"line_number":211,"context_line":"                   created with the config job. (optional, defaults to False)"},{"line_number":212,"context_line":"    :param realtime: indicates whether RAID controller realtime or not."},{"line_number":213,"context_line":"                        (Default to False)."},{"line_number":214,"context_line":"    :returns: id of the created job"},{"line_number":215,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":216,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_4a69c022","line":213,"range":{"start_line":213,"start_character":25,"end_line":213,"end_character":32},"updated":"2019-02-27 14:41:02.000000000","message":"s/Default/optional, defaults/\nThe indentation is also not correct.","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"88e7cf6330cb2da144481c852e1ae139cacb15fb","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    :param reboot: indicates whether a reboot job should be automatically"},{"line_number":211,"context_line":"                   created with the config job. (optional, defaults to False)"},{"line_number":212,"context_line":"    :param realtime: indicates whether RAID controller realtime or not."},{"line_number":213,"context_line":"                        (Default to False)."},{"line_number":214,"context_line":"    :returns: id of the created job"},{"line_number":215,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":216,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_f43c09c0","line":213,"range":{"start_line":213,"start_character":25,"end_line":213,"end_character":32},"in_reply_to":"9fdfeff1_4a69c022","updated":"2019-02-28 00:15:04.000000000","message":"Done","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"10f5a59395db71df6eb75c558f8d1cd119568bc4","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                                   realtime\u003drealtime)"},{"line_number":657,"context_line":"        else:"},{"line_number":658,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":659,"context_line":"                                   reboot\u003dnot realtime,"},{"line_number":660,"context_line":"                                   realtime\u003drealtime)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_0a2738c9","line":659,"range":{"start_line":659,"start_character":42,"end_line":659,"end_character":54},"updated":"2019-02-27 14:41:02.000000000","message":"From what I understood, the logic is: reboot the last controller if one of them is not realtime capable. So, shouldn\u0027t this then always be False?","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"139413f9b134e384e8275fca1e7371172d6974d3","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                                   realtime\u003drealtime)"},{"line_number":657,"context_line":"        else:"},{"line_number":658,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":659,"context_line":"                                   reboot\u003dnot realtime,"},{"line_number":660,"context_line":"                                   realtime\u003drealtime)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_925b4852","line":659,"range":{"start_line":659,"start_character":42,"end_line":659,"end_character":54},"in_reply_to":"9fdfeff1_0a2738c9","updated":"2019-02-28 09:13:37.000000000","message":"It will not always be false. \nIn if statement, if one of the controller is false, then all_realtime value sets to True which is assigned to reboot at the time of last controller which will reboot the server.","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"01f97c07ac6742dbdae4e7bd5d396f0f90997946","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                                   realtime\u003drealtime)"},{"line_number":657,"context_line":"        else:"},{"line_number":658,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":659,"context_line":"                                   reboot\u003dnot realtime,"},{"line_number":660,"context_line":"                                   realtime\u003drealtime)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_7bea5474","line":659,"range":{"start_line":659,"start_character":42,"end_line":659,"end_character":54},"in_reply_to":"9fdfeff1_0a2738c9","updated":"2019-02-27 16:16:40.000000000","message":"Yes, I agree with Arne here.","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"88e7cf6330cb2da144481c852e1ae139cacb15fb","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                                   realtime\u003drealtime)"},{"line_number":657,"context_line":"        else:"},{"line_number":658,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":659,"context_line":"                                   reboot\u003dnot realtime,"},{"line_number":660,"context_line":"                                   realtime\u003drealtime)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_b442013a","line":659,"range":{"start_line":659,"start_character":42,"end_line":659,"end_character":54},"in_reply_to":"9fdfeff1_7bea5474","updated":"2019-02-28 00:15:04.000000000","message":"okay","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0bdfa01fa7bfbbee6e4077f46d5869f6ba7884ea","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                                   realtime\u003drealtime)"},{"line_number":657,"context_line":"        else:"},{"line_number":658,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":659,"context_line":"                                   reboot\u003dnot realtime,"},{"line_number":660,"context_line":"                                   realtime\u003drealtime)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_7daa35d2","line":659,"range":{"start_line":659,"start_character":42,"end_line":659,"end_character":54},"in_reply_to":"9fdfeff1_925b4852","updated":"2019-02-28 09:28:20.000000000","message":"\"It will not always be false. \"\nThat\u0027s the problem, actually :-) In  the \u0027else\u0027 branch the reboot parameter should always be set to \u0027False\u0027 (since it is simply not the last controller and should hence never be rebooted).","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"4782ade9504380f1ddc2b2ff407962f604f49798","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    if \u0027raid_config_job_ids\u0027 not in driver_internal_info:"},{"line_number":646,"context_line":"        driver_internal_info[\u0027raid_config_job_ids\u0027] \u003d []"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    all_realtime \u003d True"},{"line_number":649,"context_line":"    for controller in controllers:"},{"line_number":650,"context_line":"        raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":651,"context_line":"        realtime \u003d controller[\u0027is_reboot_required\u0027] \u003d\u003d \u0027optional\u0027"},{"line_number":652,"context_line":"        all_realtime \u003d all_realtime and realtime"},{"line_number":653,"context_line":"        if controller \u003d\u003d controllers[-1]:"},{"line_number":654,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":655,"context_line":"                                   reboot\u003dnot all_realtime,"},{"line_number":656,"context_line":"                                   realtime\u003drealtime)"},{"line_number":657,"context_line":"        else:"},{"line_number":658,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":659,"context_line":"                                   reboot\u003dnot realtime,"},{"line_number":660,"context_line":"                                   realtime\u003drealtime)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"},{"line_number":663,"context_line":"                 \u0027%(controller)s on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_7dc1d57f","line":660,"range":{"start_line":648,"start_character":4,"end_line":660,"end_character":53},"updated":"2019-02-28 09:31:41.000000000","message":"Please ad a comment to explain the logic. See my earlier post for a suggestion.","commit_id":"8ccb91d9d697d7185ca4260bbaf8e5468568c132"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"46326dd8794a36bb025b2918fac9a5dfc0336fa4","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    if \u0027raid_config_job_ids\u0027 not in driver_internal_info:"},{"line_number":646,"context_line":"        driver_internal_info[\u0027raid_config_job_ids\u0027] \u003d []"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    all_realtime \u003d True"},{"line_number":649,"context_line":"    for controller in controllers:"},{"line_number":650,"context_line":"        raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":651,"context_line":"        realtime \u003d controller[\u0027is_reboot_required\u0027] \u003d\u003d \u0027optional\u0027"},{"line_number":652,"context_line":"        all_realtime \u003d all_realtime and realtime"},{"line_number":653,"context_line":"        if controller \u003d\u003d controllers[-1]:"},{"line_number":654,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":655,"context_line":"                                   reboot\u003dnot all_realtime,"},{"line_number":656,"context_line":"                                   realtime\u003drealtime)"},{"line_number":657,"context_line":"        else:"},{"line_number":658,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":659,"context_line":"                                   reboot\u003dnot realtime,"},{"line_number":660,"context_line":"                                   realtime\u003drealtime)"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"},{"line_number":663,"context_line":"                 \u0027%(controller)s on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_bd83bd02","line":660,"range":{"start_line":648,"start_character":4,"end_line":660,"end_character":53},"in_reply_to":"9fdfeff1_7dc1d57f","updated":"2019-02-28 09:41:32.000000000","message":"Got your point. \nAdding another patch","commit_id":"8ccb91d9d697d7185ca4260bbaf8e5468568c132"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0b2c6f625f696d363767379f0c66c83dea1a5db6","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    :param reboot: indicates whether a reboot job should be automatically"},{"line_number":211,"context_line":"                   created with the config job. (optional, defaults to False)"},{"line_number":212,"context_line":"    :param realtime: indicates RAID controller supports realtime."},{"line_number":213,"context_line":"                    (optional, defaults to False)"},{"line_number":214,"context_line":"    :returns: id of the created job"},{"line_number":215,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":216,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_294ce19c","line":213,"range":{"start_line":213,"start_character":20,"end_line":213,"end_character":21},"updated":"2019-03-22 15:28:43.000000000","message":"Nit: indentation","commit_id":"a8897c62a961a3a59b83d34f1e0eb58d66a51796"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"463d4a5c02914fc62d47a1899ebd4e091a8d4317","unresolved":false,"context_lines":[{"line_number":652,"context_line":"        raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":653,"context_line":"        realtime \u003d controller[\u0027is_reboot_required\u0027] \u003d\u003d \u0027optional\u0027"},{"line_number":654,"context_line":"        all_realtime \u003d all_realtime and realtime"},{"line_number":655,"context_line":"        if controller \u003d\u003d controllers[-1]:"},{"line_number":656,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":657,"context_line":"                                   reboot\u003dnot all_realtime,"},{"line_number":658,"context_line":"                                   realtime\u003drealtime)"},{"line_number":659,"context_line":"        else:"},{"line_number":660,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":661,"context_line":"                                   reboot\u003dFalse,"},{"line_number":662,"context_line":"                                   realtime\u003drealtime)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"},{"line_number":665,"context_line":"                 \u0027%(controller)s on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_d031155b","line":662,"range":{"start_line":655,"start_character":0,"end_line":662,"end_character":53},"updated":"2019-03-25 09:02:31.000000000","message":"nit: These line of codes can be collapsed to:\n\nreboot \u003d (not all_realtime) if controller \u003d\u003d controllers[-1] else False\njob_id \u003d commit_config(node, \n    raid_controller\u003draid_controller,\n    reboot\u003dreboot,\n    realtime\u003drealtime)","commit_id":"613587b44304eb7af34fe6cbcafb21c94a8f55b1"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"8044a982654a01b662b2f42e776f1339c07e2bea","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    :param reboot: indicates whether a reboot job should be automatically"},{"line_number":211,"context_line":"                   created with the config job. (optional, defaults to False)"},{"line_number":212,"context_line":"    :param realtime: indicates RAID controller supports realtime."},{"line_number":213,"context_line":"                    (optional, defaults to False)"},{"line_number":214,"context_line":"    :returns: id of the created job"},{"line_number":215,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":216,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_38435741","line":213,"range":{"start_line":213,"start_character":20,"end_line":213,"end_character":21},"updated":"2019-03-27 17:43:27.000000000","message":"Nit: indentation","commit_id":"0428696dd2699034e6cb66b8d3a638bb156d1e05"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"4885c709d790aeec12d26c4e886e85bfd417af60","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    :param reboot: indicates whether a reboot job should be automatically"},{"line_number":211,"context_line":"                   created with the config job. (optional, defaults to False)"},{"line_number":212,"context_line":"    :param realtime: indicates RAID controller supports realtime."},{"line_number":213,"context_line":"                    (optional, defaults to False)"},{"line_number":214,"context_line":"    :returns: id of the created job"},{"line_number":215,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":216,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_3cdee16c","line":213,"range":{"start_line":213,"start_character":20,"end_line":213,"end_character":21},"in_reply_to":"5fc1f717_38435741","updated":"2019-03-28 05:31:32.000000000","message":"Done","commit_id":"0428696dd2699034e6cb66b8d3a638bb156d1e05"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"8044a982654a01b662b2f42e776f1339c07e2bea","unresolved":false,"context_lines":[{"line_number":647,"context_line":"    if \u0027raid_config_job_ids\u0027 not in driver_internal_info:"},{"line_number":648,"context_line":"        driver_internal_info[\u0027raid_config_job_ids\u0027] \u003d []"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    all_realtime \u003d True"},{"line_number":651,"context_line":"    for controller in controllers:"},{"line_number":652,"context_line":"        raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":653,"context_line":"        realtime \u003d controller[\u0027is_reboot_required\u0027] \u003d\u003d \u0027optional\u0027"},{"line_number":654,"context_line":"        all_realtime \u003d all_realtime and realtime"},{"line_number":655,"context_line":"        if controller \u003d\u003d controllers[-1]:"},{"line_number":656,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":657,"context_line":"                                   reboot\u003dnot all_realtime,"},{"line_number":658,"context_line":"                                   realtime\u003drealtime)"},{"line_number":659,"context_line":"        else:"},{"line_number":660,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":661,"context_line":"                                   reboot\u003dFalse,"},{"line_number":662,"context_line":"                                   realtime\u003drealtime)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"},{"line_number":665,"context_line":"                 \u0027%(controller)s on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_f83b8f98","line":662,"range":{"start_line":650,"start_character":4,"end_line":662,"end_character":53},"updated":"2019-03-27 17:43:27.000000000","message":"As mentioned earlier, I\u0027d suggest to add a comment explaining the logic just before L650 (it took us a while to get this sorted so it\u0027d be good to document this). Something like:\n\n# Commit the configuration and reboot the last controller\n# if there is at least one controller without real time support.","commit_id":"0428696dd2699034e6cb66b8d3a638bb156d1e05"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"4885c709d790aeec12d26c4e886e85bfd417af60","unresolved":false,"context_lines":[{"line_number":647,"context_line":"    if \u0027raid_config_job_ids\u0027 not in driver_internal_info:"},{"line_number":648,"context_line":"        driver_internal_info[\u0027raid_config_job_ids\u0027] \u003d []"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    all_realtime \u003d True"},{"line_number":651,"context_line":"    for controller in controllers:"},{"line_number":652,"context_line":"        raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":653,"context_line":"        realtime \u003d controller[\u0027is_reboot_required\u0027] \u003d\u003d \u0027optional\u0027"},{"line_number":654,"context_line":"        all_realtime \u003d all_realtime and realtime"},{"line_number":655,"context_line":"        if controller \u003d\u003d controllers[-1]:"},{"line_number":656,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":657,"context_line":"                                   reboot\u003dnot all_realtime,"},{"line_number":658,"context_line":"                                   realtime\u003drealtime)"},{"line_number":659,"context_line":"        else:"},{"line_number":660,"context_line":"            job_id \u003d commit_config(node, raid_controller\u003draid_controller,"},{"line_number":661,"context_line":"                                   reboot\u003dFalse,"},{"line_number":662,"context_line":"                                   realtime\u003drealtime)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        LOG.info(\u0027Change has been committed to RAID controller \u0027"},{"line_number":665,"context_line":"                 \u0027%(controller)s on node %(node)s. \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_9cf35509","line":662,"range":{"start_line":650,"start_character":4,"end_line":662,"end_character":53},"in_reply_to":"5fc1f717_f83b8f98","updated":"2019-03-28 05:31:32.000000000","message":"Done","commit_id":"0428696dd2699034e6cb66b8d3a638bb156d1e05"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"0319d56572f40ed2c1b2b4baf70e3511af6ee519","unresolved":false,"context_lines":[{"line_number":651,"context_line":"    for controller in controllers:"},{"line_number":652,"context_line":"        raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"        # Commit the configuration and reboot the last controller"},{"line_number":655,"context_line":"        # Also below code checks if all controller supports realtime"},{"line_number":656,"context_line":"        # then node doesn\u0027t get rebooted."},{"line_number":657,"context_line":"        # If one of controller doesn\u0027t support realtime, then reboot set"}],"source_content_type":"text/x-python","patch_set":15,"id":"5fc1f717_85e77f12","line":654,"updated":"2019-04-10 15:21:22.000000000","message":"Can you remove \" and reboot the last controller\" on the line above?  The node is what may be rebooted, not the controller, and the description below specifies when that will happen.","commit_id":"cbe0cb15ff3a3d9bccc1e3e2aba04a6ed6a66bf6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"470a7a6dac5ab04c883d5215e7307c346ee98377","unresolved":false,"context_lines":[{"line_number":763,"context_line":"                span_length\u003dlogical_disk.get(\u0027span_length\u0027),"},{"line_number":764,"context_line":"                span_depth\u003dlogical_disk.get(\u0027span_depth\u0027))"},{"line_number":765,"context_line":"            controller[\u0027raid_controller\u0027] \u003d logical_disk[\u0027controller\u0027]"},{"line_number":766,"context_line":"            controller[\u0027is_reboot_required\u0027] \u003d controller_cap["},{"line_number":767,"context_line":"                \u0027is_reboot_required\u0027]"},{"line_number":768,"context_line":"            controllers.append(controller)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        return _commit_to_controllers(node, controllers)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fce034c_0839e33f","line":767,"range":{"start_line":766,"start_character":0,"end_line":767,"end_character":37},"updated":"2019-04-16 15:10:04.000000000","message":"It seems like this is less about a hardware capability, but more situational. Is \"realtime\" not marketing and more just a possibility of skipping a reboot if not required by the requested configuration?","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"8643bd338640be56a9bbf4d5bf0fb5f7ddbada00","unresolved":false,"context_lines":[{"line_number":763,"context_line":"                span_length\u003dlogical_disk.get(\u0027span_length\u0027),"},{"line_number":764,"context_line":"                span_depth\u003dlogical_disk.get(\u0027span_depth\u0027))"},{"line_number":765,"context_line":"            controller[\u0027raid_controller\u0027] \u003d logical_disk[\u0027controller\u0027]"},{"line_number":766,"context_line":"            controller[\u0027is_reboot_required\u0027] \u003d controller_cap["},{"line_number":767,"context_line":"                \u0027is_reboot_required\u0027]"},{"line_number":768,"context_line":"            controllers.append(controller)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        return _commit_to_controllers(node, controllers)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fce034c_dcff1932","line":767,"range":{"start_line":766,"start_character":0,"end_line":767,"end_character":37},"in_reply_to":"3fce034c_0839e33f","updated":"2019-04-16 21:05:13.000000000","message":"It is true that realtime mode is basically the ability to run certain jobs without rebooting the server.  That said, it is not just marketing, as changes were made to the RAID controller firmware to support realtime mode.  You can actually query the RAID controller to find out if it supports realtime mode.","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"7cd3cd7b104d9461ad25831997baf8a8b8973473","unresolved":false,"context_lines":[{"line_number":763,"context_line":"                span_length\u003dlogical_disk.get(\u0027span_length\u0027),"},{"line_number":764,"context_line":"                span_depth\u003dlogical_disk.get(\u0027span_depth\u0027))"},{"line_number":765,"context_line":"            controller[\u0027raid_controller\u0027] \u003d logical_disk[\u0027controller\u0027]"},{"line_number":766,"context_line":"            controller[\u0027is_reboot_required\u0027] \u003d controller_cap["},{"line_number":767,"context_line":"                \u0027is_reboot_required\u0027]"},{"line_number":768,"context_line":"            controllers.append(controller)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        return _commit_to_controllers(node, controllers)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fce034c_32217db1","line":767,"range":{"start_line":766,"start_character":0,"end_line":767,"end_character":37},"in_reply_to":"3fce034c_dcff1932","updated":"2019-04-18 10:26:49.000000000","message":"I hope no changes needed here.","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"aad1e0e9077558f50cca7e7fc5ccc4c707e3cf21","unresolved":false,"context_lines":[{"line_number":652,"context_line":"        raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"        # Commit the configuration"},{"line_number":655,"context_line":"        # Below code checks if all controller supports realtime"},{"line_number":656,"context_line":"        # then node doesn\u0027t get rebooted."},{"line_number":657,"context_line":"        # If one of controller doesn\u0027t support realtime, then reboot set"},{"line_number":658,"context_line":"        # to True for last controller."},{"line_number":659,"context_line":"        realtime \u003d controller[\u0027is_reboot_required\u0027] \u003d\u003d \u0027optional\u0027"},{"line_number":660,"context_line":"        all_realtime \u003d all_realtime and realtime"},{"line_number":661,"context_line":"        if controller \u003d\u003d controllers[-1]:"}],"source_content_type":"text/x-python","patch_set":22,"id":"ffb9cba7_b11b6919","line":658,"range":{"start_line":655,"start_character":0,"end_line":658,"end_character":38},"updated":"2019-04-25 09:15:21.000000000","message":"Nit, how about:\n\"The logic below will reboot the node if there is at least one controller without real time support. In that case the reboot is triggered when the configuration is committed to the last controller.\"","commit_id":"0c511b2126357d55415a0b65c7bbf75ed257f89c"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"3ed1cc67bd6b9462d81373e9e001d684f045e98b","unresolved":false,"context_lines":[{"line_number":652,"context_line":"        raid_controller \u003d controller[\u0027raid_controller\u0027]"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"        # Commit the configuration"},{"line_number":655,"context_line":"        # Below code checks if all controller supports realtime"},{"line_number":656,"context_line":"        # then node doesn\u0027t get rebooted."},{"line_number":657,"context_line":"        # If one of controller doesn\u0027t support realtime, then reboot set"},{"line_number":658,"context_line":"        # to True for last controller."},{"line_number":659,"context_line":"        realtime \u003d controller[\u0027is_reboot_required\u0027] \u003d\u003d \u0027optional\u0027"},{"line_number":660,"context_line":"        all_realtime \u003d all_realtime and realtime"},{"line_number":661,"context_line":"        if controller \u003d\u003d controllers[-1]:"}],"source_content_type":"text/x-python","patch_set":22,"id":"ffb9cba7_ccba0209","line":658,"range":{"start_line":655,"start_character":0,"end_line":658,"end_character":38},"in_reply_to":"ffb9cba7_b11b6919","updated":"2019-04-25 10:13:49.000000000","message":"Looks good! will update","commit_id":"0c511b2126357d55415a0b65c7bbf75ed257f89c"}],"ironic/tests/unit/drivers/modules/drac/test_raid.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"5f6cccebf38667d061d039bd79ee5819879aa14b","unresolved":false,"context_lines":[{"line_number":837,"context_line":"        physical_disks \u003d self._generate_physical_disks()"},{"line_number":838,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        mock_commit_config.side_effect \u003d [\u002742\u0027, \u002712\u0027]"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"        mock_create_virtual_disk.return_value \u003d {"},{"line_number":843,"context_line":"            \u0027is_reboot_required\u0027: \u0027optional\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_c4785bc2","line":840,"updated":"2019-02-26 20:08:30.000000000","message":"The StopIteration exception that occurs in this test case is due to the above line and the number of virtual disks that are being created.  If you look in the setUp method, you will see that there are 3 virtual disks being created: 1 root, and 2 non-root (line 588).  As a result, there are 3 commits that happen, not 2.  To fix the bug, just add another job id to the above list, and then modify the assertEqual statement below to check for that job id too.  Another option would be to modify this test case so that it only tries to create 2 virtual disks.","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"4d2c8c38e367c8ab07d61c94b99eb0b67d05799b","unresolved":false,"context_lines":[{"line_number":837,"context_line":"        physical_disks \u003d self._generate_physical_disks()"},{"line_number":838,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        mock_commit_config.side_effect \u003d [\u002742\u0027, \u002712\u0027]"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"        mock_create_virtual_disk.return_value \u003d {"},{"line_number":843,"context_line":"            \u0027is_reboot_required\u0027: \u0027optional\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_0c6f5828","line":840,"in_reply_to":"9fdfeff1_c4785bc2","updated":"2019-02-27 13:09:35.000000000","message":"Done","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"5f6cccebf38667d061d039bd79ee5819879aa14b","unresolved":false,"context_lines":[{"line_number":901,"context_line":"                pass"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        self.node.refresh()"},{"line_number":904,"context_line":"        self.assertEqual([\u002742\u0027, \u002712\u0027],"},{"line_number":905,"context_line":"                         self.node.driver_internal_info[\u0027raid_config_job_ids\u0027])"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_64ef2f87","line":904,"updated":"2019-02-26 20:08:30.000000000","message":"Add the new job id to the list on the above line.","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"4d2c8c38e367c8ab07d61c94b99eb0b67d05799b","unresolved":false,"context_lines":[{"line_number":901,"context_line":"                pass"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        self.node.refresh()"},{"line_number":904,"context_line":"        self.assertEqual([\u002742\u0027, \u002712\u0027],"},{"line_number":905,"context_line":"                         self.node.driver_internal_info[\u0027raid_config_job_ids\u0027])"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"    @mock.patch.object(drac_common, \u0027get_drac_client\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_ac616c3b","line":904,"in_reply_to":"9fdfeff1_64ef2f87","updated":"2019-02-27 13:09:35.000000000","message":"Done","commit_id":"39f65d8a3d00dbdad2682dfe95e09d6c280566fc"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"825e63a86b389275b6fb143fb3986d9649e6f2b4","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                raid_controller\u003d\u0027RAID.Integrated.1-1\u0027,"},{"line_number":633,"context_line":"                physical_disks\u003d["},{"line_number":634,"context_line":"                    \u0027Disk.Bay.0:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027,"},{"line_number":635,"context_line":"                    \u0027Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027],"},{"line_number":636,"context_line":"                raid_level\u003d\u00271\u0027,"},{"line_number":637,"context_line":"                size_mb\u003d51200,"},{"line_number":638,"context_line":"                disk_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_06b64cfa","line":635,"updated":"2019-02-27 19:20:04.000000000","message":"The data input to these mocks are repeated many times, can you consider defining variables","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"88e7cf6330cb2da144481c852e1ae139cacb15fb","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                raid_controller\u003d\u0027RAID.Integrated.1-1\u0027,"},{"line_number":633,"context_line":"                physical_disks\u003d["},{"line_number":634,"context_line":"                    \u0027Disk.Bay.0:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027,"},{"line_number":635,"context_line":"                    \u0027Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027],"},{"line_number":636,"context_line":"                raid_level\u003d\u00271\u0027,"},{"line_number":637,"context_line":"                size_mb\u003d51200,"},{"line_number":638,"context_line":"                disk_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_342291a4","line":635,"in_reply_to":"9fdfeff1_06b64cfa","updated":"2019-02-28 00:15:04.000000000","message":"For almost every test cases, there are some differences so I kept like this","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"0b478f37fb1521ec35578014eea165c5d73dabe7","unresolved":false,"context_lines":[{"line_number":741,"context_line":"                span_length\u003d3,"},{"line_number":742,"context_line":"                span_depth\u003d2)"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"            mock_create_virtual_disk.assert_has_calls("},{"line_number":745,"context_line":"                mock_create_virtual_disk.call_args_list)"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"            # Commits to the controller"},{"line_number":748,"context_line":"            mock_commit_config.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_6c07ca19","line":745,"range":{"start_line":744,"start_character":12,"end_line":745,"end_character":56},"updated":"2019-03-18 11:58:10.000000000","message":"I think this check always passes due to you compare the actual calls to themselves. It should be:\n\nexpected_call_list \u003d [call(...), call(...), ...]\nmock_obj.assert_has_calls(expected_call_list)","commit_id":"fe4d584d2bdc0ae6538750b3eba50a8323153806"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"d1e62d8f685b50663bc8303bd892d7f99159bc8c","unresolved":false,"context_lines":[{"line_number":741,"context_line":"                span_length\u003d3,"},{"line_number":742,"context_line":"                span_depth\u003d2)"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"            mock_create_virtual_disk.assert_has_calls("},{"line_number":745,"context_line":"                mock_create_virtual_disk.call_args_list)"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"            # Commits to the controller"},{"line_number":748,"context_line":"            mock_commit_config.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_a70aacce","line":745,"range":{"start_line":744,"start_character":12,"end_line":745,"end_character":56},"in_reply_to":"5fc1f717_6c07ca19","updated":"2019-03-18 13:55:32.000000000","message":"No, this is not the problem. Existing implementation does the same thing. Problem here is how to return multiple values for \nmock_create_virtual_disk.return_value \u003d {\n            \u0027is_reboot_required\u0027: \u0027optional\u0027,\n            \u0027commit_required\u0027: False,\n            \u0027is_commit_required\u0027: True}","commit_id":"fe4d584d2bdc0ae6538750b3eba50a8323153806"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"e03bf824cbdd61b14b70e3fe70837919eacb00fc","unresolved":false,"context_lines":[{"line_number":741,"context_line":"                span_length\u003d3,"},{"line_number":742,"context_line":"                span_depth\u003d2)"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"            mock_create_virtual_disk.assert_has_calls("},{"line_number":745,"context_line":"                mock_create_virtual_disk.call_args_list)"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"            # Commits to the controller"},{"line_number":748,"context_line":"            mock_commit_config.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_b65e4e10","line":745,"range":{"start_line":744,"start_character":12,"end_line":745,"end_character":56},"in_reply_to":"5fc1f717_a70aacce","updated":"2019-03-19 03:44:07.000000000","message":"I still think this check is meaningless as it always passes. I would want to see more reviews about this from others.","commit_id":"fe4d584d2bdc0ae6538750b3eba50a8323153806"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0b2c6f625f696d363767379f0c66c83dea1a5db6","unresolved":false,"context_lines":[{"line_number":846,"context_line":"                span_length\u003d3,"},{"line_number":847,"context_line":"                span_depth\u003d1)"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"            mock_client.create_virtual_disk.assert_has_calls("},{"line_number":850,"context_line":"                mock_client.create_virtual_disk.call_args_list, any_order\u003dTrue)"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"            # Commits to both controller"},{"line_number":853,"context_line":"            mock_commit_config.assert_has_calls("}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_81336f13","line":850,"range":{"start_line":849,"start_character":11,"end_line":850,"end_character":79},"updated":"2019-03-22 15:28:43.000000000","message":"I think this has the same issue as discussed for the other test and the previous patch set: it will always pass.","commit_id":"a8897c62a961a3a59b83d34f1e0eb58d66a51796"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"32563737a4eb3b7ad6c4de8d0ad40607ddbb1f47","unresolved":false,"context_lines":[{"line_number":846,"context_line":"                span_length\u003d3,"},{"line_number":847,"context_line":"                span_depth\u003d1)"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"            mock_client.create_virtual_disk.assert_has_calls("},{"line_number":850,"context_line":"                mock_client.create_virtual_disk.call_args_list, any_order\u003dTrue)"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"            # Commits to both controller"},{"line_number":853,"context_line":"            mock_commit_config.assert_has_calls("}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_8c99637a","line":850,"range":{"start_line":849,"start_character":11,"end_line":850,"end_character":79},"in_reply_to":"5fc1f717_81336f13","updated":"2019-03-27 06:46:06.000000000","message":"These tests are different from previous one. previous tested are mocked with mock_create_virtual_disk call but these test cases are like existing. Only addressed by creating seperate calls.","commit_id":"a8897c62a961a3a59b83d34f1e0eb58d66a51796"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0b2c6f625f696d363767379f0c66c83dea1a5db6","unresolved":false,"context_lines":[{"line_number":930,"context_line":"                span_length\u003d3,"},{"line_number":931,"context_line":"                span_depth\u003d1)"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"            mock_client.create_virtual_disk.assert_has_calls("},{"line_number":934,"context_line":"                mock_client.create_virtual_disk.call_args_list, any_order\u003dTrue)"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"            # Commits to the controller"},{"line_number":937,"context_line":"            mock_commit_config.assert_called_with("}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_89c0752c","line":934,"range":{"start_line":933,"start_character":12,"end_line":934,"end_character":79},"updated":"2019-03-22 15:28:43.000000000","message":"See above.","commit_id":"a8897c62a961a3a59b83d34f1e0eb58d66a51796"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0b2c6f625f696d363767379f0c66c83dea1a5db6","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"                span_length\u003d3,"},{"line_number":1003,"context_line":"                span_depth\u003d1)"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"            mock_client.create_virtual_disk.assert_has_calls("},{"line_number":1006,"context_line":"                mock_client.create_virtual_disk.call_args_list, any_order\u003dTrue)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"            # Commits to the controller"},{"line_number":1009,"context_line":"            mock_commit_config.assert_called_with("}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_49e04dcd","line":1006,"range":{"start_line":1005,"start_character":11,"end_line":1006,"end_character":79},"updated":"2019-03-22 15:28:43.000000000","message":"See above.","commit_id":"a8897c62a961a3a59b83d34f1e0eb58d66a51796"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0b2c6f625f696d363767379f0c66c83dea1a5db6","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"                disk_name\u003dNone,"},{"line_number":1089,"context_line":"                span_length\u003d3,"},{"line_number":1090,"context_line":"                span_depth\u003d1)"},{"line_number":1091,"context_line":"            mock_client.create_virtual_disk.assert_has_calls("},{"line_number":1092,"context_line":"                mock_client.create_virtual_disk.call_args_list, any_order\u003dTrue)"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"            # Commits to the controller"},{"line_number":1095,"context_line":"            mock_commit_config.assert_called_with("}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_a9d0d1f8","line":1092,"range":{"start_line":1091,"start_character":10,"end_line":1092,"end_character":79},"updated":"2019-03-22 15:28:43.000000000","message":"See above.","commit_id":"a8897c62a961a3a59b83d34f1e0eb58d66a51796"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0b2c6f625f696d363767379f0c66c83dea1a5db6","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"                span_length\u003d3,"},{"line_number":1189,"context_line":"                span_depth\u003d1)"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"            mock_client.create_virtual_disk.assert_has_calls("},{"line_number":1192,"context_line":"                mock_client.create_virtual_disk.call_args_list, any_order\u003dTrue)"},{"line_number":1193,"context_line":""},{"line_number":1194,"context_line":"            # Commits to the controller"},{"line_number":1195,"context_line":"            mock_commit_config.assert_called_with("}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_29062188","line":1192,"range":{"start_line":1191,"start_character":12,"end_line":1192,"end_character":79},"updated":"2019-03-22 15:28:43.000000000","message":"See above.","commit_id":"a8897c62a961a3a59b83d34f1e0eb58d66a51796"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"32563737a4eb3b7ad6c4de8d0ad40607ddbb1f47","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"                       autospec\u003dTrue)"},{"line_number":1208,"context_line":"    @mock.patch.object(drac_raid, \u0027commit_config\u0027, spec_set\u003dTrue,"},{"line_number":1209,"context_line":"                       autospec\u003dTrue)"},{"line_number":1210,"context_line":"    @mock.patch.object(drac_raid, \u0027create_virtual_disk\u0027, spec_set\u003dTrue,"},{"line_number":1211,"context_line":"                       autospec\u003dTrue)"},{"line_number":1212,"context_line":"    def test_create_configuration_fails_with_sharing_disabled("},{"line_number":1213,"context_line":"            self, mock_create_virtual_disk, mock_commit_config,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_ec98276b","line":1210,"range":{"start_line":1210,"start_character":0,"end_line":1210,"end_character":71},"updated":"2019-03-27 06:46:06.000000000","message":"I agree here, I need to change this, as this is by mistak","commit_id":"a8897c62a961a3a59b83d34f1e0eb58d66a51796"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0b2c6f625f696d363767379f0c66c83dea1a5db6","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"                span_length\u003d3,"},{"line_number":1305,"context_line":"                span_depth\u003d1)"},{"line_number":1306,"context_line":""},{"line_number":1307,"context_line":"            mock_client.create_virtual_disk.assert_has_calls("},{"line_number":1308,"context_line":"                mock_client.create_virtual_disk.call_args_list, any_order\u003dTrue)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":"            # Commits to the controller"},{"line_number":1311,"context_line":"            mock_commit_config.assert_called_with("}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_e9ffb964","line":1308,"range":{"start_line":1307,"start_character":11,"end_line":1308,"end_character":79},"updated":"2019-03-22 15:28:43.000000000","message":"See above.","commit_id":"a8897c62a961a3a59b83d34f1e0eb58d66a51796"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9ac64928e39c942268c45e2382fb5f51e1d8cb7c","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                \u0027RAID.Integrated.1-1\u0027,"},{"line_number":632,"context_line":"                [\u0027Disk.Bay.0:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027,"},{"line_number":633,"context_line":"                 \u0027Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027],"},{"line_number":634,"context_line":"                \u00271+0\u0027, 51200, None, 2, 1)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"            mock_commit_config.assert_called_once_with("},{"line_number":637,"context_line":"                task.node, raid_controller\u003d\u0027RAID.Integrated.1-1\u0027, reboot\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_c62ad62a","line":634,"updated":"2019-03-24 16:05:02.000000000","message":"fix indentation here, also I think the default raid_level for the virtual disk is \u00271\u0027, not \u00271+0\u0027","commit_id":"613587b44304eb7af34fe6cbcafb21c94a8f55b1"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"463d4a5c02914fc62d47a1899ebd4e091a8d4317","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                \u0027RAID.Integrated.1-1\u0027,"},{"line_number":632,"context_line":"                [\u0027Disk.Bay.0:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027,"},{"line_number":633,"context_line":"                 \u0027Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027],"},{"line_number":634,"context_line":"                \u00271+0\u0027, 51200, None, 2, 1)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"            mock_commit_config.assert_called_once_with("},{"line_number":637,"context_line":"                task.node, raid_controller\u003d\u0027RAID.Integrated.1-1\u0027, reboot\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_70a5c146","line":634,"in_reply_to":"5fc1f717_c62ad62a","updated":"2019-03-25 09:02:31.000000000","message":"++. The test raid level is \u00271\u0027 at L58.","commit_id":"613587b44304eb7af34fe6cbcafb21c94a8f55b1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9ac64928e39c942268c45e2382fb5f51e1d8cb7c","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                 \u0027Disk.Bay.1:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027,"},{"line_number":717,"context_line":"                 \u0027Disk.Bay.2:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027,"},{"line_number":718,"context_line":"                 \u0027Disk.Bay.3:Enclosure.Internal.0-1:RAID.Integrated.1-1\u0027],"},{"line_number":719,"context_line":"                \u00271+0\u0027, 102400, None, None, None)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"            # Commits to the controller"},{"line_number":722,"context_line":"            mock_commit_config.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_c6117606","line":719,"updated":"2019-03-24 16:05:02.000000000","message":"you need to fix indentation here","commit_id":"613587b44304eb7af34fe6cbcafb21c94a8f55b1"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"8044a982654a01b662b2f42e776f1339c07e2bea","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"                any_order\u003dTrue)"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"            # Commits to the controller"},{"line_number":1048,"context_line":"            mock_commit_config.assert_called_with("},{"line_number":1049,"context_line":"                mock.ANY, raid_controller\u003d\u0027RAID.Integrated.1-1\u0027, reboot\u003dFalse,"},{"line_number":1050,"context_line":"                realtime\u003dTrue)"},{"line_number":1051,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_18fbfb46","line":1048,"range":{"start_line":1048,"start_character":12,"end_line":1048,"end_character":50},"updated":"2019-03-27 17:43:27.000000000","message":"Why is this called multiple times now? (3x it seems from the check below)","commit_id":"0428696dd2699034e6cb66b8d3a638bb156d1e05"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"4885c709d790aeec12d26c4e886e85bfd417af60","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"                any_order\u003dTrue)"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"            # Commits to the controller"},{"line_number":1048,"context_line":"            mock_commit_config.assert_called_with("},{"line_number":1049,"context_line":"                mock.ANY, raid_controller\u003d\u0027RAID.Integrated.1-1\u0027, reboot\u003dFalse,"},{"line_number":1050,"context_line":"                realtime\u003dTrue)"},{"line_number":1051,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_7c322960","line":1048,"range":{"start_line":1048,"start_character":12,"end_line":1048,"end_character":50},"in_reply_to":"5fc1f717_18fbfb46","updated":"2019-03-28 05:31:32.000000000","message":"I changes this one now. As we have given three disk for virtual disk creation, so I have changed some logic here.\nUpdating patch soon","commit_id":"0428696dd2699034e6cb66b8d3a638bb156d1e05"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"0319d56572f40ed2c1b2b4baf70e3511af6ee519","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \u0027firmware_version\u0027: \u002721.3.0-0009\u0027,"},{"line_number":49,"context_line":"            \u0027supports_realtime\u0027: True}"},{"line_number":50,"context_line":"        self.raid_controller \u003d test_utils.dict_to_namedtuple("},{"line_number":51,"context_line":"            values\u003draid_controller_dict)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        virtual_disk_dict \u003d {"},{"line_number":54,"context_line":"            \u0027id\u0027: \u0027Disk.Virtual.0:RAID.Integrated.1-1\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5fc1f717_85b21f93","line":51,"updated":"2019-04-10 15:21:22.000000000","message":"In the above block of changes, I don\u0027t think primary_status or bus should be removed, and make_raid_controller should be called instead of dict_to_named_tuple.","commit_id":"cbe0cb15ff3a3d9bccc1e3e2aba04a6ed6a66bf6"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"29a714392f9c03b457be967ab5176aeee55f3801","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \u0027firmware_version\u0027: \u002721.3.0-0009\u0027,"},{"line_number":49,"context_line":"            \u0027supports_realtime\u0027: True}"},{"line_number":50,"context_line":"        self.raid_controller \u003d test_utils.dict_to_namedtuple("},{"line_number":51,"context_line":"            values\u003draid_controller_dict)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        virtual_disk_dict \u003d {"},{"line_number":54,"context_line":"            \u0027id\u0027: \u0027Disk.Virtual.0:RAID.Integrated.1-1\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fce034c_98dc6475","line":51,"in_reply_to":"5fc1f717_85b21f93","updated":"2019-04-15 04:21:18.000000000","message":"Done","commit_id":"cbe0cb15ff3a3d9bccc1e3e2aba04a6ed6a66bf6"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"0319d56572f40ed2c1b2b4baf70e3511af6ee519","unresolved":false,"context_lines":[{"line_number":807,"context_line":""},{"line_number":808,"context_line":"        mock_client.create_virtual_disk.side_effect \u003d [{"},{"line_number":809,"context_line":"            \u0027is_reboot_required\u0027: \u0027True\u0027,"},{"line_number":810,"context_line":"            \u0027commit_required\u0027: False,"},{"line_number":811,"context_line":"            \u0027is_commit_required\u0027: True"},{"line_number":812,"context_line":"        }, {"},{"line_number":813,"context_line":"            \u0027is_reboot_required\u0027: \u0027optional\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5fc1f717_00d37d61","line":810,"updated":"2019-04-10 15:21:22.000000000","message":"I think the above line should set commit_required to True because commit_required is really is_reboot_required under the covers.","commit_id":"cbe0cb15ff3a3d9bccc1e3e2aba04a6ed6a66bf6"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"29a714392f9c03b457be967ab5176aeee55f3801","unresolved":false,"context_lines":[{"line_number":807,"context_line":""},{"line_number":808,"context_line":"        mock_client.create_virtual_disk.side_effect \u003d [{"},{"line_number":809,"context_line":"            \u0027is_reboot_required\u0027: \u0027True\u0027,"},{"line_number":810,"context_line":"            \u0027commit_required\u0027: False,"},{"line_number":811,"context_line":"            \u0027is_commit_required\u0027: True"},{"line_number":812,"context_line":"        }, {"},{"line_number":813,"context_line":"            \u0027is_reboot_required\u0027: \u0027optional\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fce034c_18d2b45d","line":810,"in_reply_to":"5fc1f717_00d37d61","updated":"2019-04-15 04:21:18.000000000","message":"Done","commit_id":"cbe0cb15ff3a3d9bccc1e3e2aba04a6ed6a66bf6"}],"releasenotes/notes/add-realtime-support-d814d5917836e9e2.yaml":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"01f97c07ac6742dbdae4e7bd5d396f0f90997946","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add realtime support for RAID creation and deletion for "},{"line_number":5,"context_line":"    ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_7b8334cc","line":4,"updated":"2019-02-27 16:16:40.000000000","message":"There\u0027s a trailing space here","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"88e7cf6330cb2da144481c852e1ae139cacb15fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add realtime support for RAID creation and deletion for "},{"line_number":5,"context_line":"    ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_d441c53a","line":4,"in_reply_to":"9fdfeff1_7b8334cc","updated":"2019-02-28 00:15:04.000000000","message":"Done","commit_id":"ee433b29bd344cedc4bc46d95faaba8a38a8b668"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"470a7a6dac5ab04c883d5215e7307c346ee98377","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add realtime support for RAID creation and deletion for"},{"line_number":5,"context_line":"    ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fce034c_08ba43dd","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":8},"updated":"2019-04-16 15:10:04.000000000","message":"s/Add/Adds/ as the document is read as \"What does this new release bring me?\"","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"7cd3cd7b104d9461ad25831997baf8a8b8973473","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add realtime support for RAID creation and deletion for"},{"line_number":5,"context_line":"    ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fce034c_6d308ae9","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":8},"in_reply_to":"3fce034c_08ba43dd","updated":"2019-04-18 10:26:49.000000000","message":"Done","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"470a7a6dac5ab04c883d5215e7307c346ee98377","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add realtime support for RAID creation and deletion for"},{"line_number":5,"context_line":"    ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fce034c_e884970e","line":5,"range":{"start_line":4,"start_character":8,"end_line":5,"end_character":28},"updated":"2019-04-16 15:10:04.000000000","message":"Perhaps state what this really means. Something along the lines of \"Adds capability to the ``idrac`` hardware type for the creating raid sets without rebooting the bare metal node. This is only supported in Dell xyz raid controllers which support the \"realtime\" capability.\" ????","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"7cd3cd7b104d9461ad25831997baf8a8b8973473","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add realtime support for RAID creation and deletion for"},{"line_number":5,"context_line":"    ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fce034c_4d334ef7","line":5,"range":{"start_line":4,"start_character":8,"end_line":5,"end_character":28},"in_reply_to":"3fce034c_cf351a48","updated":"2019-04-18 10:26:49.000000000","message":"\u003e The support of realtime mode is dependent on the version of the\n \u003e firmware that\u0027s running on the RAID controller.  I think it\u0027s safe\n \u003e to say that realtime is supported on PERC H730 and H740 RAID\n \u003e controllers that are running recent firmware.\n\nYes","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"7cd3cd7b104d9461ad25831997baf8a8b8973473","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add realtime support for RAID creation and deletion for"},{"line_number":5,"context_line":"    ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fce034c_ad3af2c8","line":5,"range":{"start_line":4,"start_character":8,"end_line":5,"end_character":28},"in_reply_to":"3fce034c_e884970e","updated":"2019-04-18 10:26:49.000000000","message":"I will update the release notes accordingly","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"8643bd338640be56a9bbf4d5bf0fb5f7ddbada00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add realtime support for RAID creation and deletion for"},{"line_number":5,"context_line":"    ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fce034c_cf351a48","line":5,"range":{"start_line":4,"start_character":8,"end_line":5,"end_character":28},"in_reply_to":"3fce034c_e884970e","updated":"2019-04-16 21:05:13.000000000","message":"The support of realtime mode is dependent on the version of the firmware that\u0027s running on the RAID controller.  I think it\u0027s safe to say that realtime is supported on PERC H730 and H740 RAID controllers that are running recent firmware.","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"470a7a6dac5ab04c883d5215e7307c346ee98377","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3fce034c_68ad0787","line":6,"updated":"2019-04-16 15:10:04.000000000","message":"This release note should also include an upgrades section that notes the changed dependency for python-dracclient.","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"7cd3cd7b104d9461ad25831997baf8a8b8973473","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3fce034c_cd1f3e59","line":6,"in_reply_to":"3fce034c_68ad0787","updated":"2019-04-18 10:26:49.000000000","message":"Done","commit_id":"c4832a58edd3ed6f56e9c034d848850ee72284f2"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"c2a9cebb03c4ced62f45d49914ba3190d70fddd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``drac`` type for creating raid sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechnism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffb9cba7_0f0b698e","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":63},"updated":"2019-04-23 02:26:52.000000000","message":"RAID","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"c2a9cebb03c4ced62f45d49914ba3190d70fddd5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``drac`` type for creating raid sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechnism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffb9cba7_cfb6b1da","line":4,"range":{"start_line":4,"start_character":23,"end_line":4,"end_character":45},"updated":"2019-04-23 02:26:52.000000000","message":"s/hardware ``drac`` type/the ``idrac`` hardware type/","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c2d77bb24b6a6d180d8836bc0707cf2f55d4d481","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``drac`` type for creating raid sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechnism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffb9cba7_d7ae3c2d","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":63},"in_reply_to":"ffb9cba7_0f0b698e","updated":"2019-04-24 08:47:33.000000000","message":"Done","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c2d77bb24b6a6d180d8836bc0707cf2f55d4d481","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``drac`` type for creating raid sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechnism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffb9cba7_77abd01c","line":4,"range":{"start_line":4,"start_character":23,"end_line":4,"end_character":45},"in_reply_to":"ffb9cba7_cfb6b1da","updated":"2019-04-24 08:47:33.000000000","message":"Done","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"c2a9cebb03c4ced62f45d49914ba3190d70fddd5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``drac`` type for creating raid sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechnism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffb9cba7_2fc50d3d","line":6,"updated":"2019-04-23 02:26:52.000000000","message":"Please identify the controllers as Dell EMC products.","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"c2a9cebb03c4ced62f45d49914ba3190d70fddd5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``drac`` type for creating raid sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechnism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffb9cba7_cf04717e","line":6,"range":{"start_line":6,"start_character":40,"end_line":6,"end_character":49},"updated":"2019-04-23 02:26:52.000000000","message":"This can be deleted.","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c2d77bb24b6a6d180d8836bc0707cf2f55d4d481","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``drac`` type for creating raid sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechnism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffb9cba7_7780b08c","line":6,"in_reply_to":"ffb9cba7_2fc50d3d","updated":"2019-04-24 08:47:33.000000000","message":"Done","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c2d77bb24b6a6d180d8836bc0707cf2f55d4d481","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``drac`` type for creating raid sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechnism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffb9cba7_374c789d","line":6,"range":{"start_line":6,"start_character":40,"end_line":6,"end_character":49},"in_reply_to":"ffb9cba7_cf04717e","updated":"2019-04-24 08:47:33.000000000","message":"Done","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"c2a9cebb03c4ced62f45d49914ba3190d70fddd5","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    This change requires python-dracclient version 3.0.0."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffb9cba7_4fd721ef","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":56},"updated":"2019-04-23 02:26:52.000000000","message":"and later","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c2d77bb24b6a6d180d8836bc0707cf2f55d4d481","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    This change requires python-dracclient version 3.0.0."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ffb9cba7_b724e8c7","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":56},"in_reply_to":"ffb9cba7_4fd721ef","updated":"2019-04-24 08:47:33.000000000","message":"Done","commit_id":"31012e7f7c19a6068fc87a0394c31383ee0313ce"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5d304ea6952f967ef8632a57d105540264cced25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``idrac`` type for creating RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ffb9cba7_4c370be5","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":59},"updated":"2019-04-24 09:56:44.000000000","message":"s/ creating / create and delete of / ?\n\nAs per code, this feature looks like supported for \u0027deletion\u0027 of RAID as well.","commit_id":"e5ebf4f1d8f87834c81c350142aa3605606e11f8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5d304ea6952f967ef8632a57d105540264cced25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``idrac`` type for creating RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ffb9cba7_4109142f","line":4,"range":{"start_line":4,"start_character":23,"end_line":4,"end_character":47},"updated":"2019-04-24 09:56:44.000000000","message":"s/ hardware ``idrac`` type  / hardware type ``idrac`` //","commit_id":"e5ebf4f1d8f87834c81c350142aa3605606e11f8"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"5474ba946830392861fc7bf17bc8b4d0f8ec28a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``idrac`` type for creating RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ffb9cba7_27c6709c","line":4,"range":{"start_line":4,"start_character":23,"end_line":4,"end_character":47},"in_reply_to":"ffb9cba7_4109142f","updated":"2019-04-24 10:34:10.000000000","message":"Done","commit_id":"e5ebf4f1d8f87834c81c350142aa3605606e11f8"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"5474ba946830392861fc7bf17bc8b4d0f8ec28a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``idrac`` type for creating RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ffb9cba7_47c12480","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":59},"in_reply_to":"ffb9cba7_4c370be5","updated":"2019-04-24 10:34:10.000000000","message":"Done","commit_id":"e5ebf4f1d8f87834c81c350142aa3605606e11f8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5d304ea6952f967ef8632a57d105540264cced25","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``idrac`` type for creating RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ffb9cba7_61e778e6","line":6,"range":{"start_line":6,"start_character":56,"end_line":6,"end_character":72},"updated":"2019-04-24 09:56:44.000000000","message":"This looks bit vague. Is it possible to put the minimum firmware version numbers? It would help users to update their controllers to appropriate version to make use of this feature. That kind of information can go into driver documentation as well.","commit_id":"e5ebf4f1d8f87834c81c350142aa3605606e11f8"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"5474ba946830392861fc7bf17bc8b4d0f8ec28a8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware ``idrac`` type for creating RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ffb9cba7_e7bff8f8","line":6,"range":{"start_line":6,"start_character":56,"end_line":6,"end_character":72},"in_reply_to":"ffb9cba7_61e778e6","updated":"2019-04-24 10:34:10.000000000","message":"Done","commit_id":"e5ebf4f1d8f87834c81c350142aa3605606e11f8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d92e47560f0c056353fc36a736f344a095e296f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware type ``idrac`` for creating and deleting RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware version 25.5.5.0005"},{"line_number":7,"context_line":"    or later."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ffb9cba7_c930bfeb","line":4,"updated":"2019-04-24 18:47:53.000000000","message":"please respect column limit also in release notes","commit_id":"bb1532ed8d9cb2e78a27d7b88d196510c9efe623"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"29de94a7ce4ea8a44153aff8c9142cad8c097bec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware type ``idrac`` for creating and deleting RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware version 25.5.5.0005"},{"line_number":7,"context_line":"    or later."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ffb9cba7_2065e5e1","line":4,"in_reply_to":"ffb9cba7_c930bfeb","updated":"2019-04-25 04:10:58.000000000","message":"Done","commit_id":"bb1532ed8d9cb2e78a27d7b88d196510c9efe623"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"276a4c00fc97802b91d57786a7ecf20ee36dbcde","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware type ``idrac`` for creating and deleting RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware version 25.5.5.0005"},{"line_number":7,"context_line":"    or later."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ffb9cba7_079a4c6d","line":6,"range":{"start_line":6,"start_character":57,"end_line":6,"end_character":63},"updated":"2019-04-24 10:47:00.000000000","message":"s/ recent //","commit_id":"bb1532ed8d9cb2e78a27d7b88d196510c9efe623"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"29de94a7ce4ea8a44153aff8c9142cad8c097bec","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware type ``idrac`` for creating and deleting RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware version 25.5.5.0005"},{"line_number":7,"context_line":"    or later."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ffb9cba7_006a21b2","line":6,"range":{"start_line":6,"start_character":57,"end_line":6,"end_character":63},"in_reply_to":"ffb9cba7_079a4c6d","updated":"2019-04-25 04:10:58.000000000","message":"Done","commit_id":"bb1532ed8d9cb2e78a27d7b88d196510c9efe623"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d92e47560f0c056353fc36a736f344a095e296f0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware type ``idrac`` for creating and deleting RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware version 25.5.5.0005"},{"line_number":7,"context_line":"    or later."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ffb9cba7_694d1371","line":6,"range":{"start_line":6,"start_character":57,"end_line":6,"end_character":63},"in_reply_to":"ffb9cba7_079a4c6d","updated":"2019-04-24 18:47:53.000000000","message":"ditto","commit_id":"bb1532ed8d9cb2e78a27d7b88d196510c9efe623"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"29de94a7ce4ea8a44153aff8c9142cad8c097bec","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds capability to hardware type ``idrac`` for creating and deleting RAID sets without"},{"line_number":5,"context_line":"    rebooting the baremetal node. This realtime mechanism is supported on"},{"line_number":6,"context_line":"    PERC H730 and H740 RAID controllers that are running recent firmware version 25.5.5.0005"},{"line_number":7,"context_line":"    or later."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"ffb9cba7_6073ddb2","line":6,"range":{"start_line":6,"start_character":57,"end_line":6,"end_character":63},"in_reply_to":"ffb9cba7_694d1371","updated":"2019-04-25 04:10:58.000000000","message":"Done","commit_id":"bb1532ed8d9cb2e78a27d7b88d196510c9efe623"}]}