)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0dad9d827faf141ad98ae42c5b5cee9f65e27ff5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Harald Jensås \u003chjensas@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-22 08:39:02 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add network status field to port and portgroup data model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds new field network_status to portgroup and port objects."},{"line_number":10,"context_line":"Neutron events will use this to store vif status, such as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_c57e3e69","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":11},"updated":"2019-02-25 11:22:20.000000000","message":"isn\u0027t this the port\u0027s status?","commit_id":"4b8dcd5c6f964df7294530b07b24851a80ac62ec"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"aec68969d6aaabfc91366bb1ef514d73dfa6203f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Harald Jensås \u003chjensas@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-22 08:39:02 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add network status field to port and portgroup data model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds new field network_status to portgroup and port objects."},{"line_number":10,"context_line":"Neutron events will use this to store vif status, such as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_e8623716","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":11},"in_reply_to":"9fdfeff1_c57e3e69","updated":"2019-02-25 13:17:39.000000000","message":"I\u0027m trying to convey that it is the status of the port in the network service. But yeah, maby we should just name the field \u0027status\u0027?","commit_id":"4b8dcd5c6f964df7294530b07b24851a80ac62ec"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1a2d10eb1239ff178705d60d5e55fa233916e2e6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Neutron events will use this to store vif status, such as"},{"line_number":11,"context_line":"ACTIVE, DOWN, DELETED."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Storing network status in internal_info dict has race issues"},{"line_number":14,"context_line":"as the notification code in api and conductor both update"},{"line_number":15,"context_line":"the same field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 1304673"},{"line_number":18,"context_line":"Task: 29642"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_a5a0daf4","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":15},"updated":"2019-02-25 11:21:21.000000000","message":"This is why I think we should update this in the conductor, with an exclusive lock on the node.","commit_id":"4b8dcd5c6f964df7294530b07b24851a80ac62ec"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"aec68969d6aaabfc91366bb1ef514d73dfa6203f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Neutron events will use this to store vif status, such as"},{"line_number":11,"context_line":"ACTIVE, DOWN, DELETED."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Storing network status in internal_info dict has race issues"},{"line_number":14,"context_line":"as the notification code in api and conductor both update"},{"line_number":15,"context_line":"the same field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 1304673"},{"line_number":18,"context_line":"Task: 29642"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_b3d82052","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":15},"in_reply_to":"9fdfeff1_a5a0daf4","updated":"2019-02-25 13:17:39.000000000","message":"The spec says:\n\"\" .. ironic API performs node-by-mac and port-by-mac lookup, to check that the respective node and port exist. The port status received in the request body is saved to the port’s internal_info[\u0027network_status\u0027], and then process_event is triggered. On the conductor side, process_event will be doing ...\"\n\nBut, let\u0027s move it.","commit_id":"4b8dcd5c6f964df7294530b07b24851a80ac62ec"}]}
