)]}'
{"doc/source/admin/drivers/ilo.rst":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"56546c0c634e7df919ab29dc75e61fae5e2871bc","unresolved":false,"context_lines":[{"line_number":832,"context_line":"       (active and otherwise) NICs for Gen8 and Gen9 servers and ironic ports"},{"line_number":833,"context_line":"       are created for all of them. Inspection logs a warning if the node under"},{"line_number":834,"context_line":"       inspection is Gen8 or Gen9."},{"line_number":835,"context_line":"       Proliantutils release version 2.8.0 shall not be used as it might give"},{"line_number":836,"context_line":"       not give correct behaviour for NIC inspection for Gen9."},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"The operator can specify these capabilities in nova flavor for node to be selected"},{"line_number":839,"context_line":"for scheduling::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9fdfeff1_d2d9cb55","line":836,"range":{"start_line":835,"start_character":64,"end_line":836,"end_character":15},"updated":"2019-02-28 11:58:16.000000000","message":"double \"give\", how about. \"... as it might not provide the correct ...\"","commit_id":"4da5ce1b88573ac3e4890fd3550c7924430c9191"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"27455655a9fbf3cbebf7c7b5d30ac8fc50743475","unresolved":false,"context_lines":[{"line_number":832,"context_line":"       (active and otherwise) NICs for Gen8 and Gen9 servers and ironic ports"},{"line_number":833,"context_line":"       are created for all of them. Inspection logs a warning if the node under"},{"line_number":834,"context_line":"       inspection is Gen8 or Gen9."},{"line_number":835,"context_line":"       Proliantutils release version 2.8.0 shall not be used as it might give"},{"line_number":836,"context_line":"       not give correct behaviour for NIC inspection for Gen9."},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"The operator can specify these capabilities in nova flavor for node to be selected"},{"line_number":839,"context_line":"for scheduling::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9fdfeff1_084de498","line":836,"range":{"start_line":835,"start_character":64,"end_line":836,"end_character":15},"in_reply_to":"9fdfeff1_d2d9cb55","updated":"2019-02-28 13:46:08.000000000","message":"Done","commit_id":"4da5ce1b88573ac3e4890fd3550c7924430c9191"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8a47e2cd230573fe6754d704c47bd4e775f2a0a7","unresolved":false,"context_lines":[{"line_number":832,"context_line":"       (active and otherwise) NICs for Gen8 and Gen9 servers and ironic ports"},{"line_number":833,"context_line":"       are created for all of them. Inspection logs a warning if the node under"},{"line_number":834,"context_line":"       inspection is Gen8 or Gen9."},{"line_number":835,"context_line":"       Proliantutils release version 2.8.0 shall not be used as it might not"},{"line_number":836,"context_line":"       provide correct behaviour for NIC inspection for Gen9."},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"The operator can specify these capabilities in nova flavor for node to be selected"},{"line_number":839,"context_line":"for scheduling::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_c6ca5b18","line":836,"range":{"start_line":835,"start_character":7,"end_line":836,"end_character":61},"updated":"2019-03-01 05:15:18.000000000","message":"Not sure if we need this here as its a defect fix and should get covered in the Changelog of Proliantutils.","commit_id":"d6b2012fc3f2d427bed64d91840756e003f7adf9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8a47e2cd230573fe6754d704c47bd4e775f2a0a7","unresolved":false,"context_lines":[{"line_number":833,"context_line":"       are created for all of them. Inspection logs a warning if the node under"},{"line_number":834,"context_line":"       inspection is Gen8 or Gen9."},{"line_number":835,"context_line":"       Proliantutils release version 2.8.0 shall not be used as it might not"},{"line_number":836,"context_line":"       provide correct behaviour for NIC inspection for Gen9."},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"The operator can specify these capabilities in nova flavor for node to be selected"},{"line_number":839,"context_line":"for scheduling::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_a662b73c","line":836,"range":{"start_line":836,"start_character":23,"end_line":836,"end_character":32},"updated":"2019-03-01 05:15:18.000000000","message":"nit: s/ behaviour / behavior /","commit_id":"d6b2012fc3f2d427bed64d91840756e003f7adf9"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e8839c768e880c1a8d0436a203e578b13de3f5e7","unresolved":false,"context_lines":[{"line_number":832,"context_line":"       (active and otherwise) NICs for Gen8 and Gen9 servers and ironic ports"},{"line_number":833,"context_line":"       are created for all of them. Inspection logs a warning if the node under"},{"line_number":834,"context_line":"       inspection is Gen8 or Gen9."},{"line_number":835,"context_line":"       Proliantutils release version 2.8.0 shall not be used as it might not"},{"line_number":836,"context_line":"       provide correct behaviour for NIC inspection for Gen9."},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"The operator can specify these capabilities in nova flavor for node to be selected"},{"line_number":839,"context_line":"for scheduling::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fdfeff1_e18e69cf","line":836,"range":{"start_line":835,"start_character":7,"end_line":836,"end_character":61},"in_reply_to":"9fdfeff1_c6ca5b18","updated":"2019-03-01 07:33:54.000000000","message":"Ok I will remove the statement","commit_id":"d6b2012fc3f2d427bed64d91840756e003f7adf9"}],"ironic/drivers/modules/ilo/inspect.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"56546c0c634e7df919ab29dc75e61fae5e2871bc","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        # RIBCL(Gen8) protocol cannot determine if a NIC"},{"line_number":247,"context_line":"        # is physically connected with cable or not when the server"},{"line_number":248,"context_line":"        # is not provisioned. RIS(Gen9) can detect the same for few NIC"},{"line_number":249,"context_line":"        # Adapters but not for all. However it is possible to determine"},{"line_number":250,"context_line":"        # the same using Redfish(Gen10) protocol.  Hence proliantutils "},{"line_number":251,"context_line":"        # return ALL MACs for Gen8 and Gen9 while returns"},{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is been added"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_3264d7b8","line":249,"range":{"start_line":249,"start_character":10,"end_line":249,"end_character":18},"updated":"2019-02-28 11:58:16.000000000","message":"Nit: s/Adapters/adapters/","commit_id":"4da5ce1b88573ac3e4890fd3550c7924430c9191"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"27455655a9fbf3cbebf7c7b5d30ac8fc50743475","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        # RIBCL(Gen8) protocol cannot determine if a NIC"},{"line_number":247,"context_line":"        # is physically connected with cable or not when the server"},{"line_number":248,"context_line":"        # is not provisioned. RIS(Gen9) can detect the same for few NIC"},{"line_number":249,"context_line":"        # Adapters but not for all. However it is possible to determine"},{"line_number":250,"context_line":"        # the same using Redfish(Gen10) protocol.  Hence proliantutils "},{"line_number":251,"context_line":"        # return ALL MACs for Gen8 and Gen9 while returns"},{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is been added"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_08640421","line":249,"range":{"start_line":249,"start_character":10,"end_line":249,"end_character":18},"in_reply_to":"9fdfeff1_3264d7b8","updated":"2019-02-28 13:46:08.000000000","message":"Done","commit_id":"4da5ce1b88573ac3e4890fd3550c7924430c9191"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"56546c0c634e7df919ab29dc75e61fae5e2871bc","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # is physically connected with cable or not when the server"},{"line_number":248,"context_line":"        # is not provisioned. RIS(Gen9) can detect the same for few NIC"},{"line_number":249,"context_line":"        # Adapters but not for all. However it is possible to determine"},{"line_number":250,"context_line":"        # the same using Redfish(Gen10) protocol.  Hence proliantutils "},{"line_number":251,"context_line":"        # return ALL MACs for Gen8 and Gen9 while returns"},{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is been added"},{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_526abb80","line":250,"range":{"start_line":250,"start_character":49,"end_line":250,"end_character":51},"updated":"2019-02-28 11:58:16.000000000","message":"Nit: double space","commit_id":"4da5ce1b88573ac3e4890fd3550c7924430c9191"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"27455655a9fbf3cbebf7c7b5d30ac8fc50743475","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # is physically connected with cable or not when the server"},{"line_number":248,"context_line":"        # is not provisioned. RIS(Gen9) can detect the same for few NIC"},{"line_number":249,"context_line":"        # Adapters but not for all. However it is possible to determine"},{"line_number":250,"context_line":"        # the same using Redfish(Gen10) protocol.  Hence proliantutils "},{"line_number":251,"context_line":"        # return ALL MACs for Gen8 and Gen9 while returns"},{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is been added"},{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_28678827","line":250,"range":{"start_line":250,"start_character":49,"end_line":250,"end_character":51},"in_reply_to":"9fdfeff1_526abb80","updated":"2019-02-28 13:46:08.000000000","message":"Done","commit_id":"4da5ce1b88573ac3e4890fd3550c7924430c9191"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"56546c0c634e7df919ab29dc75e61fae5e2871bc","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        # is not provisioned. RIS(Gen9) can detect the same for few NIC"},{"line_number":249,"context_line":"        # Adapters but not for all. However it is possible to determine"},{"line_number":250,"context_line":"        # the same using Redfish(Gen10) protocol.  Hence proliantutils "},{"line_number":251,"context_line":"        # return ALL MACs for Gen8 and Gen9 while returns"},{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is been added"},{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_f20e4fe2","line":251,"range":{"start_line":251,"start_character":10,"end_line":251,"end_character":16},"updated":"2019-02-28 11:58:16.000000000","message":"Nit: \"return\" vs \"returns\" later in this line ... not sure if proliantutils is singular or plural either :)","commit_id":"4da5ce1b88573ac3e4890fd3550c7924430c9191"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"27455655a9fbf3cbebf7c7b5d30ac8fc50743475","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        # is not provisioned. RIS(Gen9) can detect the same for few NIC"},{"line_number":249,"context_line":"        # Adapters but not for all. However it is possible to determine"},{"line_number":250,"context_line":"        # the same using Redfish(Gen10) protocol.  Hence proliantutils "},{"line_number":251,"context_line":"        # return ALL MACs for Gen8 and Gen9 while returns"},{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is been added"},{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_487d2cb0","line":251,"range":{"start_line":251,"start_character":10,"end_line":251,"end_character":16},"in_reply_to":"9fdfeff1_f20e4fe2","updated":"2019-02-28 13:46:08.000000000","message":"proliantutils is a library name. Please check it here:\nhttps://github.com/openstack/proliantutils\n\nComments accepted.","commit_id":"4da5ce1b88573ac3e4890fd3550c7924430c9191"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"56546c0c634e7df919ab29dc75e61fae5e2871bc","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        # Adapters but not for all. However it is possible to determine"},{"line_number":250,"context_line":"        # the same using Redfish(Gen10) protocol.  Hence proliantutils "},{"line_number":251,"context_line":"        # return ALL MACs for Gen8 and Gen9 while returns"},{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is been added"},{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."},{"line_number":255,"context_line":"        if model is not None and (\u0027Gen8\u0027 in model or \u0027Gen9\u0027 in model):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d2246b62","line":252,"range":{"start_line":252,"start_character":48,"end_line":252,"end_character":55},"updated":"2019-02-28 11:58:16.000000000","message":"\"has been\"  (or \"is being\")","commit_id":"4da5ce1b88573ac3e4890fd3550c7924430c9191"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"27455655a9fbf3cbebf7c7b5d30ac8fc50743475","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        # Adapters but not for all. However it is possible to determine"},{"line_number":250,"context_line":"        # the same using Redfish(Gen10) protocol.  Hence proliantutils "},{"line_number":251,"context_line":"        # return ALL MACs for Gen8 and Gen9 while returns"},{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is been added"},{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."},{"line_number":255,"context_line":"        if model is not None and (\u0027Gen8\u0027 in model or \u0027Gen9\u0027 in model):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_687830c0","line":252,"range":{"start_line":252,"start_character":48,"end_line":252,"end_character":55},"in_reply_to":"9fdfeff1_d2246b62","updated":"2019-02-28 13:46:08.000000000","message":"Done","commit_id":"4da5ce1b88573ac3e4890fd3550c7924430c9191"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5c189af21ab2fc23ce0db86c6201646c3194e19a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # is physically connected with cable or not when the server"},{"line_number":248,"context_line":"        # is not provisioned. RIS(Gen9) can detect the same for few NIC"},{"line_number":249,"context_line":"        # adapters but not for all. However it is possible to determine"},{"line_number":250,"context_line":"        # the same using Redfish(Gen10) protocol.  Hence proliantutils"},{"line_number":251,"context_line":"        # returns ALL MACs for Gen8 and Gen9 while returns"},{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is being added"},{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_ab79322f","line":250,"range":{"start_line":250,"start_character":49,"end_line":250,"end_character":51},"updated":"2019-02-28 14:07:14.000000000","message":"Nit: double space","commit_id":"a907596a1c6250e4c8a6e2cf742666c180322376"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5c189af21ab2fc23ce0db86c6201646c3194e19a","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        # is not provisioned. RIS(Gen9) can detect the same for few NIC"},{"line_number":249,"context_line":"        # adapters but not for all. However it is possible to determine"},{"line_number":250,"context_line":"        # the same using Redfish(Gen10) protocol.  Hence proliantutils"},{"line_number":251,"context_line":"        # returns ALL MACs for Gen8 and Gen9 while returns"},{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is being added"},{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_eb989a69","line":251,"range":{"start_line":251,"start_character":50,"end_line":251,"end_character":51},"updated":"2019-02-28 14:07:14.000000000","message":"I suggest: \"... while it returns ..\"","commit_id":"a907596a1c6250e4c8a6e2cf742666c180322376"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8a47e2cd230573fe6754d704c47bd4e775f2a0a7","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is being added"},{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."},{"line_number":255,"context_line":"        if model is not None and (\u0027Gen8\u0027 in model or \u0027Gen9\u0027 in model):"},{"line_number":256,"context_line":"            LOG.warning(\u0027iLO cannot determine if the NICs are physically \u0027"},{"line_number":257,"context_line":"                        \u0027connected or not for ProLiant Gen8 and Gen9 servers. \u0027"},{"line_number":258,"context_line":"                        \u0027Hence returns all the MACs present on the server. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_4623cb05","line":255,"range":{"start_line":255,"start_character":33,"end_line":255,"end_character":69},"updated":"2019-03-01 05:15:18.000000000","message":"nit: May be this can be :\n\nservers \u003d [ \u0027Gen8\u0027, \u0027Gen9\u0027]\nif model is not None and any(serv in model for serv in servers):\n    ...","commit_id":"d6b2012fc3f2d427bed64d91840756e003f7adf9"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e8839c768e880c1a8d0436a203e578b13de3f5e7","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        # only active MACs for Gen10. A warning is being added"},{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."},{"line_number":255,"context_line":"        if model is not None and (\u0027Gen8\u0027 in model or \u0027Gen9\u0027 in model):"},{"line_number":256,"context_line":"            LOG.warning(\u0027iLO cannot determine if the NICs are physically \u0027"},{"line_number":257,"context_line":"                        \u0027connected or not for ProLiant Gen8 and Gen9 servers. \u0027"},{"line_number":258,"context_line":"                        \u0027Hence returns all the MACs present on the server. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_c55fb00c","line":255,"range":{"start_line":255,"start_character":33,"end_line":255,"end_character":69},"in_reply_to":"9fdfeff1_4623cb05","updated":"2019-03-01 07:33:54.000000000","message":"Done","commit_id":"d6b2012fc3f2d427bed64d91840756e003f7adf9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"971869eb0a70bfc9b4f2fffc5df3e2b985265b7c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."},{"line_number":255,"context_line":"        servers \u003d [\u0027Gen8\u0027, \u0027Gen9\u0027]"},{"line_number":256,"context_line":"        if model is not None and any(serv in model for serv in servers):"},{"line_number":257,"context_line":"            LOG.warning(\u0027iLO cannot determine if the NICs are physically \u0027"},{"line_number":258,"context_line":"                        \u0027connected or not for ProLiant Gen8 and Gen9 servers. \u0027"},{"line_number":259,"context_line":"                        \u0027Hence returns all the MACs present on the server. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_4e440f48","line":256,"updated":"2019-03-04 17:15:08.000000000","message":"Still, I think it\u0027s an overkill. Not blocking on it though.","commit_id":"51b67c44167209217ae1eb6b1af702212391bbb2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aa2114b911dbc8c1d02fb7aafa3bba2e5120608e","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."},{"line_number":255,"context_line":"        servers \u003d [\u0027Gen8\u0027, \u0027Gen9\u0027]"},{"line_number":256,"context_line":"        if model is not None and any(serv in model for serv in servers):"},{"line_number":257,"context_line":"            LOG.warning(\u0027iLO cannot determine if the NICs are physically \u0027"},{"line_number":258,"context_line":"                        \u0027connected or not for ProLiant Gen8 and Gen9 servers. \u0027"},{"line_number":259,"context_line":"                        \u0027Hence returns all the MACs present on the server. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_03fa6742","line":256,"updated":"2019-03-04 14:05:47.000000000","message":"nit: let\u0027s not overcomplicate it: \u0027Gen8\u0027 in model or \u0027Gen9\u0027 in model","commit_id":"51b67c44167209217ae1eb6b1af702212391bbb2"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"603848bc68b800e6e5db66a34ffd4c1b8e31109e","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."},{"line_number":255,"context_line":"        servers \u003d [\u0027Gen8\u0027, \u0027Gen9\u0027]"},{"line_number":256,"context_line":"        if model is not None and any(serv in model for serv in servers):"},{"line_number":257,"context_line":"            LOG.warning(\u0027iLO cannot determine if the NICs are physically \u0027"},{"line_number":258,"context_line":"                        \u0027connected or not for ProLiant Gen8 and Gen9 servers. \u0027"},{"line_number":259,"context_line":"                        \u0027Hence returns all the MACs present on the server. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_8b82e9a4","line":256,"in_reply_to":"9fdfeff1_03fa6742","updated":"2019-03-04 17:07:12.000000000","message":":) the same was there in patchset 3 :). I addressed as part of Shiv\u0027s comment.","commit_id":"51b67c44167209217ae1eb6b1af702212391bbb2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7b356781ffd134500778a292a85d2dadfb2c2f18","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # for the user so that he knows that he needs to remove the"},{"line_number":254,"context_line":"        # ironic ports created for inactive ports for Gen8 and Gen9."},{"line_number":255,"context_line":"        servers \u003d [\u0027Gen8\u0027, \u0027Gen9\u0027]"},{"line_number":256,"context_line":"        if model is not None and any(serv in model for serv in servers):"},{"line_number":257,"context_line":"            LOG.warning(\u0027iLO cannot determine if the NICs are physically \u0027"},{"line_number":258,"context_line":"                        \u0027connected or not for ProLiant Gen8 and Gen9 servers. \u0027"},{"line_number":259,"context_line":"                        \u0027Hence returns all the MACs present on the server. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_08ba72bf","line":256,"in_reply_to":"9fdfeff1_4e440f48","updated":"2019-03-05 03:50:59.000000000","message":"Upon second thought, I think you are right.","commit_id":"51b67c44167209217ae1eb6b1af702212391bbb2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"971869eb0a70bfc9b4f2fffc5df3e2b985265b7c","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        servers \u003d [\u0027Gen8\u0027, \u0027Gen9\u0027]"},{"line_number":256,"context_line":"        if model is not None and any(serv in model for serv in servers):"},{"line_number":257,"context_line":"            LOG.warning(\u0027iLO cannot determine if the NICs are physically \u0027"},{"line_number":258,"context_line":"                        \u0027connected or not for ProLiant Gen8 and Gen9 servers. \u0027"},{"line_number":259,"context_line":"                        \u0027Hence returns all the MACs present on the server. \u0027"},{"line_number":260,"context_line":"                        \u0027Please remove the ironic ports created for inactive \u0027"},{"line_number":261,"context_line":"                        \u0027NICs manually for the node %(node)\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_ee72a3b0","line":258,"updated":"2019-03-04 17:15:08.000000000","message":"now that you have \"servers\",  you have to do \u0027 and \u0027.join(servers) here :)\n\nI\u0027m joking, please don\u0027t do it :)","commit_id":"51b67c44167209217ae1eb6b1af702212391bbb2"}]}