)]}'
{"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"aee3730bef2f9940408f0d0a9c42bd3b3148f5e7","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            return mapping"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        uuids \u003d {i for i in idents if uuidutils.is_uuid_like(i)}"},{"line_number":410,"context_line":"        names \u003d {i for i in idents if not uuidutils.is_uuid_like(i)"},{"line_number":411,"context_line":"                 and utils.is_valid_logical_name(i)}"},{"line_number":412,"context_line":"        missing \u003d idents - set(uuids) - set(names)"},{"line_number":413,"context_line":"        if missing:"},{"line_number":414,"context_line":"            # Such nodes cannot exist, bailing out early"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_7e9299a0","line":411,"range":{"start_line":410,"start_character":38,"end_line":411,"end_character":51},"updated":"2019-03-11 07:13:36.000000000","message":"we have a handy helper is_valid_node_name()","commit_id":"885bfbda969f2cceeb6f5ac2c05461c86c6b5dbf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e4e1c26abd7d0a83287f59f910b695095de214a9","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            return mapping"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        uuids \u003d {i for i in idents if uuidutils.is_uuid_like(i)}"},{"line_number":410,"context_line":"        names \u003d {i for i in idents if not uuidutils.is_uuid_like(i)"},{"line_number":411,"context_line":"                 and utils.is_valid_logical_name(i)}"},{"line_number":412,"context_line":"        missing \u003d idents - set(uuids) - set(names)"},{"line_number":413,"context_line":"        if missing:"},{"line_number":414,"context_line":"            # Such nodes cannot exist, bailing out early"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_f5030772","line":411,"range":{"start_line":410,"start_character":38,"end_line":411,"end_character":51},"in_reply_to":"5fc1f717_7e9299a0","updated":"2019-03-11 09:47:34.000000000","message":"If you mean https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/utils.py#L349, it relies on pecan.request, which doesn\u0027t have to be available in the database context.","commit_id":"885bfbda969f2cceeb6f5ac2c05461c86c6b5dbf"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"5b9af9f9294dc0e9b851d320323ff09b63d4deac","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            return mapping"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        uuids \u003d {i for i in idents if uuidutils.is_uuid_like(i)}"},{"line_number":410,"context_line":"        names \u003d {i for i in idents if not uuidutils.is_uuid_like(i)"},{"line_number":411,"context_line":"                 and utils.is_valid_logical_name(i)}"},{"line_number":412,"context_line":"        missing \u003d idents - set(uuids) - set(names)"},{"line_number":413,"context_line":"        if missing:"},{"line_number":414,"context_line":"            # Such nodes cannot exist, bailing out early"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_0b85505a","line":411,"range":{"start_line":410,"start_character":38,"end_line":411,"end_character":51},"in_reply_to":"5fc1f717_f5030772","updated":"2019-03-11 10:54:39.000000000","message":"ack, indeed.","commit_id":"885bfbda969f2cceeb6f5ac2c05461c86c6b5dbf"}]}
