)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":1800,"context_line":"            if rpc_node[field] !\u003d patch_val:"},{"line_number":1801,"context_line":"                rpc_node[field] \u003d patch_val"},{"line_number":1802,"context_line":""},{"line_number":1803,"context_line":"    def _check_driver_changed_and_console_enabled(self, rpc_node, node_ident):"},{"line_number":1804,"context_line":"        \"\"\"Checks if the driver and the console is enabled in a node."},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"        If it does, is necessary to prevent updating it because the new driver"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_872483b0","line":1803,"updated":"2019-03-14 16:34:33.000000000","message":"should we modify this to check also for the graphical console or add a new method ?","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"02dfb82900bf440888d639ad9d3655e86256b0c0","unresolved":false,"context_lines":[{"line_number":1800,"context_line":"            if rpc_node[field] !\u003d patch_val:"},{"line_number":1801,"context_line":"                rpc_node[field] \u003d patch_val"},{"line_number":1802,"context_line":""},{"line_number":1803,"context_line":"    def _check_driver_changed_and_console_enabled(self, rpc_node, node_ident):"},{"line_number":1804,"context_line":"        \"\"\"Checks if the driver and the console is enabled in a node."},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"        If it does, is necessary to prevent updating it because the new driver"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_571abfcb","line":1803,"in_reply_to":"5fc1f717_872483b0","updated":"2019-03-26 19:41:19.000000000","message":"Yes, i missed it. I would add the graphical console check also here.","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1e0668be2ddf4e43e288c9739143f71a73b44a47","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        :param node_ident: UUID or logical name of a node."},{"line_number":342,"context_line":"        :param console_type: Type of console: serial or graphical"},{"line_number":343,"context_line":"        :raises InvalidParameterValue if console type is given other than"},{"line_number":344,"context_line":"            \u0027graphical\u0027 or \u0027serial\u0027."},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_ed38b8d3","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":15},"updated":"2019-03-27 10:21:44.000000000","message":"need to be ``:raises:`` or tox docs test fails","commit_id":"bfc9d84584172eb55ef696fb01d927fd7103aa81"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1e0668be2ddf4e43e288c9739143f71a73b44a47","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        :param enabled: Boolean value; whether to enable or disable the"},{"line_number":376,"context_line":"                console."},{"line_number":377,"context_line":"        :param console_type: Type of console: serial or graphical"},{"line_number":378,"context_line":"        :raises InvalidParameterValue if console type is given other than"},{"line_number":379,"context_line":"            \u0027graphical\u0027 or \u0027serial\u0027."},{"line_number":380,"context_line":"        \"\"\""},{"line_number":381,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_8d3334f6","line":378,"updated":"2019-03-27 10:21:44.000000000","message":"ditto","commit_id":"bfc9d84584172eb55ef696fb01d927fd7103aa81"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c7340c7054cca9d87664e577fbeb286b12322d01","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":347,"context_line":"        policy.authorize(\u0027baremetal:node:get_console\u0027, cdict, cdict)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        if console_type !\u003d \u0027serial\u0027 and console_type !\u003d \u0027graphical\u0027:"},{"line_number":350,"context_line":"            msg \u003d (\u0027Invalid console type. Allowed console types are \u0027"},{"line_number":351,"context_line":"                   \u0027either serial or graphical. The console type given \u0027"},{"line_number":352,"context_line":"                   \u0027is %(console_type)s\u0027 % {\u0027console_type\u0027: console_type})"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_42d18422","line":349,"updated":"2019-03-28 08:40:53.000000000","message":"Optional but can be re-written as::\n\n  if console_type not in (\u0027serial\u0027, \u0027graphical\u0027):","commit_id":"5425ce6b1cfee3f47be1024a45f480c575bad773"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"04c598743360f630083e63fb59f325a7c6d71d90","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":347,"context_line":"        policy.authorize(\u0027baremetal:node:get_console\u0027, cdict, cdict)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        if console_type !\u003d \u0027serial\u0027 and console_type !\u003d \u0027graphical\u0027:"},{"line_number":350,"context_line":"            msg \u003d (\u0027Invalid console type. Allowed console types are \u0027"},{"line_number":351,"context_line":"                   \u0027either serial or graphical. The console type given \u0027"},{"line_number":352,"context_line":"                   \u0027is %(console_type)s\u0027 % {\u0027console_type\u0027: console_type})"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_679cc50d","line":349,"in_reply_to":"5fc1f717_42d18422","updated":"2019-03-28 17:25:15.000000000","message":":) true. i will do it in next patchset","commit_id":"5425ce6b1cfee3f47be1024a45f480c575bad773"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c7340c7054cca9d87664e577fbeb286b12322d01","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":382,"context_line":"        policy.authorize(\u0027baremetal:node:set_console_state\u0027, cdict, cdict)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        if console_type !\u003d \u0027serial\u0027 and console_type !\u003d \u0027graphical\u0027:"},{"line_number":385,"context_line":"            msg \u003d (\u0027Invalid console type. Allowed console types are \u0027"},{"line_number":386,"context_line":"                   \u0027either serial or graphical. The console type given \u0027"},{"line_number":387,"context_line":"                   \u0027is %(console_type)s\u0027 % {\u0027console_type\u0027: console_type})"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_62ccc088","line":384,"updated":"2019-03-28 08:40:53.000000000","message":"Ditto","commit_id":"5425ce6b1cfee3f47be1024a45f480c575bad773"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"04c598743360f630083e63fb59f325a7c6d71d90","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":382,"context_line":"        policy.authorize(\u0027baremetal:node:set_console_state\u0027, cdict, cdict)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        if console_type !\u003d \u0027serial\u0027 and console_type !\u003d \u0027graphical\u0027:"},{"line_number":385,"context_line":"            msg \u003d (\u0027Invalid console type. Allowed console types are \u0027"},{"line_number":386,"context_line":"                   \u0027either serial or graphical. The console type given \u0027"},{"line_number":387,"context_line":"                   \u0027is %(console_type)s\u0027 % {\u0027console_type\u0027: console_type})"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_879f7100","line":384,"in_reply_to":"5fc1f717_62ccc088","updated":"2019-03-28 17:25:15.000000000","message":"ditto as above","commit_id":"5425ce6b1cfee3f47be1024a45f480c575bad773"}],"ironic/conductor/manager.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":993,"context_line":"                # rescuing network as well."},{"line_number":994,"context_line":"                task.driver.rescue.clean_up(task)"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"            # stop the console"},{"line_number":997,"context_line":"            # do it in this thread since we\u0027re already out of the main"},{"line_number":998,"context_line":"            # conductor thread."},{"line_number":999,"context_line":"            if node.console_enabled:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_a732df0e","line":996,"updated":"2019-03-14 16:34:33.000000000","message":"I think we should stop all the consoles here","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"02dfb82900bf440888d639ad9d3655e86256b0c0","unresolved":false,"context_lines":[{"line_number":993,"context_line":"                # rescuing network as well."},{"line_number":994,"context_line":"                task.driver.rescue.clean_up(task)"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"            # stop the console"},{"line_number":997,"context_line":"            # do it in this thread since we\u0027re already out of the main"},{"line_number":998,"context_line":"            # conductor thread."},{"line_number":999,"context_line":"            if node.console_enabled:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_971b47c8","line":996,"in_reply_to":"5fc1f717_a732df0e","updated":"2019-03-26 19:41:19.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"                notify_utils.emit_console_notification("},{"line_number":2072,"context_line":"                    task, \u0027console_restore\u0027, fields.NotificationStatus.END)"},{"line_number":2073,"context_line":"        if task.node.graphical_console_enabled:"},{"line_number":2074,"context_line":"            notify_utils.emit_console_notification("},{"line_number":2075,"context_line":"                task, \u0027console_restore\u0027, fields.NotificationStatus.START)"},{"line_number":2076,"context_line":"            try:"},{"line_number":2077,"context_line":"                task.driver.graphical_console.start_console(task)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_22401da5","line":2074,"updated":"2019-03-14 16:34:33.000000000","message":"Wondering if it would make sense to modify the emit_console_notification method to accept console_type.\nIt may reduce code repetition in some cases.","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"                notify_utils.emit_console_notification("},{"line_number":2072,"context_line":"                    task, \u0027console_restore\u0027, fields.NotificationStatus.END)"},{"line_number":2073,"context_line":"        if task.node.graphical_console_enabled:"},{"line_number":2074,"context_line":"            notify_utils.emit_console_notification("},{"line_number":2075,"context_line":"                task, \u0027console_restore\u0027, fields.NotificationStatus.START)"},{"line_number":2076,"context_line":"            try:"},{"line_number":2077,"context_line":"                task.driver.graphical_console.start_console(task)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_fda4f84c","line":2074,"in_reply_to":"5fc1f717_22401da5","updated":"2019-03-27 05:45:17.000000000","message":"I have handled the code repitition in another way.","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2076,"context_line":"            try:"},{"line_number":2077,"context_line":"                task.driver.graphical_console.start_console(task)"},{"line_number":2078,"context_line":"            except Exception as err:"},{"line_number":2079,"context_line":"                msg \u003d (_(\u0027Failed to start console while taking over the \u0027"},{"line_number":2080,"context_line":"                         \u0027node %(node)s: %(err)s.\u0027) % {\u0027node\u0027: task.node.uuid,"},{"line_number":2081,"context_line":"                                                       \u0027err\u0027: err})"},{"line_number":2082,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_e7bc6707","line":2079,"range":{"start_line":2079,"start_character":42,"end_line":2079,"end_character":49},"updated":"2019-03-14 16:34:33.000000000","message":"nit: graphical console","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2076,"context_line":"            try:"},{"line_number":2077,"context_line":"                task.driver.graphical_console.start_console(task)"},{"line_number":2078,"context_line":"            except Exception as err:"},{"line_number":2079,"context_line":"                msg \u003d (_(\u0027Failed to start console while taking over the \u0027"},{"line_number":2080,"context_line":"                         \u0027node %(node)s: %(err)s.\u0027) % {\u0027node\u0027: task.node.uuid,"},{"line_number":2081,"context_line":"                                                       \u0027err\u0027: err})"},{"line_number":2082,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_ca528767","line":2079,"range":{"start_line":2079,"start_character":42,"end_line":2079,"end_character":49},"in_reply_to":"5fc1f717_e7bc6707","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2080,"context_line":"                         \u0027node %(node)s: %(err)s.\u0027) % {\u0027node\u0027: task.node.uuid,"},{"line_number":2081,"context_line":"                                                       \u0027err\u0027: err})"},{"line_number":2082,"context_line":"                LOG.error(msg)"},{"line_number":2083,"context_line":"                # If taking over console failed, set node\u0027s console_enabled"},{"line_number":2084,"context_line":"                # back to False and set node\u0027s last error."},{"line_number":2085,"context_line":"                task.node.last_error \u003d msg"},{"line_number":2086,"context_line":"                task.node.graphical_console_enabled \u003d False"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_87f563ef","line":2083,"range":{"start_line":2083,"start_character":60,"end_line":2083,"end_character":75},"updated":"2019-03-14 16:34:33.000000000","message":"nit: graphical_console_enabled","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2080,"context_line":"                         \u0027node %(node)s: %(err)s.\u0027) % {\u0027node\u0027: task.node.uuid,"},{"line_number":2081,"context_line":"                                                       \u0027err\u0027: err})"},{"line_number":2082,"context_line":"                LOG.error(msg)"},{"line_number":2083,"context_line":"                # If taking over console failed, set node\u0027s console_enabled"},{"line_number":2084,"context_line":"                # back to False and set node\u0027s last error."},{"line_number":2085,"context_line":"                task.node.last_error \u003d msg"},{"line_number":2086,"context_line":"                task.node.graphical_console_enabled \u003d False"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_6a4d93c2","line":2083,"range":{"start_line":2083,"start_character":60,"end_line":2083,"end_character":75},"in_reply_to":"5fc1f717_87f563ef","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2217,"context_line":"                                              task.node.instance_info)"},{"line_number":2218,"context_line":"            task.node.driver_internal_info[\u0027is_whole_disk_image\u0027] \u003d iwdi"},{"line_number":2219,"context_line":"            for iface_name in task.driver.non_vendor_interfaces:"},{"line_number":2220,"context_line":"                # TODO(mkrai): Remove this check in \u0027graphical_console\u0027 API"},{"line_number":2221,"context_line":"                # patch. Do not have to return the validation result for"},{"line_number":2222,"context_line":"                # \u0027graphical_console\u0027 interface."},{"line_number":2223,"context_line":"                if iface_name \u003d\u003d \u0027graphical_console\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_223d7dc3","line":2220,"updated":"2019-03-14 16:34:33.000000000","message":"remember to remove this","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2217,"context_line":"                                              task.node.instance_info)"},{"line_number":2218,"context_line":"            task.node.driver_internal_info[\u0027is_whole_disk_image\u0027] \u003d iwdi"},{"line_number":2219,"context_line":"            for iface_name in task.driver.non_vendor_interfaces:"},{"line_number":2220,"context_line":"                # TODO(mkrai): Remove this check in \u0027graphical_console\u0027 API"},{"line_number":2221,"context_line":"                # patch. Do not have to return the validation result for"},{"line_number":2222,"context_line":"                # \u0027graphical_console\u0027 interface."},{"line_number":2223,"context_line":"                if iface_name \u003d\u003d \u0027graphical_console\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_2ac9cb24","line":2220,"in_reply_to":"5fc1f717_223d7dc3","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2320,"context_line":"                    node.console_enabled \u003d False"},{"line_number":2321,"context_line":"                    notify_utils.emit_console_notification("},{"line_number":2322,"context_line":"                        task, \u0027console_set\u0027, fields.NotificationStatus.END)"},{"line_number":2323,"context_line":"            if node.graphical_console_enabled:"},{"line_number":2324,"context_line":"                notify_utils.emit_console_notification("},{"line_number":2325,"context_line":"                    task, \u0027console_set\u0027, fields.NotificationStatus.START)"},{"line_number":2326,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_02fde1af","line":2323,"updated":"2019-03-14 16:34:33.000000000","message":"maybe there\u0027s a way to avoid this much code repetition ?","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2320,"context_line":"                    node.console_enabled \u003d False"},{"line_number":2321,"context_line":"                    notify_utils.emit_console_notification("},{"line_number":2322,"context_line":"                        task, \u0027console_set\u0027, fields.NotificationStatus.END)"},{"line_number":2323,"context_line":"            if node.graphical_console_enabled:"},{"line_number":2324,"context_line":"                notify_utils.emit_console_notification("},{"line_number":2325,"context_line":"                    task, \u0027console_set\u0027, fields.NotificationStatus.START)"},{"line_number":2326,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_4acc5734","line":2323,"in_reply_to":"5fc1f717_02fde1af","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2326,"context_line":"                try:"},{"line_number":2327,"context_line":"                    task.driver.graphical_console.stop_console(task)"},{"line_number":2328,"context_line":"                except Exception as err:"},{"line_number":2329,"context_line":"                    LOG.error(\u0027Failed to stop console while deleting \u0027"},{"line_number":2330,"context_line":"                              \u0027the node %(node)s: %(err)s.\u0027,"},{"line_number":2331,"context_line":"                              {\u0027node\u0027: node.uuid, \u0027err\u0027: err})"},{"line_number":2332,"context_line":"                    notify_utils.emit_console_notification("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_6732b760","line":2329,"range":{"start_line":2329,"start_character":46,"end_line":2329,"end_character":53},"updated":"2019-03-14 16:34:33.000000000","message":"nit: graphical console","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2326,"context_line":"                try:"},{"line_number":2327,"context_line":"                    task.driver.graphical_console.stop_console(task)"},{"line_number":2328,"context_line":"                except Exception as err:"},{"line_number":2329,"context_line":"                    LOG.error(\u0027Failed to stop console while deleting \u0027"},{"line_number":2330,"context_line":"                              \u0027the node %(node)s: %(err)s.\u0027,"},{"line_number":2331,"context_line":"                              {\u0027node\u0027: node.uuid, \u0027err\u0027: err})"},{"line_number":2332,"context_line":"                    notify_utils.emit_console_notification("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_eace632b","line":2329,"range":{"start_line":2329,"start_character":46,"end_line":2329,"end_character":53},"in_reply_to":"5fc1f717_6732b760","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2471,"context_line":""},{"line_number":2472,"context_line":"        :param context: request context."},{"line_number":2473,"context_line":"        :param node_id: node id or uuid."},{"line_number":2474,"context_line":"        :raises: UnsupportedDriverExtension if the node\u0027s driver doesn\u0027t"},{"line_number":2475,"context_line":"                 support console."},{"line_number":2476,"context_line":"        :raises: NodeConsoleNotEnabled if the console is not enabled."},{"line_number":2477,"context_line":"        :raises: InvalidParameterValue when the wrong driver info is specified."}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_e7e1c79c","line":2474,"updated":"2019-03-14 16:34:33.000000000","message":"missing param console_type","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2471,"context_line":""},{"line_number":2472,"context_line":"        :param context: request context."},{"line_number":2473,"context_line":"        :param node_id: node id or uuid."},{"line_number":2474,"context_line":"        :raises: UnsupportedDriverExtension if the node\u0027s driver doesn\u0027t"},{"line_number":2475,"context_line":"                 support console."},{"line_number":2476,"context_line":"        :raises: NodeConsoleNotEnabled if the console is not enabled."},{"line_number":2477,"context_line":"        :raises: InvalidParameterValue when the wrong driver info is specified."}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_0ad2cfd1","line":2474,"in_reply_to":"5fc1f717_e7e1c79c","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"            if (not node.console_enabled and"},{"line_number":2490,"context_line":"                (console_type \u003d\u003d \u0027serial\u0027 or console_type is None)):"},{"line_number":2491,"context_line":"                raise exception.NodeConsoleNotEnabled(node\u003dnode.uuid)"},{"line_number":2492,"context_line":"            if (not node.graphical_console_enabled and"},{"line_number":2493,"context_line":"                console_type \u003d\u003d \u0027graphical\u0027):"},{"line_number":2494,"context_line":"                raise exception.NodeConsoleNotEnabled(node\u003dnode.uuid)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_47877bb6","line":2491,"updated":"2019-03-14 16:34:33.000000000","message":"just thinking if we should maybe modify the exception to accept the type of console and report it","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"            if (not node.console_enabled and"},{"line_number":2490,"context_line":"                (console_type \u003d\u003d \u0027serial\u0027 or console_type is None)):"},{"line_number":2491,"context_line":"                raise exception.NodeConsoleNotEnabled(node\u003dnode.uuid)"},{"line_number":2492,"context_line":"            if (not node.graphical_console_enabled and"},{"line_number":2493,"context_line":"                console_type \u003d\u003d \u0027graphical\u0027):"},{"line_number":2494,"context_line":"                raise exception.NodeConsoleNotEnabled(node\u003dnode.uuid)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_aadcdbe3","line":2491,"in_reply_to":"5fc1f717_47877bb6","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2514,"context_line":"        :param node_id: node id or uuid."},{"line_number":2515,"context_line":"        :param enabled: Boolean value; whether the console is enabled or"},{"line_number":2516,"context_line":"                        disabled."},{"line_number":2517,"context_line":"        :raises: UnsupportedDriverExtension if the node\u0027s driver doesn\u0027t"},{"line_number":2518,"context_line":"                 support console."},{"line_number":2519,"context_line":"        :raises: InvalidParameterValue when the wrong driver info is specified."},{"line_number":2520,"context_line":"        :raises: MissingParameterValue if missing supplied info."}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_67b5d77d","line":2517,"updated":"2019-03-14 16:34:33.000000000","message":"missing param console_type","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2514,"context_line":"        :param node_id: node id or uuid."},{"line_number":2515,"context_line":"        :param enabled: Boolean value; whether the console is enabled or"},{"line_number":2516,"context_line":"                        disabled."},{"line_number":2517,"context_line":"        :raises: UnsupportedDriverExtension if the node\u0027s driver doesn\u0027t"},{"line_number":2518,"context_line":"                 support console."},{"line_number":2519,"context_line":"        :raises: InvalidParameterValue when the wrong driver info is specified."},{"line_number":2520,"context_line":"        :raises: MissingParameterValue if missing supplied info."}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_cad7e7be","line":2517,"in_reply_to":"5fc1f717_67b5d77d","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2530,"context_line":"        with task_manager.acquire(context, node_id, shared\u003dFalse,"},{"line_number":2531,"context_line":"                                  purpose\u003d\u0027setting console mode\u0027) as task:"},{"line_number":2532,"context_line":"            node \u003d task.node"},{"line_number":2533,"context_line":"            if console_type \u003d\u003d \u0027graphical\u0027:"},{"line_number":2534,"context_line":"                task.driver.graphical_console.validate(task)"},{"line_number":2535,"context_line":"                if enabled \u003d\u003d node.graphical_console_enabled:"},{"line_number":2536,"context_line":"                    op \u003d \u0027enabled\u0027 if enabled else \u0027disabled\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_c290394d","line":2533,"updated":"2019-03-14 16:34:33.000000000","message":"maybe add a check to verify that console_type is either graphical or serial","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2530,"context_line":"        with task_manager.acquire(context, node_id, shared\u003dFalse,"},{"line_number":2531,"context_line":"                                  purpose\u003d\u0027setting console mode\u0027) as task:"},{"line_number":2532,"context_line":"            node \u003d task.node"},{"line_number":2533,"context_line":"            if console_type \u003d\u003d \u0027graphical\u0027:"},{"line_number":2534,"context_line":"                task.driver.graphical_console.validate(task)"},{"line_number":2535,"context_line":"                if enabled \u003d\u003d node.graphical_console_enabled:"},{"line_number":2536,"context_line":"                    op \u003d \u0027enabled\u0027 if enabled else \u0027disabled\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_8add5fde","line":2533,"in_reply_to":"5fc1f717_c290394d","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2579,"context_line":"        except Exception as e:"},{"line_number":2580,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2581,"context_line":"                op \u003d _(\u0027enabling\u0027) if enabled else _(\u0027disabling\u0027)"},{"line_number":2582,"context_line":"                msg \u003d (_(\u0027Error %(op)s the console on node %(node)s. \u0027"},{"line_number":2583,"context_line":"                         \u0027Reason: %(error)s\u0027) % {\u0027op\u0027: op,"},{"line_number":2584,"context_line":"                                                 \u0027node\u0027: node.uuid,"},{"line_number":2585,"context_line":"                                                 \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_829b1164","line":2582,"updated":"2019-03-14 16:34:33.000000000","message":"I would modify the message to include the console_type parameter","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2579,"context_line":"        except Exception as e:"},{"line_number":2580,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2581,"context_line":"                op \u003d _(\u0027enabling\u0027) if enabled else _(\u0027disabling\u0027)"},{"line_number":2582,"context_line":"                msg \u003d (_(\u0027Error %(op)s the console on node %(node)s. \u0027"},{"line_number":2583,"context_line":"                         \u0027Reason: %(error)s\u0027) % {\u0027op\u0027: op,"},{"line_number":2584,"context_line":"                                                 \u0027node\u0027: node.uuid,"},{"line_number":2585,"context_line":"                                                 \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_0aebaf77","line":2582,"in_reply_to":"5fc1f717_829b1164","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":2594,"context_line":"        else:"},{"line_number":2595,"context_line":"            node.console_enabled \u003d enabled"},{"line_number":2596,"context_line":""},{"line_number":2597,"context_line":"        node.console_enabled \u003d enabled"},{"line_number":2598,"context_line":"        node.last_error \u003d None"},{"line_number":2599,"context_line":"        node.save()"},{"line_number":2600,"context_line":"        notify_utils.emit_console_notification("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_c2bef9b2","line":2597,"updated":"2019-03-14 16:34:33.000000000","message":"this line should be removed","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"00ba7b3f71cb7e1a1a3633b81265c964f871950c","unresolved":false,"context_lines":[{"line_number":2594,"context_line":"        else:"},{"line_number":2595,"context_line":"            node.console_enabled \u003d enabled"},{"line_number":2596,"context_line":""},{"line_number":2597,"context_line":"        node.console_enabled \u003d enabled"},{"line_number":2598,"context_line":"        node.last_error \u003d None"},{"line_number":2599,"context_line":"        node.save()"},{"line_number":2600,"context_line":"        notify_utils.emit_console_notification("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_aa05bb47","line":2597,"in_reply_to":"5fc1f717_c2bef9b2","updated":"2019-03-27 05:45:17.000000000","message":"Done","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":3958,"context_line":"             {\u0027node\u0027: node.uuid, \u0027instance\u0027: node.instance_uuid})"},{"line_number":3959,"context_line":""},{"line_number":3960,"context_line":""},{"line_number":3961,"context_line":"def _start_console_in_deploy(task):"},{"line_number":3962,"context_line":"    \"\"\"Start console at the end of deployment."},{"line_number":3963,"context_line":""},{"line_number":3964,"context_line":"    Console is stopped at tearing down not to be exposed to an instance user."}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_02d5e1e4","line":3961,"updated":"2019-03-14 16:34:33.000000000","message":"should we extend this method to  accept a console_type parameter or add another one for graphical_console maybe ?","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c7340c7054cca9d87664e577fbeb286b12322d01","unresolved":false,"context_lines":[{"line_number":2562,"context_line":"                task.driver.console.validate(task)"},{"line_number":2563,"context_line":"                if enabled \u003d\u003d node.console_enabled:"},{"line_number":2564,"context_line":"                    op \u003d \u0027enabled\u0027 if enabled else \u0027disabled\u0027"},{"line_number":2565,"context_line":"                    LOG.info(\"No console action was triggered because the \""},{"line_number":2566,"context_line":"                             \"console is already %s\", op)"},{"line_number":2567,"context_line":"                else:"},{"line_number":2568,"context_line":"                    node.last_error \u003d None"},{"line_number":2569,"context_line":"                    node.save()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_c2ded40f","line":2566,"range":{"start_line":2565,"start_character":30,"end_line":2566,"end_character":51},"updated":"2019-03-28 08:40:53.000000000","message":"Can we specify \"serial\" in the message?","commit_id":"5425ce6b1cfee3f47be1024a45f480c575bad773"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"04c598743360f630083e63fb59f325a7c6d71d90","unresolved":false,"context_lines":[{"line_number":2562,"context_line":"                task.driver.console.validate(task)"},{"line_number":2563,"context_line":"                if enabled \u003d\u003d node.console_enabled:"},{"line_number":2564,"context_line":"                    op \u003d \u0027enabled\u0027 if enabled else \u0027disabled\u0027"},{"line_number":2565,"context_line":"                    LOG.info(\"No console action was triggered because the \""},{"line_number":2566,"context_line":"                             \"console is already %s\", op)"},{"line_number":2567,"context_line":"                else:"},{"line_number":2568,"context_line":"                    node.last_error \u003d None"},{"line_number":2569,"context_line":"                    node.save()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_a764ed22","line":2566,"range":{"start_line":2565,"start_character":30,"end_line":2566,"end_character":51},"in_reply_to":"5fc1f717_c2ded40f","updated":"2019-03-28 17:25:15.000000000","message":"i will include console_type as parameter/argument  in the function and use that in the message in next patchset","commit_id":"5425ce6b1cfee3f47be1024a45f480c575bad773"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        :param context: request context."},{"line_number":518,"context_line":"        :param node_id: node id or uuid."},{"line_number":519,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":520,"context_line":"        :raises: UnsupportedDriverExtension if the node\u0027s driver doesn\u0027t"},{"line_number":521,"context_line":"                 support console."},{"line_number":522,"context_line":"        :raises: InvalidParameterValue when the wrong driver info is specified."},{"line_number":523,"context_line":"        :raises: MissingParameterValue if a required parameter is missing"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_620b857c","line":520,"updated":"2019-03-14 16:34:33.000000000","message":"missing param console_type","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        if console_type \u003d\u003d \u0027serial\u0027:"},{"line_number":526,"context_line":"            cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic,"},{"line_number":527,"context_line":"                                        version\u003d\u00271.11\u0027)"},{"line_number":528,"context_line":"        else:"},{"line_number":529,"context_line":"            cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic,"},{"line_number":530,"context_line":"                                        version\u003d\u00271.49\u0027)"},{"line_number":531,"context_line":"        return cctxt.call(context, \u0027get_console_information\u0027, node_id\u003dnode_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_a263ad41","line":528,"updated":"2019-03-14 16:34:33.000000000","message":"are we sure that we\u0027re getting only serial or graphical? maybe add a check ?","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"02dfb82900bf440888d639ad9d3655e86256b0c0","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        if console_type \u003d\u003d \u0027serial\u0027:"},{"line_number":526,"context_line":"            cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic,"},{"line_number":527,"context_line":"                                        version\u003d\u00271.11\u0027)"},{"line_number":528,"context_line":"        else:"},{"line_number":529,"context_line":"            cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic,"},{"line_number":530,"context_line":"                                        version\u003d\u00271.49\u0027)"},{"line_number":531,"context_line":"        return cctxt.call(context, \u0027get_console_information\u0027, node_id\u003dnode_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_3765b346","line":528,"in_reply_to":"5fc1f717_a263ad41","updated":"2019-03-26 19:41:19.000000000","message":"yes here it is either serial or graphical. Probably i will add a exclusive check in api/controllers/v1/node.py if anything else is recvd then it fails there itself.","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":541,"context_line":"        :param enabled: Boolean value; whether the console is enabled or"},{"line_number":542,"context_line":"                        disabled."},{"line_number":543,"context_line":"        :raises: UnsupportedDriverExtension if the node\u0027s driver doesn\u0027t"},{"line_number":544,"context_line":"                 support console."},{"line_number":545,"context_line":"        :raises: InvalidParameterValue when the wrong driver info is specified."},{"line_number":546,"context_line":"        :raises: MissingParameterValue if a required parameter is missing"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_0271610c","line":543,"updated":"2019-03-14 16:34:33.000000000","message":"missing param console_type","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"}],"ironic/db/sqlalchemy/alembic/versions/f5aee1383fdb_add_graphical_console_enabled.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a32caac38dc180a97d836bb8902809d38c1e3442","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"        op.add_column(\u0027nodes\u0027, sa.Column(\u0027graphical_console_enabled\u0027,"},{"line_number":36,"context_line":"                                         sa.Boolean))"}],"source_content_type":"text/x-python","patch_set":13,"id":"7faddb67_85794efc","line":36,"updated":"2019-08-27 18:05:53.000000000","message":"This breaks upgrades... \n\nAug 26 19:52:10.861018 ubuntu-bionic-rax-ord-0010443618 ironic-conductor[14251]: ERROR futurist.periodics ValueError: Field `graphical_console_enabled\u0027 cannot be None\nAug 26 19:52:10.861018 ubuntu-bionic-rax-ord-0010443618 ironic-conductor[14251]: ERROR futurist.periodics","commit_id":"e4d4bf4ec6c77027a9ede2b2787d08ed9682519e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e786b02acd7a4e9e73f4a9b26c5bb1ee72ec628f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"        op.add_column(\u0027nodes\u0027, sa.Column(\u0027graphical_console_enabled\u0027,"},{"line_number":36,"context_line":"                                         sa.Boolean))"}],"source_content_type":"text/x-python","patch_set":13,"id":"7faddb67_f69e90b6","line":36,"in_reply_to":"7faddb67_85794efc","updated":"2019-08-29 19:53:49.000000000","message":"Not Sue Julia, manually the ironic-dbsync works perfectly fine on my system with current patch set. \n\nAm i missing something else?","commit_id":"e4d4bf4ec6c77027a9ede2b2787d08ed9682519e"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a32caac38dc180a97d836bb8902809d38c1e3442","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    maintenance_reason \u003d Column(Text, nullable\u003dTrue)"},{"line_number":173,"context_line":"    fault \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":174,"context_line":"    console_enabled \u003d Column(Boolean, default\u003dFalse)"},{"line_number":175,"context_line":"    graphical_console_enabled \u003d Column(Boolean, default\u003dFalse)"},{"line_number":176,"context_line":"    inspection_finished_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":177,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":178,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7faddb67_05655e49","line":175,"updated":"2019-08-27 18:05:53.000000000","message":"this doesn\u0027t match the upgrade model model","commit_id":"e4d4bf4ec6c77027a9ede2b2787d08ed9682519e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e786b02acd7a4e9e73f4a9b26c5bb1ee72ec628f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    maintenance_reason \u003d Column(Text, nullable\u003dTrue)"},{"line_number":173,"context_line":"    fault \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":174,"context_line":"    console_enabled \u003d Column(Boolean, default\u003dFalse)"},{"line_number":175,"context_line":"    graphical_console_enabled \u003d Column(Boolean, default\u003dFalse)"},{"line_number":176,"context_line":"    inspection_finished_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":177,"context_line":"    inspection_started_at \u003d Column(DateTime, nullable\u003dTrue)"},{"line_number":178,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7faddb67_36b74824","line":175,"in_reply_to":"7faddb67_05655e49","updated":"2019-08-29 19:53:49.000000000","message":"I think you mean to add nullable field here. if i am wrong plz help me to fix it correctly.","commit_id":"e4d4bf4ec6c77027a9ede2b2787d08ed9682519e"}],"ironic/objects/node.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        \u0027traits\u0027: object_fields.ObjectField(\u0027TraitList\u0027, nullable\u003dTrue),"},{"line_number":160,"context_line":"        \u0027owner\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":161,"context_line":"        \u0027description\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":162,"context_line":"        \u0027graphical_console_enabled\u0027: object_fields.BooleanField()"},{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def as_dict(self, secure\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_62b5c57d","line":162,"updated":"2019-03-14 16:34:33.000000000","message":"nit: comma at the end","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        # NOTE(dtantsur): the default is False for protected"},{"line_number":609,"context_line":"        self._adjust_field_to_version(\u0027protected\u0027, False, target_version,"},{"line_number":610,"context_line":"                                      1, 29, remove_unavailable_fields)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        self._adjust_field_to_version(\u0027graphical_console_enabled\u0027,"},{"line_number":613,"context_line":"                                      False, target_version,"},{"line_number":614,"context_line":"                                      1, 34, remove_unavailable_fields)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_e2a8d520","line":611,"updated":"2019-03-14 16:34:33.000000000","message":"nit: remove blank line","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"}],"releasenotes/notes/graphical_console_enabled-86cec141c4d36a66.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a2ad95ac7b7f0c7c27cf3d2c37609b53b217c78c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch adds the graphical console feature to the ironic."},{"line_number":5,"context_line":"    Refer to the story ``https://storyboard.openstack.org/#!/story/1567629``"},{"line_number":6,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5fc1f717_5d1f4c5a","line":4,"updated":"2019-03-14 16:34:33.000000000","message":"I would definitely elaborate more and add more details directly here in the release note instead of just relying to storyboard.","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"02dfb82900bf440888d639ad9d3655e86256b0c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch adds the graphical console feature to the ironic."},{"line_number":5,"context_line":"    Refer to the story ``https://storyboard.openstack.org/#!/story/1567629``"},{"line_number":6,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5fc1f717_f79deb09","line":4,"in_reply_to":"5fc1f717_5d1f4c5a","updated":"2019-03-26 19:41:19.000000000","message":":) Sure","commit_id":"a50822c463db5da5097832fb9f3a3f4226e4df02"}]}