)]}'
{"ironic/drivers/modules/drac/inspect.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d64f597fd3a58a3df3a482a129e322ff19a14b3b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_utils import units"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from ironic.common import exception"},{"line_number":24,"context_line":"from ironic.common.i18n import _"},{"line_number":25,"context_line":"from ironic.common import states"},{"line_number":26,"context_line":"from ironic.drivers import base"},{"line_number":27,"context_line":"from ironic.drivers.modules.drac import common as drac_common"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_1152b014","line":24,"updated":"2019-03-06 20:03:29.000000000","message":"I think this change should be reverted","commit_id":"6e540fb6de8aee3f4c04c089adeb0cd1fcccbe8f"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d64f597fd3a58a3df3a482a129e322ff19a14b3b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                    properties[\u0027local_gb\u0027] \u003d int("},{"line_number":96,"context_line":"                        root_disk.size_mb / units.Ki)"},{"line_number":97,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":98,"context_line":"            LOG.error(\u0027DRAC driver failed to introspect node \u0027"},{"line_number":99,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":100,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":101,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_513278f3","line":98,"updated":"2019-03-06 20:03:29.000000000","message":"I think this change should be reverted","commit_id":"6e540fb6de8aee3f4c04c089adeb0cd1fcccbe8f"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d64f597fd3a58a3df3a482a129e322ff19a14b3b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            nics \u003d client.list_nics()"},{"line_number":116,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":117,"context_line":"            LOG.error(\u0027DRAC driver failed to introspect node \u0027"},{"line_number":118,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":119,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":120,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_d15bc82b","line":117,"updated":"2019-03-06 20:03:29.000000000","message":"I think this change should be reverted","commit_id":"6e540fb6de8aee3f4c04c089adeb0cd1fcccbe8f"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d64f597fd3a58a3df3a482a129e322ff19a14b3b","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":123,"context_line":"        if pxe_dev_nics is None:"},{"line_number":124,"context_line":"            LOG.warning(\u0027No PXE enabled NIC was found for node \u0027"},{"line_number":125,"context_line":"                        \u0027%(node_uuid)s.\u0027, {\u0027node_uuid\u0027: node.uuid})"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        for nic in nics:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_11895074","line":124,"updated":"2019-03-06 20:03:29.000000000","message":"This logging statement should use _LW","commit_id":"6e540fb6de8aee3f4c04c089adeb0cd1fcccbe8f"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d64f597fd3a58a3df3a482a129e322ff19a14b3b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                                    pxe_enabled\u003d(nic.id in pxe_dev_nics))"},{"line_number":132,"context_line":"                port.create()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"                LOG.info(\u0027Port created with MAC address %(mac)s \u0027"},{"line_number":135,"context_line":"                         \u0027for node %(node_uuid)s during inspection\u0027,"},{"line_number":136,"context_line":"                         {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":137,"context_line":"            except exception.MACAlreadyExists:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_71977492","line":134,"updated":"2019-03-06 20:03:29.000000000","message":"This change should be reverted","commit_id":"6e540fb6de8aee3f4c04c089adeb0cd1fcccbe8f"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d64f597fd3a58a3df3a482a129e322ff19a14b3b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                         \u0027for node %(node_uuid)s during inspection\u0027,"},{"line_number":136,"context_line":"                         {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":137,"context_line":"            except exception.MACAlreadyExists:"},{"line_number":138,"context_line":"                LOG.warning(\u0027Failed to create a port with MAC address \u0027"},{"line_number":139,"context_line":"                            \u0027%(mac)s when inspecting the node \u0027"},{"line_number":140,"context_line":"                            \u0027%(node_uuid)s because the address is already \u0027"},{"line_number":141,"context_line":"                            \u0027registered\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_11ee3022","line":138,"updated":"2019-03-06 20:03:29.000000000","message":"This change should be reverted","commit_id":"6e540fb6de8aee3f4c04c089adeb0cd1fcccbe8f"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d64f597fd3a58a3df3a482a129e322ff19a14b3b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                            \u0027registered\u0027,"},{"line_number":142,"context_line":"                            {\u0027mac\u0027: nic.mac, \u0027node_uuid\u0027: node.uuid})"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        LOG.info(\u0027Node %s successfully inspected.\u0027, node.uuid)"},{"line_number":145,"context_line":"        return states.MANAGEABLE"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _guess_root_disk(self, disks, min_size_required_mb\u003d4 * units.Ki):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_d1f748f5","line":144,"updated":"2019-03-06 20:03:29.000000000","message":"This change should be reverted.","commit_id":"6e540fb6de8aee3f4c04c089adeb0cd1fcccbe8f"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"d64f597fd3a58a3df3a482a129e322ff19a14b3b","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        try:"},{"line_number":175,"context_line":"            bios_settings \u003d client.list_bios_settings()"},{"line_number":176,"context_line":"        except drac_exceptions.BaseClientException as exc:"},{"line_number":177,"context_line":"            LOG.error(\u0027DRAC driver failed to list bios settings \u0027"},{"line_number":178,"context_line":"                      \u0027for %(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":179,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":180,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_91522067","line":177,"updated":"2019-03-06 20:03:29.000000000","message":"All the logging statements in this method should use LE, LW, LI, etc","commit_id":"6e540fb6de8aee3f4c04c089adeb0cd1fcccbe8f"}]}
