)]}'
{"ironic/api/controllers/v1/allocation.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"418eaea8ff8100cf0a26827f51e5a4890c250272","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            if pecan.request.method \u003d\u003d \"GET\":"},{"line_number":209,"context_line":"                raise webob_exc.HTTPNotFound(msg)"},{"line_number":210,"context_line":"            else:"},{"line_number":211,"context_line":"                raise webob_exc.HTTPMethodNotAllowed(msg)"},{"line_number":212,"context_line":"        return super(AllocationsController, self)._route(args, request)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _get_allocations_collection(self, node_ident\u003dNone, resource_class\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_e8c45893","line":211,"updated":"2019-03-13 10:15:30.000000000","message":"I\u0027ve seen _route in the node controller returning \"None\" in some case. Will it have the same effect?","commit_id":"7480e581d988de2bdcdb6dec483026e307b4bff2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d2c3ba712822eecb6121840d3e04d13f30481edf","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            if pecan.request.method \u003d\u003d \"GET\":"},{"line_number":209,"context_line":"                raise webob_exc.HTTPNotFound(msg)"},{"line_number":210,"context_line":"            else:"},{"line_number":211,"context_line":"                raise webob_exc.HTTPMethodNotAllowed(msg)"},{"line_number":212,"context_line":"        return super(AllocationsController, self)._route(args, request)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _get_allocations_collection(self, node_ident\u003dNone, resource_class\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_e86bf81a","line":211,"in_reply_to":"5fc1f717_68e4e8e1","updated":"2019-03-13 10:36:47.000000000","message":"Turns out I knew this once:\n\n        if remainder[0] \u003d\u003d \u0027traits\u0027 and not api_utils.allow_traits():\n            # NOTE(mgoddard): Returning here will ensure we exhibit the\n            # behaviour of previous releases for microversions without this                           \n            # endpoint.                                                                               \n            return","commit_id":"7480e581d988de2bdcdb6dec483026e307b4bff2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c7930e6497e6fdc0e357ab5de4401d95a56d382","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            if pecan.request.method \u003d\u003d \"GET\":"},{"line_number":209,"context_line":"                raise webob_exc.HTTPNotFound(msg)"},{"line_number":210,"context_line":"            else:"},{"line_number":211,"context_line":"                raise webob_exc.HTTPMethodNotAllowed(msg)"},{"line_number":212,"context_line":"        return super(AllocationsController, self)._route(args, request)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def _get_allocations_collection(self, node_ident\u003dNone, resource_class\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_68e4e8e1","line":211,"in_reply_to":"5fc1f717_e8c45893","updated":"2019-03-13 10:33:38.000000000","message":"Perhaps you mean the _lookup method? I wonder if we could modify the _lookup method on the v1 controller to return None if the subcontroller is not allowed? That could remove a lot of the version checking in the API.","commit_id":"7480e581d988de2bdcdb6dec483026e307b4bff2"}],"ironic/api/controllers/v1/deploy_template.py":[{"author":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"change_message_id":"4fabdc83716cdf01e3e554496f86f25de15a3835","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                raise webob_exc.HTTPNotFound(msg)"},{"line_number":265,"context_line":"            else:"},{"line_number":266,"context_line":"                raise webob_exc.HTTPMethodNotAllowed(msg)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        return super(DeployTemplatesController, self)._route(args, request)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def _update_changed_fields(self, template, rpc_template):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_abe897e1","line":267,"updated":"2019-03-12 19:47:18.000000000","message":"nit: blank line inconsistent between files","commit_id":"fabe6ea97761b468cd02bc73e373ca29b83cb35b"}]}
