)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5e5fdf315eaad53896b7515a8b4faff82a0f41ed","unresolved":false,"context_lines":[{"line_number":2845,"context_line":"                                  \u0027%s as it is in maintenance mode\u0027,"},{"line_number":2846,"context_line":"                                  task.node.uuid)"},{"line_number":2847,"context_line":"                        continue"},{"line_number":2848,"context_line":"                    # Add the node name, as the name would be hand for other"},{"line_number":2849,"context_line":"                    # notifier plugins"},{"line_number":2850,"context_line":"                    message[\u0027node_name\u0027] \u003d task.node.name"},{"line_number":2851,"context_line":"                    # We should convey the proper hardware type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_21f571ed","line":2848,"range":{"start_line":2848,"start_character":62,"end_line":2848,"end_character":66},"updated":"2019-03-15 04:25:32.000000000","message":"nit: handy?","commit_id":"b5d44d3aaf9bff8ac3224a820cbe6514ca506e56"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"72e321c820c8883525a85e94ef7e56f6b3237a53","unresolved":false,"context_lines":[{"line_number":2847,"context_line":"                        continue"},{"line_number":2848,"context_line":"                    # Add the node name, as the name would be hand for other"},{"line_number":2849,"context_line":"                    # notifier plugins"},{"line_number":2850,"context_line":"                    message[\u0027node_name\u0027] \u003d task.node.name"},{"line_number":2851,"context_line":"                    # We should convey the proper hardware type,"},{"line_number":2852,"context_line":"                    # which previously was hard coded to ipmi, but other"},{"line_number":2853,"context_line":"                    # drivers were transmitting other values under the"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_c1c82da7","line":2850,"range":{"start_line":2850,"start_character":20,"end_line":2850,"end_character":57},"updated":"2019-03-15 04:27:03.000000000","message":"I hope passing \u0027None\u0027 should be ok here.","commit_id":"b5d44d3aaf9bff8ac3224a820cbe6514ca506e56"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"55174bb3f83dbd8b172c21057751ab0f1911daa8","unresolved":false,"context_lines":[{"line_number":2847,"context_line":"                        continue"},{"line_number":2848,"context_line":"                    # Add the node name, as the name would be hand for other"},{"line_number":2849,"context_line":"                    # notifier plugins"},{"line_number":2850,"context_line":"                    message[\u0027node_name\u0027] \u003d task.node.name"},{"line_number":2851,"context_line":"                    # We should convey the proper hardware type,"},{"line_number":2852,"context_line":"                    # which previously was hard coded to ipmi, but other"},{"line_number":2853,"context_line":"                    # drivers were transmitting other values under the"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_26d9fe20","line":2850,"range":{"start_line":2850,"start_character":20,"end_line":2850,"end_character":57},"in_reply_to":"5fc1f717_c1c82da7","updated":"2019-03-15 13:21:39.000000000","message":"Yeah, it should be fine if nobody is using the machine. Much like instance_uuid.","commit_id":"b5d44d3aaf9bff8ac3224a820cbe6514ca506e56"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5e5fdf315eaad53896b7515a8b4faff82a0f41ed","unresolved":false,"context_lines":[{"line_number":2845,"context_line":"                                  \u0027%s as it is in maintenance mode\u0027,"},{"line_number":2846,"context_line":"                                  task.node.uuid)"},{"line_number":2847,"context_line":"                        continue"},{"line_number":2848,"context_line":"                    # Add the node name, as the name would be hand for other"},{"line_number":2849,"context_line":"                    # notifier plugins"},{"line_number":2850,"context_line":"                    message[\u0027node_name\u0027] \u003d task.node.name"},{"line_number":2851,"context_line":"                    # We should convey the proper hardware type,"},{"line_number":2852,"context_line":"                    # which previously was hard coded to ipmi, but other"},{"line_number":2853,"context_line":"                    # drivers were transmitting other values under the"},{"line_number":2854,"context_line":"                    # guise of ipmi."},{"line_number":2855,"context_line":"                    ev_type \u003d \u0027hardware.{driver}.metrics\u0027.format("},{"line_number":2856,"context_line":"                        driver\u003dtask.node.driver)"},{"line_number":2857,"context_line":"                    message[\u0027event_type\u0027] \u003d ev_type + \u0027.update\u0027"},{"line_number":2858,"context_line":""},{"line_number":2859,"context_line":"                    task.driver.management.validate(task)"},{"line_number":2860,"context_line":"                    sensors_data \u003d task.driver.management.get_sensors_data("}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_419e7db9","line":2857,"range":{"start_line":2848,"start_character":20,"end_line":2857,"end_character":63},"updated":"2019-03-15 04:25:32.000000000","message":"May be this could have been done at L2835 without before lock.","commit_id":"b5d44d3aaf9bff8ac3224a820cbe6514ca506e56"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"55174bb3f83dbd8b172c21057751ab0f1911daa8","unresolved":false,"context_lines":[{"line_number":2845,"context_line":"                                  \u0027%s as it is in maintenance mode\u0027,"},{"line_number":2846,"context_line":"                                  task.node.uuid)"},{"line_number":2847,"context_line":"                        continue"},{"line_number":2848,"context_line":"                    # Add the node name, as the name would be hand for other"},{"line_number":2849,"context_line":"                    # notifier plugins"},{"line_number":2850,"context_line":"                    message[\u0027node_name\u0027] \u003d task.node.name"},{"line_number":2851,"context_line":"                    # We should convey the proper hardware type,"},{"line_number":2852,"context_line":"                    # which previously was hard coded to ipmi, but other"},{"line_number":2853,"context_line":"                    # drivers were transmitting other values under the"},{"line_number":2854,"context_line":"                    # guise of ipmi."},{"line_number":2855,"context_line":"                    ev_type \u003d \u0027hardware.{driver}.metrics\u0027.format("},{"line_number":2856,"context_line":"                        driver\u003dtask.node.driver)"},{"line_number":2857,"context_line":"                    message[\u0027event_type\u0027] \u003d ev_type + \u0027.update\u0027"},{"line_number":2858,"context_line":""},{"line_number":2859,"context_line":"                    task.driver.management.validate(task)"},{"line_number":2860,"context_line":"                    sensors_data \u003d task.driver.management.get_sensors_data("}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_c6e83ab4","line":2857,"range":{"start_line":2848,"start_character":20,"end_line":2857,"end_character":63},"in_reply_to":"5fc1f717_419e7db9","updated":"2019-03-15 13:21:39.000000000","message":"This yes, but not the name, and I felt like they made sense together.","commit_id":"b5d44d3aaf9bff8ac3224a820cbe6514ca506e56"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"08025451ce3332fbef039f1d51385855d67d9f1b","unresolved":false,"context_lines":[{"line_number":5615,"context_line":"        self.assertEqual(5, notifier_mock.call_count)"},{"line_number":5616,"context_line":"        if six.PY2:"},{"line_number":5617,"context_line":"            # bail out if python2 as matching fails to match the"},{"line_number":5618,"context_line":"            # data structure becasue it requires the order to be consistent"},{"line_number":5619,"context_line":"            # but the mock also records the call dictionary contents in"},{"line_number":5620,"context_line":"            # random order changing with every invocation. :\\"},{"line_number":5621,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_eadbc34b","line":5618,"range":{"start_line":5618,"start_character":29,"end_line":5618,"end_character":36},"updated":"2019-03-15 01:35:58.000000000","message":"nit: because","commit_id":"b5d44d3aaf9bff8ac3224a820cbe6514ca506e56"}]}