)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fe5423f3b6ad8819e499c2a7ef8c69fecc1947eb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Advance python-dracclient version requirement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-dracclient versions 2.0.0 and later are required for bug fixes to"},{"line_number":10,"context_line":"the idrac hardware type which assign ports\u0027 pxe_enabled flags during"},{"line_number":11,"context_line":"out-of-band inspection [1] and rename Job.state to Job.status [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/617951"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_f11ab76c","line":10,"updated":"2019-03-18 11:05:00.000000000","message":"This change has been backported to all stable branches. Does this mean that we shouldn\u0027t have done it and we need to revert?","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"ba00c1ba87f16c5c780753ca62f468e0d7ee773d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Advance python-dracclient version requirement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-dracclient versions 2.0.0 and later are required for bug fixes to"},{"line_number":10,"context_line":"the idrac hardware type which assign ports\u0027 pxe_enabled flags during"},{"line_number":11,"context_line":"out-of-band inspection [1] and rename Job.state to Job.status [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/617951"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_e96e3e2d","line":10,"in_reply_to":"5fc1f717_a752ac11","updated":"2019-03-18 19:52:11.000000000","message":"In this case, the bug fix (setting pxe_enabled on ports in ironic) depends on new functionality that was added to python-dracclient (list_nic_settings) in the 1.5.0 version.  That\u0027s the reason for bumping up the version.  As a result, I think we should just bump the version to 1.5.0 for now in master, not 2.0.0.\n\nI\u0027ll take a closer look at the changes that have gone into python-dracclient and make sure that the appropriate changes have gone into ironic, including changes to driver-requirements.txt.","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"772e66995cd70a98c9ff7f1b8948428392d5c2db","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Advance python-dracclient version requirement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-dracclient versions 2.0.0 and later are required for bug fixes to"},{"line_number":10,"context_line":"the idrac hardware type which assign ports\u0027 pxe_enabled flags during"},{"line_number":11,"context_line":"out-of-band inspection [1] and rename Job.state to Job.status [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/617951"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_a752ac11","line":10,"in_reply_to":"5fc1f717_e715143e","updated":"2019-03-18 13:42:15.000000000","message":"I think the overall approach is not to bump requirements for bug fixes, unless things are hopelessly broken? Anyway, I\u0027m fine with this change, I just want to see the actual reason in the release notes.","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1d5f4b6497883adabf7925db9a6d0bda394d3b5c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Advance python-dracclient version requirement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-dracclient versions 2.0.0 and later are required for bug fixes to"},{"line_number":10,"context_line":"the idrac hardware type which assign ports\u0027 pxe_enabled flags during"},{"line_number":11,"context_line":"out-of-band inspection [1] and rename Job.state to Job.status [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/617951"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_e715143e","line":10,"in_reply_to":"5fc1f717_f11ab76c","updated":"2019-03-18 13:40:53.000000000","message":"I think they are trying to convey that while not explicitly broken, there were related bug fixes and it behooves operators to update. That being said, 2.0.0 was only released in November 2018, so I believe that realistically means the constraints were just never appropriately updated in ironic as python-dracclient fixes/changes merged.","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fe5423f3b6ad8819e499c2a7ef8c69fecc1947eb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-dracclient versions 2.0.0 and later are required for bug fixes to"},{"line_number":10,"context_line":"the idrac hardware type which assign ports\u0027 pxe_enabled flags during"},{"line_number":11,"context_line":"out-of-band inspection [1] and rename Job.state to Job.status [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/617951"},{"line_number":14,"context_line":"[2] https://review.openstack.org/#/c/643142"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_1116634a","line":11,"updated":"2019-03-18 11:05:00.000000000","message":"++","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2e1ff30e9ed8a54316e76629fe2b87b0866f90f7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-dracclient versions 2.0.0 and later are required for bug fixes to"},{"line_number":10,"context_line":"the idrac hardware type which assign ports\u0027 pxe_enabled flags during"},{"line_number":11,"context_line":"out-of-band inspection [1] and rename Job.state to Job.status [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/617951"},{"line_number":14,"context_line":"[2] https://review.openstack.org/#/c/643142"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_3b3c9e2d","line":11,"range":{"start_line":11,"start_character":27,"end_line":11,"end_character":61},"updated":"2019-03-18 09:49:16.000000000","message":"nit: that patch adds support for 2.0.0, but continues to work back to 0.1.0.","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a05a208ad5c86e24b188febeeffdabcebdaf0b59","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-dracclient versions 2.0.0 and later are required for bug fixes to"},{"line_number":10,"context_line":"the idrac hardware type which assign ports\u0027 pxe_enabled flags during"},{"line_number":11,"context_line":"out-of-band inspection [1] and rename Job.state to Job.status [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/617951"},{"line_number":14,"context_line":"[2] https://review.openstack.org/#/c/643142"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_2739dcd5","line":11,"in_reply_to":"5fc1f717_1116634a","updated":"2019-03-18 13:42:14.000000000","message":"It makes me wonder what version of python-dracclient jetpack uses.","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"ba00c1ba87f16c5c780753ca62f468e0d7ee773d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-dracclient versions 2.0.0 and later are required for bug fixes to"},{"line_number":10,"context_line":"the idrac hardware type which assign ports\u0027 pxe_enabled flags during"},{"line_number":11,"context_line":"out-of-band inspection [1] and rename Job.state to Job.status [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/617951"},{"line_number":14,"context_line":"[2] https://review.openstack.org/#/c/643142"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_490f5287","line":11,"in_reply_to":"5fc1f717_2739dcd5","updated":"2019-03-18 19:52:11.000000000","message":"I agree with Mark, and as a result, I think we should remove the reference to Job.state/Job.status and the associated patch from this comment.\n\nJetPack uses whatever version of python-dracclient is shipped in RHOSP 13 (currently z5) plus monkey patches to fix issues where the fixes have not trickled down from upstream yet.  At the present time, this equates to version 1.6.0 + monkey patches.","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5080029da6c3eda75b22cfcb40895c6f3a912ee0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-dracclient versions 2.0.0 and later are required for bug fixes to"},{"line_number":10,"context_line":"the idrac hardware type which assign ports\u0027 pxe_enabled flags during"},{"line_number":11,"context_line":"out-of-band inspection [1] and rename Job.state to Job.status [2]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/617951"},{"line_number":14,"context_line":"[2] https://review.openstack.org/#/c/643142"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_443722e5","line":11,"range":{"start_line":11,"start_character":27,"end_line":11,"end_character":61},"in_reply_to":"5fc1f717_3b3c9e2d","updated":"2019-03-19 16:52:52.000000000","message":"Done. The reference to that bug fix has been removed here and in driver-requirements.txt.","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"}],"driver-requirements.txt":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"ba00c1ba87f16c5c780753ca62f468e0d7ee773d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"python-ironic-inspector-client\u003e\u003d1.5.0"},{"line_number":10,"context_line":"python-scciclient\u003e\u003d0.8.0"},{"line_number":11,"context_line":"UcsSdk\u003d\u003d0.8.2.2;python_version\u003c\u00273\u0027"},{"line_number":12,"context_line":"python-dracclient\u003e\u003d2.0.0"},{"line_number":13,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# The CIMC drivers use the Cisco IMC SDK version 0.7.2 or greater"}],"source_content_type":"text/plain","patch_set":1,"id":"5fc1f717_24b46df1","line":12,"updated":"2019-03-18 19:52:11.000000000","message":"I think we should only bump this to 1.5.0 for now, since that\u0027s the minimum version that will fix the issue.","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5080029da6c3eda75b22cfcb40895c6f3a912ee0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"python-ironic-inspector-client\u003e\u003d1.5.0"},{"line_number":10,"context_line":"python-scciclient\u003e\u003d0.8.0"},{"line_number":11,"context_line":"UcsSdk\u003d\u003d0.8.2.2;python_version\u003c\u00273\u0027"},{"line_number":12,"context_line":"python-dracclient\u003e\u003d2.0.0"},{"line_number":13,"context_line":"python-xclarityclient\u003e\u003d0.1.6"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# The CIMC drivers use the Cisco IMC SDK version 0.7.2 or greater"}],"source_content_type":"text/plain","patch_set":1,"id":"5fc1f717_44aac2d2","line":12,"in_reply_to":"5fc1f717_24b46df1","updated":"2019-03-19 16:52:52.000000000","message":"Done","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"}],"releasenotes/notes/idrac-advance-python-dracclient-version-01c6ef671670ffb3.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2e1ff30e9ed8a54316e76629fe2b87b0866f90f7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Advances required ``python-dracclient`` version to 2.0.0 and later. Those"},{"line_number":5,"context_line":"    versions are required by the fixes to the ``idrac`` hardware type\u0027s"},{"line_number":6,"context_line":"    `bug 2004340 \u003chttps://storyboard.openstack.org/#!/story/2004340\u003e`_ and"},{"line_number":7,"context_line":"    `bug 2005225 \u003chttps://storyboard.openstack.org/#!/story/2005225\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_fb4136a7","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":67},"updated":"2019-03-18 09:49:16.000000000","message":"nit: Same comment","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"ba00c1ba87f16c5c780753ca62f468e0d7ee773d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Advances required ``python-dracclient`` version to 2.0.0 and later. Those"},{"line_number":5,"context_line":"    versions are required by the fixes to the ``idrac`` hardware type\u0027s"},{"line_number":6,"context_line":"    `bug 2004340 \u003chttps://storyboard.openstack.org/#!/story/2004340\u003e`_ and"},{"line_number":7,"context_line":"    `bug 2005225 \u003chttps://storyboard.openstack.org/#!/story/2005225\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_84944138","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":67},"in_reply_to":"5fc1f717_fb4136a7","updated":"2019-03-18 19:52:11.000000000","message":"++  Let\u0027s remove the reference to that story.","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5080029da6c3eda75b22cfcb40895c6f3a912ee0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Advances required ``python-dracclient`` version to 2.0.0 and later. Those"},{"line_number":5,"context_line":"    versions are required by the fixes to the ``idrac`` hardware type\u0027s"},{"line_number":6,"context_line":"    `bug 2004340 \u003chttps://storyboard.openstack.org/#!/story/2004340\u003e`_ and"},{"line_number":7,"context_line":"    `bug 2005225 \u003chttps://storyboard.openstack.org/#!/story/2005225\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_a4828651","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":67},"in_reply_to":"5fc1f717_fb4136a7","updated":"2019-03-19 16:52:52.000000000","message":"Done","commit_id":"2ef460d28940681e28e8da5a5bffaeb3d0583350"}]}
