)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"67373ccc7e930774d2579a4d5ad8ba2114c61482","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-23 09:27:30 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds config option to pass IPA config params to ramdisk"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds new configuration parameter"},{"line_number":10,"context_line":"\u0027[agent]ipa_config_params\u0027 to pass IPA config parameters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_c3e9281a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2019-03-26 13:38:33.000000000","message":"Should be \"Add\" to keep git lawyers at bay","commit_id":"056783a05d84156056f5e04436dfab4bb9703d3a"}],"doc/source/admin/drivers/ilo.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bb77ecd173c784eacdc0244fc25a6d22377fadfc","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    .. note::"},{"line_number":96,"context_line":"       Update ``[agent]vmedia_ipa_config_params`` option in ``ironic.conf`` to"},{"line_number":97,"context_line":"       pass configuration parameters to Ironic Python Agent(IPA) during boot"},{"line_number":98,"context_line":"       of IPA based ramdisk using virtual media. It is applicable to the nodes"},{"line_number":99,"context_line":"       that are configured with ``ilo-virtual-media`` as it\u0027s boot interface."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_9c7bdef2","line":98,"range":{"start_line":98,"start_character":69,"end_line":98,"end_character":72},"updated":"2019-03-22 08:06:43.000000000","message":"nit: can remove \"the\"","commit_id":"dd1728fe32595f97185822e0d4968339f2c1d395"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bb77ecd173c784eacdc0244fc25a6d22377fadfc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"       Update ``[agent]vmedia_ipa_config_params`` option in ``ironic.conf`` to"},{"line_number":97,"context_line":"       pass configuration parameters to Ironic Python Agent(IPA) during boot"},{"line_number":98,"context_line":"       of IPA based ramdisk using virtual media. It is applicable to the nodes"},{"line_number":99,"context_line":"       that are configured with ``ilo-virtual-media`` as it\u0027s boot interface."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_fc6b021c","line":99,"range":{"start_line":99,"start_character":7,"end_line":99,"end_character":15},"updated":"2019-03-22 08:06:43.000000000","message":"nit: can remove \"that are\"","commit_id":"dd1728fe32595f97185822e0d4968339f2c1d395"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bb77ecd173c784eacdc0244fc25a6d22377fadfc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"       Update ``[agent]vmedia_ipa_config_params`` option in ``ironic.conf`` to"},{"line_number":97,"context_line":"       pass configuration parameters to Ironic Python Agent(IPA) during boot"},{"line_number":98,"context_line":"       of IPA based ramdisk using virtual media. It is applicable to the nodes"},{"line_number":99,"context_line":"       that are configured with ``ilo-virtual-media`` as it\u0027s boot interface."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5fc1f717_5cb496d1","line":99,"range":{"start_line":99,"start_character":57,"end_line":99,"end_character":61},"updated":"2019-03-22 08:06:43.000000000","message":"nit: their","commit_id":"dd1728fe32595f97185822e0d4968339f2c1d395"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"67373ccc7e930774d2579a4d5ad8ba2114c61482","unresolved":false,"context_lines":[{"line_number":740,"context_line":"    pxe_append_params \u003d CONF.pxe.pxe_append_params"},{"line_number":741,"context_line":"    ipa_params \u003d deploy_utils.get_ipa_config_params(node)"},{"line_number":742,"context_line":"    if ipa_params:"},{"line_number":743,"context_line":"        ipa_params_str \u003d \u0027 \u0027.join("},{"line_number":744,"context_line":"            [\u0027{}\u003d{}\u0027.format(k, v) for k, v in ipa_params.items()])"},{"line_number":745,"context_line":"        pxe_append_params \u003d pxe_append_params + \" \" + ipa_params_str"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"    if CONF.debug and \u0027ipa-debug\u0027 not in pxe_append_params:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_036ad07f","line":744,"range":{"start_line":743,"start_character":25,"end_line":744,"end_character":66},"updated":"2019-03-26 13:38:33.000000000","message":"Alternatively:\n\n  \u0027 \u0027.join(\u0027\u003d\u0027.join(kv) for kv in api_params.items())","commit_id":"056783a05d84156056f5e04436dfab4bb9703d3a"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"84b9d3bd00a13f7a7ad0541fec1e37ed5bfcc42c","unresolved":false,"context_lines":[{"line_number":742,"context_line":"    if ipa_params:"},{"line_number":743,"context_line":"        ipa_params_str \u003d \u0027 \u0027.join("},{"line_number":744,"context_line":"            [\u0027{}\u003d{}\u0027.format(k, v) for k, v in ipa_params.items()])"},{"line_number":745,"context_line":"        pxe_append_params \u003d pxe_append_params + \" \" + ipa_params_str"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"    if CONF.debug and \u0027ipa-debug\u0027 not in pxe_append_params:"},{"line_number":748,"context_line":"        pxe_append_params +\u003d \u0027 ipa-debug\u003d1\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_2f581488","line":745,"range":{"start_line":745,"start_character":8,"end_line":745,"end_character":68},"updated":"2019-03-26 09:29:37.000000000","message":"Optional but can be changed to::\n  pxe_append_params +\u003d \" \" + ipa_params_str","commit_id":"056783a05d84156056f5e04436dfab4bb9703d3a"}],"ironic/conf/agent.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"67373ccc7e930774d2579a4d5ad8ba2114c61482","unresolved":false,"context_lines":[{"line_number":127,"context_line":"               help\u003d_(\u0027Wait time in seconds between attempts for validating \u0027"},{"line_number":128,"context_line":"                      \u0027Neutron agent status.\u0027)),"},{"line_number":129,"context_line":"    cfg.MultiOpt(\u0027ipa_config_params\u0027,"},{"line_number":130,"context_line":"                 item_type\u003dtypes.Dict(),"},{"line_number":131,"context_line":"                 default\u003d{},"},{"line_number":132,"context_line":"                 help\u003d_(\u0027Additional configuration parameters to pass to \u0027"},{"line_number":133,"context_line":"                        \u0027IPA during boot of ramdisk. It is a list of \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_c3d36837","line":130,"range":{"start_line":130,"start_character":17,"end_line":130,"end_character":26},"updated":"2019-03-26 13:38:33.000000000","message":"just to make sure: does `item_type` expect class or object?","commit_id":"056783a05d84156056f5e04436dfab4bb9703d3a"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"67373ccc7e930774d2579a4d5ad8ba2114c61482","unresolved":false,"context_lines":[{"line_number":1456,"context_line":"    \"\"\"Returns dictionary of IPA config params. \"\"\""},{"line_number":1457,"context_line":"    ipa_params \u003d node.driver_info.get(\"ipa_config_params\","},{"line_number":1458,"context_line":"                                      CONF.agent.ipa_config_params)"},{"line_number":1459,"context_line":"    ipa_params_dict \u003d dict((key, d[key]) for d in ipa_params for key in d)"},{"line_number":1460,"context_line":"    return ipa_params_dict"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_a3b73cf5","line":1459,"range":{"start_line":1459,"start_character":22,"end_line":1459,"end_character":26},"updated":"2019-03-26 13:38:33.000000000","message":"Can it be a dict comprehension?\n\n  {key: d[key] for d in ipa_params for key in d)}\n\nAlso, colliding keys might not be noticed.","commit_id":"056783a05d84156056f5e04436dfab4bb9703d3a"}],"releasenotes/notes/config-to-pass-ipa-config-options-80db0a88d1d44d39.yaml":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"67373ccc7e930774d2579a4d5ad8ba2114c61482","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new configuration option ``[agent]ipa_config_params`` to pass"},{"line_number":5,"context_line":"    configuration parameters to Ironic Python Agent(IPA) during boot"},{"line_number":6,"context_line":"    of IPA based ramdisk. The property ``ipa_config_params`` can be"},{"line_number":7,"context_line":"    set in the node\u0027s ``driver_info`` to override IPA  configuration"},{"line_number":8,"context_line":"    in ironic configuration file."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fc1f717_03c65069","line":5,"range":{"start_line":5,"start_character":51,"end_line":5,"end_character":52},"updated":"2019-03-26 13:38:33.000000000","message":"nit: no space","commit_id":"056783a05d84156056f5e04436dfab4bb9703d3a"}],"releasenotes/notes/ilo-vmedia-config-to-pass-ipa-config-options-80db0a88d1d44d39.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b2f9cb36d72dff881acd7a2cf5c5072d92bf8e5b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new configuration option ``vmedia_ipa_config_params`` to ``ilo``"},{"line_number":5,"context_line":"    hardware type to pass the configuration parameters to Ironic Python"},{"line_number":6,"context_line":"    Agent(IPA) during boot of IPA based ramdisk using virtual media. It"},{"line_number":7,"context_line":"    can be used when node is configured with ``ilo-virtual-media`` as"},{"line_number":8,"context_line":"    its boot interface."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_36a595a2","line":5,"range":{"start_line":5,"start_character":26,"end_line":5,"end_character":29},"updated":"2019-03-18 10:39:39.000000000","message":"additional","commit_id":"d6783dfd9d4e366ebcd07ef84b02975905c1776f"}]}