)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e6f04047e1333e3163cd32321dfc7efc5fd5f336","unresolved":false,"context_lines":[{"line_number":794,"context_line":"        pip_install_gr gunicorn"},{"line_number":795,"context_line":"    fi"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"    local cmd\u003d$(which $gunicorn)"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"    cmd+\u003d\" sushy_tools.emulator.main:app\""},{"line_number":800,"context_line":"    cmd+\u003d\" --bind \"${HOST_IP}:${IRONIC_REDFISH_EMULATOR_PORT}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_40c85c73","line":797,"range":{"start_line":797,"start_character":16,"end_line":797,"end_character":21},"updated":"2019-03-20 11:17:09.000000000","message":"maybe use \"command -v\" instead","commit_id":"bbd837ac7ae4b5b1c7300b37ca17447a440923b4"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"6a97d89331b2549fe051e703ade9aed0b4804517","unresolved":false,"context_lines":[{"line_number":794,"context_line":"        pip_install_gr gunicorn"},{"line_number":795,"context_line":"    fi"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"    local cmd\u003d$(which $gunicorn)"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"    cmd+\u003d\" sushy_tools.emulator.main:app\""},{"line_number":800,"context_line":"    cmd+\u003d\" --bind \"${HOST_IP}:${IRONIC_REDFISH_EMULATOR_PORT}\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_06a02ca5","line":797,"range":{"start_line":797,"start_character":16,"end_line":797,"end_character":21},"in_reply_to":"5fc1f717_40c85c73","updated":"2019-03-20 12:50:03.000000000","message":"The trouble with `command -v` is that it can be too smart:\n\n# command -v ls\nalias ls\u003d\u0027ls --color\u003dauto\u0027\n# command -v mkdir\n/bin/mkdir\n\nWhile `which` might never fail you:\n\n# which ls\n/bin/ls","commit_id":"bbd837ac7ae4b5b1c7300b37ca17447a440923b4"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e6f04047e1333e3163cd32321dfc7efc5fd5f336","unresolved":false,"context_lines":[{"line_number":964,"context_line":"    # It\u0027s noop if no emulator is running"},{"line_number":965,"context_line":"    stop_redfish_emulator"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"    $SYSTEMCTL disable $IRONIC_REDFISH_EMULATOR_SYSTEMD_SERVICE"},{"line_number":968,"context_line":""},{"line_number":969,"context_line":"    local unitfile\u003d\"$SYSTEMD_DIR/$IRONIC_REDFISH_EMULATOR_SYSTEMD_SERVICE\""},{"line_number":970,"context_line":"    sudo rm -f $unitfile"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    $SYSTEMCTL daemon-reload"},{"line_number":973,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_80cac44c","line":970,"range":{"start_line":967,"start_character":0,"end_line":970,"end_character":24},"updated":"2019-03-20 11:17:09.000000000","message":"maybe put this in another function or add to stop_redfish_emulator ?","commit_id":"bbd837ac7ae4b5b1c7300b37ca17447a440923b4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"49ddbb223c9a75d3c89e50d0cea78c4aeead9a39","unresolved":false,"context_lines":[{"line_number":826,"context_line":"    $SYSTEMCTL disable $IRONIC_REDFISH_EMULATOR_SYSTEMD_SERVICE"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    local unitfile\u003d\"$SYSTEMD_DIR/$IRONIC_REDFISH_EMULATOR_SYSTEMD_SERVICE\""},{"line_number":829,"context_line":"    sudo rm -f $unitfile"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    $SYSTEMCTL daemon-reload"},{"line_number":832,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5fc1f717_bc46f620","line":829,"updated":"2019-03-21 08:34:34.000000000","message":"nit: variable not needed","commit_id":"9b3cfe6e0d38ecc1d5f3b3b18981e5040f7e673b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"93380bca7bf01166517539f6357b85669dcb4d47","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"    fi"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    # It\u0027s noop if no emulator is running"},{"line_number":1014,"context_line":"    stop_redfish_emulator"},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"    cleanup_redfish_emulator"},{"line_number":1017,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5fc1f717_7cc5ee5a","line":1014,"updated":"2019-03-21 08:40:57.000000000","message":"you can remove this, I see you included it in cleanup_redfish_emulator function already","commit_id":"9b3cfe6e0d38ecc1d5f3b3b18981e5040f7e673b"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"87f3eb8f6b29737ef717375df38542f898a07b04","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"    fi"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    # It\u0027s noop if no emulator is running"},{"line_number":1014,"context_line":"    stop_redfish_emulator"},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"    cleanup_redfish_emulator"},{"line_number":1017,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5fc1f717_6f929b59","line":1014,"in_reply_to":"5fc1f717_7cc5ee5a","updated":"2019-03-26 09:54:50.000000000","message":"++","commit_id":"9b3cfe6e0d38ecc1d5f3b3b18981e5040f7e673b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"abc57d7d8845f5b419a353f93b1e156a8cc5aed7","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"    fi"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    # It\u0027s noop if no emulator is running"},{"line_number":1014,"context_line":"    stop_redfish_emulator"},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"    cleanup_redfish_emulator"},{"line_number":1017,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5fc1f717_3853126f","line":1014,"range":{"start_line":1014,"start_character":4,"end_line":1014,"end_character":25},"updated":"2019-04-01 13:47:47.000000000","message":"I think this is what the -1 review was attempting to get removed, although I\u0027m not sure I agree with removing it.","commit_id":"bfeeeed54eb1a370c256e01c506abee9c987e3f0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"28ee8886c4871238e32320dbf415abbd5c0488e1","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"    fi"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    # It\u0027s noop if no emulator is running"},{"line_number":1014,"context_line":"    stop_redfish_emulator"},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"    cleanup_redfish_emulator"},{"line_number":1017,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5fc1f717_d5e6b4b0","line":1014,"range":{"start_line":1014,"start_character":4,"end_line":1014,"end_character":25},"in_reply_to":"5fc1f717_3853126f","updated":"2019-04-09 16:01:57.000000000","message":"it\u0027s also in cleanup_redfish_emulator which is called by this function 2 lines below","commit_id":"bfeeeed54eb1a370c256e01c506abee9c987e3f0"}]}