)]}'
{"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"61e17640ba338d4e2d5c1dd5a642e6b42b4ff8f5","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        :returns: True if the deployment is completed. False otherwise"},{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def in_deploy_deploy_step(self, task):"},{"line_number":254,"context_line":"        \"\"\"Check if we are in the deploy.deploy deploy step."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        Assumes that we are in the DEPLOYWAIT state."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_cf6630bc","line":253,"updated":"2019-03-26 09:05:09.000000000","message":"s/deploy_deploy/core_deploy/ ? :)","commit_id":"cc330eb04e22005bc88b35df6473380c197f7173"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"732853b164ca776e53c9f054e34bf5f81bb6999f","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        :returns: True if the deployment is completed. False otherwise"},{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def in_deploy_deploy_step(self, task):"},{"line_number":254,"context_line":"        \"\"\"Check if we are in the deploy.deploy deploy step."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        Assumes that we are in the DEPLOYWAIT state."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_28be97ad","line":253,"in_reply_to":"5fc1f717_cf6630bc","updated":"2019-03-28 11:05:38.000000000","message":"I prefer in_deploy_deploy_deploy_step. I thought I was being restrained :)","commit_id":"cc330eb04e22005bc88b35df6473380c197f7173"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"61e17640ba338d4e2d5c1dd5a642e6b42b4ff8f5","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                    msg \u003d _(\u0027Node failed to move to active state.\u0027)"},{"line_number":365,"context_line":"                    self.reboot_to_instance(task)"},{"line_number":366,"context_line":"                else:"},{"line_number":367,"context_line":"                    node.touch_provisioning()"},{"line_number":368,"context_line":"            elif node.provision_state \u003d\u003d states.CLEANWAIT:"},{"line_number":369,"context_line":"                node.touch_provisioning()"},{"line_number":370,"context_line":"                if not node.clean_step:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_6f05bcc1","line":367,"updated":"2019-03-26 09:05:09.000000000","message":"Shouldn\u0027t we do it always? Otherwise the non-core deploy step can be timed out if it takes long enough.","commit_id":"cc330eb04e22005bc88b35df6473380c197f7173"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"732853b164ca776e53c9f054e34bf5f81bb6999f","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                    msg \u003d _(\u0027Node failed to move to active state.\u0027)"},{"line_number":365,"context_line":"                    self.reboot_to_instance(task)"},{"line_number":366,"context_line":"                else:"},{"line_number":367,"context_line":"                    node.touch_provisioning()"},{"line_number":368,"context_line":"            elif node.provision_state \u003d\u003d states.CLEANWAIT:"},{"line_number":369,"context_line":"                node.touch_provisioning()"},{"line_number":370,"context_line":"                if not node.clean_step:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_48576359","line":367,"in_reply_to":"5fc1f717_6f05bcc1","updated":"2019-03-28 11:05:38.000000000","message":"Will change to also touch when not in the core deploy step.","commit_id":"cc330eb04e22005bc88b35df6473380c197f7173"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17ef8d79226db10d4cb14a263073f81734fa3b2a","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        # TODO(mgoddard): Remove this \u0027if\u0027 in the Train release, after the"},{"line_number":262,"context_line":"        # deprecation period for supporting drivers with no deploy steps."},{"line_number":263,"context_line":"        if not task.node.driver_internal_info.get(\u0027deploy_steps\u0027):"},{"line_number":264,"context_line":"            return False"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        step \u003d task.node.deploy_step"},{"line_number":267,"context_line":"        return (step"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_73d9f480","line":264,"updated":"2019-03-28 10:58:32.000000000","message":"shouldn\u0027t it be True? Otherwise deploy actions won\u0027t work for drivers without deploy_steps.","commit_id":"bcbf94d4fadfdb3027e77c0bba482049986b800d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"732853b164ca776e53c9f054e34bf5f81bb6999f","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        # TODO(mgoddard): Remove this \u0027if\u0027 in the Train release, after the"},{"line_number":262,"context_line":"        # deprecation period for supporting drivers with no deploy steps."},{"line_number":263,"context_line":"        if not task.node.driver_internal_info.get(\u0027deploy_steps\u0027):"},{"line_number":264,"context_line":"            return False"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        step \u003d task.node.deploy_step"},{"line_number":267,"context_line":"        return (step"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_136bd084","line":264,"in_reply_to":"5fc1f717_73d9f480","updated":"2019-03-28 11:05:38.000000000","message":"Hmm, yes I think you\u0027re right. Although according to the comment we don\u0027t need to support them in Train. I guess we should explicitly remove support separately though.","commit_id":"bcbf94d4fadfdb3027e77c0bba482049986b800d"}]}