)]}'
{"api-ref/source/baremetal-api-v1-allocation.inc":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"4c15cd852522aa8050d736f1bde8c03db3431964","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    Allocation API was introduced."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. versionadded:: 1.57"},{"line_number":52,"context_line":"    Addes support for backfilling allocations."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Normal response codes: 201"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"5fc1f717_1ae16e2b","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":9},"updated":"2019-05-31 08:52:56.000000000","message":"s/Addes/Adds/","commit_id":"ad6ad319100b033e1d06ecc522508dc7d512e24c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ae7a47b8baafa42d6e11411b07733fae6fbce6a2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Allocation API was introduced."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. versionadded:: 1.58"},{"line_number":48,"context_line":"    Addes support for backfilling allocations."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Normal response codes: 201"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bfb3d3c7_b02b8080","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":9},"updated":"2019-05-21 13:17:52.000000000","message":"nit: Adds","commit_id":"149d5763efcc2ea37e42ddfc107e4eff85cee26b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"147481510e1bb8401ef1f57694013ef1f14b4df5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Allocation API was introduced."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. versionadded:: 1.58"},{"line_number":48,"context_line":"    Addes support for backfilling allocations."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Normal response codes: 201"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bfb3d3c7_ea07c31b","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":9},"in_reply_to":"bfb3d3c7_b02b8080","updated":"2019-05-21 18:05:28.000000000","message":"Done","commit_id":"149d5763efcc2ea37e42ddfc107e4eff85cee26b"}],"ironic/conductor/allocations.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ae7a47b8baafa42d6e11411b07733fae6fbce6a2","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                          \u0027cand\u0027: allocation.candidate_nodes,"},{"line_number":310,"context_line":"                          \u0027uuid\u0027: allocation.uuid}"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if error:"},{"line_number":313,"context_line":"            raise exception.AllocationFailed(uuid\u003dallocation.uuid, error\u003derror)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        allocation.node_id \u003d task.node.id"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_902e7c41","line":312,"updated":"2019-05-21 13:17:52.000000000","message":"If I understand correctly, the error here is just the latest encountered, that means that if we have a different error before it will be bypassed and forgotten.\nWould it make sense to maybe raise an exception with multiple error messages or directly multiple exceptions, so to underline all the errors occurred?\nOtherwise let\u0027s just stop at the first error encountered and raise there.","commit_id":"149d5763efcc2ea37e42ddfc107e4eff85cee26b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b6510503e3e92ff8587eaedc439f5480aefb35dd","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                          \u0027cand\u0027: allocation.candidate_nodes,"},{"line_number":310,"context_line":"                          \u0027uuid\u0027: allocation.uuid}"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if error:"},{"line_number":313,"context_line":"            raise exception.AllocationFailed(uuid\u003dallocation.uuid, error\u003derror)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        allocation.node_id \u003d task.node.id"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_6b9e7255","line":312,"in_reply_to":"bfb3d3c7_450e0033","updated":"2019-05-21 23:21:04.000000000","message":"lol I read too fast!","commit_id":"149d5763efcc2ea37e42ddfc107e4eff85cee26b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"147481510e1bb8401ef1f57694013ef1f14b4df5","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                          \u0027cand\u0027: allocation.candidate_nodes,"},{"line_number":310,"context_line":"                          \u0027uuid\u0027: allocation.uuid}"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        if error:"},{"line_number":313,"context_line":"            raise exception.AllocationFailed(uuid\u003dallocation.uuid, error\u003derror)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        allocation.node_id \u003d task.node.id"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_450e0033","line":312,"in_reply_to":"bfb3d3c7_902e7c41","updated":"2019-05-21 18:05:28.000000000","message":"\u003e Otherwise let\u0027s just stop at the first error encountered and raise there\n\nWe actually do it, note that all checks are done in \"elif\" blocks, so only the first gets executed. I can try squashing all error messages.","commit_id":"149d5763efcc2ea37e42ddfc107e4eff85cee26b"}],"ironic/conductor/manager.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ae7a47b8baafa42d6e11411b07733fae6fbce6a2","unresolved":false,"context_lines":[{"line_number":3523,"context_line":"        allocation.conductor_affinity \u003d self.conductor.id"},{"line_number":3524,"context_line":"        # Allocation backfilling is handled separately, remove node_id for now."},{"line_number":3525,"context_line":"        # Cannot use plain getattr here since oslo.versionedobjects raise"},{"line_number":3526,"context_line":"        # NotImplementedError instead of AttributeError (because life is pain)."},{"line_number":3527,"context_line":"        if \u0027node_id\u0027 in allocation and allocation.node_id:"},{"line_number":3528,"context_line":"            node_id \u003d allocation.node_id"},{"line_number":3529,"context_line":"            allocation.node_id \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfb3d3c7_f08c9880","line":3526,"range":{"start_line":3526,"start_character":57,"end_line":3526,"end_character":77},"updated":"2019-05-21 13:17:52.000000000","message":"++ :/","commit_id":"149d5763efcc2ea37e42ddfc107e4eff85cee26b"}]}