)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0bb7d6903de0c8d3341470938faff7d70d1da7ed","unresolved":false,"context_lines":[{"line_number":15,"context_line":"values matching to nic id and then update the port\u0027s pxe_enabled field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I23fa6165a542c652190c106a63beb5be98d55808"},{"line_number":18,"context_line":"Story: 2005364"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9fb8cfa7_1c11815e","line":18,"updated":"2019-07-02 21:01:41.000000000","message":"No task number?","commit_id":"916bfcc6eff70685a62a1ee551d9bd4d2fa2ad62"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"b528de97efe06b5bed938aacc117a0b5a1e986b6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"values matching to nic id and then update the port\u0027s pxe_enabled field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I23fa6165a542c652190c106a63beb5be98d55808"},{"line_number":18,"context_line":"Story: 2005364"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9fb8cfa7_a94cb4c8","line":18,"in_reply_to":"9fb8cfa7_1c11815e","updated":"2019-07-03 03:48:24.000000000","message":"Done","commit_id":"916bfcc6eff70685a62a1ee551d9bd4d2fa2ad62"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a9b4a1eb2a2681d4444321dc8c3fe386a176e63a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Reason of this failure is because we are not checking the"},{"line_number":11,"context_line":"actual pxe device interface and updating the port pxe_enabled field."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch make sure that everytime when port is created, it checks the"},{"line_number":14,"context_line":"the BIOS and UEFI boot modes of node and fetch the pxe device interfaces"},{"line_number":15,"context_line":"values matching to nic id and then update the port\u0027s pxe_enabled field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I23fa6165a542c652190c106a63beb5be98d55808"},{"line_number":18,"context_line":"Story: 2005364"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"9fb8cfa7_cd19eb7a","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":71},"updated":"2019-07-03 13:09:06.000000000","message":"So here is the fundamental issue. The port\u0027s pxe_enabled is intended to be set by administrators to be authoritative for their environment. I.e. I know I\u0027ve patched port 1 and port 2 to the provisioning network or switch, and I only want those to PXE, so I\u0027ll set them appropriately from ironic which should be the authoritative source of truth. Based upon that value is how templates are written, port configurations are chosen, and ultimately what port(s) are used in provisioning port binding.\n\nYour commit message is your making the individual piece of hardware authoritative, which is really a feature and one that doesn\u0027t align with the overall interaction of the pxe_enabled field for operators, and doesn\u0027t exactly qualify as a stable backport as a bug fix. Granted, it may be nice to know from introspection what ports were pxe enabled, but again such behavior is a feature.","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"87451b2bb3bf533a0401ea698a1b58267251d8b8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Reason of this failure is because we are not checking the"},{"line_number":11,"context_line":"actual pxe device interface and updating the port pxe_enabled field."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch make sure that everytime when port is created, it checks the"},{"line_number":14,"context_line":"the BIOS and UEFI boot modes of node and fetch the pxe device interfaces"},{"line_number":15,"context_line":"values matching to nic id and then update the port\u0027s pxe_enabled field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I23fa6165a542c652190c106a63beb5be98d55808"},{"line_number":18,"context_line":"Story: 2005364"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"7faddb67_2febe9b0","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":71},"in_reply_to":"9fb8cfa7_cd19eb7a","updated":"2019-07-03 19:49:44.000000000","message":"Hey Julia, while this may look like a new feature, it is actually a fix for a bug that has a long history: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1395819\nTLDR: If pxe_enabled is not set, then nodes can fail to PXE boot during deployment.  This is an exceptionally bad user experience in a tripleo environment, where a deployment could take a couple hours to fail.\n\nAnd to make things more confusing for the user, when in-band introspection is used, pxe_enabled is automatically correctly set on the ports and everything works perfectly (at least with OSP13).  This fix modifies iDRAC OOB introspection to behave the same way that IB introspection does in regards to setting pxe_enabled.\n\nI agree that Ironic should be the authoritative source for setting pxe_enabled.  That said, I think it\u0027s a good thing for introspection (IB or OOB) to discover the current PXE configuration.  This makes it visible to the user and if they want to change it, then they can certainly do that.\n\nMaybe an update to the commit comment would help?","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a9b4a1eb2a2681d4444321dc8c3fe386a176e63a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch make sure that everytime when port is created, it checks the"},{"line_number":14,"context_line":"the BIOS and UEFI boot modes of node and fetch the pxe device interfaces"},{"line_number":15,"context_line":"values matching to nic id and then update the port\u0027s pxe_enabled field."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I23fa6165a542c652190c106a63beb5be98d55808"},{"line_number":18,"context_line":"Story: 2005364"},{"line_number":19,"context_line":"Task: 30339"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"9fb8cfa7_6d723fb0","line":16,"updated":"2019-07-03 13:09:06.000000000","message":"As I understand it, this is a backport, we\u0027re missing the tag from which commit it was cherry picked to start?  \n\n    commit 47efa3627b14f1fcaaf274429e5b941c77bf0339\n    Merge: 3d9978bde 2b74d940c\n    Author: Zuul \u003czuul@review.openstack.org\u003e\n    Date:   Thu Dec 6 05:49:00 2018 +0000\n\n    Merge \"Fix OOB introspection to use pxe_enabled flag in idrac driver\"\n\n------\n    commit 2b74d940c932c1bb4498f47372c0545e4480799f\n    Author: digambar \u003cdigambarpatil15@yahoo.co.in\u003e\n    Date:   Tue Nov 27 04:17:02 2018 -0500\n\n    Fix OOB introspection to use pxe_enabled flag in idrac driver","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"59a45d055f25f7feb64bbab1dbd68313aa104f07","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I23fa6165a542c652190c106a63beb5be98d55808"},{"line_number":18,"context_line":"Story: 2005364"},{"line_number":19,"context_line":"Task: 30339"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"7faddb67_873036ea","line":19,"updated":"2019-07-12 17:53:06.000000000","message":"Can you add a line to indicate what patch this was cherry picked from?  Like this:\n(cherry picked from commit 2b74d940c932c1bb4498f47372c0545e4480799f)","commit_id":"a5bf3dd62f0de3b71d45ce4dc4b4d8ca2eb4ccd0"}],"ironic/drivers/modules/drac/inspect.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"feb51a20f7c4de36adc1eb1ac30bc97452473d62","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        :param client: Dracclient to list the bios settings and nics"},{"line_number":170,"context_line":"        :param nics: list of nics"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        :returns: Returns list of pxe device interfaces."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":"        pxe_dev_nics \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_f0f31a09","line":171,"updated":"2019-05-09 08:59:17.000000000","message":"missing param node","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"9d628e425f832882c4ecf31c6b0418cbfc55d0c0","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        :param client: Dracclient to list the bios settings and nics"},{"line_number":170,"context_line":"        :param nics: list of nics"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        :returns: Returns list of pxe device interfaces."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":"        pxe_dev_nics \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_67d197fb","line":171,"in_reply_to":"dfbec78f_f0f31a09","updated":"2019-05-10 08:27:17.000000000","message":"Done","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"change_message_id":"b1190c1419330a6f2df384d4ef61e157b0a1e1d3","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        :param client: Dracclient to list the bios settings and nics"},{"line_number":170,"context_line":"        :param nics: list of nics"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        :returns: Returns list of pxe device interfaces."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":"        pxe_dev_nics \u003d []"},{"line_number":175,"context_line":"        pxe_params \u003d [\"PxeDev1EnDis\", \"PxeDev2EnDis\","}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_9c799e94","line":172,"updated":"2019-05-08 21:20:40.000000000","message":"missing :raises:","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"9d628e425f832882c4ecf31c6b0418cbfc55d0c0","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        :param client: Dracclient to list the bios settings and nics"},{"line_number":170,"context_line":"        :param nics: list of nics"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        :returns: Returns list of pxe device interfaces."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":"        pxe_dev_nics \u003d []"},{"line_number":175,"context_line":"        pxe_params \u003d [\"PxeDev1EnDis\", \"PxeDev2EnDis\","}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_87cccb61","line":172,"in_reply_to":"dfbec78f_9c799e94","updated":"2019-05-10 08:27:17.000000000","message":"will do","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"917d75425a7850afb951a5d79c3421e941f04e90","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        \"\"\"Get nic attributes."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        :param nic_id: an FQDD of NIC"},{"line_number":220,"context_line":"        :param client: Dracclient instance"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        :returns: Returns dict of NIC FQDD and LegacyBootProto."},{"line_number":223,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"9fb8cfa7_48be2000","line":220,"updated":"2019-06-19 19:04:49.000000000","message":"Can you order the above params in the same order as in the method signature?","commit_id":"55486f25d6abeab63d270bfb4c8580b395be26ba"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"9067d55c1d2438b6c2e6e45ff0eff4c945ddfe3b","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        \"\"\"Get nic attributes."},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        :param nic_id: an FQDD of NIC"},{"line_number":220,"context_line":"        :param client: Dracclient instance"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        :returns: Returns dict of NIC FQDD and LegacyBootProto."},{"line_number":223,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"9fb8cfa7_24daf0e8","line":220,"in_reply_to":"9fb8cfa7_48be2000","updated":"2019-06-20 06:05:40.000000000","message":"Done","commit_id":"55486f25d6abeab63d270bfb4c8580b395be26ba"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"917d75425a7850afb951a5d79c3421e941f04e90","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        :param nic_id: an FQDD of NIC"},{"line_number":220,"context_line":"        :param client: Dracclient instance"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        :returns: Returns dict of NIC FQDD and LegacyBootProto."},{"line_number":223,"context_line":"        \"\"\""},{"line_number":224,"context_line":"        result \u003d {}"},{"line_number":225,"context_line":"        doc \u003d client.client.enumerate(DCIM_NICEnumeration)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9fb8cfa7_e844b41d","line":222,"updated":"2019-06-19 19:04:49.000000000","message":"In the line above, can you change \"Returns dict ...\" to \"a dict ...\"?","commit_id":"55486f25d6abeab63d270bfb4c8580b395be26ba"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"9067d55c1d2438b6c2e6e45ff0eff4c945ddfe3b","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        :param nic_id: an FQDD of NIC"},{"line_number":220,"context_line":"        :param client: Dracclient instance"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        :returns: Returns dict of NIC FQDD and LegacyBootProto."},{"line_number":223,"context_line":"        \"\"\""},{"line_number":224,"context_line":"        result \u003d {}"},{"line_number":225,"context_line":"        doc \u003d client.client.enumerate(DCIM_NICEnumeration)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9fb8cfa7_44d5a4b6","line":222,"in_reply_to":"9fb8cfa7_e844b41d","updated":"2019-06-20 06:05:40.000000000","message":"Done","commit_id":"55486f25d6abeab63d270bfb4c8580b395be26ba"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2542cc51dc8550cf242b445ae6bde234020c7bcd","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        :param nics: list of nics"},{"line_number":175,"context_line":"        :param node: Baremetal Node object"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        :returns: Returns list of pxe device interfaces."},{"line_number":178,"context_line":"        \"\"\""},{"line_number":179,"context_line":"        pxe_dev_nics \u003d []"},{"line_number":180,"context_line":"        nic_cap \u003d {}"}],"source_content_type":"text/x-python","patch_set":18,"id":"9fb8cfa7_61d21037","line":177,"updated":"2019-06-20 14:51:40.000000000","message":"Can you remove the word \"Returns\" on the line above?  When the docs are generated, the \":returns:\" is converted to \"Returns:\".  This will make the above statement looks like this in the generated docs:\nReturns: Returns list of ...\nSee this link for an example:\nhttps://docs.openstack.org/ironic/stein/contributor/api/ironic.drivers.modules.drac.inspect.html#ironic.drivers.modules.drac.inspect.DracInspect","commit_id":"8f08c07df7ffd7a490865a060181b3975b9121b3"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"2542cc51dc8550cf242b445ae6bde234020c7bcd","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        :param client: Dracclient instance"},{"line_number":220,"context_line":"        :param nic_id: an FQDD of NIC"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        :returns: Returns a dict of FQDD, LegacyBootProto."},{"line_number":223,"context_line":"        \"\"\""},{"line_number":224,"context_line":"        result \u003d {}"},{"line_number":225,"context_line":"        doc \u003d client.client.enumerate(DCIM_NICEnumeration)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9fb8cfa7_81d5c41d","line":222,"updated":"2019-06-20 14:51:40.000000000","message":"Can you remove the word \"Returns\" on the line above?","commit_id":"8f08c07df7ffd7a490865a060181b3975b9121b3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0bb7d6903de0c8d3341470938faff7d70d1da7ed","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"DCIM_NICEnumeration \u003d (\u0027http://schemas.dell.com/wbem/wscim/1/cim-schema/2/\u0027"},{"line_number":34,"context_line":"                       \u0027DCIM_NICEnumeration\u0027)  # noqa"},{"line_number":35,"context_line":"NS_WSMAN \u003d \u0027http://schemas.dmtf.org/wbem/wsman/1/wsman.xsd\u0027  # noqa"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_7c1c3d77","line":35,"range":{"start_line":35,"start_character":61,"end_line":35,"end_character":67},"updated":"2019-07-02 21:01:41.000000000","message":"This shouldn\u0027t need noqa... honestly.","commit_id":"916bfcc6eff70685a62a1ee551d9bd4d2fa2ad62"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"b528de97efe06b5bed938aacc117a0b5a1e986b6","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"DCIM_NICEnumeration \u003d (\u0027http://schemas.dell.com/wbem/wscim/1/cim-schema/2/\u0027"},{"line_number":34,"context_line":"                       \u0027DCIM_NICEnumeration\u0027)  # noqa"},{"line_number":35,"context_line":"NS_WSMAN \u003d \u0027http://schemas.dmtf.org/wbem/wsman/1/wsman.xsd\u0027  # noqa"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9fb8cfa7_897bf0f2","line":35,"range":{"start_line":35,"start_character":61,"end_line":35,"end_character":67},"in_reply_to":"9fb8cfa7_7c1c3d77","updated":"2019-07-03 03:48:24.000000000","message":"Done","commit_id":"916bfcc6eff70685a62a1ee551d9bd4d2fa2ad62"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"87451b2bb3bf533a0401ea698a1b58267251d8b8","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":124,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":125,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        for nic in nics:"},{"line_number":128,"context_line":"            try:"},{"line_number":129,"context_line":"                port \u003d objects.Port(task.context, address\u003dnic.mac,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7faddb67_ac8e07ce","line":126,"updated":"2019-07-03 19:49:44.000000000","message":"The code that calls into self._get_pxe_dev_nics() is missing here.","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c3fc6b1775be067012dee4162d67122a9591c055","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                      \u0027%(node_uuid)s. Reason: %(error)s.\u0027,"},{"line_number":124,"context_line":"                      {\u0027node_uuid\u0027: node.uuid, \u0027error\u0027: exc})"},{"line_number":125,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        for nic in nics:"},{"line_number":128,"context_line":"            try:"},{"line_number":129,"context_line":"                port \u003d objects.Port(task.context, address\u003dnic.mac,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7faddb67_a3204df9","line":126,"in_reply_to":"7faddb67_ac8e07ce","updated":"2019-07-05 07:31:29.000000000","message":"Ohh.. My god, how did I miss that.\nWhile updating patchsets, I haven\u0027t updated my tested code.\nBig Thank you for this.","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"87451b2bb3bf533a0401ea698a1b58267251d8b8","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        for nic in nics:"},{"line_number":128,"context_line":"            try:"},{"line_number":129,"context_line":"                port \u003d objects.Port(task.context, address\u003dnic.mac,"},{"line_number":130,"context_line":"                                    node_id\u003dnode.id)"},{"line_number":131,"context_line":"                port.create()"},{"line_number":132,"context_line":"                LOG.info(\u0027Port created with MAC address %(mac)s \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7faddb67_4c9433e9","line":129,"updated":"2019-07-03 19:49:44.000000000","message":"The code that sets pxe_enabled is missing here","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c3fc6b1775be067012dee4162d67122a9591c055","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        for nic in nics:"},{"line_number":128,"context_line":"            try:"},{"line_number":129,"context_line":"                port \u003d objects.Port(task.context, address\u003dnic.mac,"},{"line_number":130,"context_line":"                                    node_id\u003dnode.id)"},{"line_number":131,"context_line":"                port.create()"},{"line_number":132,"context_line":"                LOG.info(\u0027Port created with MAC address %(mac)s \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7faddb67_637815f8","line":129,"in_reply_to":"7faddb67_4c9433e9","updated":"2019-07-05 07:31:29.000000000","message":"Done","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"87451b2bb3bf533a0401ea698a1b58267251d8b8","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        else:"},{"line_number":168,"context_line":"            return cpu.cores"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _get_pxe_dev_nics(self, client, nics, node):"},{"line_number":171,"context_line":"        \"\"\"Get a list of pxe device interfaces."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        :param client: Dracclient to list the bios settings and nics"}],"source_content_type":"text/x-python","patch_set":21,"id":"7faddb67_6f2fa1f6","line":170,"updated":"2019-07-03 19:49:44.000000000","message":"Oops!  _get_pxe_dev_nics() is never called.","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c3fc6b1775be067012dee4162d67122a9591c055","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        else:"},{"line_number":168,"context_line":"            return cpu.cores"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _get_pxe_dev_nics(self, client, nics, node):"},{"line_number":171,"context_line":"        \"\"\"Get a list of pxe device interfaces."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        :param client: Dracclient to list the bios settings and nics"}],"source_content_type":"text/x-python","patch_set":21,"id":"7faddb67_837d11e9","line":170,"in_reply_to":"7faddb67_6f2fa1f6","updated":"2019-07-05 07:31:29.000000000","message":"Done","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04b5db976a8702941c3a60aec927838fb74def1d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":128,"context_line":"        if pxe_dev_nics is None:"},{"line_number":129,"context_line":"            LOG.warning(\u0027No PXE enabled NIC was found for node \u0027"},{"line_number":130,"context_line":"                        \u0027%(node_uuid)s.\u0027, {\u0027node_uuid\u0027: node.uuid})"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"7faddb67_0925b70a","line":128,"updated":"2019-08-08 07:59:47.000000000","message":"pxe_dev_nics cannot be None, did you mean\n\n if not pxe_dev_nics:\n\n?","commit_id":"5e8b28ac71b054214f74edebbe5f6e7dd3b51711"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"eb84c8c37695b68365921c919cbb7399af204eda","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            raise exception.HardwareInspectionFailure(error\u003dexc)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        pxe_dev_nics \u003d self._get_pxe_dev_nics(client, nics, node)"},{"line_number":128,"context_line":"        if pxe_dev_nics is None:"},{"line_number":129,"context_line":"            LOG.warning(\u0027No PXE enabled NIC was found for node \u0027"},{"line_number":130,"context_line":"                        \u0027%(node_uuid)s.\u0027, {\u0027node_uuid\u0027: node.uuid})"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"7faddb67_51a915db","line":128,"in_reply_to":"7faddb67_0925b70a","updated":"2019-08-08 09:58:48.000000000","message":"Yep","commit_id":"5e8b28ac71b054214f74edebbe5f6e7dd3b51711"}],"ironic/drivers/modules/drac/nic.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"feb51a20f7c4de36adc1eb1ac30bc97452473d62","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.drivers.modules.drac.common import drac_wsman"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"DCIM_NICEnumeration \u003d (\u0027http://schemas.dell.com/wbem/wscim/1/cim-schema/2/\u0027"},{"line_number":25,"context_line":"                       \u0027DCIM_NICEnumeration\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_7093aafb","line":24,"updated":"2019-05-09 08:59:17.000000000","message":"I would not break the url, it\u0027s ok to be inconsistent in favor of readability :)\njust add a # noqa after the line","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"9d628e425f832882c4ecf31c6b0418cbfc55d0c0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.drivers.modules.drac.common import drac_wsman"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"DCIM_NICEnumeration \u003d (\u0027http://schemas.dell.com/wbem/wscim/1/cim-schema/2/\u0027"},{"line_number":25,"context_line":"                       \u0027DCIM_NICEnumeration\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_27db9f1b","line":24,"in_reply_to":"dfbec78f_7093aafb","updated":"2019-05-10 08:27:17.000000000","message":"Done","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"feb51a20f7c4de36adc1eb1ac30bc97452473d62","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def list_nic_settings(self, nic_id\u003dNone):"},{"line_number":77,"context_line":"        \"\"\"Get nic attributes."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        :param fqdd_filter: an FQDD of NIC"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :returns: Returns dict of NIC FQDD and LegacyBootProto."},{"line_number":82,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_f0b8fa76","line":79,"updated":"2019-05-09 08:59:17.000000000","message":"I don\u0027t see this param in the func definition, also missing param nic_id","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"a8c9740c54a31670fa0e113656159e7fe3ec1fc3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def list_nic_settings(self, nic_id\u003dNone):"},{"line_number":77,"context_line":"        \"\"\"Get nic attributes."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        :param fqdd_filter: an FQDD of NIC"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :returns: Returns dict of NIC FQDD and LegacyBootProto."},{"line_number":82,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_5a89cac7","line":79,"in_reply_to":"dfbec78f_f0b8fa76","updated":"2019-05-14 04:11:58.000000000","message":"Done","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"change_message_id":"b1190c1419330a6f2df384d4ef61e157b0a1e1d3","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        :param fqdd_filter: an FQDD of NIC"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :returns: Returns dict of NIC FQDD and LegacyBootProto."},{"line_number":82,"context_line":"        \"\"\""},{"line_number":83,"context_line":"        result \u003d {}"},{"line_number":84,"context_line":"        for (namespace, attr_cls) in self.NAMESPACES:"}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_7c9b8ac8","line":81,"updated":"2019-05-08 21:20:40.000000000","message":"also missing :raises:","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"feb51a20f7c4de36adc1eb1ac30bc97452473d62","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        :param client: an instance of DRACClient."},{"line_number":100,"context_line":"        :param resource: NIC URIS."},{"line_number":101,"context_line":"        :param attr_cls: NICEnumeration Class"},{"line_number":102,"context_line":"        :fqdd_filter: NIC FQDD."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        :returns: Returns dict of NIC FQDD and LegacyBootProto."},{"line_number":105,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_b0b28293","line":102,"updated":"2019-05-09 08:59:17.000000000","message":"missing param","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"a8c9740c54a31670fa0e113656159e7fe3ec1fc3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        :param client: an instance of DRACClient."},{"line_number":100,"context_line":"        :param resource: NIC URIS."},{"line_number":101,"context_line":"        :param attr_cls: NICEnumeration Class"},{"line_number":102,"context_line":"        :fqdd_filter: NIC FQDD."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        :returns: Returns dict of NIC FQDD and LegacyBootProto."},{"line_number":105,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_baa2464a","line":102,"in_reply_to":"dfbec78f_b0b28293","updated":"2019-05-14 04:11:58.000000000","message":"Done","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"}],"ironic/tests/unit/drivers/modules/drac/test_inspect.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"87451b2bb3bf533a0401ea698a1b58267251d8b8","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        self.node.refresh()"},{"line_number":265,"context_line":"        self.assertEqual(expected_node_properties, self.node.properties)"},{"line_number":266,"context_line":"        self.assertEqual(states.MANAGEABLE, return_value)"},{"line_number":267,"context_line":"        self.assertEqual(2, mock_port_create.call_count)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def test__guess_root_disk(self):"},{"line_number":270,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7faddb67_cc7583ce","line":267,"updated":"2019-07-03 19:49:44.000000000","message":"I think we should add a check here to verify that the pxe_enabled was set correctly on the appropriate port.","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c3fc6b1775be067012dee4162d67122a9591c055","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        self.node.refresh()"},{"line_number":265,"context_line":"        self.assertEqual(expected_node_properties, self.node.properties)"},{"line_number":266,"context_line":"        self.assertEqual(states.MANAGEABLE, return_value)"},{"line_number":267,"context_line":"        self.assertEqual(2, mock_port_create.call_count)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def test__guess_root_disk(self):"},{"line_number":270,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7faddb67_318819c5","line":267,"in_reply_to":"7faddb67_cc7583ce","updated":"2019-07-05 07:31:29.000000000","message":"Sure","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"}],"ironic/tests/unit/drivers/modules/drac/utils.py":[{"author":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"change_message_id":"b1190c1419330a6f2df384d4ef61e157b0a1e1d3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"class DictToObj(object):"},{"line_number":45,"context_line":"    \"\"\"Returns a dictionary into a class\"\"\""},{"line_number":46,"context_line":"    def __init__(self, dictionary):"},{"line_number":47,"context_line":"        for key in dictionary:"},{"line_number":48,"context_line":"            setattr(self, key, dictionary[key])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_21688b1f","line":47,"updated":"2019-05-08 21:20:40.000000000","message":"self.__dict__.update(dictionary) would be simpler","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"9d628e425f832882c4ecf31c6b0418cbfc55d0c0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"class DictToObj(object):"},{"line_number":45,"context_line":"    \"\"\"Returns a dictionary into a class\"\"\""},{"line_number":46,"context_line":"    def __init__(self, dictionary):"},{"line_number":47,"context_line":"        for key in dictionary:"},{"line_number":48,"context_line":"            setattr(self, key, dictionary[key])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_47a81376","line":47,"in_reply_to":"dfbec78f_0504617a","updated":"2019-05-10 08:27:17.000000000","message":"I think Setattr is best way to do it. I dont want to change. I agree with Riccardo.","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"feb51a20f7c4de36adc1eb1ac30bc97452473d62","unresolved":false,"context_lines":[{"line_number":44,"context_line":"class DictToObj(object):"},{"line_number":45,"context_line":"    \"\"\"Returns a dictionary into a class\"\"\""},{"line_number":46,"context_line":"    def __init__(self, dictionary):"},{"line_number":47,"context_line":"        for key in dictionary:"},{"line_number":48,"context_line":"            setattr(self, key, dictionary[key])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_9003be0f","line":47,"in_reply_to":"dfbec78f_21688b1f","updated":"2019-05-09 08:59:17.000000000","message":"I disagree, there is no need to touch the instance dictionary directly, I think the setattr func is more pythonic, clearer and safer way to do it","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"change_message_id":"d0b4e1e93975d2f8d821a265e9a1edf52f5e59b5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"class DictToObj(object):"},{"line_number":45,"context_line":"    \"\"\"Returns a dictionary into a class\"\"\""},{"line_number":46,"context_line":"    def __init__(self, dictionary):"},{"line_number":47,"context_line":"        for key in dictionary:"},{"line_number":48,"context_line":"            setattr(self, key, dictionary[key])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfbec78f_0504617a","line":47,"in_reply_to":"dfbec78f_9003be0f","updated":"2019-05-09 18:18:11.000000000","message":"I prefer updating the dict directly, but I understand your point about being more pythonic and can go either way on it. I don\u0027t really think it is any safer as implemented though.","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"}],"ironic/tests/unit/drivers/third_party_driver_mock_specs.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"917d75425a7850afb951a5d79c3421e941f04e90","unresolved":false,"context_lines":[{"line_number":20,"context_line":"DRACCLIENT_SPEC \u003d ("},{"line_number":21,"context_line":"    \u0027client\u0027,"},{"line_number":22,"context_line":"    \u0027constants\u0027,"},{"line_number":23,"context_line":"    \u0027exceptions\u0027,"},{"line_number":24,"context_line":")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DRACCLIENT_CLIENT_MOD_SPEC \u003d ("}],"source_content_type":"text/x-python","patch_set":15,"id":"9fb8cfa7_48c86073","line":23,"updated":"2019-06-19 19:04:49.000000000","message":"Can you undo the change on the above line?","commit_id":"55486f25d6abeab63d270bfb4c8580b395be26ba"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"9067d55c1d2438b6c2e6e45ff0eff4c945ddfe3b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"DRACCLIENT_SPEC \u003d ("},{"line_number":21,"context_line":"    \u0027client\u0027,"},{"line_number":22,"context_line":"    \u0027constants\u0027,"},{"line_number":23,"context_line":"    \u0027exceptions\u0027,"},{"line_number":24,"context_line":")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DRACCLIENT_CLIENT_MOD_SPEC \u003d ("}],"source_content_type":"text/x-python","patch_set":15,"id":"9fb8cfa7_04dfacd6","line":23,"in_reply_to":"9fb8cfa7_48c86073","updated":"2019-06-20 06:05:40.000000000","message":"Done","commit_id":"55486f25d6abeab63d270bfb4c8580b395be26ba"}],"lower-constraints.txt":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"917d75425a7850afb951a5d79c3421e941f04e90","unresolved":false,"context_lines":[{"line_number":125,"context_line":"repoze.lru\u003d\u003d0.7"},{"line_number":126,"context_line":"requests\u003d\u003d2.14.2"},{"line_number":127,"context_line":"requestsexceptions\u003d\u003d1.4.0"},{"line_number":128,"context_line":"requests-mock\u003d\u003d1.5.2"},{"line_number":129,"context_line":"restructuredtext-lint\u003d\u003d1.1.3"},{"line_number":130,"context_line":"retrying\u003d\u003d1.2.3"},{"line_number":131,"context_line":"rfc3986\u003d\u003d0.3.1"}],"source_content_type":"text/plain","patch_set":15,"id":"9fb8cfa7_08190887","line":128,"updated":"2019-06-19 19:04:49.000000000","message":"Are you sure we need requests-mock?  It doesn\u0027t look like the new unit tests are mocking at that level.","commit_id":"55486f25d6abeab63d270bfb4c8580b395be26ba"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"9067d55c1d2438b6c2e6e45ff0eff4c945ddfe3b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"repoze.lru\u003d\u003d0.7"},{"line_number":126,"context_line":"requests\u003d\u003d2.14.2"},{"line_number":127,"context_line":"requestsexceptions\u003d\u003d1.4.0"},{"line_number":128,"context_line":"requests-mock\u003d\u003d1.5.2"},{"line_number":129,"context_line":"restructuredtext-lint\u003d\u003d1.1.3"},{"line_number":130,"context_line":"retrying\u003d\u003d1.2.3"},{"line_number":131,"context_line":"rfc3986\u003d\u003d0.3.1"}],"source_content_type":"text/plain","patch_set":15,"id":"9fb8cfa7_84ecfc8f","line":128,"in_reply_to":"9fb8cfa7_08190887","updated":"2019-06-20 06:05:40.000000000","message":"No, its not needed now. I forgot to remove.\nDone!","commit_id":"55486f25d6abeab63d270bfb4c8580b395be26ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0bb7d6903de0c8d3341470938faff7d70d1da7ed","unresolved":false,"context_lines":[{"line_number":50,"context_line":"kombu\u003d\u003d4.1.0"},{"line_number":51,"context_line":"linecache2\u003d\u003d1.0.0"},{"line_number":52,"context_line":"logutils\u003d\u003d0.3.5"},{"line_number":53,"context_line":"lxml\u003d\u003d4.3.3"},{"line_number":54,"context_line":"Mako\u003d\u003d1.0.7"},{"line_number":55,"context_line":"MarkupSafe\u003d\u003d1.0"},{"line_number":56,"context_line":"mccabe\u003d\u003d0.2.1"}],"source_content_type":"text/plain","patch_set":20,"id":"9fb8cfa7_bc287597","line":53,"updated":"2019-07-02 21:01:41.000000000","message":"This value exceeds the upper constraint for rocky.\nhttps://github.com/openstack/requirements/blob/stable/rocky/upper-constraints.txt#L29","commit_id":"916bfcc6eff70685a62a1ee551d9bd4d2fa2ad62"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"b528de97efe06b5bed938aacc117a0b5a1e986b6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"kombu\u003d\u003d4.1.0"},{"line_number":51,"context_line":"linecache2\u003d\u003d1.0.0"},{"line_number":52,"context_line":"logutils\u003d\u003d0.3.5"},{"line_number":53,"context_line":"lxml\u003d\u003d4.3.3"},{"line_number":54,"context_line":"Mako\u003d\u003d1.0.7"},{"line_number":55,"context_line":"MarkupSafe\u003d\u003d1.0"},{"line_number":56,"context_line":"mccabe\u003d\u003d0.2.1"}],"source_content_type":"text/plain","patch_set":20,"id":"9fb8cfa7_a91ef4b8","line":53,"in_reply_to":"9fb8cfa7_bc287597","updated":"2019-07-03 03:48:24.000000000","message":"Done","commit_id":"916bfcc6eff70685a62a1ee551d9bd4d2fa2ad62"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a9b4a1eb2a2681d4444321dc8c3fe386a176e63a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"kombu\u003d\u003d4.1.0"},{"line_number":51,"context_line":"linecache2\u003d\u003d1.0.0"},{"line_number":52,"context_line":"logutils\u003d\u003d0.3.5"},{"line_number":53,"context_line":"lxml\u003d\u003d4.2.3"},{"line_number":54,"context_line":"Mako\u003d\u003d1.0.7"},{"line_number":55,"context_line":"MarkupSafe\u003d\u003d1.0"},{"line_number":56,"context_line":"mccabe\u003d\u003d0.2.1"}],"source_content_type":"text/plain","patch_set":21,"id":"9fb8cfa7_c2653a1f","line":53,"updated":"2019-07-03 13:09:06.000000000","message":"Is there a lower version that this will work with because ideally this should not be a single version of this library across the ecosystem. In other words what is the minimum version necessary?","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"c3fc6b1775be067012dee4162d67122a9591c055","unresolved":false,"context_lines":[{"line_number":50,"context_line":"kombu\u003d\u003d4.1.0"},{"line_number":51,"context_line":"linecache2\u003d\u003d1.0.0"},{"line_number":52,"context_line":"logutils\u003d\u003d0.3.5"},{"line_number":53,"context_line":"lxml\u003d\u003d4.2.3"},{"line_number":54,"context_line":"Mako\u003d\u003d1.0.7"},{"line_number":55,"context_line":"MarkupSafe\u003d\u003d1.0"},{"line_number":56,"context_line":"mccabe\u003d\u003d0.2.1"}],"source_content_type":"text/plain","patch_set":21,"id":"7faddb67_91a30d50","line":53,"in_reply_to":"9fb8cfa7_c2653a1f","updated":"2019-07-05 07:31:29.000000000","message":"I will certainly try lowest version. If it works, will update accordingly","commit_id":"e7820ceecc0922061b00874ad3608878c07c4e98"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"117615186fe3ab348ee891801f88f2aeaf1b5a01","unresolved":false,"context_lines":[{"line_number":50,"context_line":"kombu\u003d\u003d4.1.0"},{"line_number":51,"context_line":"linecache2\u003d\u003d1.0.0"},{"line_number":52,"context_line":"logutils\u003d\u003d0.3.5"},{"line_number":53,"context_line":"lxml\u003d\u003d4.0.0"},{"line_number":54,"context_line":"Mako\u003d\u003d1.0.7"},{"line_number":55,"context_line":"MarkupSafe\u003d\u003d1.0"},{"line_number":56,"context_line":"mccabe\u003d\u003d0.2.1"}],"source_content_type":"text/plain","patch_set":27,"id":"7faddb67_130381c0","line":53,"updated":"2019-08-09 18:38:58.000000000","message":"Since the dependency on lxml has been removed, this change is unneeded.","commit_id":"51c62aa96236f5cb10a720df751306e55b633239"}],"test-requirements.txt":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"feb51a20f7c4de36adc1eb1ac30bc97452473d62","unresolved":false,"context_lines":[{"line_number":12,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":13,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":14,"context_line":"psycopg2\u003e\u003d2.6.2 # LGPL/ZPL"},{"line_number":15,"context_line":"requests-mock\u003e\u003d1.5.2 # Apache-2.0"},{"line_number":16,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":17,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":18,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":8,"id":"dfbec78f_733654e9","line":15,"updated":"2019-05-09 08:59:17.000000000","message":"is this the minimum version required?","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"9d628e425f832882c4ecf31c6b0418cbfc55d0c0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":13,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":14,"context_line":"psycopg2\u003e\u003d2.6.2 # LGPL/ZPL"},{"line_number":15,"context_line":"requests-mock\u003e\u003d1.5.2 # Apache-2.0"},{"line_number":16,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":17,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":18,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":8,"id":"dfbec78f_0793fb50","line":15,"in_reply_to":"dfbec78f_733654e9","updated":"2019-05-10 08:27:17.000000000","message":"Yes","commit_id":"5145cf216913e35af9e89f670ea79e184f6c03d8"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"917d75425a7850afb951a5d79c3421e941f04e90","unresolved":false,"context_lines":[{"line_number":13,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":14,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":15,"context_line":"psycopg2\u003e\u003d2.6.2 # LGPL/ZPL"},{"line_number":16,"context_line":"requests-mock\u003e\u003d1.5.2 # Apache-2.0"},{"line_number":17,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":18,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":19,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":15,"id":"9fb8cfa7_c8121063","line":16,"updated":"2019-06-19 19:04:49.000000000","message":"Are you sure we need requests-mock?  It doesn\u0027t look like the new unit tests are mocking at that level.","commit_id":"55486f25d6abeab63d270bfb4c8580b395be26ba"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"9067d55c1d2438b6c2e6e45ff0eff4c945ddfe3b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":14,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":15,"context_line":"psycopg2\u003e\u003d2.6.2 # LGPL/ZPL"},{"line_number":16,"context_line":"requests-mock\u003e\u003d1.5.2 # Apache-2.0"},{"line_number":17,"context_line":"testtools\u003e\u003d2.2.0 # MIT"},{"line_number":18,"context_line":"testresources\u003e\u003d2.0.0 # Apache-2.0/BSD"},{"line_number":19,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":15,"id":"9fb8cfa7_2403d044","line":16,"in_reply_to":"9fb8cfa7_c8121063","updated":"2019-06-20 06:05:40.000000000","message":"Done","commit_id":"55486f25d6abeab63d270bfb4c8580b395be26ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0bb7d6903de0c8d3341470938faff7d70d1da7ed","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Babel!\u003d2.4.0,\u003e\u003d2.3.4 # BSD"},{"line_number":10,"context_line":"PyMySQL\u003e\u003d0.7.6 # MIT License"},{"line_number":11,"context_line":"iso8601\u003e\u003d0.1.11 # MIT"},{"line_number":12,"context_line":"lxml\u003e\u003d4.3.3 # BSD"},{"line_number":13,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":14,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":15,"context_line":"psycopg2\u003e\u003d2.6.2 # LGPL/ZPL"}],"source_content_type":"text/plain","patch_set":20,"id":"9fb8cfa7_fc1eed72","line":12,"updated":"2019-07-02 21:01:41.000000000","message":"This exceeds the upper constraints bound for Rocky\n\nhttps://github.com/openstack/requirements/blob/stable/rocky/upper-constraints.txt#L29","commit_id":"916bfcc6eff70685a62a1ee551d9bd4d2fa2ad62"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"b528de97efe06b5bed938aacc117a0b5a1e986b6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Babel!\u003d2.4.0,\u003e\u003d2.3.4 # BSD"},{"line_number":10,"context_line":"PyMySQL\u003e\u003d0.7.6 # MIT License"},{"line_number":11,"context_line":"iso8601\u003e\u003d0.1.11 # MIT"},{"line_number":12,"context_line":"lxml\u003e\u003d4.3.3 # BSD"},{"line_number":13,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":14,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":15,"context_line":"psycopg2\u003e\u003d2.6.2 # LGPL/ZPL"}],"source_content_type":"text/plain","patch_set":20,"id":"9fb8cfa7_6976bc0f","line":12,"in_reply_to":"9fb8cfa7_fc1eed72","updated":"2019-07-03 03:48:24.000000000","message":"Done","commit_id":"916bfcc6eff70685a62a1ee551d9bd4d2fa2ad62"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04b5db976a8702941c3a60aec927838fb74def1d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Babel!\u003d2.4.0,\u003e\u003d2.3.4 # BSD"},{"line_number":10,"context_line":"PyMySQL\u003e\u003d0.7.6 # MIT License"},{"line_number":11,"context_line":"iso8601\u003e\u003d0.1.11 # MIT"},{"line_number":12,"context_line":"lxml\u003e\u003d4.0.0 # BSD"},{"line_number":13,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":14,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":15,"context_line":"psycopg2\u003e\u003d2.6.2 # LGPL/ZPL"}],"source_content_type":"text/plain","patch_set":25,"id":"7faddb67_2922f302","line":12,"updated":"2019-08-08 07:59:47.000000000","message":"We shouldn\u0027t add new dependencies on stable branches. Since it\u0027s only for tests, could you use the built-in python ElementTree?","commit_id":"5e8b28ac71b054214f74edebbe5f6e7dd3b51711"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"eb84c8c37695b68365921c919cbb7399af204eda","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Babel!\u003d2.4.0,\u003e\u003d2.3.4 # BSD"},{"line_number":10,"context_line":"PyMySQL\u003e\u003d0.7.6 # MIT License"},{"line_number":11,"context_line":"iso8601\u003e\u003d0.1.11 # MIT"},{"line_number":12,"context_line":"lxml\u003e\u003d4.0.0 # BSD"},{"line_number":13,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":14,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":15,"context_line":"psycopg2\u003e\u003d2.6.2 # LGPL/ZPL"}],"source_content_type":"text/plain","patch_set":25,"id":"7faddb67_31957989","line":12,"in_reply_to":"7faddb67_2922f302","updated":"2019-08-08 09:58:48.000000000","message":"As dracclient library uses lxml lib so I used here.\nI need to test changing the above attributes with xml.Element instead of lxml.","commit_id":"5e8b28ac71b054214f74edebbe5f6e7dd3b51711"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"117615186fe3ab348ee891801f88f2aeaf1b5a01","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Babel!\u003d2.4.0,\u003e\u003d2.3.4 # BSD"},{"line_number":10,"context_line":"PyMySQL\u003e\u003d0.7.6 # MIT License"},{"line_number":11,"context_line":"iso8601\u003e\u003d0.1.11 # MIT"},{"line_number":12,"context_line":"lxml\u003e\u003d4.0.0 # BSD"},{"line_number":13,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":14,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":15,"context_line":"psycopg2\u003e\u003d2.6.2 # LGPL/ZPL"}],"source_content_type":"text/plain","patch_set":27,"id":"7faddb67_3308fdd7","line":12,"updated":"2019-08-09 18:38:58.000000000","message":"Since the dependency on lxml has been removed, this change is unneeded.","commit_id":"51c62aa96236f5cb10a720df751306e55b633239"}]}