)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"615ddd16aa420a6350b780a1d79cf9107c7cf4bd","unresolved":false,"context_lines":[{"line_number":2892,"context_line":""},{"line_number":2893,"context_line":"        filters \u003d {}"},{"line_number":2894,"context_line":"        if not CONF.conductor.send_sensor_data_all_nodes:"},{"line_number":2895,"context_line":"            filters[\u0027associated\u0027] \u003d True"},{"line_number":2896,"context_line":""},{"line_number":2897,"context_line":"        nodes \u003d queue.Queue()"},{"line_number":2898,"context_line":"        for node_info in self.iter_nodes(fields\u003d[\u0027instance_uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_82f2e86e","line":2895,"updated":"2019-03-29 18:09:59.000000000","message":"While we\u0027re here, maybe change this to \u0027provision_state\u0027: \u0027active\u0027? Associated !\u003d deployed (in addition to what you spotted, a node can have an instance_uuid in any state).","commit_id":"7921233bbc744285efe6eaa39ed2b5e76d096727"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ced743a9ec71b2e5ffea3f7ee49fedba79f143ff","unresolved":false,"context_lines":[{"line_number":2892,"context_line":""},{"line_number":2893,"context_line":"        filters \u003d {}"},{"line_number":2894,"context_line":"        if not CONF.conductor.send_sensor_data_all_nodes:"},{"line_number":2895,"context_line":"            filters[\u0027associated\u0027] \u003d True"},{"line_number":2896,"context_line":""},{"line_number":2897,"context_line":"        nodes \u003d queue.Queue()"},{"line_number":2898,"context_line":"        for node_info in self.iter_nodes(fields\u003d[\u0027instance_uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_6b02190e","line":2895,"in_reply_to":"5fc1f717_82f2e86e","updated":"2019-04-03 16:10:28.000000000","message":"This is a good question.... And I think someone filed a bug somewhere along the way (but it may have been ages ago) that ceilometer data exposed power-off information for an instance that was being deployed, so I gues that is actually a good idea.","commit_id":"7921233bbc744285efe6eaa39ed2b5e76d096727"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8552971478c48ec00b6f3031695f8fe1c60cee3d","unresolved":false,"context_lines":[{"line_number":2893,"context_line":"        filters \u003d {}"},{"line_number":2894,"context_line":"        if not CONF.conductor.send_sensor_data_for_undeployed_nodes:"},{"line_number":2895,"context_line":"            filters[\u0027provision_state\u0027] \u003d states.ACTIVE"},{"line_number":2896,"context_line":""},{"line_number":2897,"context_line":"        nodes \u003d queue.Queue()"},{"line_number":2898,"context_line":"        for node_info in self.iter_nodes(fields\u003d[\u0027instance_uuid\u0027],"},{"line_number":2899,"context_line":"                                         filters\u003dfilters):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_50ac779e","line":2896,"updated":"2019-04-04 02:37:58.000000000","message":"Do we collect for nodes have been allocated? they don\u0027t have active state I think.","commit_id":"68ba345520926bd279d64ff721002a6eebd744f6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"effb4fcc98e406e75faf83156885d68afd84b099","unresolved":false,"context_lines":[{"line_number":2893,"context_line":"        filters \u003d {}"},{"line_number":2894,"context_line":"        if not CONF.conductor.send_sensor_data_for_undeployed_nodes:"},{"line_number":2895,"context_line":"            filters[\u0027provision_state\u0027] \u003d states.ACTIVE"},{"line_number":2896,"context_line":""},{"line_number":2897,"context_line":"        nodes \u003d queue.Queue()"},{"line_number":2898,"context_line":"        for node_info in self.iter_nodes(fields\u003d[\u0027instance_uuid\u0027],"},{"line_number":2899,"context_line":"                                         filters\u003dfilters):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_88e5c60c","line":2896,"in_reply_to":"5fc1f717_50ac779e","updated":"2019-04-04 14:10:48.000000000","message":"We did and there was people that would complain long in the past that they would get sensor data indicating the power was off before the node was fully online.","commit_id":"68ba345520926bd279d64ff721002a6eebd744f6"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"aa70ded5dc38439ef283beaaced2d0659d47e4f0","unresolved":false,"context_lines":[{"line_number":2893,"context_line":"        filters \u003d {}"},{"line_number":2894,"context_line":"        if not CONF.conductor.send_sensor_data_for_undeployed_nodes:"},{"line_number":2895,"context_line":"            filters[\u0027provision_state\u0027] \u003d states.ACTIVE"},{"line_number":2896,"context_line":""},{"line_number":2897,"context_line":"        nodes \u003d queue.Queue()"},{"line_number":2898,"context_line":"        for node_info in self.iter_nodes(fields\u003d[\u0027instance_uuid\u0027],"},{"line_number":2899,"context_line":"                                         filters\u003dfilters):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_f7219db5","line":2896,"in_reply_to":"5fc1f717_88e5c60c","updated":"2019-04-08 08:53:15.000000000","message":"Hmm, I was thinking there is a slightly behavior change between Stein and Train releases, for Stein release, allocated nodes will send sensor data (which seems a bug to me), while in Train this option must be specified for allocated nodes. Maybe no one care about this difference, they will set this option anyway, not just for the special case.","commit_id":"68ba345520926bd279d64ff721002a6eebd744f6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7a043f894860f181f2e4426ff80a04167bf662c3","unresolved":false,"context_lines":[{"line_number":2893,"context_line":"        filters \u003d {}"},{"line_number":2894,"context_line":"        if not CONF.conductor.send_sensor_data_for_undeployed_nodes:"},{"line_number":2895,"context_line":"            filters[\u0027provision_state\u0027] \u003d states.ACTIVE"},{"line_number":2896,"context_line":""},{"line_number":2897,"context_line":"        nodes \u003d queue.Queue()"},{"line_number":2898,"context_line":"        for node_info in self.iter_nodes(fields\u003d[\u0027instance_uuid\u0027],"},{"line_number":2899,"context_line":"                                         filters\u003dfilters):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_2318101c","line":2896,"in_reply_to":"5fc1f717_f7219db5","updated":"2019-04-10 02:42:00.000000000","message":"Slight difference which I hopefully conveyed in the release note. I\u0027m fairly sure this is barely being used but we\u0027re trying to leverage it for metalkube.","commit_id":"68ba345520926bd279d64ff721002a6eebd744f6"}],"ironic/conf/conductor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"615ddd16aa420a6350b780a1d79cf9107c7cf4bd","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                help\u003d_(\u0027List of comma separated meter types which need to be\u0027"},{"line_number":126,"context_line":"                       \u0027 sent to Ceilometer. The default value, \"ALL\", is a \u0027"},{"line_number":127,"context_line":"                       \u0027special value meaning send all the sensor data.\u0027)),"},{"line_number":128,"context_line":"    cfg.BoolOpt(\u0027send_sensor_data_all_nodes\u0027,"},{"line_number":129,"context_line":"                default\u003dFalse,"},{"line_number":130,"context_line":"                help\u003d_(\u0027The default for sensor data collection is to only \u0027"},{"line_number":131,"context_line":"                       \u0027collect data for machines that are deployed, however \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_22e774af","line":128,"updated":"2019-03-29 18:09:59.000000000","message":"s/all_nodes/for_undeployed_nodes/ ?","commit_id":"7921233bbc744285efe6eaa39ed2b5e76d096727"}],"releasenotes/notes/send-sensor-data-for-all-nodes-a732d9df43e74318.yaml":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"aeb7cdc81089d7709de28d098c3d79b2fb7b9255","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Fixes an issue where nodes in the process of deployment may have metrics"},{"line_number":16,"context_line":"    data collected and transmitted during the deployment process which"},{"line_number":17,"context_line":"    may erroniously generate alarms depending on the operator\u0027s monitoring"},{"line_number":18,"context_line":"    configuration. This was due to a database filter relying upon the"},{"line_number":19,"context_line":"    indicator of an ``instance_uuid`` as opposed to the state of a node."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_74e42c3d","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":19},"updated":"2019-04-02 15:32:32.000000000","message":"Nit: erroneously","commit_id":"f2d3d4f8ef0dcb7e19d548633d284c0285ecc9e5"}]}