)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f827e7f4c3a608f4a0e33cff3a14f26947ea1a16","unresolved":false,"context_lines":[{"line_number":3588,"context_line":""},{"line_number":3589,"context_line":""},{"line_number":3590,"context_line":"# NOTE(dtantsur): Hopefully one day is enough?"},{"line_number":3591,"context_line":"_DEFAULT_TEMP_URL_TIMEOUT \u003d 86400"},{"line_number":3592,"context_line":""},{"line_number":3593,"context_line":""},{"line_number":3594,"context_line":"def _store_configdrive(node, configdrive):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e85cb31a","line":3591,"updated":"2019-04-02 23:05:57.000000000","message":"wait a second... Didn\u0027t we have a parameter for a tempurl timeout the swift config?","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a3e7fca848cb0f33a68b93f992d20c4e3a80cacb","unresolved":false,"context_lines":[{"line_number":3588,"context_line":""},{"line_number":3589,"context_line":""},{"line_number":3590,"context_line":"# NOTE(dtantsur): Hopefully one day is enough?"},{"line_number":3591,"context_line":"_DEFAULT_TEMP_URL_TIMEOUT \u003d 86400"},{"line_number":3592,"context_line":""},{"line_number":3593,"context_line":""},{"line_number":3594,"context_line":"def _store_configdrive(node, configdrive):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_9f90b044","line":3591,"in_reply_to":"5fc1f717_4ba9418e","updated":"2019-04-03 22:42:04.000000000","message":"I thought that was for all swift tempurls...","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"5e918683fb408f09e58c0fc7ca859161c66b8c64","unresolved":false,"context_lines":[{"line_number":3588,"context_line":""},{"line_number":3589,"context_line":""},{"line_number":3590,"context_line":"# NOTE(dtantsur): Hopefully one day is enough?"},{"line_number":3591,"context_line":"_DEFAULT_TEMP_URL_TIMEOUT \u003d 86400"},{"line_number":3592,"context_line":""},{"line_number":3593,"context_line":""},{"line_number":3594,"context_line":"def _store_configdrive(node, configdrive):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b0bd9b03","line":3591,"in_reply_to":"5fc1f717_9f90b044","updated":"2019-04-04 02:20:39.000000000","message":"One configuration option makes sense to me, my only concern is when we are dealing with whole disk image, configdrive is retrieved after image deployment, the time varies depending on image size, it should be a larger value to be safe in theory.","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6721c889114f1ddc70794d9d657c23e1d86dcfd5","unresolved":false,"context_lines":[{"line_number":3588,"context_line":""},{"line_number":3589,"context_line":""},{"line_number":3590,"context_line":"# NOTE(dtantsur): Hopefully one day is enough?"},{"line_number":3591,"context_line":"_DEFAULT_TEMP_URL_TIMEOUT \u003d 86400"},{"line_number":3592,"context_line":""},{"line_number":3593,"context_line":""},{"line_number":3594,"context_line":"def _store_configdrive(node, configdrive):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_4ba9418e","line":3591,"in_reply_to":"5fc1f717_e85cb31a","updated":"2019-04-03 01:00:17.000000000","message":"there is a glance option [glance]swift_temp_url_duration, which is used for the instance image, not sure it\u0027s the same thing in your mind.","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e5c7233d1374327824fc2d5d7e04e0f4e2c1d409","unresolved":false,"context_lines":[{"line_number":3609,"context_line":"    \"\"\""},{"line_number":3610,"context_line":"    if CONF.deploy.configdrive_use_object_store:"},{"line_number":3611,"context_line":"        # NOTE(lucasagomes): No reason to use a different timeout than"},{"line_number":3612,"context_line":"        # the one used for deploying the node"},{"line_number":3613,"context_line":"        timeout \u003d (CONF.conductor.deploy_callback_timeout"},{"line_number":3614,"context_line":"                   if CONF.conductor.deploy_callback_timeout \u003e 0"},{"line_number":3615,"context_line":"                   else _DEFAULT_TEMP_URL_TIMEOUT)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_9f321a5e","line":3612,"updated":"2019-04-02 09:58:49.000000000","message":"Well, it\u0027s kind of true still, except in one case","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1ae0c56ecff80d710e9176da76ba7a1266b6d030","unresolved":false,"context_lines":[{"line_number":3609,"context_line":"    \"\"\""},{"line_number":3610,"context_line":"    if CONF.deploy.configdrive_use_object_store:"},{"line_number":3611,"context_line":"        # NOTE(lucasagomes): No reason to use a different timeout than"},{"line_number":3612,"context_line":"        # the one used for deploying the node"},{"line_number":3613,"context_line":"        timeout \u003d (CONF.conductor.deploy_callback_timeout"},{"line_number":3614,"context_line":"                   if CONF.conductor.deploy_callback_timeout \u003e 0"},{"line_number":3615,"context_line":"                   else _DEFAULT_TEMP_URL_TIMEOUT)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b35e3774","line":3612,"updated":"2019-04-02 06:07:41.000000000","message":"the note is not reflecting part of truth now","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1ae0c56ecff80d710e9176da76ba7a1266b6d030","unresolved":false,"context_lines":[{"line_number":3612,"context_line":"        # the one used for deploying the node"},{"line_number":3613,"context_line":"        timeout \u003d (CONF.conductor.deploy_callback_timeout"},{"line_number":3614,"context_line":"                   if CONF.conductor.deploy_callback_timeout \u003e 0"},{"line_number":3615,"context_line":"                   else _DEFAULT_TEMP_URL_TIMEOUT)"},{"line_number":3616,"context_line":"        container \u003d CONF.conductor.configdrive_swift_container"},{"line_number":3617,"context_line":"        object_name \u003d _get_configdrive_obj_name(node)"},{"line_number":3618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5386f3bc","line":3615,"updated":"2019-04-02 06:07:41.000000000","message":"No idea why we use both interval and timeout to determine whether to run the periodic task. It seems reasonable to me that, we can set a non-zero minimum value for deploy_callback_timeout. I remember there is some history reason of not doing so (and it can be a negative value too).","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4749dd3e10a66f7febe9e8eac4b3f74d3c71705f","unresolved":false,"context_lines":[{"line_number":3612,"context_line":"        # the one used for deploying the node"},{"line_number":3613,"context_line":"        timeout \u003d (CONF.conductor.deploy_callback_timeout"},{"line_number":3614,"context_line":"                   if CONF.conductor.deploy_callback_timeout \u003e 0"},{"line_number":3615,"context_line":"                   else _DEFAULT_TEMP_URL_TIMEOUT)"},{"line_number":3616,"context_line":"        container \u003d CONF.conductor.configdrive_swift_container"},{"line_number":3617,"context_line":"        object_name \u003d _get_configdrive_obj_name(node)"},{"line_number":3618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_3d309b07","line":3615,"in_reply_to":"5fc1f717_1f9cc059","updated":"2019-04-04 09:26:49.000000000","message":"I can add a fallback to swift_temp_url_duration, although I don\u0027t like the [glance] section. Should we move it with deprecation?","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ae74f247518b214eb0dbe1529990871af9669a27","unresolved":false,"context_lines":[{"line_number":3612,"context_line":"        # the one used for deploying the node"},{"line_number":3613,"context_line":"        timeout \u003d (CONF.conductor.deploy_callback_timeout"},{"line_number":3614,"context_line":"                   if CONF.conductor.deploy_callback_timeout \u003e 0"},{"line_number":3615,"context_line":"                   else _DEFAULT_TEMP_URL_TIMEOUT)"},{"line_number":3616,"context_line":"        container \u003d CONF.conductor.configdrive_swift_container"},{"line_number":3617,"context_line":"        object_name \u003d _get_configdrive_obj_name(node)"},{"line_number":3618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_98ed1db9","line":3615,"in_reply_to":"5fc1f717_3d309b07","updated":"2019-04-04 10:01:42.000000000","message":"I agree with falling back to \u0027swift_temp_url_duration\u0027 and to moving the swift related configs to separate section.","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6721c889114f1ddc70794d9d657c23e1d86dcfd5","unresolved":false,"context_lines":[{"line_number":3612,"context_line":"        # the one used for deploying the node"},{"line_number":3613,"context_line":"        timeout \u003d (CONF.conductor.deploy_callback_timeout"},{"line_number":3614,"context_line":"                   if CONF.conductor.deploy_callback_timeout \u003e 0"},{"line_number":3615,"context_line":"                   else _DEFAULT_TEMP_URL_TIMEOUT)"},{"line_number":3616,"context_line":"        container \u003d CONF.conductor.configdrive_swift_container"},{"line_number":3617,"context_line":"        object_name \u003d _get_configdrive_obj_name(node)"},{"line_number":3618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_6b9afd62","line":3615,"in_reply_to":"5fc1f717_487ce771","updated":"2019-04-03 01:00:17.000000000","message":"When timeout is set to zero, our periodic task will not be enabled, so it doesn\u0027t mean a node will fail in the end..\n\nA reasonable move is to set a minimum value for deploy_callback_timeout, and remove it from [1]. I would prefer this way, if there is no upgrade considerations.\n\n[1] https://github.com/openstack/ironic/blob/56acabf/ironic/conductor/manager.py#L1870-L1871","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a3e7fca848cb0f33a68b93f992d20c4e3a80cacb","unresolved":false,"context_lines":[{"line_number":3612,"context_line":"        # the one used for deploying the node"},{"line_number":3613,"context_line":"        timeout \u003d (CONF.conductor.deploy_callback_timeout"},{"line_number":3614,"context_line":"                   if CONF.conductor.deploy_callback_timeout \u003e 0"},{"line_number":3615,"context_line":"                   else _DEFAULT_TEMP_URL_TIMEOUT)"},{"line_number":3616,"context_line":"        container \u003d CONF.conductor.configdrive_swift_container"},{"line_number":3617,"context_line":"        object_name \u003d _get_configdrive_obj_name(node)"},{"line_number":3618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_1f9cc059","line":3615,"in_reply_to":"5fc1f717_4ee06af9","updated":"2019-04-03 22:42:04.000000000","message":"Okay, but shouldn\u0027t we be representing the swift tempurl duration timeout as it is a tunable for the lifetime of tempurls?","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f827e7f4c3a608f4a0e33cff3a14f26947ea1a16","unresolved":false,"context_lines":[{"line_number":3612,"context_line":"        # the one used for deploying the node"},{"line_number":3613,"context_line":"        timeout \u003d (CONF.conductor.deploy_callback_timeout"},{"line_number":3614,"context_line":"                   if CONF.conductor.deploy_callback_timeout \u003e 0"},{"line_number":3615,"context_line":"                   else _DEFAULT_TEMP_URL_TIMEOUT)"},{"line_number":3616,"context_line":"        container \u003d CONF.conductor.configdrive_swift_container"},{"line_number":3617,"context_line":"        object_name \u003d _get_configdrive_obj_name(node)"},{"line_number":3618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_487ce771","line":3615,"in_reply_to":"5fc1f717_5386f3bc","updated":"2019-04-02 23:05:57.000000000","message":"Reading the bug, I kind of wonder if the right thing to do is actually fail deployment at this point and the value is 0. The deployment is clearly misconfigured and the operator peception vs. software behavior now differs. :\\","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"799f282c20fe2e1d3cc193891abc72bfda73ebab","unresolved":false,"context_lines":[{"line_number":3612,"context_line":"        # the one used for deploying the node"},{"line_number":3613,"context_line":"        timeout \u003d (CONF.conductor.deploy_callback_timeout"},{"line_number":3614,"context_line":"                   if CONF.conductor.deploy_callback_timeout \u003e 0"},{"line_number":3615,"context_line":"                   else _DEFAULT_TEMP_URL_TIMEOUT)"},{"line_number":3616,"context_line":"        container \u003d CONF.conductor.configdrive_swift_container"},{"line_number":3617,"context_line":"        object_name \u003d _get_configdrive_obj_name(node)"},{"line_number":3618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_4ee06af9","line":3615,"in_reply_to":"5fc1f717_6b9afd62","updated":"2019-04-03 09:29:21.000000000","message":"I can easily imagine someone setting deploy_callback_timeout\u003d0 to mean \"please no timeout\", why is it a misconfiguration? We even document it in the option help.","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"edddf23e004579193825b9a44df48f5acf4b579b","unresolved":false,"context_lines":[{"line_number":3609,"context_line":"        timeout \u003d (CONF.conductor.configdrive_swift_temp_url_duration"},{"line_number":3610,"context_line":"                   or CONF.conductor.deploy_callback_timeout"},{"line_number":3611,"context_line":"                   # The documented default in ironic.conf.conductor"},{"line_number":3612,"context_line":"                   or 1800)"},{"line_number":3613,"context_line":"        container \u003d CONF.conductor.configdrive_swift_container"},{"line_number":3614,"context_line":"        object_name \u003d _get_configdrive_obj_name(node)"},{"line_number":3615,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_10b6f2fb","line":3612,"range":{"start_line":3612,"start_character":22,"end_line":3612,"end_character":26},"updated":"2019-04-16 06:18:47.000000000","message":"Instead of having 1800 here, wont it be better to have \u0027default\u0027 value of config \u0027configdrive_swift_temp_url_duration\u0027 as 1800 in addition to \u0027min\u0027 value?","commit_id":"2039138cfe2854b477f06d9185eddbdb264b649f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"318f0dc1798cf9dc580a8cd627964d988a48f17c","unresolved":false,"context_lines":[{"line_number":3609,"context_line":"        timeout \u003d (CONF.conductor.configdrive_swift_temp_url_duration"},{"line_number":3610,"context_line":"                   or CONF.conductor.deploy_callback_timeout"},{"line_number":3611,"context_line":"                   # The documented default in ironic.conf.conductor"},{"line_number":3612,"context_line":"                   or 1800)"},{"line_number":3613,"context_line":"        container \u003d CONF.conductor.configdrive_swift_container"},{"line_number":3614,"context_line":"        object_name \u003d _get_configdrive_obj_name(node)"},{"line_number":3615,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_d3e1512c","line":3612,"range":{"start_line":3612,"start_character":22,"end_line":3612,"end_character":26},"in_reply_to":"3fce034c_10b6f2fb","updated":"2019-04-16 09:19:22.000000000","message":"Then we won\u0027t be able to fall back to deploy_callback_timeout. It will be a behavior change on upgrade.","commit_id":"2039138cfe2854b477f06d9185eddbdb264b649f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3cb29d6d20a0124b7c99621929c479a7043eb646","unresolved":false,"context_lines":[{"line_number":3609,"context_line":"        timeout \u003d (CONF.conductor.configdrive_swift_temp_url_duration"},{"line_number":3610,"context_line":"                   or CONF.conductor.deploy_callback_timeout"},{"line_number":3611,"context_line":"                   # The documented default in ironic.conf.conductor"},{"line_number":3612,"context_line":"                   or 1800)"},{"line_number":3613,"context_line":"        container \u003d CONF.conductor.configdrive_swift_container"},{"line_number":3614,"context_line":"        object_name \u003d _get_configdrive_obj_name(node)"},{"line_number":3615,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_961737a4","line":3612,"range":{"start_line":3612,"start_character":22,"end_line":3612,"end_character":26},"in_reply_to":"3fce034c_d3e1512c","updated":"2019-04-16 10:35:44.000000000","message":"Thanks, Got it.","commit_id":"2039138cfe2854b477f06d9185eddbdb264b649f"}],"releasenotes/notes/zero-temp-url-c21e208f8933c6f6.yaml":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"03f44c312c7a8e1b9406357b12e2a4bed4c1f982","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    No longer tries to create a temporary URL with zero lifetime if the"},{"line_number":5,"context_line":"    ``deploy_callback_timeout`` option is set to zero. A lifetime of one day"},{"line_number":6,"context_line":"    is used in this case, please set ``deploy_callback_timeout`` to a large"},{"line_number":7,"context_line":"    value if it is not enough."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_027c8e70","line":6,"range":{"start_line":6,"start_character":39,"end_line":6,"end_character":62},"updated":"2019-04-02 11:09:49.000000000","message":"Can we also mention the `conductor` group here?","commit_id":"3a2a68bfe655cfd6134528cb54c7f147c1e838ba"}]}
