)]}'
{"ironic/conf/default.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"fecd8200853c6a5027924bd05dc8158f0fb0419f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                help\u003d_(\u0027Used if there is a formatting error when generating \u0027"},{"line_number":167,"context_line":"                       \u0027an exception message (a programming error). If True, \u0027"},{"line_number":168,"context_line":"                       \u0027raise an exception; if False, use the unformatted \u0027"},{"line_number":169,"context_line":"                       \u0027message.\u0027)),"},{"line_number":170,"context_line":"    cfg.IntOpt(\u0027log_in_db_max_size\u0027, default\u003d4096,"},{"line_number":171,"context_line":"               help\u003d_(\u0027Max number of characters of any node \u0027"},{"line_number":172,"context_line":"                      \u0027last_error/maintenance_reason pushed to database.\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"bfb3d3c7_2fd614f3","side":"PARENT","line":169,"updated":"2019-05-24 02:35:46.000000000","message":"shouldn\u0027t we mark it as deprecated and use the value from ironic_lib in preference and fall back to this option?","commit_id":"ed5c3d940da3b97e3ef55c5dbe1250c59b6634d3"}],"ironic/tests/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"87fe82ecf6a533a6bb655c0fc5a4c11cac22393c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def _set_config(self):"},{"line_number":121,"context_line":"        self.cfg_fixture \u003d self.useFixture(config_fixture.Config(CONF))"},{"line_number":122,"context_line":"        self.config(use_stderr\u003dFalse,"},{"line_number":123,"context_line":"                    fatal_exception_format_errors\u003dTrue,"},{"line_number":124,"context_line":"                    tempdir\u003dtempfile.tempdir)"},{"line_number":125,"context_line":"        self.config(cleaning_network\u003duuidutils.generate_uuid(),"},{"line_number":126,"context_line":"                    group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"bfb3d3c7_2dc0677b","side":"PARENT","line":123,"updated":"2019-05-23 16:21:00.000000000","message":"I think we should keep these options configured for unit tests.","commit_id":"ed5c3d940da3b97e3ef55c5dbe1250c59b6634d3"}],"releasenotes/notes/use-ironic-lib-exception-4bff237c9667bf46.yaml":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"fecd8200853c6a5027924bd05dc8158f0fb0419f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - Use the module exception from ironic-lib."},{"line_number":4,"context_line":"    Update ironic-lib minimum version required to 2.17.0."},{"line_number":5,"context_line":"    Also removes the option ``fatal_exception_format_errors`` from the"},{"line_number":6,"context_line":"    ``DEFAULT`` section in favor of the same option in the ``ironic-lib``"},{"line_number":7,"context_line":"    section from ironic-lib."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bfb3d3c7_0fdb101b","line":7,"range":{"start_line":5,"start_character":4,"end_line":7,"end_character":28},"updated":"2019-05-24 02:35:46.000000000","message":"Maybe this change should be in the upgrade/deprection section, and I suspect we need to follow a deprecation policy, before we remove this option from DEFAULT.","commit_id":"817685f4ebba703386145527af066550b41b430e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0e7c1e94415941700ef384ac208213356246fc28","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - Use the module exception from ironic-lib."},{"line_number":4,"context_line":"    Update ironic-lib minimum version required to 2.17.0."},{"line_number":5,"context_line":"    Also removes the option ``fatal_exception_format_errors`` from the"},{"line_number":6,"context_line":"    ``DEFAULT`` section in favor of the same option in the ``ironic-lib``"},{"line_number":7,"context_line":"    section from ironic-lib."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bfb3d3c7_ccb89fe6","line":7,"range":{"start_line":5,"start_character":4,"end_line":7,"end_character":28},"in_reply_to":"bfb3d3c7_0fdb101b","updated":"2019-05-24 10:02:09.000000000","message":"you\u0027re probably right, I will upload an update with the deprecation instead of the direct removal","commit_id":"817685f4ebba703386145527af066550b41b430e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cbdb54c706e10341e66227795de3a3114f38d55b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The configuration option ``[DEFAULT]/fatal_exception_format_errors`` is now"},{"line_number":4,"context_line":"    deprecated."},{"line_number":5,"context_line":"    Please use the ``fatal_exception_format_errors`` in the ``ironic-lib``"},{"line_number":6,"context_line":"    section from ironic-lib."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - Use the module exception from ironic-lib."},{"line_number":9,"context_line":"    Update ironic-lib minimum version required to 2.17.1."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_a36a31b0","line":6,"range":{"start_line":5,"start_character":19,"end_line":6,"end_character":27},"updated":"2019-06-07 06:38:19.000000000","message":"Section name is \u0027ironic_lib\u0027 [1]. Also why is this option is not being listed in sample config file[2]?\n\ns/ \u0027``fatal_exception_format_errors`` in the ``ironic-lib``\n    section from ironic-lib\u0027\u0027 / \u0027configuration option ``[ironic_lib]/fatal_exception_format_errors`` instead\u0027 /\n\n[1] https://github.com/openstack/ironic-lib/blob/7daba837f6f8f7fe202ce53c5ff5f86e1db88a29/ironic_lib/exception.py#L49\n\n[2] http://logs.openstack.org/03/649303/18/check/openstack-tox-docs/6f26076/html/configuration/sample-config.html","commit_id":"eb0ea477957ccbbcff6aa6b3acd60fcca0633780"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"aac4ad3c688cbefef5a8ef6af9c5f3c89a4ebc8b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The configuration option ``[DEFAULT]/fatal_exception_format_errors`` is now"},{"line_number":4,"context_line":"    deprecated."},{"line_number":5,"context_line":"    Please use the ``fatal_exception_format_errors`` in the ``ironic-lib``"},{"line_number":6,"context_line":"    section from ironic-lib."},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - Use the module exception from ironic-lib."},{"line_number":9,"context_line":"    Update ironic-lib minimum version required to 2.17.1."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_731b7480","line":6,"range":{"start_line":5,"start_character":19,"end_line":6,"end_character":27},"in_reply_to":"9fb8cfa7_a36a31b0","updated":"2019-06-11 07:47:30.000000000","message":"Done","commit_id":"eb0ea477957ccbbcff6aa6b3acd60fcca0633780"}],"tools/config/ironic-config-generator.conf":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f47f1296c5a17218915074377b6fff19e64cb00b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"namespace \u003d ironic"},{"line_number":5,"context_line":"namespace \u003d ironic_lib.disk_utils"},{"line_number":6,"context_line":"namespace \u003d ironic_lib.disk_partitioner"},{"line_number":7,"context_line":"namespace \u003d ironic_lib.fatal_exception_format_errors"},{"line_number":8,"context_line":"namespace \u003d ironic_lib.mdns"},{"line_number":9,"context_line":"namespace \u003d ironic_lib.metrics"},{"line_number":10,"context_line":"namespace \u003d ironic_lib.metrics_statsd"}],"source_content_type":"text/plain","patch_set":20,"id":"9fb8cfa7_1c96c594","line":7,"updated":"2019-06-11 09:40:07.000000000","message":"this should be ironic_lib.exception\nnamespace needs to be matched with what exposed in the ironic-lib https://opendev.org/openstack/ironic-lib/src/branch/master/setup.cfg#L26-L33","commit_id":"ac8e581fcd795c44e58b0218bd7294d814e1e5a7"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"459d7fa9ba2952e93ec9fde029ab238fcdc38e99","unresolved":false,"context_lines":[{"line_number":4,"context_line":"namespace \u003d ironic"},{"line_number":5,"context_line":"namespace \u003d ironic_lib.disk_utils"},{"line_number":6,"context_line":"namespace \u003d ironic_lib.disk_partitioner"},{"line_number":7,"context_line":"namespace \u003d ironic_lib.fatal_exception_format_errors"},{"line_number":8,"context_line":"namespace \u003d ironic_lib.mdns"},{"line_number":9,"context_line":"namespace \u003d ironic_lib.metrics"},{"line_number":10,"context_line":"namespace \u003d ironic_lib.metrics_statsd"}],"source_content_type":"text/plain","patch_set":20,"id":"9fb8cfa7_fcdbb1e9","line":7,"in_reply_to":"9fb8cfa7_1c96c594","updated":"2019-06-11 10:01:28.000000000","message":"right, thanks Kaifeng\nI\u0027ll change it","commit_id":"ac8e581fcd795c44e58b0218bd7294d814e1e5a7"}]}