)]}'
{"ironic/conf/default.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"949ed4a2a45c5504044539d56e61f4caaac74a14","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                       \u0027an exception message (a programming error). If True, \u0027"},{"line_number":168,"context_line":"                       \u0027raise an exception; if False, use the unformatted \u0027"},{"line_number":169,"context_line":"                       \u0027message.\u0027)),"},{"line_number":170,"context_line":"    cfg.IntOpt(\"log_in_db_max_size\", default\u003d1024,"},{"line_number":171,"context_line":"               help\u003d_(\u0027Max size of any node error/reason pushed to database\u0027))"},{"line_number":172,"context_line":"]"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_45acec8b","line":170,"updated":"2019-04-12 14:49:40.000000000","message":"Where does 1024 come from? I think it\u0027s even less than mysql TEXT size..","commit_id":"d7f376ab6dbb8fd43154c5ab97df6ffa8a3ad99b"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e05e78d40a71c0a3d2d8854bc9e5b9f44365aa55","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                       \u0027message.\u0027)),"},{"line_number":170,"context_line":"    cfg.IntOpt(\"log_in_db_max_size\", default\u003d4096,"},{"line_number":171,"context_line":"               help\u003d_(\u0027Max size of any node last_error/maintenance_reason \u0027"},{"line_number":172,"context_line":"                      \u0027pushed to database\u0027))"},{"line_number":173,"context_line":"]"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"hash_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_86c89755","line":172,"range":{"start_line":172,"start_character":41,"end_line":172,"end_character":42},"updated":"2019-04-12 20:44:51.000000000","message":"nit: missing a period.","commit_id":"5102857db4888345a80c60b860fdd8ef61725bd8"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"dfa7de7133e4fbf2364aaa4db22c014ef17ff969","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                       \u0027raise an exception; if False, use the unformatted \u0027"},{"line_number":169,"context_line":"                       \u0027message.\u0027)),"},{"line_number":170,"context_line":"    cfg.IntOpt(\"log_in_db_max_size\", default\u003d4096,"},{"line_number":171,"context_line":"               help\u003d_(\u0027Max size of any node last_error/maintenance_reason \u0027"},{"line_number":172,"context_line":"                      \u0027pushed to database.\u0027))"},{"line_number":173,"context_line":"]"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_b377e53a","line":171,"range":{"start_line":171,"start_character":27,"end_line":171,"end_character":34},"updated":"2019-04-16 09:33:03.000000000","message":"nit: size of characters of","commit_id":"1a19195326891f430f21ce8e280b0bfacf31b8b3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b22e7a400d57aeabc9c71294ca4b7fd5c9fca5a9","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                       \u0027an exception message (a programming error). If True, \u0027"},{"line_number":168,"context_line":"                       \u0027raise an exception; if False, use the unformatted \u0027"},{"line_number":169,"context_line":"                       \u0027message.\u0027)),"},{"line_number":170,"context_line":"    cfg.IntOpt(\"log_in_db_max_size\", default\u003d4096,"},{"line_number":171,"context_line":"               help\u003d_(\u0027Max number of characters of any node \u0027"},{"line_number":172,"context_line":"                      \u0027last_error/maintenance_reason pushed to database.\u0027))"},{"line_number":173,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fce034c_54af407c","line":170,"range":{"start_line":170,"start_character":15,"end_line":170,"end_character":35},"updated":"2019-04-19 07:56:07.000000000","message":"you should use single quotes for consistency","commit_id":"d0f41cc835828347b7a275cd4792d379f5136ea1"}],"ironic/objects/node.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f7dbd8d73c6dd2f179265cff20086f7f86634277","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            attr_value \u003d getattr(self, attr_name, \u0027\u0027)"},{"line_number":427,"context_line":"            if attr_value and isinstance(attr_value, six.string_types) and \\"},{"line_number":428,"context_line":"                    len(attr_value) \u003e CONF.log_in_db_max_size:"},{"line_number":429,"context_line":"                LOG.debug(\"Truncating too long %s for node %s\", attr_name,"},{"line_number":430,"context_line":"                          self.uuid)"},{"line_number":431,"context_line":"                setattr(self, attr_name,"},{"line_number":432,"context_line":"                        getattr(self, attr_name)[0:CONF.log_in_db_max_size])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_268ede78","line":429,"range":{"start_line":429,"start_character":27,"end_line":429,"end_character":61},"updated":"2019-04-10 04:18:32.000000000","message":"May be better to add the value of truncated length CONF.log_in_db_max_size to the message.\ns/ \u0027Truncating too long %s for node %s\u0027 / \u0027Truncating too long %s to %s characters for node %s.\u0027 /","commit_id":"bee22435007189fafddbc77f973fa247df5d2a4e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f7dbd8d73c6dd2f179265cff20086f7f86634277","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            attr_value \u003d getattr(self, attr_name, \u0027\u0027)"},{"line_number":427,"context_line":"            if attr_value and isinstance(attr_value, six.string_types) and \\"},{"line_number":428,"context_line":"                    len(attr_value) \u003e CONF.log_in_db_max_size:"},{"line_number":429,"context_line":"                LOG.debug(\"Truncating too long %s for node %s\", attr_name,"},{"line_number":430,"context_line":"                          self.uuid)"},{"line_number":431,"context_line":"                setattr(self, attr_name,"},{"line_number":432,"context_line":"                        getattr(self, attr_name)[0:CONF.log_in_db_max_size])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_0688826e","line":429,"range":{"start_line":429,"start_character":16,"end_line":429,"end_character":25},"updated":"2019-04-10 04:18:32.000000000","message":"Should the log level more than \u0027debug\u0027 (may be info) as this is something Ironic does explicitly?","commit_id":"bee22435007189fafddbc77f973fa247df5d2a4e"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"db90f8b9b6794093d7ea11d4ba3282a6ff64b081","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            attr_value \u003d getattr(self, attr_name, \u0027\u0027)"},{"line_number":427,"context_line":"            if attr_value and isinstance(attr_value, six.string_types) and \\"},{"line_number":428,"context_line":"                    len(attr_value) \u003e CONF.log_in_db_max_size:"},{"line_number":429,"context_line":"                LOG.debug(\"Truncating too long %s for node %s\", attr_name,"},{"line_number":430,"context_line":"                          self.uuid)"},{"line_number":431,"context_line":"                setattr(self, attr_name,"},{"line_number":432,"context_line":"                        getattr(self, attr_name)[0:CONF.log_in_db_max_size])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_333d78bb","line":429,"range":{"start_line":429,"start_character":16,"end_line":429,"end_character":25},"in_reply_to":"5fc1f717_0688826e","updated":"2019-04-12 08:36:11.000000000","message":"Done","commit_id":"bee22435007189fafddbc77f973fa247df5d2a4e"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"db90f8b9b6794093d7ea11d4ba3282a6ff64b081","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            attr_value \u003d getattr(self, attr_name, \u0027\u0027)"},{"line_number":427,"context_line":"            if attr_value and isinstance(attr_value, six.string_types) and \\"},{"line_number":428,"context_line":"                    len(attr_value) \u003e CONF.log_in_db_max_size:"},{"line_number":429,"context_line":"                LOG.debug(\"Truncating too long %s for node %s\", attr_name,"},{"line_number":430,"context_line":"                          self.uuid)"},{"line_number":431,"context_line":"                setattr(self, attr_name,"},{"line_number":432,"context_line":"                        getattr(self, attr_name)[0:CONF.log_in_db_max_size])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_d3499460","line":429,"range":{"start_line":429,"start_character":27,"end_line":429,"end_character":61},"in_reply_to":"5fc1f717_268ede78","updated":"2019-04-12 08:36:11.000000000","message":"Done","commit_id":"bee22435007189fafddbc77f973fa247df5d2a4e"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"dfa7de7133e4fbf2364aaa4db22c014ef17ff969","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        for attr_name in (\u0027last_error\u0027, \u0027maintenance_reason\u0027):"},{"line_number":426,"context_line":"            attr_value \u003d getattr(self, attr_name, \u0027\u0027)"},{"line_number":427,"context_line":"            if attr_value and isinstance(attr_value, six.string_types) and \\"},{"line_number":428,"context_line":"                    len(attr_value) \u003e CONF.log_in_db_max_size:"},{"line_number":429,"context_line":"                LOG.info(\"Truncating too long %s to %s characters for node %s\","},{"line_number":430,"context_line":"                         attr_name, CONF.log_in_db_max_size, self.uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_33dd3542","line":427,"range":{"start_line":427,"start_character":74,"end_line":427,"end_character":76},"updated":"2019-04-16 09:33:03.000000000","message":"nit: we could use () to wrap the condition to avoid hard line break.","commit_id":"1a19195326891f430f21ce8e280b0bfacf31b8b3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bc36ca70130bddaa9b56dccb24158796dc30e1e3","unresolved":false,"context_lines":[{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        for attr_name in (\u0027last_error\u0027, \u0027maintenance_reason\u0027):"},{"line_number":426,"context_line":"            attr_value \u003d getattr(self, attr_name, \u0027\u0027)"},{"line_number":427,"context_line":"            if attr_value and isinstance(attr_value, six.string_types) and \\"},{"line_number":428,"context_line":"                    len(attr_value) \u003e CONF.log_in_db_max_size:"},{"line_number":429,"context_line":"                LOG.info(\"Truncating too long %s to %s characters for node %s\","},{"line_number":430,"context_line":"                         attr_name, CONF.log_in_db_max_size, self.uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_e24a7525","line":427,"range":{"start_line":427,"start_character":74,"end_line":427,"end_character":76},"in_reply_to":"3fce034c_33dd3542","updated":"2019-04-16 14:17:19.000000000","message":"missed this! thanks Kaifeng\nplease change it","commit_id":"1a19195326891f430f21ce8e280b0bfacf31b8b3"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"dfa7de7133e4fbf2364aaa4db22c014ef17ff969","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                LOG.info(\"Truncating too long %s to %s characters for node %s\","},{"line_number":430,"context_line":"                         attr_name, CONF.log_in_db_max_size, self.uuid)"},{"line_number":431,"context_line":"                setattr(self, attr_name,"},{"line_number":432,"context_line":"                        getattr(self, attr_name)[0:CONF.log_in_db_max_size])"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        updates \u003d self.do_version_changes_for_db()"},{"line_number":435,"context_line":"        self._validate_property_values(updates.get(\u0027properties\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_53b9e1e6","line":432,"range":{"start_line":432,"start_character":24,"end_line":432,"end_character":48},"updated":"2019-04-16 09:33:03.000000000","message":"this is redundant, we could use attr_value directly.","commit_id":"1a19195326891f430f21ce8e280b0bfacf31b8b3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b22e7a400d57aeabc9c71294ca4b7fd5c9fca5a9","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            attr_value \u003d getattr(self, attr_name, \u0027\u0027)"},{"line_number":427,"context_line":"            if (attr_value and isinstance(attr_value, six.string_types) and"},{"line_number":428,"context_line":"                    len(attr_value) \u003e CONF.log_in_db_max_size):"},{"line_number":429,"context_line":"                LOG.info(\"Truncating too long %s to %s characters for node %s\","},{"line_number":430,"context_line":"                         attr_name, CONF.log_in_db_max_size, self.uuid)"},{"line_number":431,"context_line":"                setattr(self, attr_name,"},{"line_number":432,"context_line":"                        attr_value[0:CONF.log_in_db_max_size])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fce034c_d4c25034","line":429,"range":{"start_line":429,"start_character":25,"end_line":429,"end_character":78},"updated":"2019-04-19 07:56:07.000000000","message":"ditto single quotes","commit_id":"d0f41cc835828347b7a275cd4792d379f5136ea1"}],"releasenotes/notes/bug-2005377-5c63357681a465ec.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"949ed4a2a45c5504044539d56e61f4caaac74a14","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes node last_error and maintenance_reason overflow with too long error"},{"line_number":4,"context_line":"    messages, preventing the object from being correctly committed to database."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fce034c_a59fd04e","line":4,"updated":"2019-04-12 14:49:40.000000000","message":"Let\u0027s mention the new option.","commit_id":"d7f376ab6dbb8fd43154c5ab97df6ffa8a3ad99b"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"a8195e3f35a53f13b1a9f8ff8b76b078b18a1386","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes node last_error and maintenance_reason overflow with too long error"},{"line_number":4,"context_line":"    messages, preventing the object from being correctly committed to database."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fce034c_e6271bb6","line":4,"in_reply_to":"3fce034c_a59fd04e","updated":"2019-04-12 19:58:24.000000000","message":"Done. Not sure about the name of the option btw.","commit_id":"d7f376ab6dbb8fd43154c5ab97df6ffa8a3ad99b"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"dfa7de7133e4fbf2364aaa4db22c014ef17ff969","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Fixes node last_error and maintenance_reason overflow with too long error"},{"line_number":4,"context_line":"    messages, preventing the object from being correctly committed to database."},{"line_number":5,"context_line":"    The maximum message length can be customized through a new configuration"},{"line_number":6,"context_line":"    parameter, \u0027DEFAULT/log_in_db_max_size\u0027 (default, 4096 characters)."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fce034c_b39e0561","line":6,"range":{"start_line":6,"start_character":16,"end_line":6,"end_character":23},"updated":"2019-04-16 09:33:03.000000000","message":"nit: [DEFAULT]","commit_id":"1a19195326891f430f21ce8e280b0bfacf31b8b3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b22e7a400d57aeabc9c71294ca4b7fd5c9fca5a9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Fixes node last_error and maintenance_reason overflow with too long error"},{"line_number":4,"context_line":"    messages, preventing the object from being correctly committed to database."},{"line_number":5,"context_line":"    The maximum message length can be customized through a new configuration"},{"line_number":6,"context_line":"    parameter, \u0027[DEFAULT]/log_in_db_max_size\u0027 (default, 4096 characters)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fce034c_14d21801","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":46},"updated":"2019-04-19 07:56:07.000000000","message":"this should be wrapped in double backquote ``[DEFAULT]/log_in_db_max_size``","commit_id":"d0f41cc835828347b7a275cd4792d379f5136ea1"}]}