)]}'
{"ironic/common/mdns.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a06d2badfc3faf008fce88a99230bbbd3e26fe5f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        :param endpoint: full endpoint to reach the service."},{"line_number":49,"context_line":"        :param properties: optional properties as a dictionary."},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        ip, port, params \u003d _parse_endpoint(endpoint)"},{"line_number":52,"context_line":"        params \u003d dict(properties or {}, **params)"},{"line_number":53,"context_line":"        info \u003d zeroconf.ServiceInfo(_MDNS_DOMAIN,"},{"line_number":54,"context_line":"                                    \u0027%s.%s\u0027 % (service_type, _MDNS_DOMAIN),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fce034c_fed549e6","line":51,"updated":"2019-04-15 14:00:38.000000000","message":"This might be part of the problem...","commit_id":"0b0830cc3c7911c77090b9dc321d29027ad38ee5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a06d2badfc3faf008fce88a99230bbbd3e26fe5f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    # FIXME(dtantsur): the zeroconf library does not support IPv6, use IPv4"},{"line_number":99,"context_line":"    # only resolving for now."},{"line_number":100,"context_line":"    try:"},{"line_number":101,"context_line":"        host \u003d socket.gethostbyname(url.hostname)"},{"line_number":102,"context_line":"        # zeroconf requires addresses in network format (and see above re IPv6)"},{"line_number":103,"context_line":"        ip \u003d socket.inet_aton(host)"},{"line_number":104,"context_line":"    except socket.error as ex:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fce034c_dedacd15","line":101,"updated":"2019-04-15 14:00:38.000000000","message":"so this is going to need to be overridable because hostname could just be \"magic.conductor\" which could be to another interface\u0027s IP address or even 127.0.0.1...  When for this to work it needs to be the IP in the same broadcast domain as the agent. tl;dr I think we need to be able to explicitly set it to the address virbr0 holds in the bifrost jobs or soemthing like that so they are on the same logical network.","commit_id":"0b0830cc3c7911c77090b9dc321d29027ad38ee5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6986b4fbdfbe293be30e9658015b55a712497c23","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    # FIXME(dtantsur): the zeroconf library does not support IPv6, use IPv4"},{"line_number":99,"context_line":"    # only resolving for now."},{"line_number":100,"context_line":"    try:"},{"line_number":101,"context_line":"        host \u003d socket.gethostbyname(url.hostname)"},{"line_number":102,"context_line":"        # zeroconf requires addresses in network format (and see above re IPv6)"},{"line_number":103,"context_line":"        ip \u003d socket.inet_aton(host)"},{"line_number":104,"context_line":"    except socket.error as ex:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fce034c_7ebb9971","line":101,"in_reply_to":"3fce034c_dedacd15","updated":"2019-04-15 14:07:15.000000000","message":"The whole endpoint is overridable, but I see your point.","commit_id":"0b0830cc3c7911c77090b9dc321d29027ad38ee5"}],"ironic/conductor/base_manager.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3f473f43f98f634cbc67c55518d925c052afb8f7","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        self._periodic_tasks.wait()"},{"line_number":327,"context_line":"        self._executor.shutdown(wait\u003dTrue)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if self._zeroconf is not None:"},{"line_number":330,"context_line":"            self._zeroconf.close()"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        self._started \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"ffb9cba7_56720a13","line":329,"updated":"2019-04-26 12:53:32.000000000","message":"should stop advertising as one of the first actions during shutdown, so maybe move this up","commit_id":"3944aa46e78fc14ed5b73561afe7da8b1b017d29"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c0bb5a567f2153c2a4c307d6606c9c08c64125e0","unresolved":false,"context_lines":[{"line_number":579,"context_line":"    def _publish_endpoint(self):"},{"line_number":580,"context_line":"        params \u003d {}"},{"line_number":581,"context_line":"        if CONF.debug:"},{"line_number":582,"context_line":"            params[\u0027ipa_debug\u0027] \u003d True"},{"line_number":583,"context_line":"        self._zeroconf \u003d mdns.Zeroconf()"},{"line_number":584,"context_line":"        self._zeroconf.register_service(\u0027baremetal\u0027,"},{"line_number":585,"context_line":"                                        deploy_utils.get_ironic_api_url(),"}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_912b7793","line":582,"updated":"2019-05-28 10:33:22.000000000","message":"Oo","commit_id":"c36a01a43994f7f4a8cb0f44bd0859d41cea83cd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9796e40bbef8e07d4ed371fbeb90d876631b9870","unresolved":false,"context_lines":[{"line_number":579,"context_line":"    def _publish_endpoint(self):"},{"line_number":580,"context_line":"        params \u003d {}"},{"line_number":581,"context_line":"        if CONF.debug:"},{"line_number":582,"context_line":"            params[\u0027ipa_debug\u0027] \u003d True"},{"line_number":583,"context_line":"        self._zeroconf \u003d mdns.Zeroconf()"},{"line_number":584,"context_line":"        self._zeroconf.register_service(\u0027baremetal\u0027,"},{"line_number":585,"context_line":"                                        deploy_utils.get_ironic_api_url(),"}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_fcb2b848","line":582,"in_reply_to":"bfb3d3c7_912b7793","updated":"2019-05-29 06:35:01.000000000","message":"This is the same logic we have for PXE - enable IPA debugging if ironic debugging is enabled: https://github.com/openstack/ironic/blob/3f734c8728f0cf436921d57ce6b2389687684221/ironic/common/pxe_utils.py#L741-L742","commit_id":"c36a01a43994f7f4a8cb0f44bd0859d41cea83cd"}],"ironic/conf/conductor.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"838d37fce537fec3d13df9bb681c1551de44b806","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                help\u003d_(\u0027Allow deleting nodes which are in state \u0027"},{"line_number":223,"context_line":"                       \u0027\\\u0027available\\\u0027. Defaults to True.\u0027)),"},{"line_number":224,"context_line":"    cfg.BoolOpt(\u0027enable_mdns\u0027, default\u003dFalse,"},{"line_number":225,"context_line":"                help\u003d_(\u0027Whether to enable publishing the ironic-inspector API \u0027"},{"line_number":226,"context_line":"                       \u0027endpoint via multicast DNS.\u0027)),"},{"line_number":227,"context_line":"]"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_91f05793","line":225,"range":{"start_line":225,"start_character":63,"end_line":225,"end_character":73},"updated":"2019-05-28 10:14:24.000000000","message":"s/ \u0027-inspector\u0027//","commit_id":"c36a01a43994f7f4a8cb0f44bd0859d41cea83cd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9796e40bbef8e07d4ed371fbeb90d876631b9870","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                help\u003d_(\u0027Allow deleting nodes which are in state \u0027"},{"line_number":223,"context_line":"                       \u0027\\\u0027available\\\u0027. Defaults to True.\u0027)),"},{"line_number":224,"context_line":"    cfg.BoolOpt(\u0027enable_mdns\u0027, default\u003dFalse,"},{"line_number":225,"context_line":"                help\u003d_(\u0027Whether to enable publishing the ironic-inspector API \u0027"},{"line_number":226,"context_line":"                       \u0027endpoint via multicast DNS.\u0027)),"},{"line_number":227,"context_line":"]"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bfb3d3c7_bc8a0067","line":225,"range":{"start_line":225,"start_character":63,"end_line":225,"end_character":73},"in_reply_to":"bfb3d3c7_91f05793","updated":"2019-05-29 06:35:01.000000000","message":"Sigh. I\u0027ll post a follow-up correcting it.","commit_id":"c36a01a43994f7f4a8cb0f44bd0859d41cea83cd"}]}