)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"69ffbb9c6a2a95ad0db979cf526ae11a4ec9c742","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"By default our data model only sends port data for only ports"},{"line_number":10,"context_line":"which we are attaching. That being said, depending on the switch"},{"line_number":11,"context_line":"configuraiton, we need to transmit all port data for an ML2"},{"line_number":12,"context_line":"driver to piece the universe together when port groups are"},{"line_number":13,"context_line":"in use."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_ea899cc9","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":13},"updated":"2019-05-28 13:21:23.000000000","message":"nit: configuration","commit_id":"d706d4c4bbdb113572d0d80de1195a60d7c4569f"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"ffd339f5e125533244da7b30238f1324d72b0bdd","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I8d0f4e28efb05af704839f3b92cb3dfd48d57940"},{"line_number":20,"context_line":"Story: 2005494"},{"line_number":21,"context_line":"Task: 30959"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fb8cfa7_fa3a68cb","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":11},"updated":"2019-06-03 01:21:51.000000000","message":"task number seems error.","commit_id":"18e710fee47fe4b84749e1c3617c44a8db6dcadc"}],"ironic/common/neutron.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"ffd339f5e125533244da7b30238f1324d72b0bdd","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    if not add_all_ports:"},{"line_number":255,"context_line":"        pxe_enabled_ports \u003d [p for p in task.ports if p.pxe_enabled]"},{"line_number":256,"context_line":"    else:"},{"line_number":257,"context_line":"        pxe_enabled_ports \u003d task.ports"},{"line_number":258,"context_line":"    if not pxe_enabled_ports:"},{"line_number":259,"context_line":"        raise exception.NetworkError(_("},{"line_number":260,"context_line":"            \"No available PXE-enabled port on node %s.\") % node.uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_ba495061","line":257,"range":{"start_line":257,"start_character":8,"end_line":257,"end_character":25},"updated":"2019-06-03 01:21:51.000000000","message":"nit: We can make this more meaningful, since not all ports are pxe_enabled.","commit_id":"18e710fee47fe4b84749e1c3617c44a8db6dcadc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0610e24b5b72c0e9244b5d030e4fd8c458988bbc","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    if not add_all_ports:"},{"line_number":255,"context_line":"        pxe_enabled_ports \u003d [p for p in task.ports if p.pxe_enabled]"},{"line_number":256,"context_line":"    else:"},{"line_number":257,"context_line":"        pxe_enabled_ports \u003d task.ports"},{"line_number":258,"context_line":"    if not pxe_enabled_ports:"},{"line_number":259,"context_line":"        raise exception.NetworkError(_("},{"line_number":260,"context_line":"            \"No available PXE-enabled port on node %s.\") % node.uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_4e6f31c5","line":257,"range":{"start_line":257,"start_character":8,"end_line":257,"end_character":25},"in_reply_to":"9fb8cfa7_ba495061","updated":"2019-06-03 13:52:10.000000000","message":"Eh, the purpose for these attachments are largely for PXE configuration parameters,  so I think it is fine for now.","commit_id":"18e710fee47fe4b84749e1c3617c44a8db6dcadc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"156c61b41726f0f3772a69fc901369e59c2d1ce4","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    if not add_all_ports:"},{"line_number":344,"context_line":"        macs \u003d [p.address for p in task.ports if p.pxe_enabled]"},{"line_number":345,"context_line":"    else:"},{"line_number":346,"context_line":"        macs \u003d [p.address for p in task.ports]"},{"line_number":347,"context_line":"    if macs:"},{"line_number":348,"context_line":"        params \u003d {"},{"line_number":349,"context_line":"            \u0027network_id\u0027: network_uuid,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_d713a80c","line":346,"updated":"2019-06-04 02:46:52.000000000","message":"I wonder whether we need to mark the port should be removed in the internal info, I never feel safe on configuration options as they can change. Rare case though, just thinking loudly.","commit_id":"1918c6a07ee6a0730a91e7891cccaf2ab84f3443"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"785e24daed46e376f64d3d7fd67b7a786a509fce","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    if not add_all_ports:"},{"line_number":344,"context_line":"        macs \u003d [p.address for p in task.ports if p.pxe_enabled]"},{"line_number":345,"context_line":"    else:"},{"line_number":346,"context_line":"        macs \u003d [p.address for p in task.ports]"},{"line_number":347,"context_line":"    if macs:"},{"line_number":348,"context_line":"        params \u003d {"},{"line_number":349,"context_line":"            \u0027network_id\u0027: network_uuid,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_34519d0f","line":346,"in_reply_to":"9fb8cfa7_d713a80c","updated":"2019-06-06 21:03:04.000000000","message":"I\u0027m not really sure of the cases where that would be needed...","commit_id":"1918c6a07ee6a0730a91e7891cccaf2ab84f3443"}],"releasenotes/notes/transmit-all-ports-b570009d1a008067.yaml":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"156c61b41726f0f3772a69fc901369e59c2d1ce4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    neutron will be requested not to assign an IP address to the port. This"},{"line_number":14,"context_line":"    is to prevent additional issues that may occur depending on physical"},{"line_number":15,"context_line":"    switch configuration."},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Fixes an issue during provisioning network attachment where"},{"line_number":18,"context_line":"    neutron ports were being created with the same data structure"},{"line_number":19,"context_line":"    being re-used."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_37b80429","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":5},"updated":"2019-06-04 02:46:52.000000000","message":"I guess this is under fixes while text above is under features?","commit_id":"1918c6a07ee6a0730a91e7891cccaf2ab84f3443"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7aa7d42429efea37e85d14316eff293e4b0cd447","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    neutron will be requested not to assign an IP address to the port. This"},{"line_number":14,"context_line":"    is to prevent additional issues that may occur depending on physical"},{"line_number":15,"context_line":"    switch configuration."},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Fixes an issue during provisioning network attachment where"},{"line_number":18,"context_line":"    neutron ports were being created with the same data structure"},{"line_number":19,"context_line":"    being re-used."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_89dfebd4","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":5},"in_reply_to":"9fb8cfa7_2cfb7747","updated":"2019-06-10 14:42:04.000000000","message":"Not wanting to argue, I guess I could restructure it a little less... Let me do that actually.","commit_id":"1918c6a07ee6a0730a91e7891cccaf2ab84f3443"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"785e24daed46e376f64d3d7fd67b7a786a509fce","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    neutron will be requested not to assign an IP address to the port. This"},{"line_number":14,"context_line":"    is to prevent additional issues that may occur depending on physical"},{"line_number":15,"context_line":"    switch configuration."},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Fixes an issue during provisioning network attachment where"},{"line_number":18,"context_line":"    neutron ports were being created with the same data structure"},{"line_number":19,"context_line":"    being re-used."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_943c09c9","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":5},"in_reply_to":"9fb8cfa7_37b80429","updated":"2019-06-06 21:03:04.000000000","message":"This is one of those fine lines where it is kind of a feature, but operationally it is a fix, so I typed up both as fixes since I intend to backport this.","commit_id":"1918c6a07ee6a0730a91e7891cccaf2ab84f3443"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ea7360fa3a3f1e2c253c2ee12adcda57e1c8ee06","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    neutron will be requested not to assign an IP address to the port. This"},{"line_number":14,"context_line":"    is to prevent additional issues that may occur depending on physical"},{"line_number":15,"context_line":"    switch configuration."},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Fixes an issue during provisioning network attachment where"},{"line_number":18,"context_line":"    neutron ports were being created with the same data structure"},{"line_number":19,"context_line":"    being re-used."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_2cfb7747","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":5},"in_reply_to":"9fb8cfa7_943c09c9","updated":"2019-06-10 01:01:35.000000000","message":"Well, I won\u0027t argue whether it\u0027s a feature, thought the description appears like one.","commit_id":"1918c6a07ee6a0730a91e7891cccaf2ab84f3443"}]}