)]}'
{"ironic/common/pxe_utils.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b6c71fef44496f0d476abebadec41ba8e179e08e","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                                                task.node.uuid))"},{"line_number":398,"context_line":"    dhcp_opts \u003d dhcp_options_for_instance(task)"},{"line_number":399,"context_line":"    for opt in dhcp_opts:"},{"line_number":400,"context_line":"        opt[\u0027opt_value\u0027] \u003d None"},{"line_number":401,"context_line":"    vifs \u003d network.get_node_vif_ids(task)"},{"line_number":402,"context_line":"    if vifs[\u0027ports\u0027] or vifs[\u0027portgroups\u0027]:"},{"line_number":403,"context_line":"        provider \u003d dhcp_factory.DHCPFactory()"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_ba7aaf85","line":400,"range":{"start_line":400,"start_character":8,"end_line":400,"end_character":31},"updated":"2019-05-17 14:37:38.000000000","message":"Is setting None really what we want?\nDon\u0027t we want to remove the options from \u0027extra_dhcp_opts\u0027 field on the neutron port completely?","commit_id":"2c4ee707119d4209e229c5b4503e4d11d48b282c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ad12f67ae9fa60bd275f0348ac2c7fc5a76d835","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    if vifs[\u0027ports\u0027] or vifs[\u0027portgroups\u0027]:"},{"line_number":403,"context_line":"        provider \u003d dhcp_factory.DHCPFactory()"},{"line_number":404,"context_line":"        try:"},{"line_number":405,"context_line":"            provider.update_dhcp(task, dhcp_opts, vifs)"},{"line_number":406,"context_line":"        except exception.FailedToUpdateDHCPOptOnPort as dhcpException:"},{"line_number":407,"context_line":"            LOG.warning(str(dhcpException))"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_002ebd42","line":405,"range":{"start_line":405,"start_character":12,"end_line":405,"end_character":55},"updated":"2019-04-24 03:41:28.000000000","message":"Help us understand, if we\u0027re explicitly unbinding and in at least one case deleting the port the port, why do we need to remove the dhcp configuration?","commit_id":"2c4ee707119d4209e229c5b4503e4d11d48b282c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a0198e3a22021b4a361d0aa2dd8fcca4a67c7641","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    if vifs[\u0027ports\u0027] or vifs[\u0027portgroups\u0027]:"},{"line_number":403,"context_line":"        provider \u003d dhcp_factory.DHCPFactory()"},{"line_number":404,"context_line":"        try:"},{"line_number":405,"context_line":"            provider.update_dhcp(task, dhcp_opts, vifs)"},{"line_number":406,"context_line":"        except exception.FailedToUpdateDHCPOptOnPort as dhcpException:"},{"line_number":407,"context_line":"            LOG.warning(str(dhcpException))"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_578d13d1","line":405,"range":{"start_line":405,"start_character":12,"end_line":405,"end_character":55},"in_reply_to":"ffb9cba7_002ebd42","updated":"2019-04-28 03:21:24.000000000","message":"Here, I think we should clean up the dhcp options for pxe/ipxe booting once we removed the pxe ftp/http settings to avoid the unwanted pxe process if the machine has been set pxe as first boot order accidentally by user.","commit_id":"2c4ee707119d4209e229c5b4503e4d11d48b282c"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b6c71fef44496f0d476abebadec41ba8e179e08e","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    if vifs[\u0027ports\u0027] or vifs[\u0027portgroups\u0027]:"},{"line_number":403,"context_line":"        provider \u003d dhcp_factory.DHCPFactory()"},{"line_number":404,"context_line":"        try:"},{"line_number":405,"context_line":"            provider.update_dhcp(task, dhcp_opts, vifs)"},{"line_number":406,"context_line":"        except exception.FailedToUpdateDHCPOptOnPort as dhcpException:"},{"line_number":407,"context_line":"            LOG.warning(str(dhcpException))"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_1aae5be7","line":405,"range":{"start_line":405,"start_character":12,"end_line":405,"end_character":55},"in_reply_to":"ffb9cba7_578d13d1","updated":"2019-05-17 14:37:38.000000000","message":"We delete the actual files the options would refer too above. A user accidentally setting PXE boot as first would result in some file not found error. How is the user experience improved by setting it to None, or not specifying the option at all?","commit_id":"2c4ee707119d4209e229c5b4503e4d11d48b282c"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a52e17679f66cbe82c99406db8ff5e244300b20a","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        provider \u003d dhcp_factory.DHCPFactory()"},{"line_number":404,"context_line":"        try:"},{"line_number":405,"context_line":"            provider.update_dhcp(task, dhcp_opts, vifs)"},{"line_number":406,"context_line":"        except exception.FailedToUpdateDHCPOptOnPort as dhcpException:"},{"line_number":407,"context_line":"            LOG.warning(str(dhcpException))"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_b2a4e8ba","line":406,"updated":"2019-04-24 05:23:14.000000000","message":"Nit: dhcpException should be called dhcp_exception.","commit_id":"2c4ee707119d4209e229c5b4503e4d11d48b282c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9ad12f67ae9fa60bd275f0348ac2c7fc5a76d835","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        try:"},{"line_number":405,"context_line":"            provider.update_dhcp(task, dhcp_opts, vifs)"},{"line_number":406,"context_line":"        except exception.FailedToUpdateDHCPOptOnPort as dhcpException:"},{"line_number":407,"context_line":"            LOG.warning(str(dhcpException))"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"def _dhcp_option_file_or_url(task, urlboot\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_606a1981","line":407,"range":{"start_line":407,"start_character":24,"end_line":407,"end_character":27},"updated":"2019-04-24 03:41:28.000000000","message":"You don\u0027t need to cast it to a string and it would be good to provide additional context as in \"Error doing x: %(error)s\"","commit_id":"2c4ee707119d4209e229c5b4503e4d11d48b282c"}]}