)]}'
{"ironic/drivers/modules/drac/inspect.py":[{"author":{"_account_id":7321,"name":"Prakash Ramchandran","email":"pramchan@yahoo.com","username":"pramchan"},"change_message_id":"84bda7a9381500224a9f39f8677c2e843e21616a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DCIM_NICEnumeration \u003d (\u0027http://schemas.dell.com/wbem/wscim/1/cim-schema/2/\u0027"},{"line_number":35,"context_line":"                       \u0027DCIM_NICEnumeration\u0027)  # noqa"},{"line_number":36,"context_line":"NS_WSMAN \u003d \u0027http://schemas.dmtf.org/wbem/wsman/1/wsman.xsd\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f7a251fb","line":36,"updated":"2020-02-03 22:11:12.000000000","message":"BootMode setting to BIOS or UEFI is currently only supported as Vendor Pass through enable/disable Feature, hence we are using WSMAN web interface and not Redfish with CIMI / DMTF schema based support in Ironic.","commit_id":"e645be2ba0422685aeff2bc7e4487e6306daa5fa"},{"author":{"_account_id":7321,"name":"Prakash Ramchandran","email":"pramchan@yahoo.com","username":"pramchan"},"change_message_id":"40b0578c79d37f00011d26da6101c546f7e4faa2","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DCIM_NICEnumeration \u003d (\u0027http://schemas.dell.com/wbem/wscim/1/cim-schema/2/\u0027"},{"line_number":35,"context_line":"                       \u0027DCIM_NICEnumeration\u0027)  # noqa"},{"line_number":36,"context_line":"NS_WSMAN \u003d \u0027http://schemas.dmtf.org/wbem/wsman/1/wsman.xsd\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d7a395af","line":36,"in_reply_to":"3fa7e38b_f7a251fb","updated":"2020-02-03 22:25:29.000000000","message":"http://schemas.dmtf.org/ - This has webm hypermedia link and wsman falls under that, where as what I am talking of is cimi that uses redfish host profile and interfaces. Airships may target name space(tns) schemas, protocol (OData) and Open APISs (Swagger)through Cluster API and Metal-3 in future. Plus community is also perusing smash for legacy hosts.","commit_id":"e645be2ba0422685aeff2bc7e4487e6306daa5fa"}],"ironic/tests/unit/drivers/modules/drac/test_inspect.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5d2244d26bfffd5c2e8066f28323237cde4b221e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"             \u0027speed\u0027: \u00271000 Mbps\u0027,"},{"line_number":122,"context_line":"             \u0027duplex\u0027: \u0027full duplex\u0027,"},{"line_number":123,"context_line":"             \u0027media_type\u0027: \u0027Base T\u0027}]"},{"line_number":124,"context_line":"        bios_boot_settings \u003d {\u0027BootMode\u0027: {\u0027current_value\u0027: \u0027Bios\u0027}}"},{"line_number":125,"context_line":"        uefi_boot_settings \u003d {\u0027BootMode\u0027: {\u0027current_value\u0027: \u0027Uefi\u0027}}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.memory \u003d [test_utils.dict_to_namedtuple(values\u003dm) for m in memory]"},{"line_number":128,"context_line":"        self.cpus \u003d [test_utils.dict_to_namedtuple(values\u003dc) for c in cpus]"},{"line_number":129,"context_line":"        self.virtual_disks \u003d [test_utils.dict_to_namedtuple(values\u003dvd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_19233bbf","line":126,"range":{"start_line":124,"start_character":0,"end_line":126,"end_character":0},"updated":"2019-04-30 00:41:14.000000000","message":"This was introduced by changes to master and prior [1] which were subsequently reverted on stable/rocky and prior [2]. The source of this cherry-pick uses it, so it is added to increase this cherry-pick\u0027s fidelity.\n\n[1] https://review.opendev.org/#/q/2b74d940c932c1bb4498f47372c0545e4480799f\n[2] https://review.opendev.org/#/q/topic:revert-fix-idrac-oob-inspect-pxe","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5d2244d26bfffd5c2e8066f28323237cde4b221e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.physical_disks \u003d [test_utils.dict_to_namedtuple(values\u003dpd)"},{"line_number":132,"context_line":"                               for pd in physical_disks]"},{"line_number":133,"context_line":"        self.nics \u003d [test_utils.dict_to_namedtuple(values\u003dn) for n in nics]"},{"line_number":134,"context_line":"        self.bios_boot_settings \u003d test_utils.dict_of_object(bios_boot_settings)"},{"line_number":135,"context_line":"        self.uefi_boot_settings \u003d test_utils.dict_of_object(uefi_boot_settings)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def test_get_properties(self):"},{"line_number":138,"context_line":"        expected \u003d drac_common.COMMON_PROPERTIES"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_39115f5e","line":135,"range":{"start_line":134,"start_character":0,"end_line":135,"end_character":79},"updated":"2019-04-30 00:41:14.000000000","message":"This was introduced by changes to master and prior [1] which were subsequently reverted on stable/rocky and prior [2]. The source of this cherry-pick uses it, so it is added to increase this cherry-pick\u0027s fidelity.\n\n[1] https://review.opendev.org/#/q/2b74d940c932c1bb4498f47372c0545e4480799f\n[2] https://review.opendev.org/#/q/topic:revert-fix-idrac-oob-inspect-pxe","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5d2244d26bfffd5c2e8066f28323237cde4b221e","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        mock_client.list_cpus.return_value \u003d self.cpus"},{"line_number":156,"context_line":"        mock_client.list_virtual_disks.return_value \u003d self.virtual_disks"},{"line_number":157,"context_line":"        mock_client.list_nics.return_value \u003d self.nics"},{"line_number":158,"context_line":"        mock_client.list_bios_settings.return_value \u003d self.uefi_boot_settings"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":161,"context_line":"                                  shared\u003dTrue) as task:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_b9046f19","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":77},"updated":"2019-04-30 00:41:14.000000000","message":"This was introduced by changes to master and prior [1] which were subsequently reverted on stable/rocky and prior [2]. The source of this cherry-pick uses it, so it is added to increase this cherry-pick\u0027s fidelity.\n\n[1] https://review.opendev.org/#/q/2b74d940c932c1bb4498f47372c0545e4480799f\n[2] https://review.opendev.org/#/q/topic:revert-fix-idrac-oob-inspect-pxe","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5d2244d26bfffd5c2e8066f28323237cde4b221e","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        mock_client.list_virtual_disks.return_value \u003d []"},{"line_number":203,"context_line":"        mock_client.list_physical_disks.return_value \u003d self.physical_disks"},{"line_number":204,"context_line":"        mock_client.list_nics.return_value \u003d self.nics"},{"line_number":205,"context_line":"        mock_client.list_bios_settings.return_value \u003d self.uefi_boot_settings"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":208,"context_line":"                                  shared\u003dTrue) as task:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_fc13b55a","line":205,"range":{"start_line":205,"start_character":0,"end_line":205,"end_character":77},"updated":"2019-04-30 00:41:14.000000000","message":"This was introduced by changes to master and prior [1] which were subsequently reverted on stable/rocky and prior [2]. The source of this cherry-pick uses it, so it is added to increase this cherry-pick\u0027s fidelity.\n\n[1] https://review.opendev.org/#/q/2b74d940c932c1bb4498f47372c0545e4480799f\n[2] https://review.opendev.org/#/q/topic:revert-fix-idrac-oob-inspect-pxe","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5d2244d26bfffd5c2e8066f28323237cde4b221e","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        mock_client.list_cpus.return_value \u003d self.cpus"},{"line_number":250,"context_line":"        mock_client.list_virtual_disks.return_value \u003d self.virtual_disks"},{"line_number":251,"context_line":"        mock_client.list_nics.return_value \u003d self.nics"},{"line_number":252,"context_line":"        mock_client.list_bios_settings.return_value \u003d self.uefi_boot_settings"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        mock_port_create.side_effect \u003d exception.MACAlreadyExists(\"boom\")"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_9c05d913","line":253,"range":{"start_line":252,"start_character":0,"end_line":253,"end_character":0},"updated":"2019-04-30 00:41:14.000000000","message":"This was introduced by changes to master and prior [1] which were subsequently reverted on stable/rocky and prior [2]. The source of this cherry-pick uses it, so it is added to increase this cherry-pick\u0027s fidelity.\n\n[1] https://review.opendev.org/#/q/2b74d940c932c1bb4498f47372c0545e4480799f\n[2] https://review.opendev.org/#/q/topic:revert-fix-idrac-oob-inspect-pxe","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"}],"ironic/tests/unit/drivers/modules/drac/utils.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5d2244d26bfffd5c2e8066f28323237cde4b221e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    enabled_raid_interfaces\u003d[\u0027idrac\u0027, \u0027fake\u0027, \u0027no-raid\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class DictToObj(object):"},{"line_number":35,"context_line":"    \"\"\"Returns a dictionary into a class\"\"\""},{"line_number":36,"context_line":"    def __init__(self, dictionary):"},{"line_number":37,"context_line":"        for key in dictionary:"},{"line_number":38,"context_line":"            setattr(self, key, dictionary[key])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def dict_to_namedtuple(name\u003d\u0027GenericNamedTuple\u0027, values\u003dNone):"},{"line_number":42,"context_line":"    \"\"\"Converts a dict to a collections.namedtuple\"\"\""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_79bfd760","line":40,"range":{"start_line":34,"start_character":0,"end_line":40,"end_character":0},"updated":"2019-04-30 00:41:14.000000000","message":"This was introduced by changes to master and prior [1] which were subsequently reverted on stable/rocky and prior [2]. The source of this cherry-pick uses it, so it is added to increase this cherry-pick\u0027s fidelity.\n\n[1] https://review.opendev.org/#/q/2b74d940c932c1bb4498f47372c0545e4480799f\n[2] https://review.opendev.org/#/q/topic:revert-fix-idrac-oob-inspect-pxe","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5d2244d26bfffd5c2e8066f28323237cde4b221e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        values \u003d {}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    return collections.namedtuple(name, list(values))(**values)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def dict_of_object(data):"},{"line_number":51,"context_line":"    \"\"\"Create a dictionary object\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    for k, v in data.items():"},{"line_number":54,"context_line":"        if isinstance(v, dict):"},{"line_number":55,"context_line":"            dict_obj \u003d DictToObj(v)"},{"line_number":56,"context_line":"            data[k] \u003d dict_obj"},{"line_number":57,"context_line":"    return data"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_f97747d3","line":57,"range":{"start_line":48,"start_character":0,"end_line":57,"end_character":15},"updated":"2019-04-30 00:41:14.000000000","message":"This was introduced by changes to master and prior [1] which were subsequently reverted on stable/rocky and prior [2]. The source of this cherry-pick uses it, so it is added to increase this cherry-pick\u0027s fidelity.\n\n[1] https://review.opendev.org/#/q/2b74d940c932c1bb4498f47372c0545e4480799f\n[2] https://review.opendev.org/#/q/topic:revert-fix-idrac-oob-inspect-pxe","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"}],"releasenotes/notes/set-boot-mode-4c42b3fd0b5f5b37.yaml":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"5d2244d26bfffd5c2e8066f28323237cde4b221e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set boot_mode in node properties during OOB Introspection"},{"line_number":5,"context_line":"    for ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_f9dbc7e9","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":32},"updated":"2019-04-30 00:41:14.000000000","message":"I propose to modify this release note in a follow-on change to master which would describe this change as a bug fix, instead of a new feature. It would be backported to all applicable stable branches.","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d784b8ab46d21b0f3b3d334147f078189c10e1c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set boot_mode in node properties during OOB Introspection"},{"line_number":5,"context_line":"    for ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_5edde3dd","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":32},"in_reply_to":"dfbec78f_b031390e","updated":"2019-05-16 06:51:03.000000000","message":"based on that statement we need the stein backport first.\n\nWe can have the discussion on this in that backport.","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"83052dde7ed8738f677a07a89dd27dee8fdec7d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set boot_mode in node properties during OOB Introspection"},{"line_number":5,"context_line":"    for ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_b031390e","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":32},"in_reply_to":"ffb9cba7_a5974048","updated":"2019-05-07 22:05:35.000000000","message":"The intention is for the release note to be the same on every branch that has this change, Iad8060fa13e37a2fa78d998c56d132b11ff948cf.\n\nTo accomplish that, the modified release note would need to be backported to every stable branch to which this change, is backported, including stable/rocky. It would also be backported to stable/stein, which was created after the original change was merged on master.","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"},{"author":{"_account_id":29405,"name":"Rachit Kapadia","email":"kapadiarachit007@gmail.com","username":"rachit7194"},"change_message_id":"3e48c7b777fa0817471c76a18bf995c3500ac90c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set boot_mode in node properties during OOB Introspection"},{"line_number":5,"context_line":"    for ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_a5974048","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":32},"in_reply_to":"ffb9cba7_f9dbc7e9","updated":"2019-05-02 06:10:44.000000000","message":"just one doubt..!! To backport changes on all stable branches except stable/rocky?","commit_id":"479edd2a22a3c62a553efd4ab5fbf84282b3c60f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4e6afc425ab7645f8ab8013979d6cfae3def9a7f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set boot_mode in node properties during OOB Introspection"},{"line_number":5,"context_line":"    for ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_1b929aa0","line":2,"updated":"2019-10-07 15:50:52.000000000","message":"This should be changed to \u0027fixes\u0027 IMO","commit_id":"e645be2ba0422685aeff2bc7e4487e6306daa5fa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39e5ca116077bca892d45c299e1b76dfccadacd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set boot_mode in node properties during OOB Introspection"},{"line_number":5,"context_line":"    for ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_b83d68de","line":2,"updated":"2019-10-09 09:10:53.000000000","message":"Well, this is a feature, since not setting boot mode is the default behavior of ironic.","commit_id":"e645be2ba0422685aeff2bc7e4487e6306daa5fa"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"de589794491768646671c4e42fbb081128e1c38f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Set boot_mode in node properties during OOB Introspection"},{"line_number":5,"context_line":"    for ``idrac`` hardware type."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_6045e0b3","line":2,"in_reply_to":"3fa7e38b_b83d68de","updated":"2019-10-10 12:42:56.000000000","message":"Do we have a bug filed in launchpad or storyboard we can refer this patch to?","commit_id":"e645be2ba0422685aeff2bc7e4487e6306daa5fa"}]}
