)]}'
{"ironic/common/raid.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"190fd1154176119bc6f3ccc1621124ad6336ce44","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    try:"},{"line_number":40,"context_line":"        logical_disks \u003d raid_config[\u0027logical_disks\u0027]"},{"line_number":41,"context_line":"    except KeyError:"},{"line_number":42,"context_line":"        # the raid_config may be empty, e.g. after cleaning"},{"line_number":43,"context_line":"        return"},{"line_number":44,"context_line":"    root_logical_disks \u003d [x for x in logical_disks if x.get(\u0027is_root_volume\u0027)]"},{"line_number":45,"context_line":"    if len(root_logical_disks) \u003e 1:"},{"line_number":46,"context_line":"        msg \u003d _(\"Raid config cannot have more than one root volume. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_36852a5b","line":43,"range":{"start_line":41,"start_character":4,"end_line":43,"end_character":14},"updated":"2019-05-09 10:13:46.000000000","message":"We do not need this check. If the \u0027logical_disks\u0027 are not present in raid_config json schema validation would fail [1] [2], [3] which happens before call to this method.\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L1094-L1121\n[2] https://github.com/openstack/ironic/blob/master/ironic/drivers/raid_config_schema.json\n[3] https://github.com/openstack/ironic/blob/master/ironic/common/raid.py#L50-L71","commit_id":"0e09d45c7afe26d4ba15fd48cd82d05376167131"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"190fd1154176119bc6f3ccc1621124ad6336ce44","unresolved":false,"context_lines":[{"line_number":724,"context_line":""},{"line_number":725,"context_line":"    @staticmethod"},{"line_number":726,"context_line":"    @agent_base_vendor.post_clean_step_hook("},{"line_number":727,"context_line":"        interface\u003d\u0027deploy\u0027, step\u003d\u0027create_configuration\u0027)"},{"line_number":728,"context_line":"    @agent_base_vendor.post_clean_step_hook("},{"line_number":729,"context_line":"        interface\u003d\u0027raid\u0027, step\u003d\u0027create_configuration\u0027)"},{"line_number":730,"context_line":"    def _create_configuration_final(task, command):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_b6983ac0","line":727,"range":{"start_line":727,"start_character":8,"end_line":727,"end_character":55},"updated":"2019-05-09 10:13:46.000000000","message":"This would not be required as \u0027create_configuration\u0027 should be part of \u0027raid\u0027 interface.","commit_id":"0e09d45c7afe26d4ba15fd48cd82d05376167131"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"190fd1154176119bc6f3ccc1621124ad6336ce44","unresolved":false,"context_lines":[{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    @staticmethod"},{"line_number":771,"context_line":"    @agent_base_vendor.post_clean_step_hook("},{"line_number":772,"context_line":"        interface\u003d\u0027deploy\u0027, step\u003d\u0027delete_configuration\u0027)"},{"line_number":773,"context_line":"    @agent_base_vendor.post_clean_step_hook("},{"line_number":774,"context_line":"        interface\u003d\u0027raid\u0027, step\u003d\u0027delete_configuration\u0027)"},{"line_number":775,"context_line":"    def _delete_configuration_final(task, command):"},{"line_number":776,"context_line":"        \"\"\"Clean step hook after RAID configuration was deleted."}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_d6936ea2","line":773,"range":{"start_line":772,"start_character":7,"end_line":773,"end_character":44},"updated":"2019-05-09 10:13:46.000000000","message":"ditto.","commit_id":"0e09d45c7afe26d4ba15fd48cd82d05376167131"}]}