)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"fc147cf9141183533b42c80b250a51e5dedf6893","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added reset_idrac cleaning step in the iDRAC driver that resets "},{"line_number":10,"context_line":"the iDRAC also added unit tests for the same."},{"line_number":11,"context_line":"Added known_good_state cleaning step in the iDRAC driver that"},{"line_number":12,"context_line":"performs Reset the iDRAC, Clear the job queue to get the iDRAC "},{"line_number":13,"context_line":"into a known-good state also added unit tests for the same."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I4be8b9da394c6957edb0e42040321b39145ab710"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_ee2b1c7f","line":12,"updated":"2019-05-10 12:42:57.000000000","message":"Can you remove the trailing spaces on lines 9 \u0026 12?","commit_id":"303bbd2b4a22a00fc811cd190e7056edb3986e92"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"1c83e08e90205e7aac32b99ce69122c3d66c1105","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added reset_idrac cleaning step in the iDRAC driver that resets "},{"line_number":10,"context_line":"the iDRAC also added unit tests for the same."},{"line_number":11,"context_line":"Added known_good_state cleaning step in the iDRAC driver that"},{"line_number":12,"context_line":"performs Reset the iDRAC, Clear the job queue to get the iDRAC "},{"line_number":13,"context_line":"into a known-good state also added unit tests for the same."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I4be8b9da394c6957edb0e42040321b39145ab710"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_2d7e15af","line":12,"in_reply_to":"dfbec78f_ee2b1c7f","updated":"2019-05-10 20:37:34.000000000","message":"Done","commit_id":"303bbd2b4a22a00fc811cd190e7056edb3986e92"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"da2d46f1fb68bc7321ba1964a0699b59e66d83b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fb8cfa7_a8cb451c","line":17,"updated":"2019-06-03 12:49:33.000000000","message":"please also add the Task number associated to the change","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"a559d1b238088ca48afb2f151387e0db000c1e1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fb8cfa7_82408b09","line":17,"in_reply_to":"9fb8cfa7_0e3b79d1","updated":"2019-06-04 09:40:15.000000000","message":"Done","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"644ac2c50364a04944feac4b3bde56fe05d75919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fb8cfa7_0e3b79d1","line":17,"in_reply_to":"9fb8cfa7_73a3fe50","updated":"2019-06-03 13:48:57.000000000","message":"the Task number is in the Story, 33562","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"a559d1b238088ca48afb2f151387e0db000c1e1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fb8cfa7_e23b8799","line":17,"in_reply_to":"9fb8cfa7_a8cb451c","updated":"2019-06-04 09:40:15.000000000","message":"Done","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"6ccb5fc068b4f794fd4b88e3b6812f0b9b7f41ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fb8cfa7_73a3fe50","line":17,"in_reply_to":"9fb8cfa7_a8cb451c","updated":"2019-06-03 13:42:35.000000000","message":"Story number is mentioned above. We dont have task number, please consider story as all.","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"}],"ironic/drivers/modules/drac/management.py":[{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"fc147cf9141183533b42c80b250a51e5dedf6893","unresolved":false,"context_lines":[{"line_number":361,"context_line":"    @METRICS.timer(\u0027DracManagement.reset_idrac\u0027)"},{"line_number":362,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":363,"context_line":"    def reset_idrac(self, task):"},{"line_number":364,"context_line":"        \"\"\"Reset the iDRAC configuration."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":367,"context_line":"        :returns: None if it is completed."}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_ce4df872","line":364,"updated":"2019-05-10 12:42:57.000000000","message":"Can you delete \"configuration\" on the line above so lessen the chance that the user will confuse this reset with a factory defaults reset?","commit_id":"303bbd2b4a22a00fc811cd190e7056edb3986e92"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"1c83e08e90205e7aac32b99ce69122c3d66c1105","unresolved":false,"context_lines":[{"line_number":361,"context_line":"    @METRICS.timer(\u0027DracManagement.reset_idrac\u0027)"},{"line_number":362,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":363,"context_line":"    def reset_idrac(self, task):"},{"line_number":364,"context_line":"        \"\"\"Reset the iDRAC configuration."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":367,"context_line":"        :returns: None if it is completed."}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_6d572d5a","line":364,"in_reply_to":"dfbec78f_ce4df872","updated":"2019-05-10 20:37:34.000000000","message":"Done","commit_id":"303bbd2b4a22a00fc811cd190e7056edb3986e92"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b344d8191fdaf35c7ccfce6ecc3d6b97aebe91ad","unresolved":false,"context_lines":[{"line_number":361,"context_line":"    @METRICS.timer(\u0027DracManagement.reset_idrac\u0027)"},{"line_number":362,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":363,"context_line":"    def reset_idrac(self, task):"},{"line_number":364,"context_line":"        \"\"\"Reset the iDRAC configuration."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":367,"context_line":"        :returns: None if it is completed."}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_df85a35b","line":364,"in_reply_to":"dfbec78f_ce4df872","updated":"2019-05-10 15:51:47.000000000","message":"If it\u0027s not resetting the configuration, then we should say what it is resetting.","commit_id":"303bbd2b4a22a00fc811cd190e7056edb3986e92"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"ccb647a61132db3b8b2bd348dfa166ea07494b43","unresolved":false,"context_lines":[{"line_number":361,"context_line":"    @METRICS.timer(\u0027DracManagement.reset_idrac\u0027)"},{"line_number":362,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":363,"context_line":"    def reset_idrac(self, task):"},{"line_number":364,"context_line":"        \"\"\"Reset the iDRAC configuration."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":367,"context_line":"        :returns: None if it is completed."}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_e800eb03","line":364,"in_reply_to":"dfbec78f_df85a35b","updated":"2019-05-10 18:07:46.000000000","message":"Hey Doug, it\u0027s actually resetting the iDRAC itself, which is equivalent to rebooting it.","commit_id":"303bbd2b4a22a00fc811cd190e7056edb3986e92"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"6b125f43adbfcd5d27799162311efe508e884253","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":387,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":388,"context_line":"        client.delete_jobs(job_ids\u003d[\u0027JID_CLEARALL_FORCE\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_d3c7e511","line":388,"range":{"start_line":388,"start_character":37,"end_line":388,"end_character":55},"updated":"2019-05-10 12:19:04.000000000","message":"Define this string as a constant in this file.","commit_id":"303bbd2b4a22a00fc811cd190e7056edb3986e92"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"1c83e08e90205e7aac32b99ce69122c3d66c1105","unresolved":false,"context_lines":[{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":387,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":388,"context_line":"        client.delete_jobs(job_ids\u003d[\u0027JID_CLEARALL_FORCE\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_2d74d5fd","line":388,"range":{"start_line":388,"start_character":37,"end_line":388,"end_character":55},"in_reply_to":"dfbec78f_d3c7e511","updated":"2019-05-10 20:37:34.000000000","message":"Done","commit_id":"303bbd2b4a22a00fc811cd190e7056edb3986e92"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c613643cf9e0686d8a368bc76785de58ad31adde","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":380,"context_line":"    def known_good_state(self, task):"},{"line_number":381,"context_line":"        \"\"\"Reset the iDRAC, Clear the job queue."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_6f2d6245","line":380,"range":{"start_line":378,"start_character":4,"end_line":380,"end_character":37},"updated":"2019-05-17 05:26:20.000000000","message":"Instead of having another step. Can we add an optional argument to `reset_idrac` clean_step to accept argument for clearing the job queue? Ex:\n...\n@base.clean_step(priority\u003d0, argsinfo\u003d{\n    \u0027delete_jobs\u0027: {\n        \u0027description\u0027: (\"Clear all the jobs on iDRAC\"),\n        \u0027required\u0027: False }\n})\ndef reset_idrac(self, task, **kwargs):\n{\n    node \u003d task.node\n    client \u003d drac_common.get_drac_client(node)\n    client.reset_idrac(force\u003dTrue, wait\u003dTrue)\n\n    # Clear the job queue.\n    if kwargs.get(\u0027delete_jobs\u0027):\n        client.delete_jobs(job_ids\u003d[_CLEAR_JOB_IDS])\n}","commit_id":"0fafed4b86b23d91ba7509a2fe256c474d0410d2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a4f311063549d514515a2dac6663d4932a8b929a","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":380,"context_line":"    def known_good_state(self, task):"},{"line_number":381,"context_line":"        \"\"\"Reset the iDRAC, Clear the job queue."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_a69671ef","line":380,"range":{"start_line":378,"start_character":4,"end_line":380,"end_character":37},"in_reply_to":"bfb3d3c7_2d234458","updated":"2019-05-29 03:52:54.000000000","message":"Thank you for clarification. The Automated cleaning steps cannot not take any arguments. For manual cleaning steps one can pass the arguments. Since you wanted to avoid arguments I thought you intend to use it during automated cleaning.\nIf you are planning to add more operations during reset I would recommend to provide a single step that takes one argument which would indicate the next action. This would avoid having multiple steps performing nearly similar things. But its your choice.\nEx: \ndef reset_idrac(self, task, **kwargs):\n    node \u003d task.node\n    client \u003d drac_common.get_drac_client(node)\n\n    # Reset DRAC\n    client.reset_idrac(force\u003dTrue, wait\u003dTrue)\n\n    # Perform further actions\n    action \u003d kwargs.get(\u0027action\u0027)\n    if action \u003d\u003d \u0027clear_jobs\u0027\n        do_clear_job\n    if action \u003d\u003d \u0027something_else\u0027\n        do_something_else","commit_id":"0fafed4b86b23d91ba7509a2fe256c474d0410d2"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"e20ddb477e4815bb375bb5f5b398b56936e0d6bc","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":380,"context_line":"    def known_good_state(self, task):"},{"line_number":381,"context_line":"        \"\"\"Reset the iDRAC, Clear the job queue."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_fe757ecd","line":380,"range":{"start_line":378,"start_character":4,"end_line":380,"end_character":37},"in_reply_to":"bfb3d3c7_6f2d6245","updated":"2019-05-17 13:02:34.000000000","message":"Hey Shiv, the known good cleaning step is intended to include executing all operations necessary to put the iDRAC into a known good state.  This patch is setting up the framework for that.  In the short term, we are planning on adding checking to see if the iDRAC is in recovery mode and taking it out if so.  In the longer term, we will be adding checking to see if the server is booted into the lifecycle controller GUI and kicking it out of the GUI if needed.  There may be more operations that we are not currently aware of that will need to be added in the future.  The known good cleaning step is supposed to be the big hammer that implements all of these best practices.  If the user wants to pick and choose which of these operations are executed, then they can run individual cleaning steps to do that.","commit_id":"0fafed4b86b23d91ba7509a2fe256c474d0410d2"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"f6c9f3d85938323b77f92336b81ebc8a27b8c60a","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":380,"context_line":"    def known_good_state(self, task):"},{"line_number":381,"context_line":"        \"\"\"Reset the iDRAC, Clear the job queue."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_d6c8e1a6","line":380,"range":{"start_line":378,"start_character":4,"end_line":380,"end_character":37},"in_reply_to":"bfb3d3c7_a69671ef","updated":"2019-05-29 19:30:53.000000000","message":"I think I would prefer to stick with the current design.  The reset cleaning step will only do a reset, the clear job queue cleaning step will only clear the job queue, and the known-good cleaning step will both reset and clear the job queue, plus any other actions that are necessary to bring the iDRAC into a known good state.  We will be adding at least taking the iDRAC out of recovery mode to the known-good step as well, and we may be adding other actions to it as well as time goes on.","commit_id":"0fafed4b86b23d91ba7509a2fe256c474d0410d2"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"b387d6bc1be31eee7c3b76042566f54330fc94fb","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":380,"context_line":"    def known_good_state(self, task):"},{"line_number":381,"context_line":"        \"\"\"Reset the iDRAC, Clear the job queue."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_2d234458","line":380,"range":{"start_line":378,"start_character":4,"end_line":380,"end_character":37},"in_reply_to":"bfb3d3c7_d6548f55","updated":"2019-05-28 22:22:31.000000000","message":"At the present time, we are planning on using them in manual cleaning only, though we want to leave open the possibility of using them for automated cleaning in the future.  Can you clarify why you think this design only makes sense for automated cleaning?  If we start adding flags to this cleaning step for turning on/off each possible substep, then we will end up with 3 or 4 flags initially, and will have to continue adding more as we add more substeps to this cleaning step.  I think it\u0027s a cleaner design to have one cleaning step that implements best practices, and an additional cleaning step for each substep that the user can execute in any combination they see fit if they don\u0027t want all of the substeps executed.  This approach eliminates the need to continually add flags every time we need to add another substep to this cleaning step.","commit_id":"0fafed4b86b23d91ba7509a2fe256c474d0410d2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"df7e9d808d361cf1bd6d9b5c5e5c817c27ab1c15","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":380,"context_line":"    def known_good_state(self, task):"},{"line_number":381,"context_line":"        \"\"\"Reset the iDRAC, Clear the job queue."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_d6548f55","line":380,"range":{"start_line":378,"start_character":4,"end_line":380,"end_character":37},"in_reply_to":"bfb3d3c7_fe757ecd","updated":"2019-05-27 14:06:07.000000000","message":"Ok. So your strategy is not letting user provide any input arguments, but to call the different cleaning steps itself. It makes sense if these were to be used in automated cleaning. Are they planned to be used in automated cleaning? If so, you need to add configs to set the priority for these clean steps.","commit_id":"0fafed4b86b23d91ba7509a2fe256c474d0410d2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"162ab133c02a31cdd2866d4a01caed0362ce528a","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        :returns: None if it is completed."},{"line_number":385,"context_line":"        :raises: DracOperationError on an error from python-dracclient."},{"line_number":386,"context_line":"        \"\"\""},{"line_number":387,"context_line":"        node \u003d task.node"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":390,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":391,"context_line":"        client.delete_jobs(job_ids\u003d[_CLEAR_JOB_IDS])"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_10a31702","line":390,"range":{"start_line":387,"start_character":8,"end_line":390,"end_character":49},"updated":"2019-05-13 06:02:11.000000000","message":"Is it possible to use self.reset_idrac(task) here? Just my idea.","commit_id":"0fafed4b86b23d91ba7509a2fe256c474d0410d2"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"6230c23b1fb84dea0c41c2df63805bee0b419aef","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        :returns: None if it is completed."},{"line_number":385,"context_line":"        :raises: DracOperationError on an error from python-dracclient."},{"line_number":386,"context_line":"        \"\"\""},{"line_number":387,"context_line":"        node \u003d task.node"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":390,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":391,"context_line":"        client.delete_jobs(job_ids\u003d[_CLEAR_JOB_IDS])"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_f3c44d93","line":390,"range":{"start_line":387,"start_character":8,"end_line":390,"end_character":49},"in_reply_to":"dfbec78f_10a31702","updated":"2019-05-13 07:28:08.000000000","message":"I would keep like this only because client.reset_idrac call is different from self.reset_idrac()","commit_id":"0fafed4b86b23d91ba7509a2fe256c474d0410d2"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c20ccb70c1f95e4dbd34f13b20681c74cac72444","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        raise NotImplementedError()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    @METRICS.timer(\u0027DracManagement.reset_idrac\u0027)"},{"line_number":365,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":366,"context_line":"    def reset_idrac(self, task):"},{"line_number":367,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_9496254c","line":365,"range":{"start_line":365,"start_character":21,"end_line":365,"end_character":31},"updated":"2019-06-10 10:13:47.000000000","message":"Why is the priority set as 0? 0 means skip.","commit_id":"a2c60a00a3d5e81046f8c0d600258c736ba63f7f"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"30c87524eddcafddeb250b6b3b935d5fecdd0e7e","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        raise NotImplementedError()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    @METRICS.timer(\u0027DracManagement.reset_idrac\u0027)"},{"line_number":365,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":366,"context_line":"    def reset_idrac(self, task):"},{"line_number":367,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_ea245ab1","line":365,"range":{"start_line":365,"start_character":21,"end_line":365,"end_character":31},"in_reply_to":"9fb8cfa7_9496254c","updated":"2019-06-10 12:40:37.000000000","message":"Hey Madhuri, At the present time, we are planning on using them in manual cleaning only, so priority\u003d0 will disable/skip reset_idrac clean step and will not run during automated cleaning, that\u0027s why we sets priority as 0.","commit_id":"a2c60a00a3d5e81046f8c0d600258c736ba63f7f"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"e87faf357ff95f2b97b838484fdf862fb906effd","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        raise NotImplementedError()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    @METRICS.timer(\u0027DracManagement.reset_idrac\u0027)"},{"line_number":365,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":366,"context_line":"    def reset_idrac(self, task):"},{"line_number":367,"context_line":"        \"\"\"Reset the iDRAC."},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_c856272b","line":365,"range":{"start_line":365,"start_character":21,"end_line":365,"end_character":31},"in_reply_to":"9fb8cfa7_ea245ab1","updated":"2019-06-11 13:54:24.000000000","message":"Done","commit_id":"a2c60a00a3d5e81046f8c0d600258c736ba63f7f"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"e87faf357ff95f2b97b838484fdf862fb906effd","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        node \u003d task.node"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_9c19507b","line":376,"range":{"start_line":376,"start_character":0,"end_line":376,"end_character":49},"updated":"2019-06-11 13:54:24.000000000","message":"What does Wait\u003dTrue do in light that return is None?","commit_id":"a2c60a00a3d5e81046f8c0d600258c736ba63f7f"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"4e6b0f79b846d843098d3d7bc48efbe683ba8695","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        node \u003d task.node"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        client \u003d drac_common.get_drac_client(node)"},{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_bc28d496","line":376,"range":{"start_line":376,"start_character":0,"end_line":376,"end_character":49},"in_reply_to":"9fb8cfa7_9c19507b","updated":"2019-06-11 14:36:24.000000000","message":"wait\u003dTrue waits for the iDRAC to return to operational state, like https://github.com/openstack/python-dracclient/blob/master/dracclient/client.py#L248","commit_id":"a2c60a00a3d5e81046f8c0d600258c736ba63f7f"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c20ccb70c1f95e4dbd34f13b20681c74cac72444","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":380,"context_line":"    def known_good_state(self, task):"},{"line_number":381,"context_line":"        \"\"\"Reset the iDRAC, Clear the job queue."},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_549c2d69","line":379,"updated":"2019-06-10 10:13:47.000000000","message":"Ditto","commit_id":"a2c60a00a3d5e81046f8c0d600258c736ba63f7f"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"4e6b0f79b846d843098d3d7bc48efbe683ba8695","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":380,"context_line":"    def known_good_state(self, task):"},{"line_number":381,"context_line":"        \"\"\"Reset the iDRAC, Clear the job queue."},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_7ccd7c2f","line":379,"in_reply_to":"9fb8cfa7_549c2d69","updated":"2019-06-11 14:36:24.000000000","message":"Done","commit_id":"a2c60a00a3d5e81046f8c0d600258c736ba63f7f"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"30c87524eddcafddeb250b6b3b935d5fecdd0e7e","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        client.reset_idrac(force\u003dTrue, wait\u003dTrue)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    @METRICS.timer(\u0027DracManagement.known_good_state\u0027)"},{"line_number":379,"context_line":"    @base.clean_step(priority\u003d0)"},{"line_number":380,"context_line":"    def known_good_state(self, task):"},{"line_number":381,"context_line":"        \"\"\"Reset the iDRAC, Clear the job queue."},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9fb8cfa7_0a4f6e6b","line":379,"in_reply_to":"9fb8cfa7_549c2d69","updated":"2019-06-10 12:40:37.000000000","message":"Hey Madhuri, At the present time, we are planning on using them in manual cleaning only, so priority\u003d0 will disable/skip  known_good_state clean step and will not run during automated cleaning, that\u0027s why we sets priority as 0.","commit_id":"a2c60a00a3d5e81046f8c0d600258c736ba63f7f"}],"releasenotes/notes/add_clean_step_reset_idrac_and_known_good_state-cdbebf97d7b87fe7.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"da2d46f1fb68bc7321ba1964a0699b59e66d83b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset_idrac cleaning step in the iDRAC driver that resets"},{"line_number":5,"context_line":"    the iDRAC also added unit tests for the same."},{"line_number":6,"context_line":"    Adds known_good_state cleaning step in the iDRAC driver that"},{"line_number":7,"context_line":"    performs Reset the iDRAC, Clear the job queue to get the iDRAC"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_68bc6d69","line":4,"updated":"2019-06-03 12:49:33.000000000","message":"I would rewrite this, if you have 2 new features, split them properly or combine in one sentence.","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"da2d46f1fb68bc7321ba1964a0699b59e66d83b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset_idrac cleaning step in the iDRAC driver that resets"},{"line_number":5,"context_line":"    the iDRAC also added unit tests for the same."},{"line_number":6,"context_line":"    Adds known_good_state cleaning step in the iDRAC driver that"},{"line_number":7,"context_line":"    performs Reset the iDRAC, Clear the job queue to get the iDRAC"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_a867c525","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":54},"updated":"2019-06-03 12:49:33.000000000","message":"``idrac`` hardware type","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"6ccb5fc068b4f794fd4b88e3b6812f0b9b7f41ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset_idrac cleaning step in the iDRAC driver that resets"},{"line_number":5,"context_line":"    the iDRAC also added unit tests for the same."},{"line_number":6,"context_line":"    Adds known_good_state cleaning step in the iDRAC driver that"},{"line_number":7,"context_line":"    performs Reset the iDRAC, Clear the job queue to get the iDRAC"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_137642da","line":4,"in_reply_to":"9fb8cfa7_68bc6d69","updated":"2019-06-03 13:42:35.000000000","message":"Agree","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"a559d1b238088ca48afb2f151387e0db000c1e1b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset_idrac cleaning step in the iDRAC driver that resets"},{"line_number":5,"context_line":"    the iDRAC also added unit tests for the same."},{"line_number":6,"context_line":"    Adds known_good_state cleaning step in the iDRAC driver that"},{"line_number":7,"context_line":"    performs Reset the iDRAC, Clear the job queue to get the iDRAC"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_a2d02f52","line":4,"in_reply_to":"9fb8cfa7_68bc6d69","updated":"2019-06-04 09:40:15.000000000","message":"Please review updated patch, and let me know if any changes required.","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"a559d1b238088ca48afb2f151387e0db000c1e1b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset_idrac cleaning step in the iDRAC driver that resets"},{"line_number":5,"context_line":"    the iDRAC also added unit tests for the same."},{"line_number":6,"context_line":"    Adds known_good_state cleaning step in the iDRAC driver that"},{"line_number":7,"context_line":"    performs Reset the iDRAC, Clear the job queue to get the iDRAC"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_a2f7cff5","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":54},"in_reply_to":"9fb8cfa7_a867c525","updated":"2019-06-04 09:40:15.000000000","message":"Done","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"e60f4a6d194756ccf1b53fedfe9b87beb996a21f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    the iDRAC also added unit tests for the same."},{"line_number":6,"context_line":"    Adds known_good_state cleaning step in the iDRAC driver that"},{"line_number":7,"context_line":"    performs Reset the iDRAC, Clear the job queue to get the iDRAC"},{"line_number":8,"context_line":"    into a known-good state also added unit tests for the same."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_8f34344c","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":63},"updated":"2019-06-04 09:09:20.000000000","message":"rpittau, Chris -  how about below note - \n\n\"\nAdds reset and known-good-state cleaning steps to hardware type ``idrac`. \nReset actually resets the node and known-good-state brings node to known good cleaning state.\"","commit_id":"86185efd5ae2f1d46c16ab62f410fa37e775aaa7"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"72b063fdbd5f0f0a91d15d54deaaa939b20e6f0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac`."},{"line_number":5,"context_line":"    Reset actually resets the node and known-good-state brings node to"},{"line_number":6,"context_line":"    known good cleaning state."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_28ee4c22","line":4,"range":{"start_line":4,"start_character":70,"end_line":4,"end_character":75},"updated":"2019-06-05 06:02:02.000000000","message":"s\\``idrac`\\``idrac``\n\nReplace ``idrac` with ``idrac``","commit_id":"fbc15ac3db599e8ada4ce5b998e209fc00aa84ca"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"be665c0291c2dbbf567c5be40b1ff2c550b51c12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac`."},{"line_number":5,"context_line":"    Reset actually resets the node and known-good-state brings node to"},{"line_number":6,"context_line":"    known good cleaning state."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_e3e13700","line":4,"range":{"start_line":4,"start_character":70,"end_line":4,"end_character":75},"in_reply_to":"9fb8cfa7_28ee4c22","updated":"2019-06-05 07:22:59.000000000","message":"Done","commit_id":"fbc15ac3db599e8ada4ce5b998e209fc00aa84ca"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"dfb4277e3eceaf8a29e633a7df5fe66fd672821b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac`."},{"line_number":5,"context_line":"    Reset actually resets the node and known-good-state brings node to"},{"line_number":6,"context_line":"    known good cleaning state."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_28d72c4e","line":5,"range":{"start_line":5,"start_character":45,"end_line":5,"end_character":49},"updated":"2019-06-05 06:10:03.000000000","message":"Please add below statement \n\"Reset actually resets the node and part of known-good-state  it also resets the node and deletes all the job to make sure node will in good state\"","commit_id":"fbc15ac3db599e8ada4ce5b998e209fc00aa84ca"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"be665c0291c2dbbf567c5be40b1ff2c550b51c12","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac`."},{"line_number":5,"context_line":"    Reset actually resets the node and known-good-state brings node to"},{"line_number":6,"context_line":"    known good cleaning state."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_a3e33f05","line":5,"range":{"start_line":5,"start_character":45,"end_line":5,"end_character":49},"in_reply_to":"9fb8cfa7_28d72c4e","updated":"2019-06-05 07:22:59.000000000","message":"Done","commit_id":"fbc15ac3db599e8ada4ce5b998e209fc00aa84ca"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8ad184bd65f1d3b3b1cf8c6216f16e18d9795c7c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_631ea7bb","line":5,"range":{"start_line":5,"start_character":34,"end_line":5,"end_character":47},"updated":"2019-06-05 07:47:22.000000000","message":"just separate the sentences with a semi-colon, should be ok","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8ad184bd65f1d3b3b1cf8c6216f16e18d9795c7c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_0379ebfa","line":5,"range":{"start_line":5,"start_character":64,"end_line":5,"end_character":66},"updated":"2019-06-05 07:47:22.000000000","message":"you can remove \"it\"","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"0610ad4280cc7870d8396ab06c0c5581cdffe5a8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_750c183b","line":5,"range":{"start_line":5,"start_character":64,"end_line":5,"end_character":66},"in_reply_to":"9fb8cfa7_0379ebfa","updated":"2019-06-05 10:21:32.000000000","message":"Done","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"0610ad4280cc7870d8396ab06c0c5581cdffe5a8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_7525f8aa","line":5,"range":{"start_line":5,"start_character":34,"end_line":5,"end_character":47},"in_reply_to":"9fb8cfa7_631ea7bb","updated":"2019-06-05 10:21:32.000000000","message":"Done","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8ad184bd65f1d3b3b1cf8c6216f16e18d9795c7c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_e31297b1","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":36},"updated":"2019-06-05 07:47:22.000000000","message":"clears the job queue","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8ad184bd65f1d3b3b1cf8c6216f16e18d9795c7c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_83271b13","line":6,"range":{"start_line":6,"start_character":55,"end_line":6,"end_character":59},"updated":"2019-06-05 07:47:22.000000000","message":"is","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"0610ad4280cc7870d8396ab06c0c5581cdffe5a8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_7544181c","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":36},"in_reply_to":"9fb8cfa7_15411c3a","updated":"2019-06-05 10:21:32.000000000","message":"Done","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"e38e5aa5195337a80c50930b519adbd3a7f5b46b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_15411c3a","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":36},"in_reply_to":"9fb8cfa7_4f5ce57d","updated":"2019-06-05 10:09:28.000000000","message":"\"Reset actually resets the node; known-good-state also resets the node and clears the job queue to make sure node is in good state\"\n\nThis one.","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"0610ad4280cc7870d8396ab06c0c5581cdffe5a8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_153cbcc6","line":6,"range":{"start_line":6,"start_character":55,"end_line":6,"end_character":59},"in_reply_to":"9fb8cfa7_83271b13","updated":"2019-06-05 10:21:32.000000000","message":"Done","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"0610ad4280cc7870d8396ab06c0c5581cdffe5a8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_353780e6","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":36},"in_reply_to":"9fb8cfa7_e31297b1","updated":"2019-06-05 10:21:32.000000000","message":"Done","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"207a0183e1842eec2422a10d13bb7d328debc43f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state it also resets"},{"line_number":6,"context_line":"    the node and deletes all the job to make sure node will in good state."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_4f5ce57d","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":36},"in_reply_to":"9fb8cfa7_e31297b1","updated":"2019-06-05 08:58:16.000000000","message":"Hey Riccardo, How about below note?\n\nAdds reset and known-good-state cleaning steps to hardware type ``idrac``.\nReset actually resets the node and part of known-good-state; also resets the node and clears the job queue to make sure node is in good state.","commit_id":"f4c219cf8faa96e42408cd1987a5cc946d625016"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"48a6299f5cc43f412afe69af22692885a001b525","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state; also resets"},{"line_number":6,"context_line":"    the node and clears the job queue to make sure node is in good state."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_755ad82a","line":5,"range":{"start_line":5,"start_character":34,"end_line":5,"end_character":46},"updated":"2019-06-05 10:09:42.000000000","message":"would remove \"and part of\" and just move the semi-colon here to separate reset and known-good-state parts","commit_id":"07c209063ac3dc7bbe56c1279e17621c3db8e967"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"0610ad4280cc7870d8396ab06c0c5581cdffe5a8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node and part of known-good-state; also resets"},{"line_number":6,"context_line":"    the node and clears the job queue to make sure node is in good state."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_95374cb1","line":5,"range":{"start_line":5,"start_character":34,"end_line":5,"end_character":46},"in_reply_to":"9fb8cfa7_755ad82a","updated":"2019-06-05 10:21:32.000000000","message":"Done","commit_id":"07c209063ac3dc7bbe56c1279e17621c3db8e967"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"a0d79d93a5763580d682f56ce806cf0a7c1ff45e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node; known-good-state also resets the node and"},{"line_number":6,"context_line":"    clears the job queue to make sure node is in good state."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_9d8686db","line":5,"updated":"2019-06-05 20:53:15.000000000","message":"Would you mind changing \"resets the node\" to \"resets the iDRAC\" in both cases on the line above?","commit_id":"c066517352047b3fe96162dfea4aa87e698c31ad"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"3009f9490adfc3db7b59e669c9289d05c6a934a3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node; known-good-state also resets the node and"},{"line_number":6,"context_line":"    clears the job queue to make sure node is in good state."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_217e586b","line":5,"in_reply_to":"9fb8cfa7_9d8686db","updated":"2019-06-05 21:14:32.000000000","message":"Done","commit_id":"c066517352047b3fe96162dfea4aa87e698c31ad"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"a0d79d93a5763580d682f56ce806cf0a7c1ff45e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node; known-good-state also resets the node and"},{"line_number":6,"context_line":"    clears the job queue to make sure node is in good state."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_ddcabe18","line":6,"updated":"2019-06-05 20:53:15.000000000","message":"Would you mind changing the above line to:\n\nclears the Lifecycle Controller job queue to make sure the iDRAC is in good state.","commit_id":"c066517352047b3fe96162dfea4aa87e698c31ad"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"3009f9490adfc3db7b59e669c9289d05c6a934a3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the node; known-good-state also resets the node and"},{"line_number":6,"context_line":"    clears the job queue to make sure node is in good state."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_41810c4a","line":6,"in_reply_to":"9fb8cfa7_ddcabe18","updated":"2019-06-05 21:14:32.000000000","message":"Done","commit_id":"c066517352047b3fe96162dfea4aa87e698c31ad"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ce194d4b42286886117634316a529fe330fcb139","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the iDRAC; known-good-state also resets the iDRAC"},{"line_number":6,"context_line":"    and clears the Lifecycle Controller job queue to make sure the iDRAC is in"},{"line_number":7,"context_line":"    good state."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_6438233d","line":4,"range":{"start_line":4,"start_character":19,"end_line":4,"end_character":35},"updated":"2019-06-17 15:06:39.000000000","message":"s/ known-good-state / ``known_good_state`` /","commit_id":"25f3dc866d538a47ecf611b1830853f0e05a887d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ce194d4b42286886117634316a529fe330fcb139","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the iDRAC; known-good-state also resets the iDRAC"},{"line_number":6,"context_line":"    and clears the Lifecycle Controller job queue to make sure the iDRAC is in"},{"line_number":7,"context_line":"    good state."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_e4ee53b3","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":14},"updated":"2019-06-17 15:06:39.000000000","message":"s/ reset / ``reset_idrac`` /","commit_id":"25f3dc866d538a47ecf611b1830853f0e05a887d"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"7b963a6c1429238f8d7adcfc0300b8f2e3fb68fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the iDRAC; known-good-state also resets the iDRAC"},{"line_number":6,"context_line":"    and clears the Lifecycle Controller job queue to make sure the iDRAC is in"},{"line_number":7,"context_line":"    good state."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_3aa9e08f","line":4,"range":{"start_line":4,"start_character":19,"end_line":4,"end_character":35},"in_reply_to":"9fb8cfa7_6438233d","updated":"2019-06-17 16:24:57.000000000","message":"Done","commit_id":"25f3dc866d538a47ecf611b1830853f0e05a887d"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"7b963a6c1429238f8d7adcfc0300b8f2e3fb68fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the iDRAC; known-good-state also resets the iDRAC"},{"line_number":6,"context_line":"    and clears the Lifecycle Controller job queue to make sure the iDRAC is in"},{"line_number":7,"context_line":"    good state."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_fa926858","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":14},"in_reply_to":"9fb8cfa7_e4ee53b3","updated":"2019-06-17 16:24:57.000000000","message":"Done","commit_id":"25f3dc866d538a47ecf611b1830853f0e05a887d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ce194d4b42286886117634316a529fe330fcb139","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the iDRAC; known-good-state also resets the iDRAC"},{"line_number":6,"context_line":"    and clears the Lifecycle Controller job queue to make sure the iDRAC is in"},{"line_number":7,"context_line":"    good state."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_043da72b","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":9},"updated":"2019-06-17 15:06:39.000000000","message":"ditto","commit_id":"25f3dc866d538a47ecf611b1830853f0e05a887d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ce194d4b42286886117634316a529fe330fcb139","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the iDRAC; known-good-state also resets the iDRAC"},{"line_number":6,"context_line":"    and clears the Lifecycle Controller job queue to make sure the iDRAC is in"},{"line_number":7,"context_line":"    good state."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_243a2b34","line":5,"range":{"start_line":5,"start_character":37,"end_line":5,"end_character":53},"updated":"2019-06-17 15:06:39.000000000","message":"ditto","commit_id":"25f3dc866d538a47ecf611b1830853f0e05a887d"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"7b963a6c1429238f8d7adcfc0300b8f2e3fb68fb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the iDRAC; known-good-state also resets the iDRAC"},{"line_number":6,"context_line":"    and clears the Lifecycle Controller job queue to make sure the iDRAC is in"},{"line_number":7,"context_line":"    good state."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_1a909c4e","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":9},"in_reply_to":"9fb8cfa7_043da72b","updated":"2019-06-17 16:24:57.000000000","message":"Done","commit_id":"25f3dc866d538a47ecf611b1830853f0e05a887d"},{"author":{"_account_id":29834,"name":"Pradip Kadam","email":"pradip.kadam001@gmail.com","username":"pradip.kadam001"},"change_message_id":"7b963a6c1429238f8d7adcfc0300b8f2e3fb68fb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds reset and known-good-state cleaning steps to hardware type ``idrac``."},{"line_number":5,"context_line":"    Reset actually resets the iDRAC; known-good-state also resets the iDRAC"},{"line_number":6,"context_line":"    and clears the Lifecycle Controller job queue to make sure the iDRAC is in"},{"line_number":7,"context_line":"    good state."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9fb8cfa7_da99a479","line":5,"range":{"start_line":5,"start_character":37,"end_line":5,"end_character":53},"in_reply_to":"9fb8cfa7_243a2b34","updated":"2019-06-17 16:24:57.000000000","message":"Done","commit_id":"25f3dc866d538a47ecf611b1830853f0e05a887d"}]}