)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"27b1b6b2c680c47c34e513a92cc196c7f2ebb26b","unresolved":false,"context_lines":[{"line_number":1843,"context_line":"                -H \"OpenStack-API-Version: placement 1.6\" \\"},{"line_number":1844,"context_line":"                $endpoint/resource_providers/$p/traits)"},{"line_number":1845,"context_line":"            for trait in $IRONIC_DEFAULT_TRAITS; do"},{"line_number":1846,"context_line":"                if [[ -z \"$(echo $rp_traits | grep $trait)\" ]]; then"},{"line_number":1847,"context_line":"                    amount\u003d0"},{"line_number":1848,"context_line":"                fi"},{"line_number":1849,"context_line":"            done"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfbec78f_403e54c1","line":1846,"range":{"start_line":1846,"start_character":51,"end_line":1846,"end_character":57},"updated":"2019-05-16 16:20:15.000000000","message":"Should wrap this in double quotes (though escaping them is annoying) so we don\u0027t match \"CUSTOM_GOLD_BAR\" when we were going for \"CUSTOM_GOLD\".\n\nWould also be better to use the return code from grep instead of -z on the output. Whereupon you can also use -q to suppress the output (we\u0027ll still see the value of $trait because we\u0027re under -x).\n\nSummary:\n\n if ! echo $rp_traits | grep -q \u0027\"\u0027$trait\u0027\"\u0027; then","commit_id":"45e0d140e96604140a24fe7ffb5d434570cad51f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"57558ae4147c36acd68bfa091bdbbf70cdce7aa7","unresolved":false,"context_lines":[{"line_number":1843,"context_line":"                -H \"OpenStack-API-Version: placement 1.6\" \\"},{"line_number":1844,"context_line":"                $endpoint/resource_providers/$p/traits)"},{"line_number":1845,"context_line":"            for trait in $IRONIC_DEFAULT_TRAITS; do"},{"line_number":1846,"context_line":"                if [[ -z \"$(echo $rp_traits | grep $trait)\" ]]; then"},{"line_number":1847,"context_line":"                    amount\u003d0"},{"line_number":1848,"context_line":"                fi"},{"line_number":1849,"context_line":"            done"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfbec78f_80cf6c27","line":1846,"range":{"start_line":1846,"start_character":51,"end_line":1846,"end_character":57},"in_reply_to":"dfbec78f_403e54c1","updated":"2019-05-16 16:52:41.000000000","message":"Ack. I want to see a run of this pass first before making changes.","commit_id":"45e0d140e96604140a24fe7ffb5d434570cad51f"}]}