)]}'
{"ironic/drivers/modules/drac/bios.py":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f506b51bd67bb533488c52cd0b2c5be9c5868441","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    :param kwargs: a dictionary of {\u0027AttributeName\u0027: \u0027NewValue\u0027}"},{"line_number":111,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":112,"context_line":"    :returns: A dictionary containing the is_commit_required key with a boolean"},{"line_number":113,"context_line":"              value indicating whether commit_bios_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"},{"line_number":116,"context_line":"              commit_bios_config() call if a reboot should be performed."}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_7f5405cb","line":113,"range":{"start_line":113,"start_character":39,"end_line":113,"end_character":59},"updated":"2019-05-20 21:35:15.000000000","message":"See below.","commit_id":"50eb432f0d17ecb967bef99c2c2eec7b56586857"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"4d2f62f74efda2fc49d0a2fb3125d876175d3224","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    :param kwargs: a dictionary of {\u0027AttributeName\u0027: \u0027NewValue\u0027}"},{"line_number":111,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":112,"context_line":"    :returns: A dictionary containing the is_commit_required key with a boolean"},{"line_number":113,"context_line":"              value indicating whether commit_bios_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"},{"line_number":116,"context_line":"              commit_bios_config() call if a reboot should be performed."}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_6dcc4abc","line":113,"range":{"start_line":113,"start_character":39,"end_line":113,"end_character":59},"in_reply_to":"bfb3d3c7_7f5405cb","updated":"2019-05-21 20:59:52.000000000","message":"Done","commit_id":"50eb432f0d17ecb967bef99c2c2eec7b56586857"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f506b51bd67bb533488c52cd0b2c5be9c5868441","unresolved":false,"context_lines":[{"line_number":113,"context_line":"              value indicating whether commit_bios_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"},{"line_number":116,"context_line":"              commit_bios_config() call if a reboot should be performed."},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":"    node \u003d task.node"},{"line_number":119,"context_line":"    drac_job.validate_job_queue(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_bf4a7d24","line":116,"range":{"start_line":116,"start_character":14,"end_line":116,"end_character":34},"updated":"2019-05-20 21:35:15.000000000","message":"Shouldn\u0027t this be commit_config() in this module, instead of commit_bios_config() in ./vendor_passtrhu.py?","commit_id":"50eb432f0d17ecb967bef99c2c2eec7b56586857"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"4d2f62f74efda2fc49d0a2fb3125d876175d3224","unresolved":false,"context_lines":[{"line_number":113,"context_line":"              value indicating whether commit_bios_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"},{"line_number":116,"context_line":"              commit_bios_config() call if a reboot should be performed."},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":"    node \u003d task.node"},{"line_number":119,"context_line":"    drac_job.validate_job_queue(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_8dcf3eaf","line":116,"range":{"start_line":116,"start_character":14,"end_line":116,"end_character":34},"in_reply_to":"bfb3d3c7_8a3e47d8","updated":"2019-05-21 20:59:52.000000000","message":"Done","commit_id":"50eb432f0d17ecb967bef99c2c2eec7b56586857"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"97803f5217de4ea78dba790a22ec38d274bc8799","unresolved":false,"context_lines":[{"line_number":113,"context_line":"              value indicating whether commit_bios_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"},{"line_number":116,"context_line":"              commit_bios_config() call if a reboot should be performed."},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":"    node \u003d task.node"},{"line_number":119,"context_line":"    drac_job.validate_job_queue(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_8a3e47d8","line":116,"range":{"start_line":116,"start_character":14,"end_line":116,"end_character":34},"in_reply_to":"bfb3d3c7_bf4a7d24","updated":"2019-05-21 17:56:32.000000000","message":"++","commit_id":"50eb432f0d17ecb967bef99c2c2eec7b56586857"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"4d2f62f74efda2fc49d0a2fb3125d876175d3224","unresolved":false,"context_lines":[{"line_number":113,"context_line":"              value indicating whether commit_bios_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"},{"line_number":116,"context_line":"              commit_bios_config() call if a reboot should be performed."},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":"    node \u003d task.node"},{"line_number":119,"context_line":"    drac_job.validate_job_queue(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_4dc14680","line":116,"range":{"start_line":116,"start_character":14,"end_line":116,"end_character":34},"in_reply_to":"bfb3d3c7_bf4a7d24","updated":"2019-05-21 20:59:52.000000000","message":"Done","commit_id":"50eb432f0d17ecb967bef99c2c2eec7b56586857"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6b3dd3d64dcb0491f11f0ed59104633d807e2519","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":110,"context_line":"    :param kwargs: a dictionary of {\u0027AttributeName\u0027: \u0027NewValue\u0027}"},{"line_number":111,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":112,"context_line":"    :returns: A dictionary containing the is_commit_required key with a boolean"},{"line_number":113,"context_line":"              value indicating whether commit_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_e53f9fb1","line":112,"range":{"start_line":112,"start_character":42,"end_line":112,"end_character":60},"updated":"2019-05-27 08:57:18.000000000","message":"nit: s/ is_commit_required/ \u0027is_commit_required\u0027 /","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"55bd70731572105fa5149b0b322407874f738727","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    :param task: a TaskManager instance containing the node to act on."},{"line_number":110,"context_line":"    :param kwargs: a dictionary of {\u0027AttributeName\u0027: \u0027NewValue\u0027}"},{"line_number":111,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":112,"context_line":"    :returns: A dictionary containing the is_commit_required key with a boolean"},{"line_number":113,"context_line":"              value indicating whether commit_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_d520f0ae","line":112,"range":{"start_line":112,"start_character":42,"end_line":112,"end_character":60},"in_reply_to":"bfb3d3c7_e53f9fb1","updated":"2019-05-28 20:55:18.000000000","message":"Done","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6b3dd3d64dcb0491f11f0ed59104633d807e2519","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":112,"context_line":"    :returns: A dictionary containing the is_commit_required key with a boolean"},{"line_number":113,"context_line":"              value indicating whether commit_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"},{"line_number":116,"context_line":"              commit_config() call if a reboot should be performed."},{"line_number":117,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_8548235c","line":114,"range":{"start_line":114,"start_character":43,"end_line":114,"end_character":61},"updated":"2019-05-27 08:57:18.000000000","message":"nir: s/ is_reboot_required/ \u0027is_reboot_required\u0027 /","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"55bd70731572105fa5149b0b322407874f738727","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":112,"context_line":"    :returns: A dictionary containing the is_commit_required key with a boolean"},{"line_number":113,"context_line":"              value indicating whether commit_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"},{"line_number":116,"context_line":"              commit_config() call if a reboot should be performed."},{"line_number":117,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_9516f854","line":114,"range":{"start_line":114,"start_character":43,"end_line":114,"end_character":61},"in_reply_to":"bfb3d3c7_8548235c","updated":"2019-05-28 20:55:18.000000000","message":"Done","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6b3dd3d64dcb0491f11f0ed59104633d807e2519","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":112,"context_line":"    :returns: A dictionary containing the is_commit_required key with a boolean"},{"line_number":113,"context_line":"              value indicating whether commit_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"},{"line_number":116,"context_line":"              commit_config() call if a reboot should be performed."},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":"    node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_a55e870f","line":115,"range":{"start_line":114,"start_character":66,"end_line":115,"end_character":40},"updated":"2019-05-27 08:57:18.000000000","message":"Can we call it a boolean value?\ns/ \"which has a value of \u0027true\u0027 or \u0027false\u0027 \"/ \"with a boolean value\" /","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"55bd70731572105fa5149b0b322407874f738727","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    :raises: DracOperationError on an error from python-dracclient."},{"line_number":112,"context_line":"    :returns: A dictionary containing the is_commit_required key with a boolean"},{"line_number":113,"context_line":"              value indicating whether commit_config() needs to be called"},{"line_number":114,"context_line":"              to make the changes, and the is_reboot_required key which has a"},{"line_number":115,"context_line":"              value of \u0027true\u0027 or \u0027false\u0027.  This key is used to indicate to the"},{"line_number":116,"context_line":"              commit_config() call if a reboot should be performed."},{"line_number":117,"context_line":"    \"\"\""},{"line_number":118,"context_line":"    node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_00aac86f","line":115,"range":{"start_line":114,"start_character":66,"end_line":115,"end_character":40},"in_reply_to":"bfb3d3c7_a55e870f","updated":"2019-05-28 20:55:18.000000000","message":"While it is true that only \u0027true\u0027 or \u0027false\u0027 can be returned here, the generic set_settings() code [1] actually returns an instance of RebootRequired, which may have the values \u0027true\u0027, \u0027false\u0027, or \u0027optional\u0027 [2].\n\n\u0027optional\u0027 is an indicator that realtime mode is supported and reboot is optional as a result.  However, realtime mode is not currently supported by the firmware when setting BIOS settings and as a result it will not be returned here.\n\nThe utility set_settings() method is used in other cases which do support realtime mode.\n\nIf you feel strongly about changing the above to reference boolean, then I can do that, though it\u0027s not exactly true.\n\n[1] https://github.com/openstack/python-dracclient/blob/master/dracclient/utils.py#L403\n[2] https://github.com/openstack/python-dracclient/blob/master/dracclient/constants.py#L47","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"}],"ironic/drivers/modules/drac/vendor_passthru.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6b3dd3d64dcb0491f11f0ed59104633d807e2519","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                                 \"value indicating whether \""},{"line_number":80,"context_line":"                                 \"commit_bios_config() needs to be called \""},{"line_number":81,"context_line":"                                 \"to make the changes, and the \""},{"line_number":82,"context_line":"                                 \"\u0027is_reboot_required\u0027 key with a value of \""},{"line_number":83,"context_line":"                                 \"\u0027true\u0027 or \u0027false\u0027.  This key is used to \""},{"line_number":84,"context_line":"                                 \"indicate to the commit_bios_config() call \""},{"line_number":85,"context_line":"                                 \"if a reboot should be performed.\"))"},{"line_number":86,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_85b6e33d","line":83,"range":{"start_line":82,"start_character":55,"end_line":83,"end_character":51},"updated":"2019-05-27 08:57:18.000000000","message":"Can we call it a boolean value?\ns/ \"which has a value of \u0027true\u0027 or \u0027false\u0027 \"/ \"with a boolean value\" /","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"55bd70731572105fa5149b0b322407874f738727","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                                 \"value indicating whether \""},{"line_number":80,"context_line":"                                 \"commit_bios_config() needs to be called \""},{"line_number":81,"context_line":"                                 \"to make the changes, and the \""},{"line_number":82,"context_line":"                                 \"\u0027is_reboot_required\u0027 key with a value of \""},{"line_number":83,"context_line":"                                 \"\u0027true\u0027 or \u0027false\u0027.  This key is used to \""},{"line_number":84,"context_line":"                                 \"indicate to the commit_bios_config() call \""},{"line_number":85,"context_line":"                                 \"if a reboot should be performed.\"))"},{"line_number":86,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_20eeecb3","line":83,"range":{"start_line":82,"start_character":55,"end_line":83,"end_character":51},"in_reply_to":"bfb3d3c7_85b6e33d","updated":"2019-05-28 20:55:18.000000000","message":"Same here.","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6b3dd3d64dcb0491f11f0ed59104633d807e2519","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        :returns: A dictionary containing the ``is_commit_required`` key with a"},{"line_number":96,"context_line":"                  Boolean value indicating whether commit_bios_config() needs"},{"line_number":97,"context_line":"                  to be called to make the changes, and the"},{"line_number":98,"context_line":"                  ``is_reboot_required`` key with a value of \u0027true\u0027 or \u0027false\u0027."},{"line_number":99,"context_line":"                  This key is used to indicate to the commit_bios_config() call"},{"line_number":100,"context_line":"                  if a reboot should be performed."},{"line_number":101,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_a5b3e74c","line":98,"range":{"start_line":98,"start_character":41,"end_line":98,"end_character":78},"updated":"2019-05-27 08:57:18.000000000","message":"ditto","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"55bd70731572105fa5149b0b322407874f738727","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        :returns: A dictionary containing the ``is_commit_required`` key with a"},{"line_number":96,"context_line":"                  Boolean value indicating whether commit_bios_config() needs"},{"line_number":97,"context_line":"                  to be called to make the changes, and the"},{"line_number":98,"context_line":"                  ``is_reboot_required`` key with a value of \u0027true\u0027 or \u0027false\u0027."},{"line_number":99,"context_line":"                  This key is used to indicate to the commit_bios_config() call"},{"line_number":100,"context_line":"                  if a reboot should be performed."},{"line_number":101,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_e031b45b","line":98,"range":{"start_line":98,"start_character":41,"end_line":98,"end_character":78},"in_reply_to":"bfb3d3c7_a5b3e74c","updated":"2019-05-28 20:55:18.000000000","message":"Same here.","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"}],"releasenotes/notes/idrac-remove-commit_required-d9ea849e8f5e78e2.yaml":[{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"208f671113a3fb8ec86e8e2b61358384a16fdf9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Documents the removal of commit_required from the dictionary returned"},{"line_number":4,"context_line":"    by the set_bios_config vendor passthru call in the iDRAC hardware type."},{"line_number":5,"context_line":"    Use is_commit_required instead. commit_required was removed in"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_68d08a20","line":2,"updated":"2019-05-23 20:08:22.000000000","message":"Have you considered also documenting the new is_reboot_required key returned in the dictionary?","commit_id":"09879d40f6e9628b0f07123222ab9cda28b4bc19"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"fbee08e1fd4b387af0ffe11a27be67be94f89b4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Documents the removal of commit_required from the dictionary returned"},{"line_number":4,"context_line":"    by the set_bios_config vendor passthru call in the iDRAC hardware type."},{"line_number":5,"context_line":"    Use is_commit_required instead. commit_required was removed in"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_7e460024","line":2,"in_reply_to":"bfb3d3c7_68d08a20","updated":"2019-05-23 21:40:07.000000000","message":"Done","commit_id":"09879d40f6e9628b0f07123222ab9cda28b4bc19"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"208f671113a3fb8ec86e8e2b61358384a16fdf9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Documents the removal of commit_required from the dictionary returned"},{"line_number":4,"context_line":"    by the set_bios_config vendor passthru call in the iDRAC hardware type."},{"line_number":5,"context_line":"    Use is_commit_required instead. commit_required was removed in"},{"line_number":6,"context_line":"    python-dracclient version 3.0.0."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_c8cf36ae","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":18},"updated":"2019-05-23 20:08:22.000000000","message":"This seems out of place when I view the built release notes in a browser.","commit_id":"09879d40f6e9628b0f07123222ab9cda28b4bc19"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"208f671113a3fb8ec86e8e2b61358384a16fdf9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Documents the removal of commit_required from the dictionary returned"},{"line_number":4,"context_line":"    by the set_bios_config vendor passthru call in the iDRAC hardware type."},{"line_number":5,"context_line":"    Use is_commit_required instead. commit_required was removed in"},{"line_number":6,"context_line":"    python-dracclient version 3.0.0."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_e8a1daaa","line":3,"range":{"start_line":3,"start_character":29,"end_line":3,"end_character":44},"updated":"2019-05-23 20:08:22.000000000","message":"nit: Please consider formatting this as a literal by surrounding it with double backquotes -- ``commit_required``. The same applies to the other literals in this note, set_bios_config, is_commit_required, and python-dracclient.","commit_id":"09879d40f6e9628b0f07123222ab9cda28b4bc19"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"fbee08e1fd4b387af0ffe11a27be67be94f89b4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Documents the removal of commit_required from the dictionary returned"},{"line_number":4,"context_line":"    by the set_bios_config vendor passthru call in the iDRAC hardware type."},{"line_number":5,"context_line":"    Use is_commit_required instead. commit_required was removed in"},{"line_number":6,"context_line":"    python-dracclient version 3.0.0."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_bbed6a8c","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":18},"in_reply_to":"bfb3d3c7_c8cf36ae","updated":"2019-05-23 21:40:07.000000000","message":"Done","commit_id":"09879d40f6e9628b0f07123222ab9cda28b4bc19"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"fbee08e1fd4b387af0ffe11a27be67be94f89b4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Documents the removal of commit_required from the dictionary returned"},{"line_number":4,"context_line":"    by the set_bios_config vendor passthru call in the iDRAC hardware type."},{"line_number":5,"context_line":"    Use is_commit_required instead. commit_required was removed in"},{"line_number":6,"context_line":"    python-dracclient version 3.0.0."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_dbc7fe11","line":3,"range":{"start_line":3,"start_character":29,"end_line":3,"end_character":44},"in_reply_to":"bfb3d3c7_e8a1daaa","updated":"2019-05-23 21:40:07.000000000","message":"Done","commit_id":"09879d40f6e9628b0f07123222ab9cda28b4bc19"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6b3dd3d64dcb0491f11f0ed59104633d807e2519","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``commit_required`` is no longer present in the dictionary returned by"},{"line_number":5,"context_line":"    the ``set_bios_config`` vendor passthru call in the iDRAC hardware type."},{"line_number":6,"context_line":"    ``commit_required`` was split into two keys: ``is_commit_required`` and"},{"line_number":7,"context_line":"    ``is_reboot_required``, which indicate the actions necessary to complete"},{"line_number":8,"context_line":"    setting the BIOS settings.  ``commit_required`` was removed in"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_65d96f7d","line":5,"range":{"start_line":5,"start_character":56,"end_line":5,"end_character":61},"updated":"2019-05-27 08:57:18.000000000","message":"s/ iDRAC/ ``idrac`` /","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"},{"author":{"_account_id":10250,"name":"Christopher Dearborn","email":"Christopher.Dearborn@dell.com","username":"cdearbor"},"change_message_id":"55bd70731572105fa5149b0b322407874f738727","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``commit_required`` is no longer present in the dictionary returned by"},{"line_number":5,"context_line":"    the ``set_bios_config`` vendor passthru call in the iDRAC hardware type."},{"line_number":6,"context_line":"    ``commit_required`` was split into two keys: ``is_commit_required`` and"},{"line_number":7,"context_line":"    ``is_reboot_required``, which indicate the actions necessary to complete"},{"line_number":8,"context_line":"    setting the BIOS settings.  ``commit_required`` was removed in"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_80b55880","line":5,"range":{"start_line":5,"start_character":56,"end_line":5,"end_character":61},"in_reply_to":"bfb3d3c7_65d96f7d","updated":"2019-05-28 20:55:18.000000000","message":"Done","commit_id":"0fba6cf4b2403799a345ee38be5e18cd85f9932b"}]}