)]}'
{"ironic/drivers/modules/ansible/playbooks/roles/deploy/files/partition_configdrive.sh":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"225d30c0774d3f49d2d97b4e8160240d6cde5dfd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        log \"Fixing GPT to use all of the space on device $DEVICE\""},{"line_number":61,"context_line":"        sgdisk -e $DEVICE || fail \"move backup GPT data structures to the end of ${DEVICE}\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # Create small partition at the end of the device and labellize it directly"},{"line_number":64,"context_line":"        log \"Adding configdrive partition to $DEVICE\""},{"line_number":65,"context_line":"        # Get a one shot partlabel, with a pseudo-random 5 chars chunk to avoid"},{"line_number":66,"context_line":"        # any conflict with any other pre-existing partlabel"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_0ddd7e6f","line":63,"range":{"start_line":63,"start_character":62,"end_line":63,"end_character":71},"updated":"2019-06-06 09:19:01.000000000","message":"nit: label","commit_id":"08372a481898cccfa080110779444cc592e0f2f8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"454d651b0ea99482bfe52b5dbcebf301111e6765","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        log \"Adding configdrive partition to $DEVICE\""},{"line_number":66,"context_line":"        # Get a one shot partlabel, with a pseudo-random 5 chars chunk to avoid"},{"line_number":67,"context_line":"        # any conflict with any other pre-existing partlabel"},{"line_number":68,"context_line":"        PARTLABEL\u003dconfig-$(\u003c /dev/urandom tr -dc a-z0-9 | head -c 5)"},{"line_number":69,"context_line":"        sgdisk -n 0:-64MB:0 -c 0:$PARTLABEL $DEVICE || fail \"creating configdrive on ${DEVICE}\""},{"line_number":70,"context_line":"        partprobe"},{"line_number":71,"context_line":"        ISO_PARTITION\u003d/dev/disk/by-partlabel/$PARTLABEL"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_406486e4","line":68,"updated":"2019-06-07 11:32:57.000000000","message":"Is there any reason we cannot use config-2, which is the expected configdrive label?\n\nActually, I\u0027m struggling to understand how the partition is found by cloud-init if we don\u0027t provide this name.","commit_id":"a09a34207c8bc0e396a95167d53f9543cb205b4a"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"e6a312afb739c01dbffea8d0bc31d9adac991523","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        log \"Adding configdrive partition to $DEVICE\""},{"line_number":66,"context_line":"        # Get a one shot partlabel, with a pseudo-random 5 chars chunk to avoid"},{"line_number":67,"context_line":"        # any conflict with any other pre-existing partlabel"},{"line_number":68,"context_line":"        PARTLABEL\u003dconfig-$(\u003c /dev/urandom tr -dc a-z0-9 | head -c 5)"},{"line_number":69,"context_line":"        sgdisk -n 0:-64MB:0 -c 0:$PARTLABEL $DEVICE || fail \"creating configdrive on ${DEVICE}\""},{"line_number":70,"context_line":"        partprobe"},{"line_number":71,"context_line":"        ISO_PARTITION\u003d/dev/disk/by-partlabel/$PARTLABEL"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_60174aef","line":68,"in_reply_to":"9fb8cfa7_406486e4","updated":"2019-06-07 11:51:11.000000000","message":"\u0027config-2\u0027 is the expected fs label, not the partition label\n\nAt this point we cannot label the fs because there is none\n(the configdrive will bring its fs, iso or fat, when dd\u0027d on the part)\n\n\u0027config-2\u0027 label is thus added later.\n\nSo we could indeed call the partlabel with the same name as the fs label (config-2) but nothing forces us to.\n\nAnd I thought avoiding using hardcoded name as much as possible when not required was better, to avoid as much as possible name conflict with other parts (depending on the crafted image partitioning)","commit_id":"a09a34207c8bc0e396a95167d53f9543cb205b4a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c85e898980d87861291d9d1ba03f7c5182e9022","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        log \"Adding configdrive partition to $DEVICE\""},{"line_number":66,"context_line":"        # Get a one shot partlabel, with a pseudo-random 5 chars chunk to avoid"},{"line_number":67,"context_line":"        # any conflict with any other pre-existing partlabel"},{"line_number":68,"context_line":"        PARTLABEL\u003dconfig-$(\u003c /dev/urandom tr -dc a-z0-9 | head -c 5)"},{"line_number":69,"context_line":"        sgdisk -n 0:-64MB:0 -c 0:$PARTLABEL $DEVICE || fail \"creating configdrive on ${DEVICE}\""},{"line_number":70,"context_line":"        partprobe"},{"line_number":71,"context_line":"        ISO_PARTITION\u003d/dev/disk/by-partlabel/$PARTLABEL"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_00bf6e61","line":68,"in_reply_to":"9fb8cfa7_60174aef","updated":"2019-06-07 12:15:33.000000000","message":"Makes sense, thanks for explanation!","commit_id":"a09a34207c8bc0e396a95167d53f9543cb205b4a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"454d651b0ea99482bfe52b5dbcebf301111e6765","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        fi"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        log \"Adding configdrive partition to $DEVICE\""},{"line_number":88,"context_line":"        parted -a optimal -s -- $DEVICE mkpart primary fat32 $startlimit $endlimit || fail \"creating configdrive on ${DEVICE}\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Find partition we just created"},{"line_number":91,"context_line":"        # Dump all partitions, ignore empty ones, then get the last partition ID"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_605f4a0e","line":88,"updated":"2019-06-07 11:32:57.000000000","message":"Same here, I\u0027m surprised we don\u0027t just use config-2","commit_id":"a09a34207c8bc0e396a95167d53f9543cb205b4a"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"e6a312afb739c01dbffea8d0bc31d9adac991523","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        fi"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        log \"Adding configdrive partition to $DEVICE\""},{"line_number":88,"context_line":"        parted -a optimal -s -- $DEVICE mkpart primary fat32 $startlimit $endlimit || fail \"creating configdrive on ${DEVICE}\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Find partition we just created"},{"line_number":91,"context_line":"        # Dump all partitions, ignore empty ones, then get the last partition ID"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_20d71226","line":88,"in_reply_to":"9fb8cfa7_605f4a0e","updated":"2019-06-07 11:51:11.000000000","message":"See answer above","commit_id":"a09a34207c8bc0e396a95167d53f9543cb205b4a"}],"releasenotes/notes/bug-2005764-15f45e11b9f9c96d.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d7b16d9718b484db4b9bc16d7f70ed467ba4b282","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a deployment issue entcountered during deployment, more precisely"},{"line_number":5,"context_line":"    during the configdrive partition creation step. On some specific devices"},{"line_number":6,"context_line":"    like nvme drives, the created configdrive partition could not correctly"},{"line_number":7,"context_line":"    be identified (required to dump data onto it afterward)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_d012a058","line":4,"range":{"start_line":4,"start_character":29,"end_line":4,"end_character":41},"updated":"2019-06-06 04:34:32.000000000","message":"s/ entcountered / encountered /","commit_id":"08372a481898cccfa080110779444cc592e0f2f8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d7b16d9718b484db4b9bc16d7f70ed467ba4b282","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a deployment issue entcountered during deployment, more precisely"},{"line_number":5,"context_line":"    during the configdrive partition creation step. On some specific devices"},{"line_number":6,"context_line":"    like nvme drives, the created configdrive partition could not correctly"},{"line_number":7,"context_line":"    be identified (required to dump data onto it afterward)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_d03b80ce","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":13},"updated":"2019-06-06 04:34:32.000000000","message":"nit: s/ nvme / NVMe /","commit_id":"08372a481898cccfa080110779444cc592e0f2f8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d7b16d9718b484db4b9bc16d7f70ed467ba4b282","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixes a deployment issue entcountered during deployment, more precisely"},{"line_number":5,"context_line":"    during the configdrive partition creation step. On some specific devices"},{"line_number":6,"context_line":"    like nvme drives, the created configdrive partition could not correctly"},{"line_number":7,"context_line":"    be identified (required to dump data onto it afterward)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_102278a5","line":7,"range":{"start_line":7,"start_character":59,"end_line":7,"end_character":60},"updated":"2019-06-06 04:34:32.000000000","message":"Also you can add  link to story Id here. This fix may required to be back ported.","commit_id":"08372a481898cccfa080110779444cc592e0f2f8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d7b16d9718b484db4b9bc16d7f70ed467ba4b282","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes a deployment issue entcountered during deployment, more precisely"},{"line_number":5,"context_line":"    during the configdrive partition creation step. On some specific devices"},{"line_number":6,"context_line":"    like nvme drives, the created configdrive partition could not correctly"},{"line_number":7,"context_line":"    be identified (required to dump data onto it afterward)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_5028f084","line":7,"range":{"start_line":6,"start_character":66,"end_line":7,"end_character":17},"updated":"2019-06-06 04:34:32.000000000","message":"should it  be:\ns/\u0027correctly be identified\u0027 / \u0027be correctly identified\u0027/","commit_id":"08372a481898cccfa080110779444cc592e0f2f8"}]}