)]}'
{"ironic/drivers/modules/redfish/bios.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"50330a3934642c97c5275927c38c4606f74403b3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":51,"context_line":"        :raises: RedfishConnectionError when it fails to connect to Redfish"},{"line_number":52,"context_line":"        :raises: RedfishError on an error from the Sushy library"},{"line_number":53,"context_line":"        :raises: UnsupportedDriverExtension if the system does not support BIOS"},{"line_number":54,"context_line":"            settings"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5a5def12","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":43},"updated":"2019-06-13 10:22:20.000000000","message":"Perhaps this already works as it should, just to make sure..\n\nIs it plausible with Redfish if BIOS bits are not present in JSON at least initially, still the user can push some new attributes?\n\nIn other words, does the absence of BIOS data (or just attributes) implies that BIOS is entirely unsupported?\n\nThis is say that may be we should not fail too hard if reading fails?","commit_id":"a0073bf70b854e55f6f3a1cdcd1f003078c46c1b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f1e6a341dfd9c290893fbf52352c2dc3d5a0af3e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":51,"context_line":"        :raises: RedfishConnectionError when it fails to connect to Redfish"},{"line_number":52,"context_line":"        :raises: RedfishError on an error from the Sushy library"},{"line_number":53,"context_line":"        :raises: UnsupportedDriverExtension if the system does not support BIOS"},{"line_number":54,"context_line":"            settings"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5abf2fa9","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":43},"in_reply_to":"9fb8cfa7_5a5def12","updated":"2019-06-13 10:52:00.000000000","message":"I\u0027m not sure how we would do that, given that even accessing system.bios would raise in this case.","commit_id":"a0073bf70b854e55f6f3a1cdcd1f003078c46c1b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"50330a3934642c97c5275927c38c4606f74403b3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        system \u003d redfish_utils.get_system(task.node)"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            attributes \u003d system.bios.attributes"},{"line_number":61,"context_line":"        except sushy.exceptions.MissingAttributeError:"},{"line_number":62,"context_line":"            error_msg \u003d _(\u0027Cannot fetch BIOS attributes for node %s, \u0027"},{"line_number":63,"context_line":"                          \u0027BIOS settings are not supported.\u0027) % task.node.uuid"},{"line_number":64,"context_line":"            LOG.error(error_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_7a431343","line":61,"updated":"2019-06-13 10:22:20.000000000","message":"May be worse making sure that this is the exception that will be raised when BIOS is not present in JSON... Sushy docs at one place notes that this exception is only raised when a *required* attribute is not present.\n\nAlso, is it possible that either bios or bios.attributes is missing? Should these two cases be treated differently?","commit_id":"a0073bf70b854e55f6f3a1cdcd1f003078c46c1b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f1e6a341dfd9c290893fbf52352c2dc3d5a0af3e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        system \u003d redfish_utils.get_system(task.node)"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            attributes \u003d system.bios.attributes"},{"line_number":61,"context_line":"        except sushy.exceptions.MissingAttributeError:"},{"line_number":62,"context_line":"            error_msg \u003d _(\u0027Cannot fetch BIOS attributes for node %s, \u0027"},{"line_number":63,"context_line":"                          \u0027BIOS settings are not supported.\u0027) % task.node.uuid"},{"line_number":64,"context_line":"            LOG.error(error_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_3ac4bb3f","line":61,"in_reply_to":"9fb8cfa7_7a431343","updated":"2019-06-13 10:52:00.000000000","message":"I\u0027m basing my assumptions on the first traceback from http://paste.openstack.org/show/752824/","commit_id":"a0073bf70b854e55f6f3a1cdcd1f003078c46c1b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"50330a3934642c97c5275927c38c4606f74403b3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        system \u003d redfish_utils.get_system(task.node)"},{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            bios \u003d system.bios"},{"line_number":135,"context_line":"        except sushy.exceptions.MissingAttributeError:"},{"line_number":136,"context_line":"            error_msg \u003d (_(\u0027Redfish BIOS factory reset failed for node \u0027"},{"line_number":137,"context_line":"                           \u0027%s, because BIOS settings are not supported.\u0027) %"},{"line_number":138,"context_line":"                         task.node.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_7adf9368","line":135,"updated":"2019-06-13 10:22:20.000000000","message":"Ditto","commit_id":"a0073bf70b854e55f6f3a1cdcd1f003078c46c1b"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"48c39cf31b6d6618f32c72400c8049a29224824c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        LOG.debug(\u0027Factory reset BIOS settings for node %(node_uuid)s\u0027,"},{"line_number":101,"context_line":"                  {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            system.bios.reset_bios()"},{"line_number":104,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":105,"context_line":"            error_msg \u003d (_(\u0027Redfish BIOS factory reset failed for node \u0027"},{"line_number":106,"context_line":"                           \u0027%(node)s. Error: %(error)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_f61cce14","line":103,"updated":"2019-06-17 08:03:00.000000000","message":"I think it\u0027s better to put \"system.bios\" in a seperate try block, same as L134.","commit_id":"46884deba3c271b7aae493729635b3c84343d55f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97b35ef772b228b4d26c188d95873be8822702b0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        LOG.debug(\u0027Factory reset BIOS settings for node %(node_uuid)s\u0027,"},{"line_number":101,"context_line":"                  {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            system.bios.reset_bios()"},{"line_number":104,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":105,"context_line":"            error_msg \u003d (_(\u0027Redfish BIOS factory reset failed for node \u0027"},{"line_number":106,"context_line":"                           \u0027%(node)s. Error: %(error)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_a10052ad","line":103,"in_reply_to":"9fb8cfa7_163962f1","updated":"2019-06-17 09:06:34.000000000","message":"We do, it will be included in the error message.","commit_id":"46884deba3c271b7aae493729635b3c84343d55f"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"f7090a10343b0304763aa87f8d24b3b9a7798c7f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        LOG.debug(\u0027Factory reset BIOS settings for node %(node_uuid)s\u0027,"},{"line_number":101,"context_line":"                  {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            system.bios.reset_bios()"},{"line_number":104,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":105,"context_line":"            error_msg \u003d (_(\u0027Redfish BIOS factory reset failed for node \u0027"},{"line_number":106,"context_line":"                           \u0027%(node)s. Error: %(error)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_163962f1","line":103,"in_reply_to":"9fb8cfa7_16440274","updated":"2019-06-17 08:37:32.000000000","message":"So that we know that BIOS settings are not supported.","commit_id":"46884deba3c271b7aae493729635b3c84343d55f"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"2cef7fadc9a676c8c646a56a90ecd0fa2de81e8f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        LOG.debug(\u0027Factory reset BIOS settings for node %(node_uuid)s\u0027,"},{"line_number":101,"context_line":"                  {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            system.bios.reset_bios()"},{"line_number":104,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":105,"context_line":"            error_msg \u003d (_(\u0027Redfish BIOS factory reset failed for node \u0027"},{"line_number":106,"context_line":"                           \u0027%(node)s. Error: %(error)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_5cd05954","line":103,"in_reply_to":"9fb8cfa7_a10052ad","updated":"2019-06-17 09:56:13.000000000","message":"Ok, I don\u0027t see it done for this statement. Sorry if I am missing anything.","commit_id":"46884deba3c271b7aae493729635b3c84343d55f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9603c4c699fcb1ce519a693e9c58374be673930f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        LOG.debug(\u0027Factory reset BIOS settings for node %(node_uuid)s\u0027,"},{"line_number":101,"context_line":"                  {\u0027node_uuid\u0027: task.node.uuid})"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            system.bios.reset_bios()"},{"line_number":104,"context_line":"        except sushy.exceptions.SushyError as e:"},{"line_number":105,"context_line":"            error_msg \u003d (_(\u0027Redfish BIOS factory reset failed for node \u0027"},{"line_number":106,"context_line":"                           \u0027%(node)s. Error: %(error)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_16440274","line":103,"in_reply_to":"9fb8cfa7_f61cce14","updated":"2019-06-17 08:35:21.000000000","message":"Why do you think it is better?","commit_id":"46884deba3c271b7aae493729635b3c84343d55f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b05d6d7681e7bba1bb3eb07ba1692e58bb8d246a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            bios \u003d system.bios"},{"line_number":135,"context_line":"        except sushy.exceptions.MissingAttributeError:"},{"line_number":136,"context_line":"            error_msg \u003d (_(\u0027Redfish BIOS factory reset failed for node \u0027"},{"line_number":137,"context_line":"                           \u0027%s, because BIOS settings are not supported.\u0027) %"},{"line_number":138,"context_line":"                         task.node.uuid)"},{"line_number":139,"context_line":"            LOG.error(error_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_3ccfa5b1","line":136,"range":{"start_line":136,"start_character":41,"end_line":136,"end_character":54},"updated":"2019-06-17 10:26:27.000000000","message":"s/ \u0027factory reset\u0027 / \u0027apply configuration\u0027 /","commit_id":"46884deba3c271b7aae493729635b3c84343d55f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7b2cc99e107fa4922e6d802b87f3169fc754c9a7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            bios \u003d system.bios"},{"line_number":135,"context_line":"        except sushy.exceptions.MissingAttributeError:"},{"line_number":136,"context_line":"            error_msg \u003d (_(\u0027Redfish BIOS factory reset failed for node \u0027"},{"line_number":137,"context_line":"                           \u0027%s, because BIOS settings are not supported.\u0027) %"},{"line_number":138,"context_line":"                         task.node.uuid)"},{"line_number":139,"context_line":"            LOG.error(error_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_a6aaa36e","line":136,"range":{"start_line":136,"start_character":41,"end_line":136,"end_character":54},"in_reply_to":"9fb8cfa7_3ccfa5b1","updated":"2019-06-17 13:44:55.000000000","message":"++","commit_id":"46884deba3c271b7aae493729635b3c84343d55f"}]}