)]}'
{"ironic/common/pxe_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0c967c5f18d94ee2ab6d31020f2757f7442ee9dc","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            # added in the Stein cycle which identifies the iPXE User-Class"},{"line_number":471,"context_line":"            # directly and is only sent in DHCPv6."},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            if ip_version !\u003d 6:"},{"line_number":474,"context_line":"                dhcp_opts.append("},{"line_number":475,"context_line":"                    {\u0027opt_name\u0027: \"tag:!ipxe,%s\" % boot_file_param,"},{"line_number":476,"context_line":"                     \u0027opt_value\u0027: boot_file}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_90e8167c","line":473,"updated":"2019-06-14 08:25:32.000000000","message":"nit: I\u0027d reverse the \u0027if\u0027 block, changing !\u003d to \u003d\u003d","commit_id":"72c6ccbdb72fe258111ac4c0c1f72dd6ba120187"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3cce0f4df4d5ed8ad6a8de3535f2dbfa29bc2dec","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            # added in the Stein cycle which identifies the iPXE User-Class"},{"line_number":471,"context_line":"            # directly and is only sent in DHCPv6."},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            if ip_version !\u003d 6:"},{"line_number":474,"context_line":"                dhcp_opts.append("},{"line_number":475,"context_line":"                    {\u0027opt_name\u0027: \"tag:!ipxe,%s\" % boot_file_param,"},{"line_number":476,"context_line":"                     \u0027opt_value\u0027: boot_file}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_8471bbaa","line":473,"in_reply_to":"9fb8cfa7_50b4de7f","updated":"2019-06-14 08:42:33.000000000","message":"We do, or rather oslo.config does for us: https://github.com/openstack/ironic/blob/master/ironic/conf/pxe.py#L131-L132","commit_id":"72c6ccbdb72fe258111ac4c0c1f72dd6ba120187"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"30bd4e2336659e8385ec2ad4961e9b19841de4c6","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            # added in the Stein cycle which identifies the iPXE User-Class"},{"line_number":471,"context_line":"            # directly and is only sent in DHCPv6."},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            if ip_version !\u003d 6:"},{"line_number":474,"context_line":"                dhcp_opts.append("},{"line_number":475,"context_line":"                    {\u0027opt_name\u0027: \"tag:!ipxe,%s\" % boot_file_param,"},{"line_number":476,"context_line":"                     \u0027opt_value\u0027: boot_file}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_4448a32b","line":473,"in_reply_to":"9fb8cfa7_8471bbaa","updated":"2019-06-14 08:52:24.000000000","message":"oh right, thanks!","commit_id":"72c6ccbdb72fe258111ac4c0c1f72dd6ba120187"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9622f44599287eb9ac1944865b614af3376e40a7","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            # added in the Stein cycle which identifies the iPXE User-Class"},{"line_number":471,"context_line":"            # directly and is only sent in DHCPv6."},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            if ip_version !\u003d 6:"},{"line_number":474,"context_line":"                dhcp_opts.append("},{"line_number":475,"context_line":"                    {\u0027opt_name\u0027: \"tag:!ipxe,%s\" % boot_file_param,"},{"line_number":476,"context_line":"                     \u0027opt_value\u0027: boot_file}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_50b4de7f","line":473,"in_reply_to":"9fb8cfa7_90e8167c","updated":"2019-06-14 08:28:47.000000000","message":"maybe a silly question, but why we don\u0027t specify only versions 4 and 6 and error out for any other value?\nIsn\u0027t this prone to error in case of human mistake in the conf?","commit_id":"72c6ccbdb72fe258111ac4c0c1f72dd6ba120187"}]}